GitLab

This patch is for refactoring aria-haspopup following latest spec.

Changed the value type of aria-haspopup from boolean
to token in ARIA 1.1 [1].
Also, the implicit value for role combobox was changed
from true to listbox.

Supported values are :
- true
- false (default)
- menu
- listbox
- tree
- grid
- dialog

We expose both of "HASPOPUP" state and "haspopup:" values
for backwards compatibility.

[1] https://www.w3.org/WAI/ARIA/wiki/ARIA_1.1_Changes

Bug: 740137
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib4988026c8728f64dfe4b30e842ef68620f093a5
Reviewed-on: https://chromium-review.googlesource.com/896672
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555911}

This wires up text query functionality. Note that the bubble this view
is housed in is InActive when shown and DialogPlate does not yet request
focus on its textfield. So the user must activate the widget and focus
the textfield manually.

See bug for demo.

Bug: b:79108829
Change-Id: I55a48076208b967031f48d6693bea2e8125c3641
Reviewed-on: https://chromium-review.googlesource.com/1040532
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555910}

This CL adds a warn-before-quitting flag.  When enabled, pressing Ctrl+Shift+Q
will show a bubble asking to continue holding the shortcut to quit.  Pressing
the shortcut a second time while the bubble is showing will also confirm the
quit.

R=sky
BUG=243164

Change-Id: I97c4dc37cb5107fde975a4162f349e1ea5337b5d
Reviewed-on: https://chromium-review.googlesource.com/1031097Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555909}

This is a first step towards moving BrowserFrameHeaderAsh into
//ash/public and making it useable both in Ash (for Mash) and Chrome
(for classic).

Bug: 836992
Change-Id: I76109ef3949f803e87c153008c0bf462e8228492
Reviewed-on: https://chromium-review.googlesource.com/1042786
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555908}

FileManagerBrowserTest is a parametric test: none of the other browser
tests are (Gallery, VideoPlayer, AudioPlayer).

Having the Param postfix in the getter names is a leftover from a time
when there was only FileManagerBrowserTest. Remove the Param postfix.

Bonus points: the implementation details of the test extension browser
tests is no longer exposed. FileManageBrowserTestBase does not need to
know, nor does it care.

Bug: 833834
Change-Id: I3919b3751122afdccd1f6f0689107ab91440c427
Reviewed-on: https://chromium-review.googlesource.com/1042426Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555907}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I264fd1b0fd9275ed36a960dad24ccc048501c4e9
Reviewed-on: https://chromium-review.googlesource.com/1042929
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555906}

Bug: 839445
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5193b544cc3e6db8d03b40d807c7d7f93dea94a5
Reviewed-on: https://chromium-review.googlesource.com/1043267Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Daniel Blakemore <danblakemore@google.com>
Cr-Commit-Position: refs/heads/master@{#555905}

Currently, we only set WindowEventTarget to DirectManipulationHelper
when receive DM_POINTERHITTEST. But the crash shows OnContentUpdate
may come before DM_POINTERHITTEST. To prevent the crash we set the
WindowEventTarget when DirectManipulationHelper create.

Bug: 839338
Change-Id: I2921277178771f9124a37325a8dff47196500322
Reviewed-on: https://chromium-review.googlesource.com/1042381Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555904}

Bug:833964

Change-Id: Ia365a3fa7aba1bedd57d38ff392a5663cd0d15c7
Reviewed-on: https://chromium-review.googlesource.com/1043086Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555903}

It appears like calling ResetTimeForTesting is not actually needed for
this test to pass. Since it is causing flake due to the double/TimeTick
round-trips (see bug), just remove it.

Bug: 838676
Change-Id: Ice3e2c88e3afbdf07c52abfb8bffc9d8e0d0c8b1
Reviewed-on: https://chromium-review.googlesource.com/1042380Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555902}

This class will be used to forward feature usage events to the site
characteristics database.

Bug: 773382
Change-Id: Ibe7197a44c68f231c7aea61c85fe2ba77c3d5076
Reviewed-on: https://chromium-review.googlesource.com/1042906
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555901}

These commands create then mount fake USB and MTP volumes for testing.
Add ASSERTs that Mount() calls on these fake volumes succeeds in test.

No change in behavior, no new tests.

Bug: 833834
Change-Id: I49c9a21b629cdb6285982d622e1020b6c16dee73
Reviewed-on: https://chromium-review.googlesource.com/1042005Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555900}

Bring the FakeTestVolume comments up-to-date. Add a private helper for
getting the external mount points to make Mount() simpler.

FakeTestVolume could be used for testing read-only volumes, but is not
currently used for that: make read-only as const bool member for now.

Bug: 833834
Change-Id: I4da213998e224d3b469c8221f6902fb3f8221e25
Reviewed-on: https://chromium-review.googlesource.com/1042425Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555899}

The spec is here:
https://drafts.csswg.org/css-animations/#interface-animationevent

A layout test is changed to test this API.

Bug: 437132
Change-Id: Ic463b19488271e1caeb78afa6120bb53f7d5e94d
Reviewed-on: https://chromium-review.googlesource.com/1019383Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555898}

Now Search+D, as approved by Chrome UI Review

Bug: 837819
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If0c9343d95fd8da342df41a7530260455020e4e3
Reviewed-on: https://chromium-review.googlesource.com/1033928Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555897}

Minor: the code is similar but was not formatted the same way. Make it
formatted the same way for the reader's sake.

Bug: 833834
Change-Id: I68f8b3b46f7d02c988e59887d1dc30f1284cbb34
Reviewed-on: https://chromium-review.googlesource.com/1042325Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555896}

For compiler protection in switch statements, etc.

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: Icf86013c87d89b233d6bc27646bad8f79830af6e
Reviewed-on: https://chromium-review.googlesource.com/1043098
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555895}

This CL turns removes --enable-raster-decoder and turns on RasterDecoder
whenever --enable-oop-rasterization is passed from the command line
when starting chrome.

This is not yet true for tests. We will still use
RasterImplementationGLES and GLES2Decoder if
attribs.enable_oop_rasterization and attribs.enable_gles2_interface.
This was done to maintain coverage of both RasterImplementationGLES and
RasterImplementation.  I will clean this up in separate CLs as I rip out
OOP-R code from GLES2{Impl,Decoder}.

TBR: achuith@chromium.org, sadrul@chromium.org
Bug: 789238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3e0bd4606c70f4bb9c52117c5aa0baa6ded37665
Reviewed-on: https://chromium-review.googlesource.com/1031012
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555894}

Minor clickNotificationButton re-org while I was running my ruler over
this code. No change in behavior, no new tests.

Tbr: slangley
Bug: 833834
Change-Id: Ic23e13e89ab0d3a30d17d456c6c12c781fbc02f4
Reviewed-on: https://chromium-review.googlesource.com/1041368
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555893}

Initially appbar support was added to SettingsRootTableViewController,
as that was the only view controller which needed it.  But now, we
expect to support MDCAppBar in bookmarks screens as well, so this CL
moves it to a common base class.  We follow the pattern set by
CollectionViewController and include an appBarStyle parameter which
determines whether or not an MDCAppBar is created.

BUG=839439,839450,839460

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I057b15113987d91451ca3a104aba95dd17667cda
Reviewed-on: https://chromium-review.googlesource.com/1043006
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555892}

Tbr: chrisha@chromium.org
Bug: 839572
Change-Id: Iaf2a127be786efa2ce195f5b952aaecd0f1a9e74
Reviewed-on: https://chromium-review.googlesource.com/1043155
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555891}

This CL removes an extra application of GetBorderThicknessDip(). It was
being added in GetIconAlignmentOffset() and again outside of that call.
Also cleans up a todo for the same topic.

Bug: 839120
Change-Id: I7687903a879dd0f2e29dc7b9090052dc7ff57442
Reviewed-on: https://chromium-review.googlesource.com/1041208
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555890}

The code disabled in this CL had some side effects, e.g. left
PartialInvalidationRect not cleared after PrePaintClean, and the next
document lifecycle might do unexpected rect mapping while no
NeedsVisualRect flag set.

Bug: 836097
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib05ccfd439be78666771f8483a0b462128848c08
Reviewed-on: https://chromium-review.googlesource.com/1041570Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555889}

Also use iOS 10 simulator provided by the appropriate Xcode, and do not rely on
legacy simulators installed on the bot.

R=justincohen@chromium.org

Bug: 835036
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I933dc552a030d9410550df5ac1cd0090b6508a47
Reviewed-on: https://chromium-review.googlesource.com/1028666Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555888}

Generating a depfile from the manifest building step gives Ninja
the information it needs to trigger incremental rebuilds when static
assets or shared libraries have been modified.

Bug: 839496
Change-Id: I15aee25e8684f9d1fd6a8ad63318cc74639237f0
Reviewed-on: https://chromium-review.googlesource.com/1043047
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555887}

Change-Id: I7008b98fbf392801b796517a9a442c34815b13c4
Reviewed-on: https://chromium-review.googlesource.com/1040988Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555886}

Bug: 839534
Change-Id: I7242753e5777b15168ba8a0ff91a000a8a16c980
Reviewed-on: https://chromium-review.googlesource.com/1042624Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555885}

This reverts commit 1536dfa3.

Reason for revert: Causes data race in DownloadContentTest.ForceDownloadMessageRfc822Page test 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/21108

Original change's description:
> Reland "Move zygote code to service_manager"
> 
> Relanding the move zygote to the service manager. It was breaking the
> non NaCl build.
> 
> Original description:
> 
> "This CL moves the zygote code from content/ to
> services/service_manager/zygote. This involves moving some switches from
> content_switches.h to services/service_manager/embedder/switches.h and
> moving some codes from content/public/common/result_codes.h to the new
> services/service_manager/embedder/result_codes.h."
> 
> Tbr: avi@chromium.org
> Tbr: sky@chromium.org
> Tbr: scottmg@chromium.org
> Tbr: rockot@chromium.org
> Tbr: slan@chromium.org
> Tbr: eseckler@chromium.org
> Tbr: rsesek@chromium.org
> Bug: 831846
> Change-Id: I8a4ceb2fe6b402d512a2f45b7fab0735b891c578
> Reviewed-on: https://chromium-review.googlesource.com/1037633
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555851}

TBR=avi@chromium.org,sky@chromium.org,jcivelli@chromium.org,rockot@chromium.org,tsepez@chromium.org,slan@chromium.org,halliwell@chromium.org,scottmg@chromium.org,rsesek@chromium.org,eseckler@chromium.org

Change-Id: If3e2d0985960aaafec57f0a6db26e6f078dd7ad9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831846
Reviewed-on: https://chromium-review.googlesource.com/1043185Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555884}

Change-Id: I6cf1b34580fcd29954d15c729c4f290117d9bdeb
Reviewed-on: https://chromium-review.googlesource.com/1039064
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555883}

These tests either pass on Firefox or are bugs in Firefox.

Bug: 745778
Change-Id: I0a2997d5c3602f026e5cf9132a68a833c975d32d
Reviewed-on: https://chromium-review.googlesource.com/1042801Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555882}

Bug: 824967
Change-Id: I4eb57d85bb057061bf12848f39127a6542ebe886
Reviewed-on: https://chromium-review.googlesource.com/1037523
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555881}

Now that all desktop platforms have a browser-level implementation
for keyboard lock, it is time to remove the platform restriction
for the keyboard lock BrowserTests.

BUG=680809

Change-Id: Iad4ddea988069a73dd6cb31683a3a2086c753c47
Reviewed-on: https://chromium-review.googlesource.com/1042542Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555880}

This CL adds two UI tests:
* Testing interaction with touches.
* Verify touch and mouse events don't interfere with each other.

Bug: 829606
Change-Id: Iaea466d8746e69ce3e2081a64b9f915440a9ef8f
Reviewed-on: https://chromium-review.googlesource.com/1040775Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555879}

Update PermissionsData::AccessType to an enum class, and rename it to
PermissionsData::PageAccess. This will help prevent accidental misuse of
the enum (e.g., implicit conversion to bool, etc).

Bug: None

Change-Id: Ic81bf8cbcfd53e0700258413ef56d8150b23a046
Reviewed-on: https://chromium-review.googlesource.com/1042486
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555878}

Doing |getHeight() - getHeightMinusBrowserControls()| for the top toolbar
height does not work when the bottom toolbar is present since
|getHeightMinusBrowserControls()| takes into account the bottom toolbar.
The correct way to get the top toolbar height is through
|getTopBrowserControlsHeight()|.

Change-Id: I93ec1e43b8246c4babfa8a427bd9122c0a8fb39f
Reviewed-on: https://chromium-review.googlesource.com/1041218Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555877}

This covers the code added in crrev/c/1031010.

Bug: 833663, 734095
Change-Id: Iea3502b3543d076d6dc3285bea6e229320a2b980
Reviewed-on: https://chromium-review.googlesource.com/1040739Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555876}

* Added string converters for ScreenlockState and
RemoteDeviceLifeCycleState
* Removed 'generating EIDs' log
* Removed duplicate life cycle log

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: I40e8b5e43b1e2dc29d6542aae33b6af8b78ca722
Reviewed-on: https://chromium-review.googlesource.com/1042962Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555875}

Bug: 839154
Change-Id: Iebceacd23dde5275c72d4fb6afecedb3dab75396
Reviewed-on: https://chromium-review.googlesource.com/1035207
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555874}

This patch adds an explicit function to the SwipeableBottomSheet that
determines if a touch event is inside of the sheet's toolbar. This
eliminates the hack that existed previously that made too many
assumptions about the height of the toolbar.

Bug: 834795
Change-Id: Id195e72718ff2d37deb2891fd6264300d517352a
Reviewed-on: https://chromium-review.googlesource.com/1036224
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555873}

These tests can run on Win7 machines so enable them.

Bug: 734095
Change-Id: Idcd8e426feaf1202e544db2793a50f3574bdaaed
Reviewed-on: https://chromium-review.googlesource.com/1041154Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555872}