- 22 Jul, 2014 40 commits
-
-
armansito@chromium.org authored
This CL adds a section to app_bluetooth.html with documentation on how the chrome.bluetoothLowEnergy API should be used. BUG=382625 R=keybuk@chromium.org TBR=mkearney@chromium.org Review URL: https://codereview.chromium.org/352833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284778 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
Each URLLoaderImpl created by NetworkServiceImpl can allocate a net::URLRequest. When shutting down the app, destruction of the NetworkContext and the URLRequestContext within it expects that all net::URLRequest resources have been freed by now (it CHECKs). NetworkService is an app like any other and can't make any assumptions about when it is being destroyed relative to other apps in the system that may have been using it, so the safest thing to do is to have it gracefully tear-down in-progress URLLoaders. Note: the only reason we're not seeing the CHECK happen is because things shut down (the process terminates) before we even get to ~URLRequestContext. I'll be repairing shutdown in an upcoming CL. BUG=394477 Review URL: https://codereview.chromium.org/407593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284777 0039d316-1c4b-4281-b951-d872f2087c98
-
abhishek.a21@samsung.com authored
BUG=None Review URL: https://codereview.chromium.org/363563005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284776 0039d316-1c4b-4281-b951-d872f2087c98
-
stgao@chromium.org authored
This is to create a sub-directory for Findit and add a unittest skeleton with a script to parse DEPS file in chromium. R=mbarbella@chromium.org Review URL: https://codereview.chromium.org/391173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284775 0039d316-1c4b-4281-b951-d872f2087c98
-
vollick@chromium.org authored
We used to have trouble when the max scroll offset was zero. With this cl we detect this case and set a reasonable scroll thumb offset. BUG=None Review URL: https://codereview.chromium.org/409193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284773 0039d316-1c4b-4281-b951-d872f2087c98
-
mohammed@chromium.org authored
Permissions warning messages are suprressed around the code which make it hard to know which supress what. Put them in one DS the suppression is done in a single loop. This help visualize which suppress what and a neater place to add ones later. BUG=384487 R=kalman, meacer Review URL: https://codereview.chromium.org/404803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284771 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
It is trivial clean-up of unused thing. BUG=none TEST=build Review URL: https://codereview.chromium.org/399593006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284770 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
This appears to have broke StackedPanelBrowserTest.AddNewPanelFromDifferentProfile on windows interactive. http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/15556/steps/interactive_ui_tests/logs/AddNewPanelFromDifferentProfile [ RUN ] StackedPanelBrowserTest.AddNewPanelFromDifferentProfile Backtrace: extensions::ExtensionRegistry::RemoveObserver [0x00000001430B3030+32] (No symbol) [0x00000000086491C0] base::SupportsWeakPtr\u003CObserverListBase\u003Caura::WindowObserver> >::AsWeakPtr [0x000007FEEF42B175+85] StackedPanelBrowserTest.AddNewPanelFromDifferentProfile (run #2): ... > Use ExtensionRegistryObserver instead of DEPRECATED extension notify. > > BUG=354458 > > Review URL: https://codereview.chromium.org/262223003 TBR=limasdf@gmail.com Review URL: https://codereview.chromium.org/409983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284769 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
This API is no longer necessary with the PlatformWindow interface. TEST=built & ran on link_freon BUG=392280 TBR=danakj NOTRY=true Review URL: https://codereview.chromium.org/406093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284768 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=395739 Review URL: https://codereview.chromium.org/412543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284767 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This change makes the behavior of internal_handle_ in TempFile easier to reason about. This change is possible after a large refactoring of PnaclCoordinator that happened as a result of removing FileDownloader. BUG=239656 R=bbudge@chromium.org Review URL: https://codereview.chromium.org/413493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284766 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG=393810 TEST=gpu_unittests R=kbr@chromium.org,bajones@chromium.org Review URL: https://codereview.chromium.org/399153005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284764 0039d316-1c4b-4281-b951-d872f2087c98
-
simonhatch@chromium.org authored
Thought it would be nice to keep this feature disabled by default behind the experimental flag, but be able to potentially turn it on via a finch trial from chrome. Needs to land first: https://codereview.chromium.org/386943009/ BUG=370696 Review URL: https://codereview.chromium.org/389583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284762 0039d316-1c4b-4281-b951-d872f2087c98
-
aboxhall@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/377553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284761 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@chromium.org authored
Also added chrome_child.dll.pdb to telemetry_gpu_test isolate. This is in order to get better stack traces for debugging Issue 383963. BUG=385976,383963 NOTRY=true Review URL: https://codereview.chromium.org/409113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284760 0039d316-1c4b-4281-b951-d872f2087c98
-
varkha@chromium.org authored
BUG=178543 TEST=build embedded content shell with chromeos=1 and embedded=1 Review URL: https://codereview.chromium.org/400793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284759 0039d316-1c4b-4281-b951-d872f2087c98
-
tengs@chromium.org authored
BUG=390230 TEST=manual NOTRY=true Review URL: https://codereview.chromium.org/409903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284757 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
R=brettw@chromium.org BUG=394501 Review URL: https://codereview.chromium.org/409743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284756 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
BUG=396203 TBR=rouslan@chromium.org Review URL: https://codereview.chromium.org/408343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284755 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
Replace it with modern threading constructs: - PostTaskAndReplyWithResult gets rid of most of the logic FileThreadDeserializer was implementing. - The remainder logic didn't require any class state so it was moved to anonymous methods. Also declare JsonPrefStore explicitly NonThreadSafe (the only actions outside the UI thread should happen by posting anonymous tasks to the |sequenced_task_runner_|). This is a stepping stone in cleaning up JsonPrefStore to eventually get rid of PrefStore's ref-counting scheme. BUG=393081 Review URL: https://codereview.chromium.org/400673008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284754 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
BUG=395294 TEST=Manually tested disabling the plugin and canPlayType() returns "". R=ddorwin@chromium.org Review URL: https://codereview.chromium.org/399063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284753 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Use this implementation for mojo native_viewport. It will also be used for aura WindowTreeHost in subsequent patches. BUG=none R=ben@chromium.org Review URL: https://codereview.chromium.org/405813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284752 0039d316-1c4b-4281-b951-d872f2087c98
-
tdanderson@chromium.org authored
Add the new unit test WidgetTest.GestureEventDispatch to verify that non-scroll gesture events are dispatched to the correct views in a view hierarchy and that the default gesture handler in RootView is set correctly. This replaces the test ViewTest.GestureEvent. BUG=395397 TEST=WidgetTest.GestureEventDispatch Review URL: https://codereview.chromium.org/406943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284751 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
This is failing 75% of the time. This directory is created by copying files from other parts of the tree, and some of those have suppressions. So don't duplicate those suppressions. Also, this code isn't shipped. BUG=382995 R=thestig@chromium.org Review URL: https://codereview.chromium.org/409913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284750 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@chromium.org authored
TBR=zhaoqin@chromium.org BUG=396172 NOTRY=true Review URL: https://codereview.chromium.org/412623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284746 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284745 0039d316-1c4b-4281-b951-d872f2087c98
-
treib@chromium.org authored
This is a followup to https://codereview.chromium.org/353493002/ BUG=390520 Review URL: https://codereview.chromium.org/405433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284744 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
Sometimes fullscreen wasn't required in order to lock. In such case, fullscreen being left should have no consequence. BUG=162827 Review URL: https://codereview.chromium.org/409143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284743 0039d316-1c4b-4281-b951-d872f2087c98
-
naiem.shaik@gmail.com authored
Translate is turned into a component, classes and functions have to be moved to the translate:: namespace. BUG=331782 TEST=components_unittests:unit_tests --gtest_filter=Translate* TBR=thakis Review URL: https://codereview.chromium.org/378253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284742 0039d316-1c4b-4281-b951-d872f2087c98
-
limasdf@gmail.com authored
BUG=354046 Review URL: https://codereview.chromium.org/403843005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284741 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284740 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
I'm seeing asserts coming from PacedSender. The assert is not correct and should be removed. NOTRY=true TBR=miu BUG=none Review URL: https://codereview.chromium.org/409943004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284739 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178551:178666&mode=html TBR=johnme@chromium.org,pkasting@chromium.org BUG= Review URL: https://codereview.chromium.org/407143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284738 0039d316-1c4b-4281-b951-d872f2087c98
-
jvoung@chromium.org authored
The nexe isn't actually needed, so it could link against a dummy PNaCl shim. However, something weird is going on and it attempted to link against the real shim. See notes in reverted NaCl roll: https://codereview.chromium.org/409733002/ Leaving out some of the PNaCl targets which actually do manage to turn off pexe -> nexe translation. Since this is selectively done, beware of flipping 'build_pnacl_newlib': 0 to 1. BUG=none Review URL: https://codereview.chromium.org/409753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284737 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: https://codereview.chromium.org/401923004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284736 0039d316-1c4b-4281-b951-d872f2087c98
-
wajahat.s@samsung.com authored
FileOutStream should be closed in finally block in writeKeyToFile() method, as closing in try{} will not close and release system resources when an exeption is thrown. Also, catch relavant exception instead of catching generic exception. BUG=None. Review URL: https://codereview.chromium.org/405403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284735 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
BUG=349211 TEST=Existing tests pass. Review URL: https://codereview.chromium.org/407583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284734 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284733 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
This pulls in the following CLs: r1354: Use hash_set and hash_map instead of std::tr1::unordered_set and std::unordered_set. r1355: Enable crash reporting to work correctly when the library is inside another file (an archive). r1356: Annotate PageAllocator for MSan. BUG=394028,390618 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/411523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284732 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284731 0039d316-1c4b-4281-b951-d872f2087c98
-