GitLab

Bug: 938604
Change-Id: I376eeac8d5cf3fd6b8b5965953383ffcafa292a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787705Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@google.com>
Cr-Commit-Position: refs/heads/master@{#694357}

There will be a followup CL to move the WebUI mojo interfaces into the
existing discards.mojom file, as well as to clean up namespace usage.

Bug: 910288
Change-Id: Iafc09af534ed75a230477e4f59fa6aa9b07233c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787726Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694356}

Speculative fix to see if flake is related to preload=metadata
suspend/resume issues. This is the classic cause of this type of
problem, so it seems likely we've had another regression here.

BUG=986021
TEST=none
TBR=liberato

Change-Id: I44a7c9428a3b123ea9d17dbe6b6a25a028d845b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790262Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694355}

Roll ChromeOS orderfile from 78-3877.0-1566814872-benchmark-78.0.3893.0-r1 to 78-3877.0-1567418235-benchmark-78.0.3893.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: I2eb9b513cbecfd2ae16ae00cc22d1b50e920ac54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789993Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694354}

Bug: none
Change-Id: I1a5eef4a6e4e1956b6b28ecaa877729241c49642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790063
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694353}

Put these conversions in web_scheduling_priority.{cc,h}, next to the definition
of the WebSchedulingPriority enum

Change-Id: I329c581566b24029226524c1e1c8043b123d5589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785477Reviewed-by: Scott Haseley <shaseley@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694352}

Removes the close icon from the Bar in the new overlay
layout for Contextual Search. Leaves the Preview Tab unchanged.

Also changes the behavior of Tap on the Bar when not peeking in
the new layout -- now that just returns to the peeking position.

BUG=997748, 1000792

Change-Id: Icbd503d8cb5129af5ca4a9db164bf2ebdbc85ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785085Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694351}

This CL adds a way of retrieving the WebContents from an audio focus
request ID. This enables the Global Media Controls to keep track of the
WebContents associated with a media session. This CL uses this to track
whether the Global Media Controls are controlling foreground or
background media.

Bug: 1000679
Change-Id: I7a1cfb96f49bbaa1b359edf8ceaa20a493e3f8ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788506Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694350}

cr-lazy-render doesn't seem to be used in OOBE, so resolve Polymer 1->2
related TODOs:
- Use Polymer.Templatize instead of extending Templatizer behavior
- Delete Polymer 1 property forwarding methods

Bug: None
Change-Id: If69facb803059c40d89e522f6e8e016ac875a9ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786248Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694349}

ChromeOS does url bar animations using this code as well.

BUG=none
TEST=none

Change-Id: I5273cbd9205ff61ffa15c7bd8bcd63037840eb3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789986
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694348}

https://chromium-review.googlesource.com/c/chromium/src/+/1650524/
erroneously added a duplicate of the "securityKeysPINTooShort" key,
referencing a slightly different string.

Also delete the referenced string because it appears to be unused.

Change-Id: I441c598b6bea381a9725f6b6c7e410a87e7c65dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788235Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#694347}

Add DCHECK to ensure that user is not enrolled in supervision at the
start of the Add Supervision process. Avoids future errors where the
Add Supervision dialog is somehow launched despite the user already
being enrolled in supervision.

Bug: 977336
Change-Id: I0469fd4e11441176ecf79282ff12ff9a0dd707a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789272Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694346}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I3f8995cbfc6ecadff8d67d04bbb210bb4f74a89b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700833
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694345}

This CL updates NonModalViewControllerPresenter to not create animator
objects when the |animated| argument is NO.  This guarantees the
desired behavior since UIViewPropertyAnimator sometimes animate even
if the duration is set to zero.

Bug: 992385
Change-Id: I41126e0a3ec65e13a81ff7d153329eb5b04c5265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787447
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694344}

Keys for persistent data in the login screen storage now include owner
ID to clear data saved by each owner when its uninstalled.

Bug: 980171
Change-Id: Ie755faf6eec89a809b83f2df76b9a6d109a19f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753007
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694343}

Bug: 1000964,1001041
Change-Id: I84d41c0f7edaddb34fb1397c7191919673a60e01
TBR: abigailbklein@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788224
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694342}

Bug: 991838
Change-Id: I59cb109dc8cb01b373cb7f65f57775572ea5db0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764886
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694341}

https://android.googlesource.com/platform/external/perfetto.git/+log/debe648a37fc..744c8f48a089

git log debe648a37fc..744c8f48a089 --date=short --no-merges --format='%ad %ae %s'
2019-09-06 hjd@google.com Merge "ui: Only reset local time if we're taking ctrl time"
2019-09-06 treehugger-gerrit@google.com Merge "Fold perfetto_src_tracing_ipc into libperfetto_client"
2019-09-06 lalitm@google.com Merge "trace_processor: move db table names to macros"
2019-09-06 taylori@google.com Merge "perfetto-ui: Fix selection when searching"

Created with:
  gclient setdep -r src/third_party/perfetto@744c8f48a089

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I938c138899276dc180b561d5e0c9054dd8b534ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789690Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694340}

This patch adds an animation to show next image.

Bug: b/137228115
Test: new PhotoModelTest.* and manual

Change-Id: I70e2067cb35b5315c201c0d3769c5c092005fd5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762061Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694339}

This CL converts OOPIFs from using a compositor viewport that is the
entire size of the content layer, to a much smaller one based on the
visible intersection of the OOPIF's content with its parent's viewport.

This should decrease compositor resources used by the OOPIF, and
prevent excessively large tiles being produced.

This is a re-land of

https://chromium-review.googlesource.com/c/chromium/src/+/1778362

with a fix for the AwContentCapture tests.

TBR=mkwst@chromium.org

Bug: 852348
Change-Id: Idc7f5eda5cd743807365afcd8dd55d5f2a4e6df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778362
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#694066}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790043Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694338}

The goma settings are removed from the configs.
They could be added back if the compile is too slow.

In mb_config, compared to android-marshmallow-arm64-rel:
  * gpu_tests is removed since we don't want it running on emulator.
  * resource_whitelisting is kept as noted in crrev.com/c/1600421


Related CLs: crrev.com/c/1785743, crrev.com/c/1769798

Bug: 997376
Change-Id: I9727a8ad19ea619e39edfdeda6d2bd3a64798d55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788317Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#694337}

Change-Id: Iba620d8ba7b3c9258db9a0b883a3206326f96093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789534Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694336}

Introduce a handler that subscribes on changes in the installed login
screen extensions list and deletes login screen storage keys for
uninstalled extensions.

Bug: 980171
Change-Id: Ibf5380013ca00e93d6ecc66c868c1f9cafebc3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754027Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694335}

Bug: 721073
Change-Id: Ia38e755bfeb9e799a046156a72e1e60ff95291ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762938Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694334}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b1435392e02..4db74e30890d


Created with:
  gclient setdep -r src-internal@4db74e30890d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: None
Change-Id: I9a3ea4e12f26291a010408e0a7e4366d9bebdc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790089Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694333}

      org.chromium.webview_shell/.WebPlatformTestsActivity \
      -a android.intent.action.VIEW -d 'file:///sdcard/popup1.html'

Bug: 994939
Test: adb shell am start -n \
Change-Id: I49a633b5b2447d9cfe5329c41c10393e3766f746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788742Reviewed-by: Andrew Luo <aluo@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694332}

We want to ensure that the ImageLayerBridge will not try and dereference
a potential null skImage. Adding a check to assume it was a nullptr, even
if the StaticBitmapImage was not null but pointed internally to a null.
skImage.

Changing how the white skbitmap is generated inside webgl to be more
robust against a potential context loss.

Bug: 996287
Change-Id: I2c65a34faab9f26042c1f4ccb3eca23788955dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784983
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694331}

Bug: 982950
Change-Id: I515ed8c06ea19f33dcdfde26cc90249a70611447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783797Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694330}

This reverts commit 932dfd17.

Reason for revert: Dex fusing has been fixed in bundletool and
a new version has been rolled: crrev.com/c/1789178

Original change's description:
> Revert "Enable dist fusing for all feature modules. (reland)"
> 
> This reverts commit 78fac991.
> 
> Reason for revert: Breaking some internal builders. Will reland once they are no longer building these targets.
> 
> Original change's description:
> > Enable dist fusing for all feature modules. (reland)
> > 
> > Fixed: I have disabled building of the system image in next-* builds
> > so there should no longer be an issue. next-* builds can be re-enabled
> > when bundletool is updated.
> > 
> > This reverts commit 7c77403d.
> > 
> > Original change's description:
> > > Revert "Enable dist fusing for all feature modules."
> > > 
> > > This reverts commit 27ca1df7.
> > > 
> > > Reason for revert: This CL causes an official build failure
> > > https://crbug.com/996658
> > > 
> > > Original change's description:
> > > > Enable dist fusing for all feature modules.
> > > > 
> > > > Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431
> > > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > > > Commit-Queue: Ben Mason <benmason@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#689075}
> > > 
> > > TBR=tiborg@chromium.org,benmason@chromium.org
> > > 
> > > Change-Id: Ib696df42847a54c1257fae41ecb544df40f47e75
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764159
> > > Reviewed-by: Alex Ilin <alexilin@chromium.org>
> > > Commit-Queue: Alex Ilin <alexilin@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#689454}
> > 
> > TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Change-Id: Id4687e7980b238cdbea04a1c8921b57a974f7cd0
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768946
> > Reviewed-by: Ben Mason <benmason@chromium.org>
> > Commit-Queue: Ben Mason <benmason@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#689947}
> 
> TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Ib1558378a9b2a12b7f0260a04eeb1fbe4d1330b1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773836
> Reviewed-by: Ben Mason <benmason@chromium.org>
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#690995}

TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I5f5e2aa67eebca73b2109116b4d1beba82755d55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789826Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694329}

"tree id=67228E93CA923929527DFFCB9DE1AB88
node id=2 role=rootWebArea state={"focusable":true} parentID=369 childIds=[5]
  node id=5 role=textField state={"editable":true,"focusable":true,"multiline":true,"richlyEditable":true,"focused":true} parentID=2 childIds=[7] name=Document content
    node id=7 role=paragraph state={"editable":true,"richlyEditable":true} parentID=5 childIds=[9,14,19]
      node id=9 role=staticText state={"editable":true,"richlyEditable":true} parentID=7 childIds=[278] name=One two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen
        node id=278 role=inlineTextBox state={} parentID=9 childIds=[] name=One two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen
      node id=14 role=staticText state={"editable":true,"richlyEditable":true} parentID=7 childIds=[280] name=seventeen eighteen nineteen twenty One two three four five six seven eight nine ten eleven
        node id=280 role=inlineTextBox state={} parentID=14 childIds=[] name=seventeen eighteen nineteen twenty One two three four five six seven eight nine ten eleven
      node id=19 role=staticText state={"editable":true,"richlyEditable":true} parentID=7 childIds=[282] name=twelve thirteen fourteen fifteen sixteen seventeen eighteen nineteen twenty
        node id=282 role=inlineTextBox state={} parentID=19 childIds=[] name=twelve thirteen fourteen fifteen sixteen seventeen eighteen nineteen twenty
"
js> id9.toString()
"node id=9 role=staticText state={"editable":true,"richlyEditable":true} parentID=7 childIds=[278] name=One two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen"
js> id9.firstChild.toString()
"node id=278 role=inlineTextBox state={} parentID=9 childIds=[] name=One two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen"
js> id9.nextOnLine.toString()
"node id=279 role=inlineTextBox state={"ignored":true,"offscreen":true} parentID=7 childIds=[] name=
"

Node 279 isn't actually in the tree and triggers bad editable line output.

Bug: b:140615809,1001562
Change-Id: I4eeaeb1019f77d6fcba688f65230843c7ff4ff48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790042
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694328}

Also, remove any references to the word "virtual", as from now on
the feature will be just called "Desks".

BUG=1001568
TEST=Manually.

Change-Id: If3832d2b58fb0b4c1c20ecd85887e86cc20dad58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790285Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694327}

https://skia.googlesource.com/skia.git/+log/6d1c0d4196f1..172bb44f2d66

git log 6d1c0d4196f1..172bb44f2d66 --date=short --no-merges --format='%ad %ae %s'
2019-09-06 brianosman@google.com Make the size of program/pipeline caches configurable in GrContextOptions
2019-09-06 reed@google.com use scratch path to save on mallocs in drawAtlas
2019-09-06 robertphillips@google.com Remove IORefs from GrSurface
2019-09-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0c35e0f44dbd..df0ce01870fa (5 commits)
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e96090c3..64926377 (605 commits)
2019-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cf0e2fe12289..5d0faf9be9d7 (4 commits)
2019-09-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-05 herb@google.com Remove bool for RemoteStrike send
2019-09-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-05 reed@google.com reverse/restore order of verbs in path to be forward (normal)
2019-09-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-09-05 khushalsagar@chromium.org Reland: Only send the RemoteStrikes that have pending glyphs.
2019-09-05 egdaniel@google.com Begin renderpasses immediately in GrVkOpsRenderPass.
2019-09-05 jvanverth@google.com Add touch support to viewer
2019-09-05 michaelludwig@google.com Clean up prior backdrop-filter CL
2019-09-05 egdaniel@google.com Update some ops to create their buffers in onPrepare.
2019-09-05 ethannicholas@google.com Revert "switched SkSL interpreter over to threaded code"
2019-09-05 ethannicholas@google.com switched SkSL interpreter over to threaded code
2019-09-05 rmistry@google.com Allow PRIVATE_SKPS_GS to be empty in assets/skp/create.py

Created with:
  gclient setdep -r src/third_party/skia@172bb44f2d66

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jlavrova@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:999682
Change-Id: I474cd2dc07896c2c1a91e4fdc9b473021e1ddb6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789870Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694326}

The Windows bits were outdated.

Bug: none
Change-Id: I45fd6b70e013491080bc7028b7ce5be600e8fab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790124
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694325}

Changes:
	- Added label to 'Emulate CSS media' combobox

Screen Reader on Rendering Page:
        - https://imgur.com/YsTeXiW

SR reading label twice bug present in this tool's checkboxes:
        - https://github.com/nvaccess/nvda/issues/7948
        - https://github.com/nvaccess/nvda/issues/8885

Bug: 963183
Change-Id: I4711ef42b573f62770fb64b237077de5d20ee06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656733
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694324}

Add LoginScreenStorageListKeys() and LoginScreenStorageDelete() methods
to the SessionManagerClient.

Bug: 980171
Change-Id: Ib4492bc9dc9019798895b84f08d3c35c7d516994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753924Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Zakhar Voit <voit@google.com>
Cr-Commit-Position: refs/heads/master@{#694323}

https://webrtc.googlesource.com/src.git/+log/30323e2fb25a..b64d65e67bff

git log 30323e2fb25a..b64d65e67bff --date=short --no-merges --format='%ad %ae %s'
2019-09-06 yvesg@webrtc.org Fix NetworkEmulationManagerTest.ThroughputStats flakiness.
2019-09-06 saza@webrtc.org Remove completed TODOs

Created with:
  gclient setdep -r src/third_party/webrtc@b64d65e67bff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: Ic38017053810823c7b2b212a00e8aee592dc386b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790088Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694322}

This change:
1) Adds support to run-swarmed for targeting macOS
2) Adds a --swarming-os argument that allows specifying the OS the
   targets should run on, which is useful for targeting specific OS
   versions and such
3) Makes the outdir and target arguments mandatory positional args
   instead of named args, since they were/are required anyway (the
   script crashes if they aren't given)
4) Removes Fuchsia-specific defaults and documentation references
5) Renames the test_name argument to target_name for more consistency
   with gn/ninja parlance
6) Updates doc references, especially for #3

Bug: None
Change-Id: I64051d3e35d6b143d7688083a3c0877ffbf06ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787587
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694321}

We would like the bitmap list in BitmapCursorOzone to be either empty
or every bitmap be valid. If the provided bitmap is null, just don't
add it to the list. Instances created from WebCursors can sometimes
have null bitmaps.

Bug: 620927
Change-Id: I0e78bfcb544fe6751dc48e378e495feaec220af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789909Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694320}

This brings the frame context menu available on other platforms to Mac
and allows users to restore the previously closed tab within the
tabstrip.

BUG=997637
TEST=Right clicking at frame and contents boundaries in tabbed Chrome.

Change-Id: I3c4129641d398e38786cfa7d501edc32f2e92252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786935
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694319}

https://chromium.googlesource.com/angle/angle.git/+log/e64cea302acd..32d6006bf2ef

git log e64cea302acd..32d6006bf2ef --date=short --no-merges --format='%ad %ae %s'
2019-09-06 geofflang@chromium.org Don't block setting the DEPTH_STENCIL attachment based on the resource format.
2019-09-06 timvp@google.com Refactor ShaderVariable to Remove Specializations
2019-09-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 34953810a62c..664ad418f845 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@32d6006bf2ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org,jmadill@google.com

Bug: chromium:997702,chromium:None
Change-Id: I707d0c92cc6c6f2a65565493576b0f2a6eb536bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790082Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694318}