GitLab

Bug: 931806
Change-Id: I89db8c24edfb9a7e1c4c6bf3ac3d0faa68d70ca1
Reviewed-on: https://chromium-review.googlesource.com/c/1472450
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636087}

This CL is adding the FROM_HERE location of the call sites to each
ScopedBlockingCall. This modification will provide the
detailed location to the trace events and allow developpers do
understand cause of janks of long tasks.

This CL is adding manually the cases not caught by the previous CL:
  https://chromium-review.googlesource.com/c/chromium/src/+/1483834


TBR=gab@chromium.org

Bug: 934302
Change-Id: Id2b959ef007fd7fec6d5b7cf8373f93e816c8195
Reviewed-on: https://chromium-review.googlesource.com/c/1491896Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636086}

Bug: 897998
Change-Id: I4d3071a44efcbf539447b5cceb0e6430b3616e90
Reviewed-on: https://chromium-review.googlesource.com/c/1490500
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636085}

Change-Id: I8080c2db41db07908e4aaa76fb4138750a9a0eb8
Reviewed-on: https://chromium-review.googlesource.com/c/1478076
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636084}

This will enable tests to receive callback executions from FakeWebFrame
and configure what FakeWebFrame passes to callback. Also allows for
configuring CanCallJavascriptFunction to return false.

Change-Id: I5b84d88c2df0e30ec7d81b48b0cf9a5c66a18c51
Reviewed-on: https://chromium-review.googlesource.com/c/1482136
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636083}

Following bot results are included.
15799 15805 15821 15829 15836 15847 15852 15859

3 lines were removed and 6 lines were deflaked by consecutive
results since 15769.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: I6e6567eb120e96817e6690cd5430b4ade409e324
Reviewed-on: https://chromium-review.googlesource.com/c/1489651Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636082}

This reverts ba496ac3.

BUG=936080,933153

Change-Id: Ic173698e5285806763606b5cf38d5078947df11f
Reviewed-on: https://chromium-review.googlesource.com/c/1489637Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636081}

PIN keyboard should only be visible when device is in tablet mode.
Update view layout and add handling of gestures to move focus of access
code input.

Bug: 911326
Test: ParentAccessViewTest
Change-Id: I66ac5a039549312d1686875478ae6fa743082bd5
Reviewed-on: https://chromium-review.googlesource.com/c/1480824Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636080}

With CL [1], if a compositor animation was running, any changes
to transforms, filters, or effects were ignored during the animation,
including properties other than the ones being animated. For example,
if a transform animation was running, any changes to
backface-visibility would also be ignored, even though that change
is not handled by the compositor. With this CL, only changes to the
specific properties that can be animated on the compositor (e.g.
the transform matrix) will be ignored, while other changes will
still cause a commit.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1459592


Bug: 933141
Change-Id: If6be65239c20dd36e721e5cf4e84db992e7369c6
Reviewed-on: https://chromium-review.googlesource.com/c/1484072
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636079}

tbr: spqchan@chromium.org
Bug: 936475
Change-Id: I61678d76dfa7586a92872edca3fcc7131a604501
Reviewed-on: https://chromium-review.googlesource.com/c/1492231Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636078}

TBR: dgozman@chromium.org
No-Try: true
Bug: 936479
Change-Id: I57919f0358c30575a980377534a06b4e8ecf0760
Reviewed-on: https://chromium-review.googlesource.com/c/1492174Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636077}

A previous CL made the background color the same in all session states:
https://chromium-review.googlesource.com/c/chromium/src/+/1374197

BUG=920968

Change-Id: I50a781c9a16bf3490174d1b636bfb5a7b600561d
Reviewed-on: https://chromium-review.googlesource.com/c/1490893Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636076}

Bug: 927195
Change-Id: I8a6dbe9df6471cbb12f623fc359a88c6d1405a20
Reviewed-on: https://chromium-review.googlesource.com/c/1489177Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636075}

The indicator is confusing. Also, SingleProcessMash is about to enter
Finch dev trials and it will be even more confusing if the indicator
comes and goes.

"SingleProcessMash" still appears in about:version next to the platform
version. On test images, it also appears at the lock screen next to
that version number.

Bug: 924798
Change-Id: I481006b2a9ee88071aae3a8852467a7086e590f0
Reviewed-on: https://chromium-review.googlesource.com/c/1491767Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636074}

Bug: 915568
Change-Id: I827ee479965bba614e01a4dee3d1b117e7b031c6
Reviewed-on: https://chromium-review.googlesource.com/c/1480353Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636073}

This CL applies an Aria attribute onto the media (video/audio) to indicate
buffering.

Change-Id: I01032bb047316f4f0408f7c106f8fea0fab8ccbe
Reviewed-on: https://chromium-review.googlesource.com/c/1444612Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636072}

This CL removes an odd but obsolete feature to the Chromium linker,
which added a 16 MiB guard region when loading a given native library.

This was done a long time ago when our build system used to process
'regular' shared libraries generated by the linker, in order to compress
relocations inside it using a custom scheme. Said relocations were
later uncompressed / processed at load time through a static C++
initializer.

The main drawback of this scheme was that it modified the
correspondance between virtual addresses in the ELF files, and their
actual mapped location. This created all kind of chaos for tools like
Breakpad, and the guard region was added to mitigate the issue.

This custom compression scheme has been completely discarded, in favor
of adding the necessary machinery to the linker itself, in order to
directly generate shared libraries with the right compressed
relocations (which are of course supported by the crazy linker), without
any virtual / mapping address space discrepancies.

As such, this trick is no longer needed, simplifying our code.

This will also make it considerably easier to implementing
android_dlopen_ext() in the crazy linker.

BUG=504410,936001
R=pasko@chromium.org, agrieve@chromium.org, cjgrant@chromium.org

Change-Id: I5a38b952442160072f0e24f48289f41f0269cdc6
Reviewed-on: https://chromium-review.googlesource.com/c/1491271Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636071}

We believe that we're still seeing issues with setting new fields in
a protobuf storing information about metrics. This CL reverts setting
those fields, and one problematic place where we set a related boolean.

OmniboxEventProto.IsKeywordSuggestion - per suggestion
OmniboxEventProto.InKeywordMode - per navigation
OmniboxEventProto.KeywordModeEntryMethod - if previous field true

Original CL: 1351452

Bug: 934316
Change-Id: I099bec55826cb663dee449673a16f4ff1890e2da
Reviewed-on: https://chromium-review.googlesource.com/c/1481732Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636070}

Use reftest-wait to avoid the test finishing too early.

Change-Id: I2f568e1b4fe55eccec9f07012d7c7f8f6b66fd15
Reviewed-on: https://chromium-review.googlesource.com/c/1491135
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636069}

Bug: 891339
Change-Id: I76dc38e26dd359c656e16910dfb1d317e2f64528
Reviewed-on: https://chromium-review.googlesource.com/c/1470691
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636068}

https://android.googlesource.com/platform/external/perfetto.git/+log/5450dc0a9c83..617f4eb4e5b7


git log 5450dc0a9c83..617f4eb4e5b7 --date=short --no-merges --format='%ad %ae %s'
2019-02-27 primiano@google.com Merge "Make Producer.CreateTraceWriter thread-safe"
2019-02-27 hjd@google.com perfetto-ui: Unify track and track group borders
2019-02-27 hjd@google.com perfetto-ui: Remove 'Tracks' header panel


Created with:
  gclient setdep -r src/third_party/perfetto@617f4eb4e5b7

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ib53566536d684e1cde9a19a2e84717a1d7d732be
Reviewed-on: https://chromium-review.googlesource.com/c/1491763Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636067}

Change-Id: I81198806879df502bc3eb1b7522330c3c4a82805
Reviewed-on: https://chromium-review.googlesource.com/c/1491553
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636066}

R=drubery

Bug: 934060
Change-Id: Id95aeeead0dc3c5e60bf837d1bc8222385633471
Reviewed-on: https://chromium-review.googlesource.com/c/1490905
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636065}

Bug: 739844
Change-Id: Icf443d02de9567e9f7aacfc04141551337fe8fbb
Reviewed-on: https://chromium-review.googlesource.com/c/1488926
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636064}

These tests were in http_proxy_client_socket_pool_unittest.cc.
Since the HttpProxyClientSocketPool has since been removed, they need
a new home. This CL moves them in with most of the other socket tagging
tests, in TransportClientSocketPool's unit test file.

This is part of an effort to flatten the socket pools.
https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit

Bug: 472729
Change-Id: Ibf5a26aef732108cb5e1cfedcaf92811387091e3
Reviewed-on: https://chromium-review.googlesource.com/c/1471910
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636063}

Replace const SVGComputedStyle* with const SVGComputedStyle& as the
argument to the Diff*, InheritFrom and CopyNonInheritedFromCached
methods.

Change-Id: I79c14a39c09089882857fcbe61f4578c18cdd5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1491655Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#636062}

- Reloads client_state file every time
- Added possibility to save state keys for clients
- LocalPolicyTestServer provides function to store configuration file

I'm gonna introduce LocalPolicyTestServerMixin in the next CL

Bug: 934224
Change-Id: I7960159b5db8c62e2515f8cedccd469e66a4192e
Reviewed-on: https://chromium-review.googlesource.com/c/1482459
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636061}

https://skia.googlesource.com/skia.git/+log/ff84d8a900d4..cc61a2caa270


git log ff84d8a900d4..cc61a2caa270 --date=short --no-merges --format='%ad %ae %s'
2019-02-27 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@cc61a2caa270

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I175655299d62488535da86204e850b30662752c4
Reviewed-on: https://chromium-review.googlesource.com/c/1491761Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636060}

Bug: 905419
Change-Id: I3ef77b79942eba2e3e49775cd8195789f0554cf5
Reviewed-on: https://chromium-review.googlesource.com/c/1490446Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636059}

retry of submitted CL https://chromium-review.googlesource.com/c/chromium/src/+/1484391.


Bug: 911427
Change-Id: Iedc7fde60fd412f3e8f9e548fd6ada85e693fcb4
Reviewed-on: https://chromium-review.googlesource.com/c/1490357Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636058}

Change-Id: I8736851478dc42f877295ecf3c17c98389d63e9e
Reviewed-on: https://chromium-review.googlesource.com/c/1490112Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#636057}

ToT WebmMuxer supports Opus with >2 channels. This configuration is
never actually used (because AudioMediaStreams in Chrome don't
support it [1]) and can cause a write after bounds (see bug). This
CL removes the guilty code by not supporting >2 channels audio.

[1] https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/blink/renderer/modules/mediarecorder/README.md#can-record-stereo

Bug: 930035
Change-Id: I964c66bc660e76ee152563804c63276643f4acd6
Reviewed-on: https://chromium-review.googlesource.com/c/1489185
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636056}

Bug: 936155
Change-Id: I13d30f3a8d3893e2e27b696797f09cc5c5643495
Reviewed-on: https://chromium-review.googlesource.com/c/1490733
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636055}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbe224bbe87b..0c952caaabe0


Created with:
  gclient setdep -r src-internal@0c952caaabe0

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id7d53d5928abf8e7d52816c7475b51c5ed804748
Reviewed-on: https://chromium-review.googlesource.com/c/1491759Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636054}

ThumbnailCache::DecompressThumbnailFromFile() was originally
used in Hera. After Hera was unlaunched, it has been unused until
repurposed for TabGridLayoutAndroid feature.

Grid layout needs to read the thumbnail and show it in the tab
switcher, so the priority should be increased to USER_VISIBLE.

Bug: 930929
Change-Id: I203a0e01331e2b0153e0b0c92221880e8779b2a9
Reviewed-on: https://chromium-review.googlesource.com/c/1487776Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636053}

Enables the Ephemeral Tab, aka "Sneak peek" context menu item, to our
testing configuration.

BUG=894619

Change-Id: I9ed3499fa74cc8124641524e79b6a0976ba7eb6b
Reviewed-on: https://chromium-review.googlesource.com/c/1368586Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636052}

Due to crbug.com/892612, the AutofillDriver can live
longer than the webFrame.
As a consequence, it is not possible to store the
frame pointer and the WebFrame must be retrieved using
the frame ID before each use.

Bug: 935003
Change-Id: I5462907be5d7d2f70900c135af16ac3e774fae16
Reviewed-on: https://chromium-review.googlesource.com/c/1488791Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636051}

Tbr: jochen@chromium.org
Bug: 843903
Change-Id: Iadcfb46bdda3692b3b8717176c2ef992f83ba472
Reviewed-on: https://chromium-review.googlesource.com/c/1491653
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636050}

Clusterfuzz identified a null pointer dereference in
ComputedAccessibleNode. The local frame is requested from the document
reference stored on the element, which can be null.

BUG=919310

Change-Id: I9deb28a0dea042ffc96dba7ce8ddd9efeeab2bd8
Reviewed-on: https://chromium-review.googlesource.com/c/1457696
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636049}

Implements the client end of the CryptAuth v2 Enrollment protocol, which
consists of two request/response interactions with the CryptAuth
servers:

1a) SyncKeysRequest: Contains the names of key bundles used by us--the
    client--as well as the handles and metadata of any existing keys in
    those key bundles. General metadata about the local device, such as
    hardware and feature support, is also included. Even if new key
    bundles are not being enrolled and no metadata is being changed, the
    Enrollment protocol requires periodic check-ins with the CryptAuth
    server.

1b) SyncKeysResponse: The response from CryptAuth includes instructions
    about what existing keys should be active, inactive, or deleted
    altogether. It also provides information about what new keys, if
    any, should be generated and added to one of the key bundles listed
    in the request.  Aside from key instructions, a client directive is
    returned, which provides paramaters related to scheduling the next
    check-in with the server.

2a) EnrollKeysRequest: The second request in the Enrollment protocol is
    only necessary if the client needs to enroll new keys, as denoted in
    the SyncKeysResponse. The request contains information such as the
    material of the new public key (if it is an asymmetric key) and
    necessary proof for verifying that we indeed possess the private or
    symmetric key.

2b) EnrollKeysResponse: We simply view this response as an indication
    that the EnrollKeysRequest was sucessful.

The enrollment flow is triggered on construction, and when the
enrollment attempt finishes--successfully or not--the |callback| is
invoked.

Bug: 899080
Change-Id: I3bb662677b21247180e96dc96bf6eea7c4af25df
Reviewed-on: https://chromium-review.googlesource.com/c/1464966
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636048}