GitLab

This CL removes some dead code from dialog_delegate_unittest.cc. r206950 made
the TestDialog class a ButtonListener and added the last_pressed_button()
method. However r372427 removed the last usages of TestDialog as a
ButtonListener. This CL modifies TestDialog to not be a ButtonListener anymore
and removes the associated dead code.

BUG=NONE

Review-Url: https://codereview.chromium.org/2605273002
Cr-Commit-Position: refs/heads/master@{#440970}

https://skia.googlesource.com/skia.git/+log/db90e26e2bb7..85ff84821d5f

$ git log db90e26e2..85ff84821 --date=short --no-merges --format='%ad %ae %s'
2016-12-29 reed remove unused ForceUnique option from makeImageSnapshot

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=liyuqian@google.com

Review-Url: https://codereview.chromium.org/2607153002
Cr-Commit-Position: refs/heads/master@{#440969}

https://boringssl.googlesource.com/boringssl/+log/48e2be247a02a727487b19e745fcf6c24cc8823d..a81967b47c5eba78aedccd2bc3cb3fb95fe80bd0

BUG=none

Review-Url: https://codereview.chromium.org/2607143002
Cr-Commit-Position: refs/heads/master@{#440968}

Add UserActiveDirectoryPolicyManager configuration policy provider as a
browser context keyed service for Active Directory user policy.  To
avoid code duplication, the corresponding factory is shared with
UserCloudPolicyManager.  (Only one of the two managers can exist at the
same time.)  To clarify the factory's new role, the "Cloud" is dropped
from its name ("UserCloudPolicyManagerFactoryChromeOS").

As user and device Active Directory policy managers are very similar,
they probably should be merged in a future CL.

BUG=655971
TBR=sky (function rename in managed_bookmark_service_factory.cc)
TBR=achuith (a few renames in chrome/browser/chromeos/login)
TBR=anthonyvd (renames, type generalization in chrome/browser/profiles)
TBR=dbeam (renames propagated to policy_ui_handler.cc)

Review-Url: https://codereview.chromium.org/2606773002
Cr-Commit-Position: refs/heads/master@{#440967}

[google_landing_controller scrolledToTop] is set at the begining of
animation.
This make taps done just after another tap flaky.
Add a wait on animateHeader to wait until animation is finished.

BUG=None

Review-Url: https://codereview.chromium.org/2606023003
Cr-Commit-Position: refs/heads/master@{#440966}

include -> import
+#import "base/ios/block_types.h"
+#import "base/mac/bind_objc_block.h"
+#import "base/mac/scoped_nsobject.h"
+#import "base/test/ios/wait_util.h"
+#import "ios/chrome/app/application_delegate/metrics_mediator.h"
+#import "ios/chrome/app/application_delegate/metrics_mediator_testing.h"
+#import "ios/chrome/browser/signin/authentication_service.h"
+#import "ios/chrome/browser/ui/uikit_ui_util.h"
+#import "ios/chrome/test/app/histogram_test_util.h"
+#import "ios/chrome/test/app/history_test_util.h"
+#import "ios/chrome/test/base/perf_test_ios.h"
+#import "ios/chrome/test/block_cleanup_test.h"
+#import "ios/chrome/test/ocmock/scoped_mock_object.h"
+#import "ios/public/provider/chrome/browser/chrome_browser_provider.h"
+#import "ios/web/public/web_client.h"
+#import "ios/web/public/web_state/web_state.h"
+#import "testing/gtest_mac.h"
+#import <Foundation/Foundation.h>

import -> include
+#include "ios/chrome/test/app/bookmarks_test_util.h"
+#include "ios/chrome/test/app/settings_test_util.h"
+#include "ios/chrome/test/base/scoped_block_swizzler.h"
+#include "ios/chrome/test/earl_grey/accessibility_util.h"
+#include "ios/chrome/test/earl_grey/chrome_util.h"

Review-Url: https://codereview.chromium.org/2608733002
Cr-Commit-Position: refs/heads/master@{#440965}

In edited code is possible usage of not initialized array. It's caused
by reason, that GetProgramInfoLog and GetShaderInfoLog functions can end
without filling of the passed array. This error can be detected by MSan.
To fix this problem arrays was initialized before being passed and
printed.

R=aelias@chromium.org
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2600113002
Cr-Commit-Position: refs/heads/master@{#440964}

BUG=645640

Review-Url: https://codereview.chromium.org/2598423002
Cr-Commit-Position: refs/heads/master@{#440963}

https://skia.googlesource.com/skia.git/+log/a4cb388c0fe8..db90e26e2bb7

$ git log a4cb388c0..db90e26e2 --date=short --no-merges --format='%ad %ae %s'
2016-12-27 liyuqian Fix typos in the sheriffing document

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=liyuqian@google.com

Review-Url: https://codereview.chromium.org/2602063002
Cr-Commit-Position: refs/heads/master@{#440962}

BUG=637415

Review-Url: https://codereview.chromium.org/2607113002
Cr-Commit-Position: refs/heads/master@{#440961}

There are some crash reports in android webview that suggests this
pointer is null and used. In android webview, the app gets the touch
events first, so can modify or drop events however they want. That may
be the reason certain assumptions holds in chrome, but not in webview.

Assuming that's the case, just add null checks before use.

BUG=675772

Review-Url: https://codereview.chromium.org/2595943003
Cr-Commit-Position: refs/heads/master@{#440960}

There are a lot of OWNERS files that are related to DRP, DataUsage, and
Precache. This CL aims to point the various OWNERS files to a single
source for each of thos components.

BUG=

Review-Url: https://codereview.chromium.org/2607763003
Cr-Commit-Position: refs/heads/master@{#440959}

BUG=663359

Review-Url: https://codereview.chromium.org/2609543002
Cr-Commit-Position: refs/heads/master@{#440958}

When Clearing Presented state, it is possible that no Visible item
exists.
Check before dereferencing.

Fix cl/2606873002

BUG=674986

Review-Url: https://codereview.chromium.org/2608733003
Cr-Commit-Position: refs/heads/master@{#440957}

The favicon load was at race with the page load event, which caused flakiness
in tests that verified, at page load completion time, the number of evaluated
loads recorded into histograms.

BUG=677370

Review-Url: https://codereview.chromium.org/2604173002
Cr-Commit-Position: refs/heads/master@{#440956}

Changing directly the URL may have side effects beside hiding the
scheme.
Move the formatting to GetFormattedURL.
Also refactor ToolbarModelIOS to inherit ToolbarModel.

BUG=674986

Review-Url: https://codereview.chromium.org/2606873002
Cr-Commit-Position: refs/heads/master@{#440955}

Move existing description of HarfBuzzShaper internals into shaping
section, add outline of other essential text stack functionality.

Review-Url: https://codereview.chromium.org/2601953002
Cr-Commit-Position: refs/heads/master@{#440954}

Test times out randomly on device.

BUG=493427

Review-Url: https://codereview.chromium.org/2601253002
Cr-Commit-Position: refs/heads/master@{#440953}

Instead of blanket activation, bring the tests closer to reality by setting the
subresource filtering in `activation list` mode, and bringing up a
TestSafeBrowsingService, which allows the tests to artificially mark URLs as
blacklisted, and thus allows the subresource filtering logic to receive an
activation signal when these URLs are navigated to in the main frame.

The CL also changes the test to trigger same-page navigations from the renderer
side, to prevent WebContentsObservers seeing duplicate (nested) navigations
when browser-side navigation is enabled.

BUG=637415

Review-Url: https://codereview.chromium.org/2601773005
Cr-Commit-Position: refs/heads/master@{#440952}

This UMA and code is misleading because the shared worker ref count in
RenderProcessHostImpl actually is not the number of running shared
workers. We've added comments since that clarify it.

If we want this UMA back we can add a new one later. I'll add current
stats to the bug.

BUG=403258

Review-Url: https://codereview.chromium.org/2607513002
Cr-Commit-Position: refs/heads/master@{#440951}

At Opera we test our SDK on an old MIPS device with a
peculiar toolchain. To be able to compile ImageDocument.o,
we need to call std::round(), not just round().

BUG=none

Review-Url: https://codereview.chromium.org/2548783002
Cr-Commit-Position: refs/heads/master@{#440950}

- Switching of BVC is not always immediate. Add a Wait condition.
- FastSwipe gesture sometimes fail to switch mode. Use SlowSwipe.

Review-Url: https://codereview.chromium.org/2602943002
Cr-Commit-Position: refs/heads/master@{#440949}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/24348df..3ae6916

$ git log 24348df..3ae6916 --date=short --no-merges --format=%ad %ae %s
2016-12-29 kjellander@webrtc.org Add iOS64 simulator bot running on iOS 9.0 simulator.
2016-12-28 zhihuang@webrtc.org Prepare to introduce the IceTransportInternal.
2016-12-28 kjellander@webrtc.org Revert of Disable flaky test VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9 (patchset #1 id:1 of https://codereview.webrtc.org/2568743007/ )
2016-12-28 sprang@webrtc.org Add frame rate throttling to vp8 screenshare_layers.
2016-12-28 mbonadei@webrtc.org Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check.

TBR=kjellander
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2609533002
Cr-Commit-Position: refs/heads/master@{#440948}

This has the side-effect of using the new GPU integration test harness
for these tests.

BUG=352807, 676701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2607073002
Cr-Commit-Position: refs/heads/master@{#440947}

[ToolsMenuViewToolsCell imageForImageId:] checked that id was not-zero.
Current implementation DCHECKS.
Add tests.
This is a follow up of https://codereview.chromium.org/2602903002/

TBR=marq

Review-Url: https://codereview.chromium.org/2608693002
Cr-Commit-Position: refs/heads/master@{#440946}

Cr-Commit-Position: refs/heads/master@{#440945}

BUG=677275
TEST=manual

Review-Url: https://codereview.chromium.org/2601933002
Cr-Commit-Position: refs/heads/master@{#440944}

BUG=

Review-Url: https://codereview.chromium.org/2602843002
Cr-Commit-Position: refs/heads/master@{#440943}

BUG=621697

Review-Url: https://codereview.chromium.org/2577713002
Cr-Commit-Position: refs/heads/master@{#440942}

BUG=579229
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2601993002
Cr-Commit-Position: refs/heads/master@{#440941}

- adds options to automatically duck/unduck, suspend/resume audio based on tts events.

BUG=621697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563013003
Cr-Commit-Position: refs/heads/master@{#440940}

BUG=none

Review-Url: https://codereview.chromium.org/2604013003
Cr-Commit-Position: refs/heads/master@{#440939}

BUG=579229

Review-Url: https://codereview.chromium.org/2605433002
Cr-Commit-Position: refs/heads/master@{#440938}

- os.path is provided by input_api, and it's preferred to use it
- time does not seem to be used any more
- input_api.change.AffectedFiles() with a "starts with my dir" filter
  is equivalent to input_api.AffectedFiles(); also, harness file_filter=
- os.path.split()[1] is equivalent to os.path.basename(), which is more
  readable, IMO

R=calamity@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2599593003
Cr-Commit-Position: refs/heads/master@{#440937}

Include quic_str_cat.h in all the places it's used.

Merge internal change: 142874387
https://codereview.chromium.org/2609483002/

QUIC - refactor in preparation for two streams per HTTP transaction.

The IETF WG is moving to model of using a pair of streams per

https://quicwg.github.io/base-drafts/draft-ietf-quic-http.html#rfc.section.4.2

This scheme above came about in the course of discussions on QUIC
specific changes to HPACK that will hopefully eliminate HPACK induced
HoL blocking.

This change is a refactor of QuicHeadersStream and QuicSpdySession,
moving per-session granularity items from the former to the latter.  It
does not yet make headers stream per request, but this helps prepare the way.

na/ (refactor only - no functional change).

Merge internal change: 142825457
https://codereview.chromium.org/2607873002/

BUG=

Review-Url: https://codereview.chromium.org/2609493002
Cr-Commit-Position: refs/heads/master@{#440936}

https://chromium.googlesource.com/chromium/src/+/009b4fbe8df40

BUG=674098
TBR=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2609493003 .
Cr-Commit-Position: refs/heads/master@{#440935}

Cr-Commit-Position: refs/heads/master@{#440934}

CertificateReportingService::ShutDown posts a task to the IO thread to
delete reporter_. If the service's destructor is already run, this will
cause a crash during shutdown. Instead, delete reporter_ using a static
method and without referencing CertificateReportingService's |this|.

BUG=677329

Review-Url: https://codereview.chromium.org/2601203002
Cr-Commit-Position: refs/heads/master@{#440933}

https://skia.googlesource.com/skia.git/+log/e02d3caab823..a4cb388c0fe8

$ git log e02d3caab..a4cb388c0 --date=short --no-merges --format='%ad %ae %s'
2016-12-29 brianosman Revert "Add ImageToColorSpace helper in SkImageFilter"

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=liyuqian@google.com

Review-Url: https://codereview.chromium.org/2608663002
Cr-Commit-Position: refs/heads/master@{#440932}

New code should be using HttpRequestHeaders or HttpResponseHeaders,
as appropriate.

BUG=none

Review-Url: https://codereview.chromium.org/2608563002
Cr-Commit-Position: refs/heads/master@{#440931}