- 15 Jun, 2018 40 commits
-
-
Sergei Datsenko authored
Use paths rooted to mount point when communicating with drivefs. BUG=chromium:848126 Change-Id: I3756fe7ebd9ec5aaef8237c4a91209e7db8cdef2 Reviewed-on: https://chromium-review.googlesource.com/1100729 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567541}
-
Ned Nguyen authored
Change-Id: I27304a169825489fd0b3af42c10c7581c0602c12 Reviewed-on: https://chromium-review.googlesource.com/1101922 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#567540}
-
Nicholas Verne authored
The old version of this test could cause a browser crash by shutting down too early. Now we wait until the flow has finished and the installer view is closed before shutting down. Bug: 851253 Change-Id: I9f00f23587d2e3b52c8b1355f682e5397a460de1 Reviewed-on: https://chromium-review.googlesource.com/1101599Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#567539}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/82ff2ae08f20..030b88a205c9 git log 82ff2ae08f20..030b88a205c9 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 tandrii@chromium.org cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload. Created with: gclient setdep -r src/native_client@030b88a205c9 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:796383 TBR=mseaborn@chromium.org Change-Id: I417019b2a46259d6a2ce50aeec5fcc25d102d3f4 Reviewed-on: https://chromium-review.googlesource.com/1101724Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567538}
-
Kunihiko Sakamoto authored
To clarify that it is for single Signed Exchange. Bug: 803774 Change-Id: If8503589f33749862f82c07569046abe64ec1e37 Reviewed-on: https://chromium-review.googlesource.com/1100728 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#567537}
-
Yuichiro Hanada authored
Test: keyboard_unittests. Change-Id: Ia69ef5a33cdec9a82ffac84d54205321f592b82e Reviewed-on: https://chromium-review.googlesource.com/1101607 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567536}
-
Kunihiko Sakamoto authored
To clarify that it is for single Signed Exchange. Bug: 803774 Change-Id: I9a7acc5b3c7b1074828c0560fba819ae351d6ff7 Reviewed-on: https://chromium-review.googlesource.com/1100658Reviewed-by:
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/88482c3..a5ac650 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic6c36ddf3c2f3d1e58bc3f592aa93515f3f295f9 Reviewed-on: https://chromium-review.googlesource.com/1101401 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567534}
-
Gyuyoung Kim authored
FirstMeaningfulPaintDetector has been using a hardcoded timeout value (0.5 seconds) to limit the time of checking the first meaningful paint. However, there are various devices and network bandwidths that Chromium should work. In such cases, we need to change the FMP timeout value depending on the environment. To support it, this CL introduces a new command line switch in order to set a custom timeout value for the FMP detection. Bug: 850403 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id308a72acfc3563384076bbbe19c441d506757ee Reviewed-on: https://chromium-review.googlesource.com/1090512Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#567533}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28f5dd8a4c8a..c2572baac764 git log 28f5dd8a4c8a..c2572baac764 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-14 fmalita@chromium.org [skottie] Switch to SkJSON 2018-06-14 halcanary@google.com SkTHashTable no longer uses SkNoncopy 2018-06-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-14 caryclark@skia.org do not mistake locals for methods 2018-06-14 halcanary@google.com SkTemplates no longer uses Sknoncopyable 2018-06-14 fmalita@chromium.org Reland [skjson] Size-constrained input API 2018-06-14 halcanary@google.com SkCanvas, SkImageGenerator, SkStream: remove SkNoncopyable 2018-06-14 halcanary@google.com SkRefCnt no longer a SkNoncopyable 2018-06-14 jvanverth@google.com Implement tilted concave ambient shadow 2018-06-14 fmalita@chromium.org Revert "[skjson] Size-constrained input API" Created with: gclient setdep -r src/third_party/skia@c2572baac764 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I8c7d779617a376a3b78b23d117ec30b803560caa Reviewed-on: https://chromium-review.googlesource.com/1101722Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567532}
-
Shu Chen authored
Bug: 786434 Change-Id: I7f18cf55c99c61ad398015430818626aedd4da1e Reviewed-on: https://chromium-review.googlesource.com/1098739Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567531}
-
Weidong Guo authored
Changes: 1. Add enumeration for different types of app moving. 2. Add histogram for total page number and number of pages that have empty slots. (Both numbers' increase indicates the success of the feature.) Bug: 850269 Change-Id: I8e99e4b11e86dd003a3f6425b42084834b145fc1 Reviewed-on: https://chromium-review.googlesource.com/1096117Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567530}
-
chrome://media-internalschcunningham authored
MediaLog URL strings can be arbitrarily long and originate at untrusted renderer. Truncate to 1000 chars including an ellipsis. BUG=851048 Change-Id: I5b8d72a8f907707792c508eda5c7a2b75886ad34 Reviewed-on: https://chromium-review.googlesource.com/1098015 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567529}
-
Ian Clelland authored
Three header files were renamed recently, but the corresponding lines in the relevant BUILD.gn file were missed. Change-Id: Id22ef514e25b7d16f07459771327a404393fcd86 Reviewed-on: https://chromium-review.googlesource.com/1101509Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567528}
-
Ryan Hansberry authored
The special-case request to disable Smart Lock for all devices requires, on the server-side, that the public key not be set at all. Failing to do so results in an errback from the server. Bug: 824568, 752273 Change-Id: I867d4a897b39b3927170488900a23b2d6450d467 Reviewed-on: https://chromium-review.googlesource.com/1102106 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#567527}
-
Wez authored
This is a reland of e17dbaf1 Original change's description: > Make base::ScopedZxHandle a zx::handle. > > - Add the ScopedZxHandle APIs to the base zx::handle. > - Add missing includes. > > This allows ScopedZxHandle to be removed incrementally from call-sites. > > Bug: 852541 > Change-Id: Idc452a450ce2bbe1266e9e0ee266115e2ea38f97 > Reviewed-on: https://chromium-review.googlesource.com/1100132 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567382} TBR: gab, rockot, kmarshall Bug: 852541, 852958 Change-Id: I66df191da2449007a154595255efc01ac732d110 Reviewed-on: https://chromium-review.googlesource.com/1101742 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#567526}
-
Mohamed Heikal authored
Fix cause for test flake WebApkIntegrationTest#testWebApkLaunchesByLauncherActivity and remove the flakey label. Bug: 852648 Change-Id: Iafbfd37297d8b589aa11455f2d6f129a74f2af43 Reviewed-on: https://chromium-review.googlesource.com/1101465Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#567525}
-
Ke He authored
This is one step of "moving //device/geolocation into //services". BUG=800659 Change-Id: I40f3c1f1b534027132e9eeb17ac5671cad398731 Reviewed-on: https://chromium-review.googlesource.com/1100680Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#567524}
-
Ke He authored
Before moving //device/geolocation into //services, we have to make sure all the clients can only depends on //device/geolocation/public. Clients shouldn't visit internal parts of the geolocation. After this, we can move geolocation into //service in a clean way in next step. BUG=800659 Change-Id: I1886e88bece4e20308e3e59a247d51b71a33ebac Reviewed-on: https://chromium-review.googlesource.com/1100550Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#567523}
-
Dirk Pranke authored
As part of the LUCI migration, we want to shut down chromium.webkit and just run the layout tests on the appropriate builders on the android/linux/mac/memory/win waterfalls instead. This CL moves the webkit_layout_test suites from WebKit Linux Trusty (dbg) to Linux Tests (dbg)(1), and from WebKit Mac 10.11 (dbg) to Mac Tests 10.13 (dbg). R=hinoka@chromium.org BUG=790293 NOTRY=true Change-Id: Iaec56746312a2aca700c77ad73314779e034f5fb Reviewed-on: https://chromium-review.googlesource.com/1101918 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#567522}
-
Rohit Rao authored
Adds a new image and view spacing when the UIRefresh experiment is enabled. Adds Dynamic Type support as well. Legacy: https://drive.google.com/file/d/1UIIDcwMcpcG-N7-AKox94UtQErhiy1ip/view Refresh: https://drive.google.com/file/d/1hrP-Cgrm1jdaK0K6BM-P-ytMMxBplwlX/view BUG=805166 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9b4ba4aac10b0b91ff38b127bf978db4ee93639d Reviewed-on: https://chromium-review.googlesource.com/1099415Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567521}
-
Yoichi Osato authored
This patch rebases image expectations for - fast/writing-mode/japanese-lr-selection.html since they are styled "writing-mode:vertical-lr" and the 1px diff is accepted. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I015c144effcba7ef57f24d475607f372c3a46a70 Reviewed-on: https://chromium-review.googlesource.com/1100374 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567520}
-
Stuart Langley authored
UMAs already existed for full and directory fetch, so just added a new histogram for TeamDrives. Added UMA for delta fetch for both the default corpus and a TeamDrive. Added expiry dates for the three UMAs. I couldn't find an example of how to test that the correct UMAs are being written in a C++ test, hence there's no tests. Bug: 843446 Change-Id: Ifd000cabc02f1b0e4cd7cf599fe83d9bfa74b8f5 Reviewed-on: https://chromium-review.googlesource.com/1092959 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Jun Choi authored
Implement Cable handshake protocol client logic that dispatches control message to the authenticator and validates incoming control messages from connected authenticator. Handshake message sent to and received from the authenticator should together be used to construct a session key with which the FidoCableDevice use to encrypt/decrypt incoming and outgoing messages. Bug: 849307 Change-Id: I818792c7234e039e43de8425ee8f7a30610073a0 Reviewed-on: https://chromium-review.googlesource.com/1089327 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#567518}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c91211414086..fce7bc9e0825 git log c91211414086..fce7bc9e0825 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 tandrii@chromium.org Add infradata/config repo to gclient. 2018-06-14 tandrii@chromium.org Revert "gclient_scm: Use cherry-picking instead of rebasing." Created with: gclient setdep -r src/third_party/depot_tools@fce7bc9e0825 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:613739,chromium:850812,chromium:853032 TBR=agable@chromium.org Change-Id: I24e9ff53d5457de436e88160a1e1637cb2b63a1d Reviewed-on: https://chromium-review.googlesource.com/1101723Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567517}
-
Chris Hamilton authored
This is in preparation for surfacing the data in the chrome://discards UX. Change-Id: I64d0f43e6f313cfd96291c3c81adc15a8d78b5a3 Reviewed-on: https://chromium-review.googlesource.com/1099596 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#567516}
-
Blake O'Hare authored
When the launcher pops up, the search field has focus. If you do this quickly after the virtual keyboard has been hidden, the transient blur heuristic will cause the keyboard to be re-shown. Backstory: Some text boxes are actively focused (user presses a text field) and some are passively focused (a window has a search box that is auto- focused). The latter cases should not cause the keyboard to show up. However, if the keyboard was recently dismissed, the "transient blur" heuristic will cause any passively focused text field to invoke the keyboard. The primary purpose of this is login flows that require you to type your name on one screen and then your password on the next screen (like the Gaia login flow) where the password field is passively focused. By explicitly dismissing the keyboard, it will clear out the counter for this heuristic and prevent the focused search field in the launcher from causing the keyboard to open if it was previously open in the past few seconds. The most common form this bug manifests is if someone clicks away from the keyboard to dismiss it with the intention of showing the shelf to immediately access the launcher. Bug: 848664 Change-Id: Ibdcb7a64906498be052c0071a611fdb639fc32f5 Reviewed-on: https://chromium-review.googlesource.com/1088450 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Nigel Tao authored
Type checking should already be covered by the existing js_type_check("closure_compile") BUILD.gn target. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3086629f3439237722f8f7b36a41031a7551901 Reviewed-on: https://chromium-review.googlesource.com/1100661Reviewed-by:calamity <calamity@chromium.org> Reviewed-by:
-
Sam McNally authored
Using DriveFS requires building and deploying ChromeOS. Add a client for the fake DriveFS launcher to allow the use of a real DriveFS from a ChromeOS chroot to be used with a target_os="chromeos" build of chrome. This connects to the fake DriveFS launcher using mojo over a unix domain socket named by a command-line flag, using the launcher to create DriveFS instances. Bug: 848126 Change-Id: I22dcca154d41bda196dd7c1782bb503f6bcba5b1 Reviewed-on: https://chromium-review.googlesource.com/1098434Reviewed-by:
-
Nicolas Pena authored
This CL adds |processingEnd| to EventTiming, and it is computed as the time when we have finished dispatching an event. The |duration| is fixed to be the time the next swap promise is resolved. It is computed in the WindowPerformance to avoid complicating the lifetime of the EventTiming class and to facilitate grouping multiple event entries into a single swap promise. This CL also fixes the computation of DOMHighResTimeStamp to be aligned with the other entry types: we use MonotonicTimeToDOMHighResTimeStamp to clamp first and then subtract instead of subtracting first and then clamping. The layouttests are modified to force swap promises to be resolved before onload when needed. To allow serving a delayed resource via php, the tests are moved to http/tests . Bug: 841224, 851484 Change-Id: I684b165ef5840b9d4da17258b0a1cc796ec43fcb Reviewed-on: https://chromium-review.googlesource.com/1095736 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
deejay authored
Previously it checked wrong text-style while calling PredicateForSearchKey() in Mac. This patch changes text style from kTextStyleBold to kTextStyleItalic. Bug: none Change-Id: Ib047928fd020ace116fff7a84b4b4c3646906f4b Reviewed-on: https://chromium-review.googlesource.com/1099097 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#567511}
-
Yutaka Hirano authored
As the feature is enabled by default, this CL removes unused code. Bug: 794073, 754918 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9064494c83ec189443a0f6493987a4a8d2c5a035 Reviewed-on: https://chromium-review.googlesource.com/1100717Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/54899e2b1191..90d481078b9b git log 54899e2b1191..90d481078b9b --date=short --no-merges --format='%ad %ae %s' 2018-06-14 dgarrett@google.com chromeos-config: Move asan's to chrome_informational. 2018-06-14 ahassani@chromium.org paygen: remove work_dir from CreateAndUploadPayload Created with: gclient setdep -r src/third_party/chromite@90d481078b9b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:808495 TBR=chrome-os-gardeners@chromium.org Change-Id: I128fcfb6d7c2424b3677638683809584a41efb62 Reviewed-on: https://chromium-review.googlesource.com/1101721Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567509}
-
Helen Li authored
ProxyResolvingClientSocketFactory's consumers (p2p sockets used by WebRTC) currently use a default-initialized net::SSLConfig struct. This net::SSLConfig doesn't respect admin policies and system settings. This CL uses the SSLConfig from SSLConfigService which has the right SSLConfig. This CL additionally removes one unneeded param (net::ClientSocketFactory*) from the factory's constructor. This CL is to prepare for servicifying ProxyResolvingClientSocket. Bug: 844187 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Idf18c9f27a0080a55b3dca16ba593302be3486bb Reviewed-on: https://chromium-review.googlesource.com/1100340 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#567508}
-
Matt Wolenetz authored
Since upcoming changeType() work will refactor some of the current code that creates and passes callbacks to StreamParser::Init(), this CL modernizes related base::Bind and base::Callback usage to either base::Bind{Once,Repeating} and base::{Once,Repeating}Callback. Note that the encrypted media init data callback is the same underlying type in StreamParser as in Demuxer, so this CL also modernizes the binding for the Demuxer version of that type. base::Bind count in //media: before=1425, after=1384 BUG=714018,751838,605134 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie8c3ef44a836c5bfa3f34ff300da760dd7f552c1 Reviewed-on: https://chromium-review.googlesource.com/1099935Reviewed-by:Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567507}
-
Helen Li authored
The network:: namespace qualifiers might be an artifact because some of the files were previously in content::. Trivial cleanup so we have consistency between new and old files. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia8575841f9fb4e193e4e5e7a4620684be08db79c Reviewed-on: https://chromium-review.googlesource.com/1101575 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
-
Peter Collingbourne authored
This is a reland of 4a2a5c4a with an additional check for use_xcode_clang. Original change's description: > build: Pass -fcomplete-member-pointers when building with clang. > > This prevents member pointers of incomplete base type from being used in > cases where they might cause problems under the Microsoft ABI. > > Specifically, the Microsoft ABI has different kinds of member pointers with > different sizes, and the choice of member pointer representation depends on > the inheritance hierarchy of the member pointer's base type. C++ allows a > member pointer's base type to be incomplete, so if it is incomplete at the > point where a variable of that member pointer type is declared, that forces > the compiler to pick the most general (i.e. largest) one. That can lead to > ODR violations since the most general representation wouldn't necessarily > be the one that would be chosen if the base type happened to be complete at > the point where the variable was declared. It can also be less size efficient > because the compiler will generally be able to choose a smaller representation > than the most general one if it were complete at the point where it is needed. > > This flag also enables additional semantic analysis that we'll need in order > to correctly implement -fsanitize=cfi for member function pointer calls. This > is because the inheritance hierarchy of the base type must be available in > order to make the CFI checks as precise as possible. > > Note that the flag is a -f flag rather than a -W flag. This is because > requiring member pointer base types to be complete is technically a > non-conforming language extension, as it may, for example, cause templates > to be instantiated which would otherwise not be, which may be observable > after code generation in conforming programs that were crafted to observe > it. However, the effects of this language extension should not be observable > in most ordinary programs. > > Bug: 847724 > Change-Id: I8d823fd4a6f21dfcadba55eefc0a69ef2e0c3479 > Reviewed-on: https://chromium-review.googlesource.com/1098217 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567086} Bug: 847724 Change-Id: I1b97980691914492945d170931d33438c68e8d0b Reviewed-on: https://chromium-review.googlesource.com/1101477Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567505}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/425d9ce2d32c..c91211414086 git log 425d9ce2d32c..c91211414086 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 ehmaldonado@chromium.org gclient_scm: Use cherry-picking instead of rebasing. 2018-06-14 ehmaldonado@chromium.org gclient: Don't allow None URLs (except in .gclient files) Created with: gclient setdep -r src/third_party/depot_tools@c91211414086 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812,chromium:839925 TBR=agable@chromium.org Change-Id: I8a9d2c829bf6a650fd793567fa3e122972016a09 Reviewed-on: https://chromium-review.googlesource.com/1101718Reviewed-by:
-
Kenichi Ishibashi authored
ByteConsumer::BeginRead() may return Result::kOK with no available read data. FetchDataLoaderAsDataPipe should handle zero read as other ByteConsumer::Client do. Bug: 807954 Change-Id: I47186ccc01d10c8ff18bdf749376598ee75342a7 Reviewed-on: https://chromium-review.googlesource.com/1096515Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567503}
-
Daniel Murphy authored
R=cmp@chromium.org Change-Id: I0d2b39043d0d3a2ef7478178bc7106dc00337171 Reviewed-on: https://chromium-review.googlesource.com/1101656 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#567502}
-
