- 18 Jul, 2018 40 commits
-
-
Gabriel Marin authored
This CL pulls in tcmalloc 2.7, the most recent release from upstream. Places the files under vendor/ and makes a copy of the code under chromium/. This CL did: # clone tcmalloc repository git clone https://github.com/gperftools/gperftools vendor # checkout the new version and remove git metadata cd vendor && git checkout gperftools-2.7 && rm -rf .git # mirror the src folder cd .. && rsync -av --delete vendor/src/ chromium/src/ This is code pulled from upstream. NOPRESUBMIT=true BUG=724399,b:70905156 Change-Id: I3a3510d514de15a8b1463725fa6f7dab9b1e6d0e Reviewed-on: https://chromium-review.googlesource.com/1130671Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#576221}
-
Ryan Daum authored
Expiry for margin-events timer was always hit because it was using the elapsed time from the last gesture swipe instead of the current. Bug: internal b/111304882 Test: manual Change-Id: Ia6caf8c1291b8bb880272141c23c57f6575b8b3e Reviewed-on: https://chromium-review.googlesource.com/1142353Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#576220}
-
Tom Anderson authored
The comments are no longer applicable. BUG=863460 R=thakis Change-Id: I29d89d18509f600aeac094fa577ec497377bcb93 Reviewed-on: https://chromium-review.googlesource.com/1142375Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576219}
-
Scott Violet authored
And makes it work with ash running the ws2. This necessiated providing support for ui::mojom::WindowServerTest in ws2. To get ash_unittests to connect to ash as a standalone service required a bit of tweaks to ash/main.cc. My plan is to fold (or delete) all of mash_unittests into ash_unittests. BUG=842365 TEST=covered by tests Change-Id: I37cd4b5a19f4570440bf4739b80eb5bd907da9c9 Reviewed-on: https://chromium-review.googlesource.com/1141063 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#576218}
-
Pavol Marko authored
The --force-devtools-available flag can be used for autotest on Chrome OS devices, because autotest tends to rely on devtools remote inspection, so disabled devtools can break autotest. It is only possible to change command-line flags in developer mode on Chrome OS devices. Bug: 838146 Test: browser_tests --gtest_filter=DevToolsAllowedByCommandLineSwitch* Change-Id: Ic45aaa618dae522adcce41a3e8d20c4c68b54dc7 Reviewed-on: https://chromium-review.googlesource.com/1141742 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576217}
-
chrome://discardsNicolas Ouellet-payeur authored
The 'Can Discard?' column indicates proactive discards, not urgent discards. Each cell in those columns shows a checkmark or crossmark, with a '[View Reason]' link. Hovering the link shows a tooltip with the reasons why it can't be frozen/discarded. The 'View Reason' button is disabled if the tab _can_ be frozen/discarded, since there are no failure reasons to show. Also, remove the 'Media' column, since it's redundant now. Screenshot (apologies for external contributors): https://screenshot.googleplex.com/n9oDCgM3ffj Bug: 864149 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ied07835a5eae7a80989226a3662dc12d3e9ee9b2 Reviewed-on: https://chromium-review.googlesource.com/1140368 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576216}
-
Donn Denman authored
Updates the logic in Contextual Search that determines whether to send a URL to our servers as part of the Resolve request. Now instead of checking the sync service we use the Unity helper -- the Unified Consent UrlKeyedDataCollectionConsentHelper. BUG=825428 Change-Id: I6d294260018fc77d1eef896d75ea3b664cfba6d0 Reviewed-on: https://chromium-review.googlesource.com/1117705 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#576215}
-
Patrick Monette authored
The comment explains that 2 browser starts are required to fully enable or disable the feature. Bug: 846953 Change-Id: I44037ab9d1c8b3a1c3f2692916ad945fedfa2b2e Reviewed-on: https://chromium-review.googlesource.com/1142345 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#576214}
-
Victor Costan authored
USE_SYSTEM_SQLITE used to be supported on iOS, and now is a no-op. This CL removes the references to it from //sql, to avoid confusing readers. The CL also breaks down an unnecessarily large unit test in //sql/connection_unittest.cc that happend to be near the changes in this CL. Change-Id: I47c324300b54362529364a5ef26ee45b45fe3b76 Reviewed-on: https://chromium-review.googlesource.com/1137921Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#576213}
-
Danyao Wang authored
WKBackForwardList is updated before navigation delegates are called on back/forward navigations. This creates a window between decidePolicy and didStartProvisionalNavigation where WKBasedNavigationManager incorrectly identifies WKBackForwardList.currentItem as last committed, even though it is really the pending item. Creating the pending item in decidePolicy delegate fixes this problem. Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3252edd1def6d0d2eb1499602e05058c3b2fd3b1 Reviewed-on: https://chromium-review.googlesource.com/1142142Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#576212}
-
Koji Ishii authored
This test has "P" in a float with "ASS" in an inline formatting context, while its ref has "P" and "ASS" in the same inline formatting context. This patch disables kerning to ensure the same rendering. TBR=eae@chromium.org Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie36c9bc8885467e1272f4a7ccb936791362cdaea Reviewed-on: https://chromium-review.googlesource.com/1142049Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576211}
-
Robert Ma authored
/gen/ is already available in both file tests (via blink_test_runner.cc) and http tests (via Apache 'Alias' directives). This CL makes /gen/ also available to wptserve in Blink (both run_web_tests and run_blink_wptserve). Besides, this CL adds configuration options (release, debug, etc.) to run_blink_wptserve so that users can control which out/*/gen is served. Also fix a leaking file descriptor in filesystem.open_text_tempfile. Bug: 821496 Change-Id: I60ae0657df470dd319d002bc1c20476d33d9c05e Reviewed-on: https://chromium-review.googlesource.com/1140908 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#576210}
-
Mihai Sardarescu authored
Unfied Consent feature depends on SyncUserConsentSeparateType feature as Chromium needs to continue to record and sync user consent when the user disables event logger (USER_EVENTS sync model type). This CL also moved the unified_consent feature definition from components/signin to components/unified_consent. This is the correct code location for the feature and is also required as it now depends on a sync feature. Bug: 860433 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I062904486c7c0085b6256b3df5d4ad7edd9ca704 Reviewed-on: https://chromium-review.googlesource.com/1128962Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#576209}
-
Shakti Sahu authored
Added ListItemView, GenericListItemView, PrefetchListItemView, ImageListItemView classes to handle selection. Each of these views will implement its own UI to handle selection. Bug: 850600 Change-Id: I9707adb050b38c405ef153b2d4de9b93049ddd61 Reviewed-on: https://chromium-review.googlesource.com/1141159 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#576208}
-
Aldo Culquicondor authored
This allows the tests to be able to submit events only when the UI is fully loaded. Bug: 864840, 864161 Change-Id: I41bb0364d3019910fc0b924fd25fe4a9486e6e90 Reviewed-on: https://chromium-review.googlesource.com/1142033Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#576207}
-
Tarun Bansal authored
The experiment has been enabled by default. Bug: 838253 Change-Id: I6c9102bb8e38ae657e1b57a08a05b56e29c3c56b Reviewed-on: https://chromium-review.googlesource.com/1141433Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#576206}
-
Zhongyi Shi authored
Add histograms to collect handshake status when connection migration is triggered based on migration cause. Bug: 790547 Change-Id: I08efdc45b558d711b310aac55f412381efc3eaa6 Reviewed-on: https://chromium-review.googlesource.com/1140532Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576205}
-
Dominic Farolino authored
R=kinuko@chromium.org, peria@chromium.org, ricea@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 855968 Change-Id: I96be3b769dd75300553f639ca5fa8158771bde2c Reviewed-on: https://chromium-review.googlesource.com/1137930 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576204}
-
Bence Béky authored
Bug: 862805 Change-Id: I327807a7ca854cf97986008ccd9482cd8ccaa1b2 Reviewed-on: https://chromium-review.googlesource.com/1141282 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#576203}
-
Chris Harrelson authored
for throttled subframes. needs_forced_compositing_update_ could have been set, in cases when a style update in a throttled frame caused destructive mutations of compositing state that must be cleaned up or result in stale pointers from cc. needs_forced_compositing_update_ forces off throttling for a frame up to the compositing step, for this reason. It is cleared during the compositing update step. This means that ShouldThrottleRendering may return true after this step when it returned false before. Bug: 859596,863427 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idc4857b9f4a465f602e3bcc12a76e48d394a2689 Reviewed-on: https://chromium-review.googlesource.com/1141106Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576202}
-
Alexander Timin authored
R=skyostil@chromium.org Change-Id: Id0aea377558e876c8178e82eb3a170f678c415cc Reviewed-on: https://chromium-review.googlesource.com/1140717 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#576201}
-
Ned Nguyen authored
Bug: 621126 Change-Id: If111cc2b1f980f79362d5e52d101e915ae7ba6ef Reviewed-on: https://chromium-review.googlesource.com/1140927 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#576200}
-
Sergey Ulanov authored
This is a manual roll to bring us to the most-recent working SDK build. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: I1c614558bc5b3f2376537455d42fb705e5ce3dee Reviewed-on: https://chromium-review.googlesource.com/1141929Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576199}
-
Chase Phillips authored
Bug: None Change-Id: Id9a0356db01d1ad34ae82be263d42566c81c3871 Reviewed-on: https://chromium-review.googlesource.com/1141099Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#576198}
-
Tim Volodine authored
Improve error message when testWebViewIncludedStableInterfaces fails. Also add a guideline on how to potentially fix it. Previously there was some confusion on how to interpret the failure (see crbug.com/859141). Bug: 859141 Change-Id: I2ac1439ad164186142b16697e7378efb8a975629 Reviewed-on: https://chromium-review.googlesource.com/1127240Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#576197}
-
Roman Sorokin authored
Shows offline Gaia to sign in as an existing user when there is no network for Active Directory devices. BUG=chromium:864987 TEST=manual Change-Id: I0f80915788c96b6fd88e766dbe6526802ffe98e5 Reviewed-on: https://chromium-review.googlesource.com/1141867 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#576196}
-
Min Qin authored
This reverts commit 937dccc2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Fix an issue that ResourceDownloader was never deleted on download completion" > > This reverts commit 9faf0129. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Fix an issue that ResourceDownloader was never deleted on download completion" > > > > This reverts commit e0b12de0. > > > > Reason for revert: The Cl probably introduced flakiness in multiple download related tests (https://crbug.com/864922) > > > > Original change's description: > > > Fix an issue that ResourceDownloader was never deleted on download completion > > > > > > This CL calls the InProgressDownloadManager to delete ResourceDownloader > > > after response is completed. > > > It also fixes the issue when download is cancelled. > > > > > > BUG=864189 > > > > > > Change-Id: I184d5faaace90f49874e45b4126a0a9821fdced7 > > > Reviewed-on: https://chromium-review.googlesource.com/1138676 > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#575882} > > > > TBR=qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org > > > > Change-Id: I669a69fc135547508b44ccc8150847cc5824b2ec > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 864189 > > Reviewed-on: https://chromium-review.googlesource.com/1141684 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575981} > > TBR=qinmin@chromium.org,shaktisahu@chromium.org,dullweber@chromium.org,xingliu@chromium.org > > Change-Id: I11012d0bf159f4944d69cc13881180db9ed98d7e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 864189 > Reviewed-on: https://chromium-review.googlesource.com/1142171 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576190} TBR=qinmin@chromium.org,shaktisahu@chromium.org,dullweber@chromium.org,xingliu@chromium.org Change-Id: Ia2f90aa688078db7191cf9eeb59608619194a256 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864189 Reviewed-on: https://chromium-review.googlesource.com/1142305Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576195}
-
John Z Wu authored
//ios/web_view will use sync for autofill and password data in the near future. This is one of the many CLs needed for implementation. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I32c84aa7d5fd1836a99170741f525100dc0ac09c Reviewed-on: https://chromium-review.googlesource.com/1139182 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#576194}
-
David 'Digit' Turner authored
This CL introduces a new Python script providing various functions to make it easier to parse Android APK files for symbolization, i.e.: - ApkReader: convenience class to read the content of an APK, especially information related to uncompressed native shared libraries. Mostly useful because it can be easily mocked for unit-testing purpose. - ApkNativeLibrariesMap: convenience class to build a map of native shared libraries contained in an APK. - ApkLibraryPathTranslator: convenience class used to translate on-device APK file paths and offsets (as found in stack traces or tombstones) into a virtual device library path + offset. + Add unit-tests for all features. + Add a small apk_lib_dump.py script used to dump the list of uncompressed native libraries inside an APK and their file start/end offsets and sizes. This is mostly useful for debugging symbolization issues. NOTE: This is a partial rewrite of the corresponding code from the following patch, which shows how this will be used in the future to better symbolize tombstones: https://chromium-review.googlesource.com/c/chromium/src/+/1034054 BUG=755225 R=agrieve@chromium.org, jduborick@chromium.org, pasko@chromium.org, lizeb@chromium.org Change-Id: If71e0048fa88c859e5f256d8c960134b6b88d06f Reviewed-on: https://chromium-review.googlesource.com/1047211 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#576193}
-
Ian Kilpatrick authored
Every pass of the ExclusionSpace::Add loop invoked a copy of a shelf optimistically. This isn't needed for every pass, and only needed for the single pass where we are actually going to add the shelf. (there is potential to remove additional copies, but we'll see if that is needed later). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia7cdafc71bf0ea0c657763957ef8c5e0e0953382 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1140521Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#576192}
-
Johann authored
Attempt to run 'git cl format' when updating configuration files. R=tomfinegan@chromium.org Change-Id: Ib78ac4df3f36361d72a2fa672a2382e68a5e188f Reviewed-on: https://chromium-review.googlesource.com/1142432Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#576191}
-
Min Qin authored
This reverts commit 9faf0129. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Fix an issue that ResourceDownloader was never deleted on download completion" > > This reverts commit e0b12de0. > > Reason for revert: The Cl probably introduced flakiness in multiple download related tests (https://crbug.com/864922) > > Original change's description: > > Fix an issue that ResourceDownloader was never deleted on download completion > > > > This CL calls the InProgressDownloadManager to delete ResourceDownloader > > after response is completed. > > It also fixes the issue when download is cancelled. > > > > BUG=864189 > > > > Change-Id: I184d5faaace90f49874e45b4126a0a9821fdced7 > > Reviewed-on: https://chromium-review.googlesource.com/1138676 > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575882} > > TBR=qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org > > Change-Id: I669a69fc135547508b44ccc8150847cc5824b2ec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 864189 > Reviewed-on: https://chromium-review.googlesource.com/1141684 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575981} TBR=qinmin@chromium.org,shaktisahu@chromium.org,dullweber@chromium.org,xingliu@chromium.org Change-Id: I11012d0bf159f4944d69cc13881180db9ed98d7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864189 Reviewed-on: https://chromium-review.googlesource.com/1142171Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576190}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e2c00841a55f..799e075abeea git log e2c00841a55f..799e075abeea --date=short --no-merges --format='%ad %ae %s' 2018-07-18 jmadill@chromium.org Replace D24_UNORM with a packed version. Created with: gclient setdep -r src/third_party/angle@799e075abeea The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iacddff49bd41e6cf52e6b788b12070ec5969deaf Reviewed-on: https://chromium-review.googlesource.com/1142007Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576189}
-
Lily Houghton authored
ConnectionTypeObserver is deprecated. This CL modifies AffiliationFetchThrottler to use NetworkChangeObserver instead. For more details, see the linked design doc in the bug below. Bug: 754695 Change-Id: I38b53ce245a74c19be41aab2558a9c3e7fc7b1d1 Reviewed-on: https://chromium-review.googlesource.com/1134019Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#576188}
-
Christopher Grant authored
This change makes the future introduction of a VR UI feature module possible by cutting dependencies between VrShellGl and UI code. This includes creating a UI support shim to help avoid UI calls directly to code that may not be exported to modules in the future. BUG= Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib2edbe31ca8c6fcbbfbd8facc9913d6068eda208 Reviewed-on: https://chromium-review.googlesource.com/1141934 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#576187}
-
David Black authored
See bug for screenshot. Bug: b:111596959 Change-Id: I96ebd18bcb7d4905df5e539a5ace36154e49c146 Reviewed-on: https://chromium-review.googlesource.com/1142225 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#576186}
-
Mustafa Çamurcu authored
Currently, all KeyEvents are dispatched with EventType set to ET_KEY_PRESSED. This cl fixes it. Change-Id: I6302ed77634ecd64ba18509272ef58c96b37a6f6 Reviewed-on: https://chromium-review.googlesource.com/1142383 Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576185}
-
Kevin Bailey authored
MacOS is capable of generating an accessibility description for the search icon on the Omnibox, but we currently don't fill it in. This CL adds a name to it (and there may be a follow-up to tweak the "image" string that is also getting appended.) Bug: 862745 Change-Id: I53f7250c848761127a29bdad4e215830c365bb97 Reviewed-on: https://chromium-review.googlesource.com/1138548Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576184}
-
Mohsen Izadi authored
BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2e886c67eb09f89a1bf8ddcdfc83bd8382dfa907 Reviewed-on: https://chromium-review.googlesource.com/1140918 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#576183}
-
Sidney San Martín authored
The PiP window has a simple layer tree and triggers the FSLP code path. But, this path didn't previously consider the video layer part of the area that needs a backdrop, so the backdrop layer (the root layer) was made too small. It would be better if this code just had access to the size of the page instead of having to guess by looking at the layer tree, but I don't think it does right now. Bug: 863580 Change-Id: Ib2e9ae24e98932b77b365a985dc956aa08287eb7 Reviewed-on: https://chromium-review.googlesource.com/1140923Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576182}
-