- 07 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ebfe4643bf0..efce0d1b7657 git log 4ebfe4643bf0..efce0d1b7657 --date=short --no-merges --format='%ad %ae %s' 2019-09-07 ehmaldonado@chromium.org gclient_utils: Fix bug in CheckCallAndFilter in Python 3. Created with: gclient setdep -r src/third_party/depot_tools@efce0d1b7657 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I6cf1518fc189ee51ac0fd67446f01ba656af3e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694533}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29504a0396b2..f54c3cac6a64 Created with: gclient setdep -r src-internal@f54c3cac6a64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I99f33ebd977b6ffcbe651213e9aebcad6ab1842f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790764Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694532}
-
Lei Zhang authored
A couple of them got removed in https://crrev.com/694112. Change-Id: If299e30f0063a7ed20b6091aa2cd0919525d868c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790584Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#694531}
-
Joey Arhar authored
This patch rewrites the request cookies view panel to include new information about blocked cookies emitted by the new Network ExtraInfo events, including: - Splitting the cookie table into multiple tables to make it easier to read. - Modifying CookiesTable to highlight and add an icon to cookies which were blocked. - Fixing some bugs in RequestCookiesView and NetworkRequest which caused the cookies panel to not appear when it should. - Modifying SDK.Cookie and SDK.CookieParser to store blocking information and the original cookie line. Screenshots before: https://imgur.com/I7WBSgz Screenshot after: https://imgur.com/uHTU3ID Bug: 856777 Change-Id: I044aa7fcd4fe8db121fd7aaa13ff9d6cd829aae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756252 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#694530}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fd9b7e654b05..eb590e0e22e9 git log fd9b7e654b05..eb590e0e22e9 --date=short --no-merges --format='%ad %ae %s' 2019-09-07 thestig@chromium.org Reapply git EOL policy for .in files. 2019-09-06 thestig@chromium.org Remove some redundant assertions in CFFL_ListBox. 2019-09-06 thestig@chromium.org Remove |CPDF_FormField::m_Flags|. 2019-09-06 thestig@chromium.org Add CFFL_ComboBox::GetComboBox(). Created with: gclient setdep -r src/third_party/pdfium@eb590e0e22e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I63079b1c75e76a28efbc8681fa135d16c96618a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790793Reviewed-by:
-
Ankit Kumar 🌪️ authored
This CL refactors populating kPreviousOnLineId and kNextOnLineId into its own function. It also reuses FinishStaticNode(). Bug: 981448 Change-Id: Ic2035791f79ed3cd5c983e0006524ec44ce3c7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776154Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#694528} -
Julie Jeongeun Kim authored
This CL converts Resolve from blob_url_store.mojom amd members from data_element.mojom and serialized_blob.mojom to new Mojo types. It also updates methods and members which use them with mojo::PendingRemote and mojo::Remote. Bug: 955171, 978694 Change-Id: Ib4a387e5047c82467f93392d9f8b65370896840a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782461 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#694527}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I11136adc53f4bedeb81399d1974d49ad6b7a2be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790295Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694526}
-
Julie Jeongeun Kim authored
This CL converts WidgetRequest to new Mojo types. It uses PendingReceiver and Receiver instead of WidgetRequest and Binding. Bug: 955171 Change-Id: Ied7433ff792fe6ceefd83a30bc276328966f901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787675 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0dbf1e37194c..fcd6915ca283 git log 0dbf1e37194c..fcd6915ca283 --date=short --no-merges --format='%ad %ae %s' 2019-09-07 simonhatch@chromium.org Pinpoint - Use new /describe master parameter Created with: gclient setdep -r src/third_party/catapult@fcd6915ca283 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:992162 Change-Id: Ieb7caf1c03a535a442330c3f65f069f47f3f45bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790790Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/380561393385..0a427689977d git log 380561393385..0a427689977d --date=short --no-merges --format='%ad %ae %s' 2019-09-07 iannucci@chromium.org Remove use of deprecated tempfile module in skia. Created with: gclient setdep -r src/third_party/skia@0a427689977d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: I3d463b68cb81cd25d107546aa08483eb73f01410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790792Reviewed-by:
-
Caleb Rouleau authored
Bug is unrelated but does demonstrate his knowledge of the area. Bug: 923564 Change-Id: I802712335ee34d9898fb4a5fceb7a9ab50c409b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790433 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#694522}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aecd1fb5. With Chromium commits locally applied on WPT: 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 9d7721df "Strip the fragment directive and update scroll-to-text WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload kojii@chromium.org: external/wpt/css/CSS2/linebox kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 mcasas@chromium.org: external/wpt/geolocation-API msisov@igalia.com: external/wpt/webvtt rego@igalia.com: external/wpt/css/css-grid external/wpt/css/css-ui rob.buis@samsung.com: external/wpt/quirks NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6469e403068b1115df8d858dcd7f24aaba079e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790702Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694521}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca5820a7d61c..29504a0396b2 Created with: gclient setdep -r src-internal@29504a0396b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic774fa99b4c720ca6d804a6723b98cb75b61d8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790788Reviewed-by:
-
Andrew Luo authored
Bug: 1001679 Change-Id: Ia61af264eac4ed9f683eb2350a99ecdf3c21c72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790406 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#694519}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/metrics. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mpearson@chromium.org Bug: 891670 Change-Id: I6c3ac385951a8694e9238f47eec6c4520cff2613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786963 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694518}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b64d65e67bff..3146ea01ae59 git log b64d65e67bff..3146ea01ae59 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 50f07bc3..b67ee864 (694314:694439) 2019-09-06 qingsi@webrtc.org Use obfuscated IPs in logging in p2p/ and pc/. 2019-09-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision df72a9a5..50f07bc3 (694187:694314) Created with: gclient setdep -r src/third_party/webrtc@3146ea01ae59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I020758fd4cc693ed3615d2326d9b0f2a1304c9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790787Reviewed-by:
-
Kai Ninomiya authored
This reverts commit b524af00. Reason for revert: M78 has branched (r693954) Original change's description: > Disable use_dawn for the branch point. > > This flag controls the inclusion of Dawn and the availability of WebGPU > which we want to keep limited to Canary for now. > > TBR=kbr@chromium.org > BUG=chromium:985142 > > Change-Id: I7677ec0571bcf394af4442829ad86e92a87b8a6b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784611 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693224} TBR=kbr@chromium.org,cwallez@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:985142 Change-Id: Ia5128d014026d46c0138d9a948b851856da5d310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789430Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#694516}
-
Peter Boström authored
Avoids replacing 3-dot menu icon with update icon which users find confusing, and explicitly calls out an update being available. Bug: chromium:1001731 Change-Id: I7807ec8444953c489001b15e89746a5db62abd1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788496 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#694515}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/08b68dba6a8d..380561393385 git log 08b68dba6a8d..380561393385 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 benjaminwagner@google.com [infra] Update Mac 10.14 bots to 10.14.6 Created with: gclient setdep -r src/third_party/skia@380561393385 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:989139 Change-Id: I7a1f3618a9a4d69b82586045506c09b7bac2846c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790385Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bd6c633b6e72..0dbf1e37194c git log bd6c633b6e72..0dbf1e37194c --date=short --no-merges --format='%ad %ae %s' 2019-09-06 rmhasan@google.com [Telemetry] Add system condition tags frozen set to typ expectations module Created with: gclient setdep -r src/third_party/catapult@0dbf1e37194c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:999335 Change-Id: Ib3f65be7c663783c62bf14c6e7fcf71f2209f1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789979Reviewed-by:
-
Cici Ruan authored
Currently, the AutotestPrivateTakeScreenshotFunction returns the primary screenshot. To get the screenshot of external displays, it adds another api AutotestPrivateTakeScreenshotForDisplayFunction. It helps take the screenshot of specific display. Bug: b/134981068 Test: Call the api to see if it gets the screenshot as needed. Change-Id: Ic46637b0828aa76a068c6b52358082a6323b4548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779177 Commit-Queue: Cici Ruan <cuicuiruan@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Cici Ruan <cuicuiruan@google.com> Cr-Commit-Position: refs/heads/master@{#694512}
-
Rachel Wong authored
This change adds three metrics: 1. The position index of the launched item. 2. The number of item types included in each impression set. (Diversity) 3. Whether or not an item was clicked. (CTR) Bug: 999912 Change-Id: I0a725c141f353f4fb89cd04110cf9731d01f96fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781124Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#694511}
-
Miyoung Shin authored
This CL converts MediaSessionServiceRequest in content to the new Mojo types. Bug: 955171 Change-Id: Iafc4e62a19235d6bf70cca084ae0769d7c1e441c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782459Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#694510}
-
Xing Liu authored
The display flow in ScheduledNotificationManager is now asychronous, so the glue layer must track all DisplayNotification calls and its result, and do things after all display flows are done. This CL adds a DisplayCallback which replaces Delegate. Bug: 998980 Change-Id: I88201232d882a4292bbf729c5906ab5644ab154e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787563 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694509}
-
Nate Fischer authored
No change to sample rate - this still samples at 2% for all channels. This changes the logic for computing when a client is in-sample, in a way which generalizes better to arbitrary sample rates. This also supports varying sample rate by channel, although the stable and beta/dev/canary rates are still currently the same. The eventual goal is to change the sample rate for beta/dev/canary to 99%, for consistency with Chrome. Bug: 969803 Test: Start up WebView hundreds of times, log if in sample group, judge if numbers are OK Change-Id: Ia68124434cea768f5e2a59ca88d3121f0829a48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742770 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#694508}
-
Johannes Henkel authored
Bug: 1001678 Change-Id: Iba6f8db30dfdaa84e77c6e005bfa131d6bc7704a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789976 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts MediaStreamTrackMetricsHost{Ptr, Request} in content to the new Mojo types. Bug: 955171 Change-Id: Ica78f4ad4b2f804392cace05492d56ed4a36f7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783684Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Bug: 994361 Change-Id: I04957f751b340f7c0775b6022ef2ca782ed32e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787569 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#694505}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65c12be8d1d3..ca5820a7d61c Created with: gclient setdep -r src-internal@ca5820a7d61c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2d29b39ec0ac8280cff218e0f002e43029310ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790261Reviewed-by:
-
Jérôme Lebel authored
Removing IdentityDisc feature flag. Bug: 1001073 Change-Id: I9ab7c1e7867bc51583fb287d94dd94c20acf25a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786647 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694503}
-
Xianzhu Wang authored
The previous calculation was: local_offset = hit_test_location - accumulated_offset - inner_editor->PhysicalLocation(); which was correct when the inner editor was the top element in the shadow dom or its PhysicalLocation included all offset from the text control. In a search input box, there are extra levels of layout objects between the text control and the inner editor. We need to exclude all offsets from the text control to the inner editor when calculating the local offset. Bug: 1000657 Change-Id: If1053ceffe556c2ca5be4639b21e669465c93b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789983 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694502}
-
Lei Zhang authored
It is just as easy to give the code within those namespaces unique names. This is more consistent with the naming scheme elsewhere in chrome/. e.g. ChromeAppsAPIProvider and ChromeContentClient. Change-Id: I0f79aaf1bb00f61fb6599dfabb9ddf1f5ff4ad23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790276Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#694501}
-
Tommy Steimel authored
Bug: 940049 Change-Id: Ib90a9eb315e19308c6d2b171d2ff7d57777cc84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789784 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#694500}
-
Shimi Zhang authored
This is a followup of http://crrev/c/1685837. See more at https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E/edit Bug: 955171 Change-Id: Iaa528bed1f3909a60f1c5db5bd01bf575ecd2cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787168 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#694499}
-
Nico Weber authored
Bug: 961769 Change-Id: I15c6a610aba1d90d976183be8053cf3829e16423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789425 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#694498}
-
Milad Farazmand authored
Recent CLs on V8 have been starting to use c++14 features, such as this: https://chromium-review.googlesource.com/c/v8/v8/+/1786284 Having the hard coded "gnu++11" flag causes the compilation to fail on AIX. Change-Id: Iffd74e3aed00711c8c344ea278b9533079f52ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789965Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#694497}
-
Maksim Sisov authored
As long as the conformance tests[1,2,3,4] on AMD drivers with Mesa >= 19 now pass, disable the workaround for newer drivers. [1] https://www.khronos.org/registry/webgl/sdk/tests/conformance/canvas/draw-webgl-to-canvas-test.html [2] https://www.khronos.org/registry/webgl/sdk/tests/conformance/canvas/draw-static-webgl-to-multiple-canvas-test.html [3] https://www.khronos.org/registry/webgl/sdk/tests/conformance/rendering/draw-webgl-to-canvas-2d-repeatedly.html [4] https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/tex-image-webgl.html Bug: 1000113 Change-Id: I3ea93121eaa1f363fe11c742158ef8bd3e0a953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787615 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694496}
-
Lambros Lambrou authored
This updates do_signing.sh for the new signing requirements in MacOS 10.15. This CL: * Passes --timestamp to the signing commands. * Signs the final DMG image. * Refactors the commands to avoid duplication in the keystore/no-keystore cases. Bug: 999402 Change-Id: I128a7e087f1d5019ae344b5c7e4ad041e500452b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790735 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#694495}
-
Sammie Quon authored
If there is odd number of windows, then closing the last window will leave a large gap. Fix this by shifting |scroll_offset_| before positioning windows. Long press used to be required for swipe to close. It can now be closed without a long press, just a vertical scroll is enough. Did one TODO and removed two obsolete ones. Test: manual, added tests Bug: 978112 Change-Id: I9d491ea232e2133fa28f86f299a0a69fbf971017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788220 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#694494}
-
