- 20 Aug, 2018 40 commits
-
-
Rayan Kanso authored
The WebApkServiceClient was overwriting the small icon in the notification builder. This change checks whether there was already a provided small icon bitmap before overwriting. This is the CL that introduced the bug: https://chromium-review.googlesource.com/c/chromium/src/+/978126 It will always call setSmallIconForRemoteApp on the notification builder for PWAs. For Android M+ this will overwrite the provided small icon bitmap. Bug: 867351 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If65970f3349e6a0738003d89e2721e3b2568afdc Reviewed-on: https://chromium-review.googlesource.com/1181043Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#584475}
-
Ryan Sleevi authored
This moves the handling for CRLSets out of the CertVerifier::Verify() set of parameters and makes it an explicit part of the CertVerifier::Config. Notification for CRLSet changes are now plumbed through the NetworkService to all of its NetworkContexts, rather than being a singleton on the SSLConfigService. In the process, this disables CRLSets for the chrome.platformKeys.verifyTLSServerCertificate API, but that is consistent with that API not observing other user or system configuration settings, and is part of the documented "subject to change at any time". TBR: jamiewalch@chromium.org Bug: 861849, 854635 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I818be91106274c736e074fc81947c5cb51c57564 Reviewed-on: https://chromium-review.googlesource.com/1132706 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584474}
-
Peter E Conn authored
Moving Trusted Web Activities over to CustomTabActivity gets us PostMessage for free. Unfortunately we're not ready to launch that, so disable it for the time being. Bug: 871266 Change-Id: Iaef2c08aea87be888cd98b102aeb4a87e888fd04 Reviewed-on: https://chromium-review.googlesource.com/1181139Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#584473}
-
Chris Mumford authored
Previously SimpleURLLoader would always upload the entire file. This allows the caller to specify a portion of the file to be uploaded. Bug: 844979 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8c2d6267fb65a5012f49c9f3ce943c44dc4837db Reviewed-on: https://chromium-review.googlesource.com/1180072 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
UnifiedConsent.ConsentBump.Action is added for iOS. It has already been added into Chromium with: crrev.com/c/1143185 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieda1e49c547182c6f044effdcf66e294f946c875 Reviewed-on: https://chromium-review.googlesource.com/1174832Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584471}
-
Charlene Yan authored
The calculations for bookmark bar icons should only impact the start y location of the icons and not the height. Regression mentioned in comment #5 in the bug is due to removing kBookmarkBarBottomMargin in the previous CL for the bug. The underlying reason for this is that GetPreferredHeight() was being used for both the bookmark height as well as the button heights. Bug: 865555 Change-Id: Ief5328a2a3a8c23ebfbaa9a393f1c3af4c7a6920 Reviewed-on: https://chromium-review.googlesource.com/1170226 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#584470}
-
Scott Haseley authored
TabLoadTracker unit tests were enabled only on non-Android platforms, but TabLoadTracker is included on Android builds. Bug: 861800 Change-Id: I571298a10dbc5113aaabde47a8288ad675c87e8b Reviewed-on: https://chromium-review.googlesource.com/1129461Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#584469}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/31458a557486..e8964a2cd375 git log 31458a557486..e8964a2cd375 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 wangge@google.com Explicitly read/write command line file as_root. Created with: gclient setdep -r src/third_party/catapult@e8964a2cd375 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:871748 TBR=sullivan@chromium.org Change-Id: I9c8a898f3350a755e26c31b50d24551477ddbdb0 Reviewed-on: https://chromium-review.googlesource.com/1181184Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584468}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12e3df13cfa5..7c42e01cedb9 git log 12e3df13cfa5..7c42e01cedb9 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 borenet@google.com [infra] Speculative fix for vpython cache 2018-08-20 fmalita@chromium.org [skottie] Pre-flight animation in-point, out-point 2018-08-20 borenet@google.com [docs] Remove outdated section about automatic tree closures Created with: gclient setdep -r src/third_party/skia@7c42e01cedb9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Id17ad05e3c0b8cadc8ee97a27729c4efa4e0208c Reviewed-on: https://chromium-review.googlesource.com/1181183Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584467}
-
Mostyn Bramley-Moore authored
These two files both define a TestCase struct in the anonymous namespace: payment_details_validation_unittest.cc payments_validators_unittest.cc These can conflict in jumbo builds. Let's isolate one of them by using a file-specific namespace instead of the anonymous namespace. Change-Id: Ic8e3fa255dde091311c02f73273a244782c4d2c3 Reviewed-on: https://chromium-review.googlesource.com/1180212Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584466}
-
Dominick Ng authored
It becomes more complicated, but web_app_provider.cc becomes simpler. Change-Id: I976ac72d40c1e153ba8cbb15f42931885a453ee1 Reviewed-on: https://chromium-review.googlesource.com/1170145 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Misha Efimov authored
Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ied0c3de493c817e0836fcf42e09736509acbd2d1 Reviewed-on: https://chromium-review.googlesource.com/1086127 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584464}
-
Annie Sullivan authored
Bug: 738854 Change-Id: If29018f3125540bd3abe15f46b5a13994215066b TBR: tdresser@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174633 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584463}
-
Gauthier Ambard authored
This CL changes the VoiceSearch LayoutGuide to position it using frames instead of autolayout as the autolayout positioning is introducing a bug on 3x devices. Bug: 874017 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I451e3c787065347a1b0ece28fb4f68de7c31b8e4 Reviewed-on: https://chromium-review.googlesource.com/1181049Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#584462}
-
Devlin Cronin authored
Relanding since the CL wasn't the cause of test flakiness. Original change's description: > [Extensions] Introduce common client initialization > > In order to extract apps-specific code from extensions, we'll need to > be able to add extra information to the extensions client from outside > extensions code. This will require having a centralized initialization > for the extensions client. > > Introduce a single method, EnsureExtensionsClientInitialized(), which > constructs and sets the ChromeExtensionsClient. Remove the old way of > constructing the client, ChromeExtensionsClient::GetInstance(). Update > all callers to construct the client via the new method. > > While we're at it, update the client to use base::NoDestructor instead > of LazyInstance. > > Bug: 873937 > Change-Id: I47147cd5f33ea44079c0a319626c57f3c5813af8 > Reviewed-on: https://chromium-review.googlesource.com/1175459 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583217} TBR=thestig@chromium.org,rdevlin.cronin@chromium.org Bug: 873937 Change-Id: Idf8fdc2ca89e3f0e481fbfd310c5ebc6067311f1 Reviewed-on: https://chromium-review.googlesource.com/1181162Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584461}
-
stkhapugin@chromium.org authored
Ignores the scroll events caused by the updated suggestions. Bug: 813025 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I10bee25484c964ded91afe47e7f51f8146e16f7b Reviewed-on: https://chromium-review.googlesource.com/1181131Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 816318, 874515 Change-Id: I8d165ec355036f8c190bb21e1c50ee8f9b6a4d5a Reviewed-on: https://chromium-review.googlesource.com/1176389Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#584459}
-
Friedrich Horschig authored
This test is already disabled for all other platforms but (as linked in the bug) Windows bots also reported flakes. Therefore, disable it for windows as well. TBR=clamy@chromium.org Bug: 665296 Change-Id: I3991d966d72509324c00c28d82ace55d698eecb4 Reviewed-on: https://chromium-review.googlesource.com/1181262Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584458}
-
Dominic Battre authored
This CL disables manual password generation in the context menu in case the user has disabled the password manager or the site has an SSL problem (in which case Chrome would not fill the credential). Bug: 875751 Change-Id: I900590e6674ba0d039033fb5bacfb83f39bcba52 Reviewed-on: https://chromium-review.googlesource.com/1180966Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#584457}
-
Nico Weber authored
Setting YASM_TEST_SUITE makes yasm output deterministic: - the PE/COFF timestamp field is always 0 (this breaks link.exe /incremental, but we no longer user link.exe) - in debug info, yasm identifies itself as "yasm HEAD" instead of e.g. "yasm 1.3.0" (we don't care much about this effect) - in debug info, file paths are no longer absolute but relative to '.' Bug: 330260 Change-Id: Icafe7abd6a637b86af2b5b8e7f88e0bfa042da50 Reviewed-on: https://chromium-review.googlesource.com/1180718Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584456}
-
Mohsen Izadi authored
This change replaces usage of content::BrowserGpuMemoryBufferManager with viz::HostGpuMemoryBufferManager. With this change BrowserGpuMemoryBufferManager is not needed anymore and code to handle buffer allocation in GpuProcessHost is also removed. BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6a9387e2e33a5d98d4ed7559618f4995256bafa4 Reviewed-on: https://chromium-review.googlesource.com/1095815 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#584455}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/908689d04718..f1f363fae757 git log 908689d04718..f1f363fae757 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 srte@webrtc.org Renames test::VideoCapturer to TestVideoCapturer. 2018-08-20 titovartem@webrtc.org Mark DirectTransport subclasses ctors as deprecated and switch from them 2018-08-20 titovartem@webrtc.org Deprecate two DirectTransport ctors and remove their direct usage. Created with: gclient setdep -r src/third_party/webrtc@f1f363fae757 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I499c1d650c245f84c711271483112bfc4ff36158 Reviewed-on: https://chromium-review.googlesource.com/1181182Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584454}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I10afdab7594aaf5d79a6e8c1c98911511b55969d Reviewed-on: https://chromium-review.googlesource.com/1177701Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#584453}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0e1fc1042fe0..f8268f7ccb65 git log 0e1fc1042fe0..f8268f7ccb65 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 derat@chromium.org chromeos_config: Remove warn_only from Tast suites. Created with: gclient setdep -r src/third_party/chromite@f8268f7ccb65 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifca7c0600690cf69ea8975ff990301114dff801b Reviewed-on: https://chromium-review.googlesource.com/1181201Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584452}
-
Thomas Tangl authored
This is a reland of 28ac1ad7 The were two problems: - There was a call to internal::GetUnifiedConsentFeatureState() in UnifiedConsentService::ShouldShowConsentBump(). Instead of using this function, the check for the feature state should happen on the platform level. This is already done on Desktop, so removing the call will resolve the problem. - The initialization of scoped_unified_consent_ in the unit tests had a bug. When the variable was reset with a new value, the new value was created before the old one was deleted which led to a memory leak. Original change's description: > [unified-consent] Refactor migration code and add settings updates > > The migration code in the UnifiedConsentService is refactored: > - The migration state IN_PROGRESS_SHOULD_SHOW_CONSENT_BUMP is > extracted to it's own pref kShouldShowUnifiedConsentBump. > - The migration state kInProgressWaitForSyncInit is introduced > to be able to update the settings for migration when sync is > initialized. > > Additional changes: > - ShouldShowConsentBump only returns true if the consent bump > feature is enabled. > - The rollback enables sync-everything now also when the user is > not syncing USER_EVENTS (which is disabled during the migration). > > Users that previously had the unified consent feature enabled and > for which ShouldShowConsentBump=true, will not be shown the consent > bump anymore after this CL is landed. This will only affect a few > users on Canary and Dev. > > Bug: 863932 > Change-Id: I211805f9059cd26056ed81d01ff19470b8caed3c > Reviewed-on: https://chromium-review.googlesource.com/1172690 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584341} TBR=ellyjones@chromium.org TBR=droger@chromium.org Bug: 863932 Change-Id: Ic041ac99da729d072f49fc9aa6adfe5624fc089e Reviewed-on: https://chromium-review.googlesource.com/1180921 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Test is still flaky. Original change's description: > Disable TabManagerTest.ProactiveFastShutdownWithBeforeunloadHandler > > TBR=wjmaclean@chromium.org > NOTRY=true > > Bug: 874915 > Change-Id: Id0fae86ef2e130185d92ad28383c74036dcd96f3 > Reviewed-on: https://chromium-review.googlesource.com/1177881 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583660} TBR=xidachen@chromium.org,wjmaclean@chromium.org Bug: 874915 Change-Id: I75d5ca813702dace0d3966baac2bd69d517dd1c8 Reviewed-on: https://chromium-review.googlesource.com/1181164Reviewed-by:
-
Peter Wen authored
GMSCore API libraries now ship their own third party licenses. We append these licenses to the Android SDK license for each package in order to ensure that they are all present in our releases. Bug: 868879 Change-Id: Ib169e7cbb4c67a1f6a34b11dfe1502fcf4d4155e Reviewed-on: https://chromium-review.googlesource.com/1159323 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#584449}
-
Xiyuan Xia authored
test_ws could exit before |aura_test_helper_| is created. This CL handles such case. TBR=sky@chromium.org Bug: 874089 Change-Id: I65a29329fb079795f939a082dd60d4e680d282f5 Reviewed-on: https://chromium-review.googlesource.com/1180362 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#584448}
-
Peter Kasting authored
This required: * Deleting the old pre-custom-titlebar rect intersection code, which bypassed the drag extension code. AFIACT this code had no advantages over the common code in BrowserNonClientFrameView. * Fixing a color computation bug in GetTabBackgroundColor() that I introduced in https://chromium-review.googlesource.com/1173715 , where it ignored the requested active state of the frame. This probably had other bad effects too. * Fixing code in the tab strip that failed to mirror bounds correctly, so this would work in RTL. Again, that probably resulted in other bugs too. While testing that this worked right with the new tab button, I also fixed (via simplification) an unrelated issue where the new tab button hit test region in refresh was a rectangle instead of the correct path. Bug: 862276 Test: Run chrome on Windows 10 with --disable-features=Windows10CustomTitlebar, then hover the top couple pixels of a background tab in a restored window in the default theme. The tab should not light up with a hover effect until you get 6 px or so down into the tab. Change-Id: Iabc80cdde7f67251214c5308687105f13ea22f19 Reviewed-on: https://chromium-review.googlesource.com/1180594Reviewed-by:
-
Ryan Daum authored
- TTS extension API was being installed without custom bindings. - Also adds registration of the lazy_background_page API, which TTS bindings need. Bug: internal b/111972492 Test: manual Change-Id: I03307abf2c8eb996d92d8978cd565edc0c388c22 Reviewed-on: https://chromium-review.googlesource.com/1181167Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#584446}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6676079d2b79..12e3df13cfa5 git log 6676079d2b79..12e3df13cfa5 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 fmalita@chromium.org [skottie] Harden interpolation checks for shapes Created with: gclient setdep -r src/third_party/skia@12e3df13cfa5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I150ef8cb81a1f17295fdd59566dc0eb867cefc65 Reviewed-on: https://chromium-review.googlesource.com/1181181Reviewed-by:
-
Peter Wen authored
After this update individual API library versions can be updated independently. Licensing improvements are also in this update which will be used in a follow-up CL. Extra deps added: - com_google_android_gms_play_services_clearcut - com_google_android_gms_play_services_flags - com_google_android_gms_play_services_phenotype - com_google_android_gms_play_services_places_placereport - com_google_android_gms_play_services_stats Binary size increase of +58,148 bytes normalized apk size. These are not shipped in downstream anyways. Binary-Size: New library dependencies Bug: 869935 Change-Id: Ia53f69c4756adac4f55be820eaf7ef1393a975d2 Reviewed-on: https://chromium-review.googlesource.com/1158999 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
-
Bailey Berro authored
If the policy for NetworkFileSharesAllowed is set to false, users will not be able to mount shares nor will the be able to access the mount ui Bug: chromium:757625 Change-Id: Ief64c9a9c3c2a574b931bc3f21516d471c26bcd4 Reviewed-on: https://chromium-review.googlesource.com/1152490Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#584443}
-
Aldo Culquicondor authored
The used source class was causing several performance regressions. Bug: 874363, 874365 Change-Id: I697f4380c978aa6c7dbc6d41759bfbbdae0878db Reviewed-on: https://chromium-review.googlesource.com/1176379Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#584442}
-
Charlie Harrison authored
This is in preparation to add a struct UkmSource::Metadata, which would need to be used in //services. TBR=sky@chromium.org Bug: 873316 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0d33f6ece24b9176ff86310ef2e7347453b5ccfa Reviewed-on: https://chromium-review.googlesource.com/1179992Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#584441}
-
Juan Antonio Navarro Perez authored
Stories have been consinstently failing on N5X and Pixel 2 bots. TBR=nednguyen@google.com NOTRY=true Bug: 875859 Change-Id: I9d41fa293a90e6961eabc6b29711d8b824d469ce Reviewed-on: https://chromium-review.googlesource.com/1181140Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#584440}
-
Vadym Doroshenko authored
It contains a number of tiny clean ups: 1.Using range based for 2.Dropping autofill:: namespace in favor of using 3.Using map lookup instead of range based for by map. 4.Old comment removal in password_manager.cc Bug: 875768 Change-Id: I6d7c481139d59e8de35ec49ad58f9486de04359d Reviewed-on: https://chromium-review.googlesource.com/1177743 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Sriram authored
Removing media/seek-to-currentTime.html infavor of the wpt test at wpt/html/semantics/embedded-content/media-elements/seeking/ Change-Id: I115785280c5fb0a9fdab449feea1f8a348b9271e Reviewed-on: https://chromium-review.googlesource.com/1181017Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#584438}
-
David Roger authored
This CL stops recording the user actions related to the regular sync confirmation when the consent bump is used. Adds a new bucket in the consent bump histogram for the "Abort" case. Bug: 871267 Change-Id: I35b4ce80c6da0e0fe871f6d10ab799e555960e05 Reviewed-on: https://chromium-review.googlesource.com/1179664 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
They were disabled by mistake on the wrong platform. TBR=nednguyen@google.com NOTRY=true Bug: 874935 Change-Id: I9b50b481e97b9f2c01cde4cc43f1627ea4663c51 Reviewed-on: https://chromium-review.googlesource.com/1181135Reviewed-by:
-
