GitLab

BUG=chromium:811811
BUG=chromium:811905
BUG=chromium:811815
BUG=chromium:811796
BUG=chromium:811831
BUG=chromium:811789
BUG=chromium:811809
BUG=chromium:811821
BUG=chromium:811869
BUG=chromium:811866
BUG=chromium:811781
BUG=chromium:811799
BUG=chromium:811814
BUG=chromium:811864
BUG=chromium:811835
BUG=chromium:811834

Change-Id: I91e9f88b93354a27f6ca04622399218fd0dd5d42
Reviewed-on: https://chromium-review.googlesource.com/952046Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541517}

Compilation in GCC fails because of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80654
if T in WTF::Optional<WTF::Vector<T>> is not trivially copy constructible.
The problem already happened in std::vector and was workarounded. This
change implements a similar fix for WTF::Vector.

Bug: 816952

Change-Id: If87f01beb952e03eb49dcaf0c5db6efd745bf05e
Reviewed-on: https://chromium-review.googlesource.com/944404
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541516}

This makes the Fetch API more standards compliant by
enforcing the enum values in the RequestInit dictionary,
as this is not taken care of by the IDL bindings themselves.
This enforces the mode, credentials, cache, and redirect properties
of RequestInit.

R=yhirano@chromium.org, yoav@yoav.ws

Bug: 777116
Change-Id: I8db5fd991b5ffa039dc2f67b4d8f525647fbf915
Reviewed-on: https://chromium-review.googlesource.com/841270
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541515}

Bug: 787097
Change-Id: I1db9b3edcd0fd7a5686b3a7c2f0993c551b3e9f6
Reviewed-on: https://chromium-review.googlesource.com/953070Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541514}

This reverts commit d979063b.

Reason for revert: Reasonable pending times, right now; let these builders back on the CQ while we keep any eye on things and work on a more permanent solution.

Original change's description:
> Mark builders with Win10 GCE slaves as experimental.
> 
> Bug: 819355
> Change-Id: Ib242933a5a3d1cf4d03edac0cb4b4e6be468b12d
> Reviewed-on: https://chromium-review.googlesource.com/952777
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: smut <smut@google.com>
> Cr-Commit-Position: refs/heads/master@{#541326}

TBR=smut@google.com,jchinlee@chromium.org,jbudorick@chromium.org

Change-Id: I827b55a796c8e41f273552a9ea42e222b59b8d4d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819355
Reviewed-on: https://chromium-review.googlesource.com/953030Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541513}

Bug: 807015
Test: Manual
Change-Id: I532b1a9441208ecf794c4975d3871880f6c43896
Reviewed-on: https://chromium-review.googlesource.com/945144
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541512}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idf5ef903e9e1eb9c1a55e62df3ed173731fa1920
Reviewed-on: https://chromium-review.googlesource.com/939864Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541511}

R=isherman@chromium.org

Bug: None
Change-Id: I0c8907156c04dbd37fa64acd52648d3e34a5fdf8
Reviewed-on: https://chromium-review.googlesource.com/946188
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541510}

Change-Id: I458faa93c93fba0d32b81f2de54d7c370a2d9219
Reviewed-on: https://chromium-review.googlesource.com/952454Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541509}

Move the ChannelMerger and ChannelSplitter tests to WPT.
ChannelSplitteraudiochannelsplitter.html removed from SmokeTests.

Note that ChannelMerger/audiochannelmerger-cycle.html isn't moved.
Firefox currently fails this test, but I think Firefox is correct and
Chrome is wrong.  We'll move this test later.

Bug: 745778
Change-Id: I981a773a9c654f26d15e80eb5ec699b0eca0c8d7
Reviewed-on: https://chromium-review.googlesource.com/949053Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541508}

Previously, BrowserViewRenderer made sure to use synchronous draws until
it receives a non-empty frame from the compositor, before it starts
using async draws. This is to ensure that GL bindings are initialized by
the compositor before calling into draw functor.

GL init has been made thread safe now. See gpu::InitializeGLThreadSafe.

However, we may have accidentally come to depend on sending a
synchronous IPC on init before start using async IPCs (which may have
more places to be dropped randomly than sync IPCs). So out of an
abudance of caution, change the behavior to send a single synchronous
IPC (without waiting for non-empty frame).

Note this does have the side effect that we may send empty or null
frames to render thread, so draw functor may be called before receiving
first non-null/non-empty CompositorFrame.

One step closer to getting rid of synchronous hardware draw altogether.

Change-Id: I30167e74df7bb0f2a880401f0545148e160fe001
Reviewed-on: https://chromium-review.googlesource.com/941544Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541507}

Previously this code used ClientSharedBitmapManager to allocate
shared memory which would report the allocations thru the mojo-based
SharedBitmapAllocationNotifier to the display compositor. But we
want to tell the display compositor on the CompositorFrameSink so it
is in the same channel as SubmitCompositorFrame.

So BitmapRasterBufferProvider now receives a LayerTreeFrameSink
instead of a SharedBitmapManager, does allocation of shared memory
through base+mojo, and reports the allocations and destructions to
the CompositorFrameSink.

The ResourcePool and its resources are all destroyed before the
CompositorFrameSink, so it can hold a raw pointer to the frame sink
in each SoftwareBacking to notify when the shared memory is freed.

This doesn't break the old notification path, and clients of
ClientSharedBitmapManager will still notify their SharedBitmapIds
to the display compositor with SharedBitmapAllocationNotifier, and
with a valid sequence number. However for the
BitmapRasterBufferProvider+ResourcePool, the sequence numbers are
now 0 since they are not needed, as the notification goes to the
same interface as SubmitCompositorFrame and will be well ordered.

Notably, this means that the browser compositor's software
resources will be allocated in shared memory, as the
BitmapRasterBufferProvider and the CompositorFrameSink have
no interface to pass raw pointers to the display. This is required
for the VizDisplayCompositor feature, and as we close the shared
memory fds it shouldn't greatly impact the browser process.

R=kylechar@chromium.org
TBR=sky

Bug: 730660
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I8354b11344afa58866105e970a0efc9741294b50
Reviewed-on: https://chromium-review.googlesource.com/935266
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541506}

This is split out from the CL to test all widgets and views for nameless
focusable objects. See crrev.com/c/951933.

Bug: 819350
Change-Id: I2e9a97939e502493e864fec9bb6b840338905a77
Reviewed-on: https://chromium-review.googlesource.com/952988
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541505}

Bug: 469376
Change-Id: I7183682e397479a2e8bb6cd167e99e09e4d3dd67
Reviewed-on: https://chromium-review.googlesource.com/952774Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541504}

Test: trybots
Bug: 764393
Change-Id: I4122ec6a4e722cde7bb048b72e9d579d6edbb151
Reviewed-on: https://chromium-review.googlesource.com/952575Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541503}

This will simplify the plumbing required for Android as it will be
shared with the one on desktop.

Bug: 726619
Change-Id: I19cf0b6befac15d540e869c195e04d9d71ea1f28
Reviewed-on: https://chromium-review.googlesource.com/946255Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541502}

This flag isn't used currently, but it will be soon.

BUG=803319

Change-Id: Id6755d662092d9078a516acd000ffe905dbe7c73
Reviewed-on: https://chromium-review.googlesource.com/952569
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541501}

This was originally https://chromium-review.googlesource.com/c/chromium/src/+/929942
but was reverted because of the hacky way it implemented a components/ function
in Chrome.

It's now rebased on https://chromium-review.googlesource.com/c/chromium/src/+/949362
which made that behavior unnecessary.

Background:
Polychrome is an intermediate step to shipping MacViews browser.
Currently, switching between Cocoa browser and MacViews browser requires
a buildflag. Polychrome builds both Cocoa and MacViews into the same
binary and allows switching between them based on a feature flag.
More details at crbug.com/802257

As Cocoa and (much of) Views were not typically built together,
some symbols were reused. With Polychrome, these are duplicate symbols.
This CL resolves the issue by renaming the Cocoa symbols, and then
shimming them for the (regular, not Polychrome) Cocoa build.

Bug: 808017
Change-Id: Ia42c202e474614c97759aab28c88f580bc0ffabd
Reviewed-on: https://chromium-review.googlesource.com/950063Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541500}

Combines MojoAttachSerializedMessageBuffer,
MojoExtendSerializedMessagePayload, and
MojoCommitSerializedMessageContents (phew!) into a single
MojoAppendMessageData.

Renames MojoGetSerializedMessageContents to MojoGetMessageData.

Adds extensible options parameters to both calls.

Restores a flag for MojoGetMessageData to ignore attached handles,
allowing callers to e.g. peek at message contents non-destructively.

This is in preparation for actual commitment to a stable API. Modulo a
likely rename of the "Mojo" prefix, these message functions should
henceforth be considered stable and must maintain forward-compatibility
indefinitely.

TBR=dcheng@chromium.org

Bug: 819046
Change-Id: Ie6a572c84146a5ab3b40c8415eb179a809570bfe
Reviewed-on: https://chromium-review.googlesource.com/951870
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541499}

Add a new mirroring component under components/ for the new mirroring
service. The browser side codes are moved into the component in this CL.
The media/remoting codes and other mirroring service codes will be added
in later CLs.

Bug: 734672
Change-Id: I0187f40bdfa44bcf7a9645b8bce4130fa6738eb0
Reviewed-on: https://chromium-review.googlesource.com/943822Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541498}

The helper namespace declarations for manifest_keys,
manifest_errors are declared both inside anonymous namespace
and extensions namespace. This is ambiguous and makes
compilation fail.

So move all the helper declarations out of the anonymous
namespace.

Change-Id: I778b81c8094b12842fd47ae982b6cf620d208671
Reviewed-on: https://chromium-review.googlesource.com/944407
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541497}

This is split out from the CL to test all widgets and views for nameless
focusable objects. See crrev.com/c/951933.

Bug: 819350
Change-Id: Ia777a77da739ead813d8f898e194366d20e3601e
Reviewed-on: https://chromium-review.googlesource.com/952987Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541496}

Bug: 706389
Change-Id: I445e77e3da2782a7a8d6593cb46417fcaef96394
Reviewed-on: https://chromium-review.googlesource.com/952553Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541495}

BUG=818861,818751

Change-Id: Ie418d245523011f71d185ad4195ebdee3d2e4765
Reviewed-on: https://chromium-review.googlesource.com/951978Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541494}

- Make Cronet test server serve files from data directory.
- Change Android NativeTestServer to use Cronet test server.

Bug: 786559
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7f19519e9ee588e028976f4aa3411f735e69a4c1
Reviewed-on: https://chromium-review.googlesource.com/941589
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541493}

The setup for this test refers to features::kViewsBrowserWindows which
was moved to ui/base in https://chromium-review.googlesource.com/c/chromium/src/+/949362

Change-Id: I69ea6064330a094dd041fbe7b244dfae0f806802
Reviewed-on: https://chromium-review.googlesource.com/952482Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541492}

Bug: 813197
Change-Id: I2cc1f37e67911bbcfacbb0235c7330b51c5146c1
Reviewed-on: https://chromium-review.googlesource.com/943741Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541491}

https://webrtc.googlesource.com/src.git/+log/db4fa4b94442..2e18061033d3

$ git log db4fa4b94..2e1806103 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I46c08e6d4580d5d5f46a7af916cf538aae8836c0
Reviewed-on: https://chromium-review.googlesource.com/953063
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541490}

TBR=csharrison

Bug: 819592
Change-Id: Iab5688d761675b69b9ecddf83dc55abd37ea875d
Reviewed-on: https://chromium-review.googlesource.com/952450Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541489}

This is an attempt to address a crash report. If after this CL, we
still see the same crashes, then we might want to consider disabling
GPU access.

BUG=817286
TEST=bots
R=geofflang@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I81979673020ec9ad6169642749cac3bb53f8decb
Reviewed-on: https://chromium-review.googlesource.com/952275Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541488}

Bug: 804686
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I12f8b20ee210f436e1d4858eddb66a6fa112faaf
Reviewed-on: https://chromium-review.googlesource.com/952033
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541487}

TBR=perezju

Bug: 819552
Change-Id: Ib4fb62e89cd7b1bdeb6de2d4e94621b4fba519c6
Reviewed-on: https://chromium-review.googlesource.com/951734Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541486}

This is only used to support pepper CDM, which is being deprecated now.
Hence remove all related code.

Bug: 772160
Change-Id: Idfd2f97dd09a8be3f9aa90c998ffc18c60987057
Reviewed-on: https://chromium-review.googlesource.com/947922
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541485}

We should (finally) remove support for manifest v1. One of the last
significant dependencies is that a lot of our tests aren't manifest v2
yet.

This CL updates the majority of manifest files under
chrome/test/data/extensions/page_actions (which are not usually
named manifest.json).

This CL only modifies files that update cleanly (i.e., no other
test updates necessary). A separate CL will address those.

Bug: 816679
Change-Id: I5bbb98be75c9a1912e3221095d8aa4db1ba6f7d2
Reviewed-on: https://chromium-review.googlesource.com/952270Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541484}

Bug: None
Test: still compiles
Change-Id: I77e8ef85f1f7ad96fb463d1e3c1b2e6d569f4938
Reviewed-on: https://chromium-review.googlesource.com/952869Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#541483}

ClipDisplayItems would use/generate antialiased clips, so it makes sense
to carry that bit (literally) forward.
Also update the FloatClip display item code-path for consistency.

Bug: 814876, 819617
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1433804bd5734857116e613c2342c49d42499ecb
Reviewed-on: https://chromium-review.googlesource.com/934450
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541482}

This is split out from the CL to test all widgets and views for nameless
focusable objects. See crrev.com/c/951933.

Bug: 819350
Change-Id: Iaba5c56454b48cf1f43cb403599d853902cf7b5e
Reviewed-on: https://chromium-review.googlesource.com/953045Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541481}

Using wpt-import in Chromium b7948fee.
With Chromium commits locally applied on WPT:
14350ac7 "[PE] Don't truncate table cell's padding"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13447

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org:
  external/wpt/css/css-text-decor
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
igrigorik@chromium.org, yoav@yoav.ws:
  external/wpt/preload
kojii@chromium.org:
  external/wpt/css/css-text/i18n
  external/wpt/css/css-text/line-break
  external/wpt/css/css-writing-modes

TBR=robertma

No-Export: true
Change-Id: Id58023b08fa221002f143927c7070764d8f0c3e9
Reviewed-on: https://chromium-review.googlesource.com/953043
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541480}

This reverts commit 6e39ad9c.

Reason for revert: Introduced test failures on the layout_ng bot.

Original change's description:
> Add support for mid ligature position on ShapeResult
> 
> Makes XPositionForOffset and CharacterIndexForPosition support
> return results inside a ligature glyph (while still not breaking ZWJs)
> by using a cursor-based TextBreakIterator inside glyphs.
> 
> This also changes how InlineTextBoxPainter handles selection paint, to
> support partial glyph selection. More specifically, for text selection
> we now render the selected glyphs twice: once in the normal text style,
> clipped out of the selection area and once in the selection style,
> clipped in the selection area.
> 
> Bug: 473476
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I121d03b436de88b367047efb8342cd975047a9ea
> Reviewed-on: https://chromium-review.googlesource.com/752342
> Commit-Queue: Fernando Serboncini <fserb@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541474}

TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org,fserb@chromium.org

Change-Id: If1420a335f12629d97f45d788fdee1a120bc8aaf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 473476
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/952168Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541479}

This CL parses the url_template as a GURL prior to substituting the
placeholders. Parsing the url_template a GURL causes '{' and '}' in
the url_template path to be escaped, and thus stops the
ReplacePlaceholders() algorithm from replacing placeholders in the
url_template path. Parsing the url_template as a GURL does not affect
how placeholders in the URL query and URL fragment are treated. This
change is in line with share target
spec https://wicg.github.io/web-share-target/

A follow up CL (part 2) will make the fact that ReplacePlaceholders()
only substitutes placeholders in the query and fragment more explicit.

URL spec reference: https://url.spec.whatwg.org/#query-state
'{' and '}'
- are in the path-percent-encode set
  https://url.spec.whatwg.org/#path-percent-encode-set
- are not in the fragment-percent-encode set
  https://url.spec.whatwg.org/#fragment-percent-encode-set
- should not be percent encoded in the URL query
  https://url.spec.whatwg.org/#query-state

BUG=694380

Change-Id: I0e3bcefa6cd9bc3997caf54ad824b6bfc87b9e88
Reviewed-on: https://chromium-review.googlesource.com/923539Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541478}