- 03 Jun, 2019 15 commits
-
-
David Staessens authored
This CL adds a new metric 'frame drop rate' to the new video_decode_accelerator_perf_tests. TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: I81bac2e01e42fcda3b08cb4608a974f9b5aa941a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577321 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665451}
-
Luciano Pacheco authored
Change SearchController.search_ method to announce via Chromevox the following search results: * When there is any results: Showing results for $SEARCH_TERM. * When there is no results: There are no results for $SEARCH_TERM. * When clearing/cancelling the search: Search term cleared, showing all files and folders. Test: browser_tests --gtest_filter=" Search/FilesAppBrowse* : DriveSpecific/FilesAppBrowserTest.Test/drivePressClearSearch_DriveFs " Bug: 888581 Change-Id: I848c9344de87a758d18114dd045cf74d001ad32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630379Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#665450}
-
Noel Gordon authored
Dont report ISO speed 0, return "undefined" instead. Update the golden test file results to match. Test: piex/tests.sh PASS, speed unchanged. Bug: 965370 Change-Id: If7a62883ca89ccf8171934a7dff11ddb0ecaea10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638932Reviewed-by:
-
Darren Shen authored
Disable: - WorkerThreadRegistryTest.BasicObservingAndWorkerId - WorkerThreadRegistryTest.TaskRunnerRemovedCorrectly on Fuchsia. TBR=falken@chromium.org Bug: 969562 Change-Id: Iaee041bfb807cade7cab292cac839b81e31b1a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640522Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#665448}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I6d77e9e24c7d1f73f7ff6db3cd2c14a914697a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638933Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#665447}
-
Ting Shao authored
When ServiceWorkerImportedScriptUpdateCheck is enabled, main script response header check failures should cause update job failure. Bug: 648295 Change-Id: I0aa1b1cb96e8bba33745fb8d5f09baa55524e7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563693 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665446}
-
Darren Shen authored
Flaky failures on multiple bots, e.g. https://ci.chromium.org/p/chromium/builders/try/fuchsia_x64/299211 TBR=falken@chromium.org Bug: 968972,968971 Change-Id: I89baef8aed2e19121a6709e48348cdbce787714b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640581Reviewed-by:
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Idcf36e666b12cb0029f6c341c868ccf4e4cba450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639597 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#665444}
-
Victor Costan authored
This CL replaces the bare new operator with std::make_unique and removes "return std::move" in favor of C++11's guaranteed copy elision. Change-Id: I66c210edc1d4529ef06ffde1bba3287d4cd3b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637248Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#665443}
-
Darren Shen authored
This reverts commit a9d56928. Reason for revert: New test failing component_unittests. See 969547 Original change's description: > [omnibox] Rename the ZeroSuggestProvider::ResultType values > > This CL renames the ZeroSuggestProvider::ResultType values to be > more descriptive, and adds more commentary. > > They used to imply that we asked the default search provider for > zero-suggestions, which was sometimes misleading, since that's not > always true. > > Bug: 963173 > Change-Id: I85a55cb57749441d2adfdb53642247fd055b7d9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631903 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665330} TBR=mpearson@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963173 Change-Id: If450a7ed3c97689ff54847deaef0c4ad8bdf7e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640580Reviewed-by:
-
Victor Costan authored
The directory only has an OWNERS file since https://crrev.com/c/1282085 removed the code there on 2018-10-16. Bug: 888904 Change-Id: I6004e00e90a009c5fdf03968cd9b59f7f8ed0272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640578 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#665441}
-
Darren Shen authored
This reverts commit 08842218. Reason for revert: Breaks compile for ios bots. See 969545 Original change's description: > Implement AppLaunchManager for controlling app-under-test for EG2 tests. > > No tests are added to smoke_egtest to test app relaunching, as it descends > from ChromeTestCase, which currently has logic which is required to run > every time the app-under-test is launched. Long-term, it is preferred if > this logic is moved to -setUp and executing before every test method. This > refactor will happen in a later CL as it requires some planning. > > Confirmed that smoke_egtest does however only launch the app once with the > change to use AppLaunchManager. > > Bug: 922813 > Change-Id: I7f33aa5a847f93295d918fdf4fff92aaf078f695 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635859 > Commit-Queue: ericale <ericale@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665367} TBR=rohitrao@chromium.org,eugenebut@chromium.org,lindsayw@chromium.org,ericale@chromium.org,monufriienko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922813 Change-Id: I425b5389d37527a30b5747a8d19339f52bcb7a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638929Reviewed-by:
-
Luciano Pacheco authored
Add a11y aria-live message for #view-button that announces the following messages: * After switching to List View: File list has changed to list view. * After switching to Thumbnail View: File list has changed to thumbnail view. Test: browser_tests --gtest_filter="GridView/FilesAppBrowserTest.Test/viewButtonSwitches" Bug: 888581 Change-Id: Ia6f02f6fa98a73b083d37e7cee84e9eb5a39f52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634512Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b0e0ade94cf..f9f6a47f27cc Created with: gclient setdep -r src-internal@f9f6a47f27cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ife1cbbc0616322d5ce2218f25639b0d995506b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640597Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665438}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c104b2d24a6f..98f2167125a8 git log c104b2d24a6f..98f2167125a8 --date=short --no-merges --format='%ad %ae %s' 2019-06-02 jmadill@chromium.org Vulkan: Refactor index buffer convert functions. Created with: gclient setdep -r src/third_party/angle@98f2167125a8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I44161b320d8a5091c1ff8b9f4a49ba068b2bbfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665437}
-
- 02 Jun, 2019 21 commits
-
-
Sara Kato authored
Bug: None Change-Id: Iecad7de324614a14c3e133f4c04037a7d8dc65bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630133Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#665436}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I058a6a9be1d22ddf745095e6646962f7be4dd9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639493Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c0ad02bc545..eca66b32fdb9 git log 3c0ad02bc545..eca66b32fdb9 --date=short --no-merges --format='%ad %ae %s' 2019-06-02 bsalomon@google.com SkVector4 as ctype for half4 Created with: gclient setdep -r src/third_party/skia@eca66b32fdb9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I02ac6e5d4af0d13f1cca979d1f8d71529ba6e6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639492Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6d88284607d2..a549bb817523 git log 6d88284607d2..a549bb817523 --date=short --no-merges --format='%ad %ae %s' 2019-06-02 johnkslang@users.noreply.github.com Merge pull request #1769 from tanderson-google/RemoveInvalidGnSource 2019-06-02 johnkslang@users.noreply.github.com Merge pull request #1782 from dgkoch/fix_1735 Created with: gclient setdep -r src/third_party/glslang/src@a549bb817523 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I4da1d30fe59d8838f1ebb57cd7750cea82f0e9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639487Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64bd50cc7d89..2b0e0ade94cf Created with: gclient setdep -r src-internal@2b0e0ade94cf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I4c7a317d72f5b350f8786f0419999db7ba99e05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640300Reviewed-by:
-
Antonio Gomes authored
This CL removes the redundant enum MediaStreamRequestResult, defined in [1], in favor of the mojom existing variant in [2]. [1] third_party/blink/public/common/mediastream/media_stream_request.h [2] third_party/blink/public/mojom/mediastream/media_stream.mojom The associated typemap [3] and traits declarations [4][5] are also removed. [3] third_party/blink/public/common/mediastream/media_stream.typemap [4] third_party/blink/common/mediastream/media_stream_mojom_traits.cc [5] hird_party/blink/public/common/mediastream/media_stream_mojom_traits.h TBR=haraken@chromium.org BUG=923394,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I371a5cac053597a73207598774a6a22ed0c73236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639237 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#665431}
-
Antonio Gomes authored
This reverts commit f2ddd07c. Reason for revert: Possibly caused crbug.com/969420 (Crash in void WTF::LinkedHashSetTranslator<blink::Member<blink::Report>, WTF::MemberHash<) Original change's description: > Replace HeapListHashSet with HeapLinkedHashSet in ReportingContext > > ListHashSet is deprecated in favor of LinkedHashSet. > > HeapLinkedHashSet's invalidate iterators when the container is > modified. This does not happen in this usage, so replacement is > simple. > > R=jbroman@chromium.org > CC=blink-reviews-vendor@chromium.org > > BUG=614112 > > Change-Id: I97895b75088dc995c47c98b67258435ffa8ab38c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584110 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#665368} TBR=jbroman@chromium.org,haraken@chromium.org,tonikitoo@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 614112 Change-Id: I54c89ab5eadf1534434305bf014d322f54e20fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640457Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/09f5aedf2cc8..3c0ad02bc545 git log 09f5aedf2cc8..3c0ad02bc545 --date=short --no-merges --format='%ad %ae %s' 2019-06-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@3c0ad02bc545 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I35d2bef943332889dd25f24ab4e0aa9efc020d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640330Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a3fa5283c9f7..6e80eaeb0400 git log a3fa5283c9f7..6e80eaeb0400 --date=short --no-merges --format='%ad %ae %s' 2019-06-01 bhthompson@google.com Remove deprecated boards from lib/paygen/testdata/paygen.json Created with: gclient setdep -r src/third_party/chromite@6e80eaeb0400 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I4fccf31b90c5f3bd675142b895cd56d00e0416c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638952Reviewed-by:
-
Andy Paicu authored
... the network service origin policy manager. This is step 4 of: https://docs.google.com/document/d/1heiIgNdO7kbaU9BLOPO4wZ9maHScB87cGT5lyjeBVAM/edit#heading=h.4en9va43fgfj This also includes a second in memory structure for the actual policy contents that was not present in the origin policy throttle. Bug: 950905 Change-Id: I493e66f97c68263e1110d9ecfa724cee0ee8310f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627036 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#665427}
-
Koji Ishii authored
Generated break opportunities are not in DOM/box tree, and that they alone should not make the line non-empty. Bug: 966817, 969449 Change-Id: Ic718171b45f64f2b66b158e49d98ac0aaffb90a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634591 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665426}
-
Koji Ishii authored
`base::Reversed` is allowed only in `platform` since r566980 (CL:1094849). This patch changes it to allow in `renderer` to make reverse range-based loops more readable. Change-Id: Ib903c9ed4ae53e95cecf051ccd652e26d6ac3783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638950Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/95b1db9619fb..bb575d48d5f9 git log 95b1db9619fb..bb575d48d5f9 --date=short --no-merges --format='%ad %ae %s' 2019-06-02 capn@google.com Address cubemap faces as consecutive layers Created with: gclient setdep -r src/third_party/swiftshader@bb575d48d5f9 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/134164485,chromium:b/129523279 TBR=swiftshader-team+autoroll@google.com Change-Id: I59530901e19f8ddbb4f7315fc5f5b80c3ad62980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639880Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cd28c22b7b65..c38806be7188 git log cd28c22b7b65..c38806be7188 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@c38806be7188 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Icebe34e6c0848cb11f51a201d2c8fc5ba19e2e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639483Reviewed-by:
-
Rune Lillesveen authored
Use Scoped* helpers to make sure the modified flags are reset for other tests. Change-Id: I68c6cd17c668367d35438ab44e93e8dcbe7006de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637565Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665422}
-
Victor Costan authored
Bug: 729800 Change-Id: I932d0e6d1fd25a44c20c2ceaf6e2bf47a81a1bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638972 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#665421}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib0b360ed137ca8b5c12043fd1cfa37308c9d6b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640339Reviewed-by:
-
Emil A Eklund authored
Bug: 741935 Change-Id: I4c9d3269abe5d93c1881f9cfa8112a5b932eab33 Tbr: jsbell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639745Reviewed-by:
-
Michael Giuffrida authored
RoundedLabelButton makes up the bulk of the sign_out_button.* files. Extract it to its own file. The sign out button itself is only used in one place, so update the other RoundedLabelButton users to include rounded_label_button.h instead. Bug: None Change-Id: I5bb3a9461ff88c79b203083de4da562a76ef45ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639458 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#665418}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ic8164ba1f7364431304e93843c48121e477da3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639743Reviewed-by:
-
BUG=762641 TBR=mukai@google.com Change-Id: I230d85f9f470f0e173d01df6074133ffc66990c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640025Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665416}
-
- 01 Jun, 2019 4 commits
-
-
Mei Liang authored
When "close all tabs", the current tab which is the next tab can be null. We should use the tab from parameter instead of using current tab. Change-Id: Ic696b68131755e0b4224e1263995340a4e30b178 Bug: 968949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639009 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665415}
-
Jinsuk Kim authored
In many places, |FullscreenManager.from(tab) == null| is used to see if a given tab is in the foreground or not. This CL replaces it with |Tab.isHidden()|. They are equivalent in all situations - tab in fg/bg, tab switcher, app in bg. This helps us step closer to deleting the method |FullscreenManager.from(tab)| entirely. Bug: 966272 Change-Id: I737fb59f94e27fc4e33838291e2263098821d6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636994Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#665414}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I87bf38c3929417d4bf4cfc2210045196ccd926cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638953Reviewed-by:
-
Xianzhu Wang authored
It failed on Linux on my (and others') local machine: [ RUN ] CSSAnimationsTest.RetargetedTransition ../../third_party/blink/renderer/core/animation/css/css_animations_test.cc:84: Failure The difference between 0.6 and GetContrastFilterAmount(element) is 9.3132279666008344e-11, which exceeds 0.00000000001, where 0.6 evaluates to 0.59999999999999998, GetContrastFilterAmount(element) evaluates to 0.60000000009313226, and 0.00000000001 evaluates to 9.9999999999999994e-12. Stack trace: ../../third_party/blink/renderer/core/animation/css/css_animations_test.cc:90: Failure The difference between 0.3 and GetContrastFilterAmount(element) is 4.6566139833004172e-11, which exceeds 0.00000000001, where 0.3 evaluates to 0.29999999999999999, GetContrastFilterAmount(element) evaluates to 0.30000000004656613, and 0.00000000001 evaluates to 9.9999999999999994e-12. Stack trace: TBR=svillar@igalia.com Change-Id: Idf6c9c10d02203460c9978431eedd016eab7f66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640138Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665412}
-
