GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE
TBR=ctguil@chromium.org

Review URL: http://codereview.chromium.org/7003072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88481 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7024034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88480 0039d316-1c4b-4281-b951-d872f2087c98

In |InferLabelFromPrevious|, <b> tagged element is not considered as inferred label. So <b> tag is added for checking. Also implemented to look for text node prior to <b
    
BUG=76296
TEST=1. Run grabber-bestbuy.com.html. 2. Make sure "6. ZIP 7. UNKNOWN"


Review URL: http://codereview.chromium.org/6993053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88479 0039d316-1c4b-4281-b951-d872f2087c98

***
Note: this is the fix without a browser test, for expediency. A CL with the test is in http://codereview.chromium.org/7046053/
***

The root cause PrerenderManager::OnCloseTabContentsDeleter was never unregistering itself as a TabContentsDelegate in CloseContents. 

r87606 exposed this by changing the TabContents destructor to deference the delegate if it's non-NULL. 

BUG=85350
TEST=None

Review URL: http://codereview.chromium.org/7108032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88478 0039d316-1c4b-4281-b951-d872f2087c98

88400 - Use the System URL Request Context in the web resource service instead of the default profile's context.

This change should be made because there will be no more default profile, because these services should be able to run without being attached to a specific profile, and because they should only ever fetch json data from controlled URLs.

BUG=64339
TEST=all current web resource tests continue to work.
Review URL: http://codereview.chromium.org/7099004

TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/7108035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88477 0039d316-1c4b-4281-b951-d872f2087c98

Fix RAF-stall that occurs when switching between WebGL animation and another tab. For some reason the RAF engine will stall permanently when switching back to a WebGL animation when the early out code is there. This just allows a DoDeferredUpdate anyway, which should be harmless because the visible check is done later.

BUG=85265
TEST=switch between WebGL particles demo and about:flags for a while, notice no stall.

Review URL: http://codereview.chromium.org/6995062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88474 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72913
TEST=unit tests with tsan


Review URL: http://codereview.chromium.org/7044059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=There was a TODO comment for that.
TEST=NONE


Review URL: http://codereview.chromium.org/7134026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88471 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15789
TEST=Ran try servers to make sure the unit test is not failing anymore, plus viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug
TBR=rkc@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88470 0039d316-1c4b-4281-b951-d872f2087c98

The test only appeared to time out when running two tests per test case. It
does not when splitting up the execute_script and javascript_url subtests
into two test cases. No other tests run two extension tests per test case
either.

R=bolms@chromium.org
BUG=78802
TEST=no

Review URL: http://codereview.chromium.org/7104078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60890
TEST=memory bots

Review URL: http://codereview.chromium.org/7046036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88463 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6995098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88462 0039d316-1c4b-4281-b951-d872f2087c98

This revert is following 88456.

TBR=hbono@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6995086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88460 0039d316-1c4b-4281-b951-d872f2087c98

R=agl@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7003069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88459 0039d316-1c4b-4281-b951-d872f2087c98

When an extension is disabled because a newer version requires higher
permissions, if you then uninstall the extension while the infobar warning
is still up, you'll get a crash if you switch to the tab that had the infobar.
This patch makes the infobar notice the extension uninstall and remove itself.

BUG=84826
TEST=As detailed in description above (and outlined in bug report too).


Review URL: http://codereview.chromium.org/7003068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88458 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=85046

Review URL: http://codereview.chromium.org/7046057

TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/6995100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88457 0039d316-1c4b-4281-b951-d872f2087c98

I revert this because of the lack of appropriate review.
This change added:
- "SpellCheck.SuggestionHitRatio" (percentage)
- "SpellCheck.SuggestionHitRatio" (boolean)

TEST=manual
TBR=darin
BUG=none

Review URL: http://codereview.chromium.org/7121006

TBR=morrita@chromium.org
Review URL: http://codereview.chromium.org/6995099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88456 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=85046

Review URL: http://codereview.chromium.org/7046057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88452 0039d316-1c4b-4281-b951-d872f2087c98

Changed the version parsing for Chrome OS if a special function has been called to strip out the leading 0. and major version number. Additionally changed about chrome os, about chrome os -> more info, about:version and the login screen to reflect version numbers more in tune with a 'platform' than OS.

BUG=chromium-os:15789
TEST=Viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug

Review URL: http://codereview.chromium.org/7108019

TBR=rkc@chromium.org
Review URL: http://codereview.chromium.org/7104076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=84783
TEST=existing tests since no new feature
Review URL: http://codereview.chromium.org/7003070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88446 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88445 0039d316-1c4b-4281-b951-d872f2087c98

```---------------------------------------------------------------------
r686 | nduca@chromium.org | 2011-06-08 16:50:48 -0700 (Wed, 08 Jun 2011) | 2 lin
es

Fix crlf newlines in surface.cpp
TBR=apatrick@chromium.org
```

---------------------------------------------------------------------
r684 | daniel@transgaming.com | 2011-06-08 13:38:09 -0700 (Wed, 08 Jun 2011) | 1
 line

Revert copyImage changes from r682 as they cause regressions on some webpages
------------------------------------------------------------------------
r683 | nduca@chromium.org | 2011-06-08 11:43:16 -0700 (Wed, 08 Jun 2011) | 3 lin
es

Recommit r668, which got undone accidentally by r673.

Review URL: http://codereview.appspot.com/4589043
------------------------------------------------------------------------

r682 | daniel@transgaming.com | 2011-06-08 05:42:28 -0700 (Wed, 08 Jun 2011) | 6 lines

No need to update texture before overwriting it with CopyImage.

Issue=163
TRAC #17019
Signed-off-by: Daniel Koch
Author: Nicolas Capens
------------------------------------------------------------------------
r681 | daniel@transgaming.com | 2011-06-08 05:41:32 -0700 (Wed, 08 Jun 2011) | 6 lines

Fix multi-sample state management.

Issue=160
TRAC #16817
Signed-off-by: Daniel Koch
Author: Nicolas Capens
------------------------------------------------------------------------
r680 | daniel@transgaming.com | 2011-06-08 05:40:23 -0700 (Wed, 08 Jun 2011) | 4 lines

Add missing DWM libraries to Release project.

Signed-off-by: Daniel Koch
Author: Nicolas Capens
------------------------------------------------------------------------

BUG=84071

Review URL: http://codereview.chromium.org/7046054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88444 0039d316-1c4b-4281-b951-d872f2087c98

This is basically a port of the ntp3 notification area, except it allows multiple links.

I think there are currently some minor bugs around most visited deletion and undo; think of this changeset as just a new piece of UI, and I will improve the functionality later.

BUG=none
TEST=[x] a most visited thumbnail and then undo

Review URL: http://codereview.chromium.org/7124002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=existing tests due to no new functionaility
Review URL: http://codereview.chromium.org/7104067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88441 0039d316-1c4b-4281-b951-d872f2087c98

Changed the version parsing for Chrome OS if a special function has been called to strip out the leading 0. and major version number. Additionally changed about chrome os, about chrome os -> more info, about:version and the login screen to reflect version numbers more in tune with a 'platform' than OS.

BUG=chromium-os:15789
TEST=Viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug

Review URL: http://codereview.chromium.org/7108019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88440 0039d316-1c4b-4281-b951-d872f2087c98

Add PyAuto automation call GetPanelInfo(). Includes basic information: title, url, renderer pid, and whether it is incognito.

BUG=chromium-os:14135
TEST=Manual.

Review URL: http://codereview.chromium.org/7108025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88439 0039d316-1c4b-4281-b951-d872f2087c98

I've run the test over 20k times without any issues. (The test passed
nearly instantly in all cases.) I've also run it under valigrind (over
100 times). I've run it with other tests and on its own numerous times
with no problems. All of this was done on Linux because that it where the
test failed.

Also, noteworthy is that this same functionality is run by other tests which
the Linux bots have been passing without incident.

BUG=53607
TEST=TemplateURLModel.Load

Review URL: http://codereview.chromium.org/3341009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88438 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88437 0039d316-1c4b-4281-b951-d872f2087c98

TBR=koz

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88436 0039d316-1c4b-4281-b951-d872f2087c98

result in some weird resizing in the tab strip.

BUG=85380
TEST=see bug
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7044061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85475
TEST=browser_tests
TBR=tsepez

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=Invoking SetSelectedIndex(-1) results in stack overflow.
TEST=NONE


Review URL: http://codereview.chromium.org/7140001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

This test is to verify that popup process launched through incognito shares a process id with it's parent process

Review URL: http://codereview.chromium.org/7068032
Patch from Jasneet <jasneet@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88429 0039d316-1c4b-4281-b951-d872f2087c98

Loading 2x bitmaps on 10.5 caused a regression in our startup time.

Since we don't need 2x bitmaps on 10.5 and 10.6 simple fix is to simply disable loading the bitmaps on those platforms.

BUG=80501
TEST=Ran on 10.6 and used logs to verify that the resource pak was not being loaded. Did the same on 10.7 and verified that the resource pak was being loaded.


Review URL: http://codereview.chromium.org/6995090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88426 0039d316-1c4b-4281-b951-d872f2087c98

Now that http://llvm.org/bugs/show_bug.cgi?id=10031 is fixed, this will hopefully
no longer crash clang.

BUG=84815
TEST=none

Review URL: http://codereview.chromium.org/7104062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88425 0039d316-1c4b-4281-b951-d872f2087c98

This change disables scaling of infobar icons. With this change it should be easier to catch clipping issues due to incorrectly sized infobar icons.

BUG=80432
TEST=Try jobs pending.


Review URL: http://codereview.chromium.org/7134024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88424 0039d316-1c4b-4281-b951-d872f2087c98

Adjust layout of settings pages to use a display table in order to adjust appropriately for internationalization.  Fix vertical alignment of headings with options.

BUG=74487, 56535
TEST=Launch in a variety of locales.  Go to 'chrome://settigns/browser'.  Check for layout problems due to overlap of an option heading and the corresponding controls.


Review URL: http://codereview.chromium.org/7088010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88419 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88418 0039d316-1c4b-4281-b951-d872f2087c98