- 22 Dec, 2018 40 commits
-
-
Keishi Hattori authored
TSAN reported lock-order-inversion because we were using two mutexes. Simplify the code to use just one. Bug: 915200 Change-Id: I5dbda4ca21cd4f5fa95ecb1c9b51922262798169 Reviewed-on: https://chromium-review.googlesource.com/c/1384384 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#618754}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12a6d452b126..13654b20ce5b git log 12a6d452b126..13654b20ce5b --date=short --no-merges --format='%ad %ae %s' 2018-12-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1e85326695b5..ae6ba9f83dd0 (1 commits) Created with: gclient setdep -r src/third_party/skia@13654b20ce5b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ifa0d37ddd32408315a251406f625ee5b56136470 Reviewed-on: https://chromium-review.googlesource.com/c/1390136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618753}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c983480b117f..12a6d452b126 git log c983480b117f..12a6d452b126 --date=short --no-merges --format='%ad %ae %s' 2018-12-22 reed@google.com use font for measuring Created with: gclient setdep -r src/third_party/skia@12a6d452b126 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I3d3664131f7ff4ea6a6d772780699cbc9462360c Reviewed-on: https://chromium-review.googlesource.com/c/1389942Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d90f23c32e1..40eb667ee22b Created with: gclient setdep -r src-internal@40eb667ee22b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7acad2144c4dbc504283895b885f6b969e16aea5 Reviewed-on: https://chromium-review.googlesource.com/c/1389941Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618751}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74a7635cce75..3d90f23c32e1 Created with: gclient setdep -r src-internal@3d90f23c32e1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7fd366e17b894f319c7e4d385100bd236c295942 Reviewed-on: https://chromium-review.googlesource.com/c/1389939Reviewed-by:
-
Tibor Goldschwendt authored
This reverts commit dbf4acb1. Reason for revert: Breaks Canary (crbug/917394) Original change's description: > Upgrade to ARCore SDK 1.5 > > Remove ARCore SDK 1.1 now that we are switching to newer version. > > android-binary-size trybot was complaining about growth of APK - this > is suppressed by adding "Binary-Size" explanation in the footer. > > The size impact is 300369 additional bytes - it should be acceptable > since it only affects canary & dev channels (not present on stable). > Additionally, the AR support will be deployed as a DFM when we release > it, so the impact on on base APK size should be way smaller than what > is currently reported by trybots. > > > is currently only packaged for dev, canary and default > channels. > > Bug: 887669 > Change-Id: I56a2230f31b4e17925ddb4e2d2b20266e55c1091 > Binary-Size: Increase is due to packaging ARCore into the APK. ARCore > Reviewed-on: https://chromium-review.googlesource.com/c/1357349 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Commit-Queue: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618330} TBR=ddorwin@chromium.org,vollick@chromium.org,michaelbai@chromium.org,yfriedman@chromium.org,mthiesse@chromium.org,agrieve@chromium.org,brucedawson@chromium.org,tiborg@chromium.org,bialpio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 887669 Change-Id: I9e294e85ee576fb6b56eb050dfeadd15388e5c5c Reviewed-on: https://chromium-review.googlesource.com/c/1390035Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618749}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/06e88361c90c..35a9c6df4446 git log 06e88361c90c..35a9c6df4446 --date=short --no-merges --format='%ad %ae %s' 2018-12-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f0099863..5f9e4ce6 (618597:618699) 2018-12-22 braveyao@webrtc.org Revert "Desktop capturer: Add OnDisplayChanged callback" 2018-12-21 amithi@webrtc.org Removing redundant argument for SSRCs from ctor of RtpVideoSender. Created with: gclient setdep -r src/third_party/webrtc@35a9c6df4446 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:915411,chromium:916961,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1b84ee48d8a97b850475baeb739739c096070ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1389659Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7bc3df7e8cba67b18e7a5c2815539b3dedef9962 Reviewed-on: https://chromium-review.googlesource.com/c/1389940Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/984a4249d8e1..74a7635cce75 Created with: gclient setdep -r src-internal@74a7635cce75 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I94f635485d990f120128d56bd1e0fcaf9bb88fb1 Reviewed-on: https://chromium-review.googlesource.com/c/1389936Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2e40d9886402..c983480b117f git log 2e40d9886402..c983480b117f --date=short --no-merges --format='%ad %ae %s' 2018-12-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@c983480b117f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I02027e70b85f3ffd452e2a41a3f504e9629e09b1 Reviewed-on: https://chromium-review.googlesource.com/c/1389937Reviewed-by:
-
Morten Stenshorne authored
R=atotic@chromium.org,pdr@chromium.org,szager@chromium.org Change-Id: I60fc71de27984f89cda0f49b582e34db1a581816 Reviewed-on: https://chromium-review.googlesource.com/c/1388484Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#618744}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1e85326695b5..ae6ba9f83dd0 git log 1e85326695b5..ae6ba9f83dd0 --date=short --no-merges --format='%ad %ae %s' 2018-12-22 jmadill@chromium.org Optimize check for active not paused XFB. Created with: gclient setdep -r src/third_party/angle@ae6ba9f83dd0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I462f18d8af049b81bf4793cc407796d98c781d59 Reviewed-on: https://chromium-review.googlesource.com/c/1389935Reviewed-by:
-
Tibor Goldschwendt authored
This reverts commit f61ad483. Reason for revert: Needs to be reverted due to revert of dbf4acb1 Original change's description: > Hook up AR hit-test to 3D ARCore hit-test API > > Now that we can use ARCore SDK 1.5, we can start using 3D version of > hit test and remove previously used one. Since we no longer use > ArFrame_hitTest, it is getting removed from arcore_shim.cc. > > Bug: 835948, 854823 > Change-Id: Ibf8e953135b04925dbebd384e16f8f08ad52a869 > Reviewed-on: https://chromium-review.googlesource.com/c/1357723 > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Commit-Queue: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618649} TBR=ddorwin@chromium.org,klausw@chromium.org,bialpio@chromium.org Change-Id: I7204392419d6d18449b7a5ad97b1a668e9829763 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835948, 854823 Reviewed-on: https://chromium-review.googlesource.com/c/1390036Reviewed-by:
-
Tibor Goldschwendt authored
This reverts commit 53ca33c7. Reason for revert: Didn't fix Canary (crbug/917394). Original change's description: > Add com.google.ar.core.min_apk_version to manifest > > This fixes a bug where there is an com.google.ar.core but no > corresponding com.google.ar.core.min_apk_version flag. > > Bug: 917394 > Change-Id: I0a27fcdac7c0412e9f451d0a60138664b47f1ad9 > Reviewed-on: https://chromium-review.googlesource.com/c/1388644 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618570} TBR=yfriedman@chromium.org,tiborg@chromium.org Change-Id: Ic40f7a1f9862817ec56bd5cd7c2ba36a86935840 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 917394 Reviewed-on: https://chromium-review.googlesource.com/c/1389995Reviewed-by:
-
Aran Gilman authored
Regarding the modified test: Blink forwards column index on rows when the index is not 0 as of https://crrev.com/c/1368945. This is required for downstream computation of the column index in child cells. The deleted code always returned a column index of 0 for rows, so it wasn't forwarded and the column index not printed. The new code can return non-zero values, and these will be printed if column index is requested. If rows having a column index causes issues, the column index could be dropped in downstream code (most likely in https://cs.chromium.org/chromium/src/ui/accessibility/platform/compute_attributes.cc). Bug: 832289 Change-Id: I116125f6015a05e67bd6e8186579c2a4b4497dfd Reviewed-on: https://chromium-review.googlesource.com/c/1388808Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618740}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/300eec0f82c3..cb71ba7b3a42 git log 300eec0f82c3..cb71ba7b3a42 --date=short --no-merges --format='%ad %ae %s' 2018-12-22 kainino@chromium.org Don't use ConsumedError on device initialization errors Created with: gclient setdep -r src/third_party/dawn@cb71ba7b3a42 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917555 TBR=cwallez@chromium.org Change-Id: Ia39c4e2b6f0f4185ded92a33dc933378c2d39918 Reviewed-on: https://chromium-review.googlesource.com/c/1389660Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/98a4e4a4135b..2e40d9886402 git log 98a4e4a4135b..2e40d9886402 --date=short --no-merges --format='%ad %ae %s' 2018-12-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d50521fd068e..1e85326695b5 (3 commits) Created with: gclient setdep -r src/third_party/skia@2e40d9886402 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Id5c9e17875f3ce15d53f9cfa2de3011ccfda0017 Reviewed-on: https://chromium-review.googlesource.com/c/1389658Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/525b0abd306d..984a4249d8e1 Created with: gclient setdep -r src-internal@984a4249d8e1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0869b5a3aef32c9203ba998d73bc99b35420f383 Reviewed-on: https://chromium-review.googlesource.com/c/1389661Reviewed-by:
-
David Black authored
New ticking behavior is flag guarded behind ChromeOSAssistantTimerTicks, disabled by default. This CL also introduced update APIs to the Assistant notification controller/model. Bug: b:118654460 Change-Id: Idf8abfe89ba8bc9c31e3b82cb6759cc22bd1f16e Reviewed-on: https://chromium-review.googlesource.com/c/1352854 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#618736}
-
Marina Ciocea authored
This is a reland of c3136103 Original change's description: > Apply constraints for remote video tracks. > > Bug: 899789 > Change-Id: I28f538888f1bd041ffa31cc650d19245228e044f > Reviewed-on: https://chromium-review.googlesource.com/c/1388436 > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618630} TBR = guidou, hbos Bug: 899789 Change-Id: I8e604e04c393b5ffdecaa1496778f076073b3a3e Reviewed-on: https://chromium-review.googlesource.com/c/1389696Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#618735}
-
Lei Zhang authored
!defined(__mips64__) got mechanically converted to: !defined(ARCH_CPU_MIPS_FAMILY) && defined(ARCH_CPU_64_BITS) when it should have been: !(defined(ARCH_CPU_MIPS_FAMILY) && defined(ARCH_CPU_64_BITS)) BUG=882085 TBR=palmer@chromium.org Change-Id: I1a21803da3d72965fa3ab113a9e54005c1d33e93 Reviewed-on: https://chromium-review.googlesource.com/c/1389796Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#618734}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01abee723f47..525b0abd306d Created with: gclient setdep -r src-internal@525b0abd306d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2474c6a70f2641ff417a2b3fa6fc38840bb8645b Reviewed-on: https://chromium-review.googlesource.com/c/1389656Reviewed-by:
-
Mohsen Izadi authored
This class is used to take screenshots used in the old gesture-nav UI. That UI is removed and this class is not used anymore. This CL also removes the |screenshot_| field from NavigationEntryImpl class. BUG=890390,170449,361594,532290 Change-Id: Ifbee81c058bd165469eb6296f6ca2a47de0355b4 Reviewed-on: https://chromium-review.googlesource.com/c/1274459 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#618732}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d375f1c8d19f..06e88361c90c git log d375f1c8d19f..06e88361c90c --date=short --no-merges --format='%ad %ae %s' 2018-12-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 26e9592d..f0099863 (618302:618597) 2018-12-21 amithi@webrtc.org Simulcast work to enable RID mux. 2018-12-21 yvesg@webrtc.org Fix potential null pointer dereference. Created with: gclient setdep -r src/third_party/webrtc@06e88361c90c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I99f3adcc02c454d6dfbb3e6d0c8c3bda74b9380c Reviewed-on: https://chromium-review.googlesource.com/c/1389004Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/52f5da43184e..1e85326695b5 git log 52f5da43184e..1e85326695b5 --date=short --no-merges --format='%ad %ae %s' 2018-12-22 jmadill@chromium.org Cache common DrawElements states. Created with: gclient setdep -r src/third_party/angle@1e85326695b5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I82273101c45bc36c9c09ff5dd7d6b3ed09a8e533 Reviewed-on: https://chromium-review.googlesource.com/c/1389756Reviewed-by:
-
Kurt Horimoto authored
This CL updates the dialog location to be calculated in the BVC's coordinate space and updates RepostFormCoordinator to use its baseViewController's view for the coordinate space. Bug: 901885 Change-Id: I9856dc041cc49a78d7f916e6662bf838d0ac5f44 Reviewed-on: https://chromium-review.googlesource.com/c/1379036 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#618729}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I67f3e09c804737cf332fdba80d334ccd1f3ff0b9 Reviewed-on: https://chromium-review.googlesource.com/c/1389539Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#618728}
-
Kurt Horimoto authored
This CL fixes BVC's ToolbarHeightProviderForFullscreen to be accurate for iPad NTPs, where the browser toolbars are visible. NTPs on iPhone or on compact widths still have the same behavior where the browser toolbars are hidden (height of 0.0) and the NTP manages its own internal toolbars. This CL uses the corrected viewport insets in order to calculate the visible portions of the content area in order to lay out the NTP and specify the inset to use for native controllers. The referenced bug occurred because BVC's old implementation of |-nativeContentHeaderHeightForWebState:| returned the header height, which caused the native content to be mistakenly pushed down despite the fact that WebState::GetView() was already laid out below the toolbars on iOS 11. Bug: 902271 Change-Id: I364773e74b3d9d0ec7b433de5462666f21b1de5b Reviewed-on: https://chromium-review.googlesource.com/c/1378847 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Daniele Castagna authored
Currently if there are multiple overlay_candidates we get a gpu fence from the output surface and set it to all the planes. Unfortunately this doesn't work for planes coming from vaapi, where the operations are not serialized with the gpu command stream. This patch lets only the overlay_candiate used for the output_surface get a fence. In this way implicit sync will be used instead for additional overlays. Bug: 916446, 914903 Test: Seek on 720_h264.mp4 played locally on eve Change-Id: I1ef7088e5aaa4ad0721072d1a4143d862f5e5d0a Reviewed-on: https://chromium-review.googlesource.com/c/1387695 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618726}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1837eca0a08e..01abee723f47 Created with: gclient setdep -r src-internal@01abee723f47 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idd009c32126d445f84f6000a044d74f27374d360 Reviewed-on: https://chromium-review.googlesource.com/c/1389755Reviewed-by:
-
Xiaohan Wang authored
These are helpers to use ON_CALL and EXPECT_CALL on mock ComPtrs more easily. Bug: 858286 Test: No functionality change. Test cleanup only. Change-Id: Ide3502d0328a8864421f426a75b48393cca80221 Reviewed-on: https://chromium-review.googlesource.com/c/1388930Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#618724}
-
Scott Chen authored
Bug: 916407 Change-Id: Id57cb35c5a13ec60b992c6271f115f9136eefaa7 Reviewed-on: https://chromium-review.googlesource.com/c/1387733 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#618723}
-
Nico Weber authored
No behavior change. Bug: none Change-Id: I5a59b69e4640a5144a86e9f3ce25508c5c265c19 Reviewed-on: https://chromium-review.googlesource.com/c/1388820Reviewed-by:
-
Carlos IL authored
As part of Safe Browsing committed interstitials, this CL adds a navigation throttle that checks if a failed navigation was due to a SB hit, and if so creates and shows an interstitial. Bindings for commands will be added in a separate CL. Bug: 910794 Change-Id: I28053de0252a005ff2896b9b17ac83c02d5d2d6f Reviewed-on: https://chromium-review.googlesource.com/c/1370502Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#618721}
-
Sergey Ulanov authored
Previously SharedImageBackingFactoryGLTexture::MakeGLImage() was failing when it didn't have ImageFactory, even when creating an image from a shared memory buffer. Textures can be created from shared memory without ImageFactory. Updated MakeGLImage() to handle this case properly. Bug: 778467 Change-Id: I43b522dbfd76dafd0aba8d95d37c3fabcaf33b0e Reviewed-on: https://chromium-review.googlesource.com/c/1389159 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#618720}
-
Sunny Sachanandani authored
Use BT 709 primaries by default, use nominal (limited) range if color space is Rec 709 or 601, and use xvYCC for full range encoding. Bug: 848093, 917399 Change-Id: Iab54c9523826853265cf92cdd5b806fd82cd03e1 Reviewed-on: https://chromium-review.googlesource.com/c/1389504Reviewed-by:
-
Ken Rockot authored
Changes the service_manifest target to emit C++ sources for that specific Manifest definition. Previously we only generated sources for catalog_cpp_source targets, which aggregated JSON data from multiple service_manifest targets. Every service_manifest GN template thus now emits two artifacts: the same collated JSON as before (including packaged services and overlays), since embedders use this to generate runtime manifest resources; and a new source_set target which expresses the same manifest in terms of C++ sources, with proper dependencies on each dependency manifest's source_set. The point of this is to make it possible for incremental migration away from generated code and over to code that lives in the source tree. For example, many implementations of ContentBrowserClient override GetServiceManifestOverlay() and use parsed JSON resources at runtime to construct a Manifest object. After this change, any of those cases can be individually converted to use the generated source_set instead of the generated JSON, and the JSON resource can be deleted. Once this lands, catalog targets can also be eliminated and replaced by helpers in the tree which return the same lists of manifests that the catalog-generated code returns now. Finally, after all that, remaining service manifests can be (mostly) independently pulled out of generated code. The end result will be: no more JSON manifests anywhere, no more catalog() or catalog_cpp_source() GN targets, and no more service_manifest() GN targets. TBR=sky@chromium.org Bug: 895616 Change-Id: Ie3d53a96ac79952383e473f23d390583306be2fa Reviewed-on: https://chromium-review.googlesource.com/c/1388158 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#618718}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4308d9f929ba..1837eca0a08e Created with: gclient setdep -r src-internal@1837eca0a08e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I30f73d9240c9ecfc9a5f1934062f599a51491919 Reviewed-on: https://chromium-review.googlesource.com/c/1389655Reviewed-by:
-
Kurt Horimoto authored
The previous API exposed an NSLayoutConstraint publicly that can be activated/deactivated. This allowed for a scenario in which a constraint in an invalid state could be reactivated, causing an exception. This CL moves management of that constriant internally to OpenInToolbar, such that the constraint is only ever activated immediately upon creation. Since the code creating the constraint uses NamedGuide's |+guideWithName:view:|, we're guaranteed that the guide's view is in the same hierarchy as the OpenInToolbar upon creation of the constraint. Bug: 907485 Change-Id: I03b601130bbea2d43de9af6b614543aeea00bb8c Reviewed-on: https://chromium-review.googlesource.com/c/1379030Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a0967383087..98a4e4a4135b git log 2a0967383087..98a4e4a4135b --date=short --no-merges --format='%ad %ae %s' 2018-12-22 reed@google.com remove uncalled onDrawTextRSXform Created with: gclient setdep -r src/third_party/skia@98a4e4a4135b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Iff4da0de01044b0bde03fff65313467d3d376d38 Reviewed-on: https://chromium-review.googlesource.com/c/1389595Reviewed-by:
-
