- 19 Sep, 2017 40 commits
-
-
Nate Chapin authored
LocalDOMWindow::InstallNewDocument is called for all Document installations, whereas DocumentLoader::InstallNewDocument is omitted for Documents created by XSLT transforms. Supplements may use a stale ExecutionContxt if not updated for all Document installs. Bug: 765902 Test: fast/xsl/supplements-after-xslt-transform.html Change-Id: Ic7ce996b16fe319ba01e296f2e935a967fe309ea Reviewed-on: https://chromium-review.googlesource.com/671465Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#502865}
-
Thoren Paulson authored
The manifest declaration for CastWebContentsActivity had an intent filter for launching the activity from the apps menu or launcher. That doesn't work, and when this gets merged with our internal manifest, results in users being able to attempt to "Open" the web contents activity only to see it crash. This removes the intent filter. Bug: internal b/65837237 Test: build internal cast shell, check you can't open it Change-Id: Ib78bceda7f2834e5ef347e9a45ce5eb9e6a50b05 Reviewed-on: https://chromium-review.googlesource.com/671215Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#502864}
-
Sylvain Defresne authored
The template to declare asset catalog (imageset, appicon, launchimage) copy the resources into a .xcassets directory in $target_gen_dir, thus there is no need to put them in a .xcassets directory in the checkout. Standardize the asset catalog declarations so that the asset catalogs are in a resources/ sub-directory, the corresponding target is in the resources/BUILD.gn file. Bug: none Change-Id: I56a751add67f7d77e95dcb0b213dfd756f129310 Reviewed-on: https://chromium-review.googlesource.com/672704Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502863}
-
Ivan Sandrk authored
CrOS CL @ crrev.com/c/663541 Bug: chromium:764451 Change-Id: I8982adeaf8ac1b89fe6c339513b1cf22efaed303 Reviewed-on: https://chromium-review.googlesource.com/663548 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#502862}
-
jdoerrie authored
This change removes most usages of base::WrapUnique and base::MakeUnique in //components/password_manager in favor of C++14's std::make_unique. Bug: 755727 Change-Id: I9f76925becbca409c06235831925a5f0870cb3df Reviewed-on: https://chromium-review.googlesource.com/672504Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#502861}
-
Paul Jensen authored
-mstackrealign implied -fno-omit-frame-pointer which greatly shrank the unwind tables (.eh_frame section). Removing the flag (in crrev.com/499401) therefore improved code size but requires emission of full unwind tables, significantly impacting overall binary size. When building for x86 Android and optimizing for size and generating unwind tables, this fix enables frame pointers. Bug: 762629 Change-Id: I43515e6159a2aa1ef06e362c52f6525d2d67bf4f Reviewed-on: https://chromium-review.googlesource.com/657566Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#502860}
-
Michael Thiessen authored
This is a regression that wasn't caught because VrShell is enabled by default. The tab should never be null when entering VR. Bug: Change-Id: I034dc7c673ac2deda5481f398fdcd06fb5a0f05b Reviewed-on: https://chromium-review.googlesource.com/671728Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#502859}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c5a43d3..b7b0ee77 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ie5fac1dbe5bdd7999dfee116d5bfdde3f4722bff Reviewed-on: https://chromium-review.googlesource.com/672604Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#502858}
-
Iulia Harasim authored
This CL adds render tests for personalized signin promos in NTP content suggestions and the golden files associated to each test. Bug: 737743 Change-Id: I32cacf8cb5e8aac1a507581e43b18e765d790ecb Reviewed-on: https://chromium-review.googlesource.com/667147Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Iulia Harasim <iuliah@google.com> Cr-Commit-Position: refs/heads/master@{#502857}
-
Kevin Cernekee authored
Add Android->Chrome RPC calls to report that an Android VPN client has connected or disconnected. Add a Chrome->Android RPC call to let users terminate Android VPNs through the Chrome OS UI. BUG=696865 TEST=connect to a third party VPN on Android Change-Id: Iadedfc6c458267f009a3b3dc8cbb8c37dcbebd6f Reviewed-on: https://chromium-review.googlesource.com/592545Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Kevin Cernekee <cernekee@chromium.org> Cr-Commit-Position: refs/heads/master@{#502856}
-
Lukasz Anforowicz authored
This CL reverts r412572 - |TestRunner::will_navigate_| is no longer needed, because right now PlzNavigate creates a dummy provisional DocumentLoader at the start of a renderer-initiated navigation - the presence of a provisional DocumentLoader is taken into account when computing when to stop the layout TestRunner. Bug: 765752 Change-Id: Ia50aabbba25937777c6c966ec8e056d4014bd971 Reviewed-on: https://chromium-review.googlesource.com/669602Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#502855}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4eec6def. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2049 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley@chromium.org No-Export: true Change-Id: I5b9835e90a572be60e06cad5ed1e5e927ebda033 Reviewed-on: https://chromium-review.googlesource.com/671965 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502854}
-
Koji Ishii authored
This patch moves the logic for the 'word-wrap' property from HandleText() to its lower function, BreakText(). Since HandleOverflow() directly calls BreakText(), this change fixes the logic to properly kick in not only when scanning forward but also when rewinding. fast/text/basic/015.html is rebaselined because its expected image for the current line breaker breaks at the incorrect position (the 2nd block breaks after 'i', not after 'u'.) Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1f3c809411417329420b6af8269b1cceb8796b54 Reviewed-on: https://chromium-review.googlesource.com/672167Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#502853}
-
Mohamad Ahmadi authored
Avoids disabling the PAY button in the payment items page when the PAY or the cancel buttons are tapped. Besides the unwanted visual change in the PAY button's appearance when it is tapped until the animation is completed, this may be contributing to why the PAY button doesn't predictably work when voice over is on. Bug: 766453 Change-Id: Ia795b77489710564bc9a1507c3ac2515b4c0463d Reviewed-on: https://chromium-review.googlesource.com/672608 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#502852}
-
Anton Urusov authored
This is the initial version of the policy-tool page that is created to make managing policies easier for admins. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia58300dc786a6dabcd14721d134fb52027934739 Reviewed-on: https://chromium-review.googlesource.com/613507Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Anton Urusov <urusant@google.com> Cr-Commit-Position: refs/heads/master@{#502851}
-
Tatiana Gornak authored
BUG=739343 Change-Id: I81eb671ca64b84df871bf071af6817117acbd9a5 Reviewed-on: https://chromium-review.googlesource.com/672544Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#502850}
-
Gauthier Ambard authored
And fix the testMostVisitedNewTab which was the failing test. It is failing because the doodle is showing, taking too much space on the collection view. The "sufficientlyVisible" check is failing because it is checking that the view is > 75% shown on screen, not taking into account its subviews. Bug: 766495 Change-Id: I084f8c8dab9152ce155a73d39561c8c76c6277e9 Reviewed-on: https://chromium-review.googlesource.com/672529 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#502849}
-
sebsg authored
Bug: 748223 Change-Id: I12752f13d311d1e61dbacb66e61abd8672154a99 Reviewed-on: https://chromium-review.googlesource.com/667948Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#502848}
-
EhsanK authored
This CL allows creation of MimeHandlerViewGuest even when element size is 0x0. This is specifically important for Google slides pages where an <embed> of size 0 is used for print previewing the page. Essentially, we need to makes sure for such <embed>'s the guest is created (after attaching) and embed.postMessage works fine. Bug : 763812 Change-Id: I7ad0cd0898aee2e1b5d6b15dd9bfdcb100a8e16b Reviewed-on: https://chromium-review.googlesource.com/667900 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#502847}
-
Alex Clarke authored
This feature was not helpful because it complicated dealing with about:blank and granting additional virtual time. Virtual time should be used like so to avoid race conditions: 1. Navigate to about:blank 2. Set VirtualTimePolicy::PAUSED 3. Navigate to target page 4. Wait for Page.frameStartedLoading has fired 5. Set VirtualTimePolicy::DETERMINISTIC_LOADING with a budget of say 6000ms 6. Wait for budget to expire See VirtualTimeBrowserTest as an example of how to do this. The page is ready to be inspected. If you need to do something like click on a button and wait for the browser to process any navigations tha might result then do so while virtual time is paused due to budget running out and then issue more budget. This patch also tries to deflake VirtialTime test. I found a few bits of state that were not cleaned up between runs, although there's still something strange going on with that test which causes some of the virtual time tests to rerun. Bug: Change-Id: Ie530f9086815ef27c4cc3e65589a831e8fbe6b93 Reviewed-on: https://chromium-review.googlesource.com/671017 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#502846}
-
Peter Kotwicz authored
This CL fixes a few of the WebApkUpdateManager tests which regressed as a result of https://chromium-review.googlesource.com/591917 This CL also replaces comments referencing ManifestUpgradeDetector to reference WebApkUpdateDataFetcher instead. BUG=None Change-Id: Ifc9dfaffd59ef88e083c600f3e20d17b5c5debc0 Reviewed-on: https://chromium-review.googlesource.com/663414Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502845}
-
Yuly Novikov authored
This reverts commit ef7da402. Reason for revert: Possible cause of crbug.com/766473 Original change's description: > Revert "Disable surfaceless EGL on Android" > > This reverts commit dd49d9c1. > > Reason for revert: works well after > https://chromium-review.googlesource.com/646188 > > Original change's description: > > Disable surfaceless EGL on Android > > > > There are outstanding bugs related to how Android code meant for WebView > > is interacting with surfaceless EGL. These cause crashing on startup > > and incorrect rendering on platforms that support surfaceless EGL. Work > > around the issues by disabling surfaceless EGL on Android to unblock work > > before a more complete solution can be developed. > > > > BUG=382349 > > > > Review URL: https://codereview.chromium.org/330453003 > > > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276713 0039d316-1c4b-4281-b951-d872f2087c98 > > BUG=382349 > TEST=Start Chromium, run WebGL Aquarium on Pixel C > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Id8b03aa5a91bfe087ce59c3c7a6b63f6e09a4171 > Reviewed-on: https://chromium-review.googlesource.com/669842 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502609} TBR=ynovikov@chromium.org,kbr@chromium.org,oetuaho@nvidia.com Change-Id: Ib83d4c05d3ead960f56287af48156342121ff70e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 382349 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/672723Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#502844}
-
Rob Buis authored
After #501642 some callsites behave differently because they only tested for initial/inherit, not unset. So use IsCSSWideKeyword instead. Bug: 660273 Change-Id: Ibe8842ac21da804c43104fd978983d84c9f65001 Reviewed-on: https://chromium-review.googlesource.com/667865Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#502843}
-
Helen Li authored
vcdiff dependency is used for SDCH. SDCH has been disabled in Chrome in M59. This CL removes vcdiff dependency from src/DEPS. TBR=jochen@chromium.org Bug: 762686 Change-Id: I836e501c09900c4d49bf742a5b430d3e586a3a66 Reviewed-on: https://chromium-review.googlesource.com/671147Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#502842}
-
Charles Vazac authored
Bug: 702760 Change-Id: Ic02ef50fbf2776f63c578397d82bc77e1dd7184f Reviewed-on: https://chromium-review.googlesource.com/665354 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#502841}
-
Francois Doray authored
This method is called when the opacity of an aura::Window's Layer changes. It will be used to recompute aura::Window occlusion states. Bug: 738387 Change-Id: I42e07cd0f4370091515645cfe6cbd7cd633edb87 Reviewed-on: https://chromium-review.googlesource.com/665178 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#502840}
-
Ramya Sharma authored
issue: https://screenshot.googleplex.com/BCNV2sT8deF.png Bug: 695749 Change-Id: I87f6875ad6040b0a1d167bd46de15bdcd61e57f9 Reviewed-on: https://chromium-review.googlesource.com/672463Reviewed-by:
Marti Wong <martiw@chromium.org> Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#502839}
-
Sylvain Defresne authored
In order to roll GN fc561c03..cf557ff0 (r498655:r502818) and pick up the following changes: eab0e88e Add support for partial_info_plist to create_bundle. a5c648fa [GN] Adds const to the comparison operator of the DepsIterator a6c6d28e Fix GN bootstrap 9c37f1fb [GN] Add unit tests for the mapping between PBXObject and it's name. 95ce69ba Fix GN bootstrap for MacOS X 315b910c Fix GN bootstrap 39ca4928 Fix roll_gn.py script. TBR=dpranke@chromium.org Change-Id: I1fd1b1c35bda88277984eb6f4bc73a74b6ab0002 Reviewed-on: https://chromium-review.googlesource.com/671018Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502838}
-
Sylvain Defresne authored
The file build/config/ios/imageset.gni was introduced to avoid breaking the downstream build after the file rename. Remove it as the downstream code has been fixed to use the new path. Bug: 764286 Change-Id: I0dbaccca19f87017ed1a34ee7eeb37d94e1aaad9 Reviewed-on: https://chromium-review.googlesource.com/671384 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#502837}
-
clamy authored
The last committed NavigationEntry is incorrect when we shortcut a RenderFrameHost swap due to a sad tab. It's also wrong for subframes. BUG=764641 TEST=Navigate to a WebUI page from a sad tab (in PlzNavigate) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I5580699f27389b10ecfd6d3cfe419c244ddf0a5e Reviewed-on: https://chromium-review.googlesource.com/667405 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Reis (OOO until 9/25) <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#502836}
-
Ramya Sharma authored
Two issues when new folder was created: 1. if row is behind k/b then it is not visible to user to edit. 2. if the newly created folder is below visible area on screen, cell is not created and hence we cannot shift focus to this newly created folder. Demo: https://drive.google.com/a/chromium.org/file/d/0B5e_gsRJBxElb2ZUSWxqczBMX3M/view?usp=sharing Bug: 695749,766623 Change-Id: Iea25042088942d4ada50f90e392e5921514743cb Reviewed-on: https://chromium-review.googlesource.com/671825 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by:
Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#502835}
-
Tatiana Gornak authored
This reverts commit bbebe805. Reason for revert: Suspecting in breaking the compilation for ChromeOS build Original change's description: > Migrate Bool(ean)?DBusMethodCallback to DBusMethodCallback<bool>. > > Part of OnceCallback migration in chromeos/dbus. > > BUG=739622 > TEST=Ran trybot. > > Change-Id: Ic932aa7c018297a064889c4f05c8578bca712474 > Reviewed-on: https://chromium-review.googlesource.com/666944 > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Stefan Kuhne <skuhne@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502831} TBR=hashimoto@chromium.org,stevenjb@chromium.org,skuhne@chromium.org,bauerb@chromium.org,hidehiko@chromium.org,waffles@chromium.org,emaxx@chromium.org Change-Id: I4dcf82e6eb3f745582c48c9b035c92b0c72b69ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 739622 Reviewed-on: https://chromium-review.googlesource.com/672505Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#502834}
-
Gauthier Ambard authored
The ContentSuggestions empty sections can be displayed if their section info allow them to. For now they are only displayed if they are started at the opening of the NTP. This CL fixes it by adding them if needed. Bug: 765075 Change-Id: Ieb8dde40d14044bfb674bcd9108b84775d1b4531 Reviewed-on: https://chromium-review.googlesource.com/671021Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#502833}
-
Sylvain Defresne authored
The CL https://chromium-review.googlesource.com/578630 configured all platform to use C11 but did not remove the code enabling C99 on iOS/macOS. This caused iOS/macOS to use an older standard. Bug: 766484 Change-Id: I31090257abe4feb770a0b088cfa657e2b42ca624 Reviewed-on: https://chromium-review.googlesource.com/671349Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502832}
-
Hidehiko Abe authored
Part of OnceCallback migration in chromeos/dbus. BUG=739622 TEST=Ran trybot. Change-Id: Ic932aa7c018297a064889c4f05c8578bca712474 Reviewed-on: https://chromium-review.googlesource.com/666944 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502831}
-
stkhapugin@chromium.org authored
Disables testMostVisitedNewIncognitoTab because it's failing multiple times on bots downstream. Bug: 766495 Change-Id: Ie640c58e32eb87ed7b6ae070e35e111fbe23cd81 Reviewed-on: https://chromium-review.googlesource.com/671011 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#502830}
-
Philip Jägenstedt authored
Reported by Simon Pieters. No-Try: true Change-Id: I466202c42da81f89083cc3479035b2cb1924e8af Reviewed-on: https://chromium-review.googlesource.com/672366Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#502829}
-
Iulia Harasim authored
This CL changes the personalized signin promo's description in Recent Tabs on both iOS and Android. Bug: 766312 Change-Id: I6197e39fdc874e74124ce282085429c8001db131 Reviewed-on: https://chromium-review.googlesource.com/671352Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Iulia Harasim <iuliah@google.com> Cr-Commit-Position: refs/heads/master@{#502828}
-
Kent Tamura authored
|basename| is a base of the name 'V8*Partial'. So it's an interface name, not a file basename. Bug: 760462 Change-Id: Ic04bc604aea37a33d8c78fa4cc505fe3f30b120e Reviewed-on: https://chromium-review.googlesource.com/672029Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502827}
-
Vitalii Iarko authored
The color is encoded as @ColorInt with alpha channel equal to 255. In the JNI bridge the absence of color is encoded as 0, because we would not have a fully transparent color anyway. Bug: 754183 Change-Id: I236a1e4e0659a9e732ad437cdb295fe6056737f4 Reviewed-on: https://chromium-review.googlesource.com/671347 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#502826}
-