GitLab

Seems like it's incorrect to defer this creation the way we do
currently.

BUG=468362

Review URL: https://codereview.chromium.org/1021483005

Cr-Commit-Position: refs/heads/master@{#322301}

Cr-Commit-Position: refs/heads/master@{#322300}

Background: mojo rolled out a new version that requires callbacks (as
defined by the => syntax in mojom) must be invoked before they go out
of scope, otherwise it indicates a connection error on the callback's
recipient, which will destroy mojom implementations that are strongly
bound to the connection.

Note that a partial fix was added in crrev.com/1019173002. This patch
addresses the remaining points.

BUG=468575

Review URL: https://codereview.chromium.org/996173006

Cr-Commit-Position: refs/heads/master@{#322299}

This moves code out of //java/apps/chrome/.../precache into:
  . //components/precache/android/: classes that provide information about
    device-state, network connectivity etc.
  . //chrome/android/.../precache/: precache service and service launchers.

BUG=401552

Review URL: https://codereview.chromium.org/1031003003

Cr-Commit-Position: refs/heads/master@{#322298}

BUG=none

Review URL: https://codereview.chromium.org/1002283004

Cr-Commit-Position: refs/heads/master@{#322297}

This prevents whitespace and non-ASCII characters from being displayed in
the url, stopping attacks where a carefully crafted URL can be used
to display a message in the popup.

BUG=466351

Review URL: https://codereview.chromium.org/1011383005

Cr-Commit-Position: refs/heads/master@{#322296}

Screenshots:

Old plugin blocking UI: https://drive.google.com/file/d/0B9q2eN9gDoUIX1NFVjAtY0w2V2c/view?usp=sharing
New plugin blocking UI: https://drive.google.com/file/d/0B9q2eN9gDoUITk5jVDVuZDIwUmc/view?usp=sharing
New plugin blocking UI (Mac): https://drive.google.com/file/d/0B9q2eN9gDoUIc3RhLVdzVExOQTQ/view?usp=sharing

Old popup blocking UI: https://drive.google.com/file/d/0B9q2eN9gDoUIZzdTZHg4czJCMFU/view?usp=sharing
New popup blocking UI (unchanged): https://drive.google.com/file/d/0B9q2eN9gDoUIVFFNNXRDU1dDWTQ/view?usp=sharing

BUG=414399

Review URL: https://codereview.chromium.org/1025503002

Cr-Commit-Position: refs/heads/master@{#322295}

Review URL: https://codereview.chromium.org/1027383003

Cr-Commit-Position: refs/heads/master@{#322294}

touch noise filtering is at
https://chromium.googlesource.com/chromiumos/platform/touch_noise_filter/+/master

When a touch is detected as touch noise, an ET_TOUCH_CANCELLED event is sent and
all of the subsequent events for that touch are dropped. A "touch press"
initiates a new touch.

BUG=407840
TEST=TouchNoiseFinderTest.*, TouchEventConverterEvdevTouchNoiseTest.*

Review URL: https://codereview.chromium.org/991533002

Cr-Commit-Position: refs/heads/master@{#322293}

On OSX the main audio thread is the UI thread due to limitations
in the CoreAudio API. Since we're making effectively read only
calls sending the audio hardware config from the worker task
runner should be fine. We already do this in several other places
for device enumeration (since it's way to slow on UI thread).

BUG=469737
TEST=none

Review URL: https://codereview.chromium.org/1029933003

Cr-Commit-Position: refs/heads/master@{#322292}

This string will have an accompanying code change that we hope to have ready in time to merge into Chrome 42 for Android. The string needs to land early so we can kick off the translation process.

BUG=469853

Review URL: https://codereview.chromium.org/1034863003

Cr-Commit-Position: refs/heads/master@{#322291}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/862b1f1..34f0727

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1031273003

Cr-Commit-Position: refs/heads/master@{#322290}

Should make clearer the remaining dependencies of net/ on mime_util.h

BUG=none

Review URL: https://codereview.chromium.org/1028233004

Cr-Commit-Position: refs/heads/master@{#322289}

Some netifs could be ignored by command line flag, --netifs-to-ignore, and
internet could be accessible via those netifs.
Many testing scripts and developers set this for ethernet link and
use ethernet to get testing results.

BUG=internal b/19593970

Review URL: https://codereview.chromium.org/1037693005

Cr-Commit-Position: refs/heads/master@{#322288}

  + Formatting changes found while merging.
  + Added private: to MockAckNotifierDelegate class.

Merge internal change: 89527377

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1034823002

Cr-Commit-Position: refs/heads/master@{#322287}

Mask values are seperated out into consts of type
SupportedInitDataTypes. Also removes unused function
IsSaneInitDataTypeWithContainer().

BUG=417440
TEST=EME layout tests pass

Review URL: https://codereview.chromium.org/1027363002

Cr-Commit-Position: refs/heads/master@{#322286}

Instead of just having Function or Function= for each callback, use the
function() Closure Compiler type documentation.  Additionally, add support for
@deprecated function documentation.

BUG=461039

Review URL: https://codereview.chromium.org/1036593004

Cr-Commit-Position: refs/heads/master@{#322285}

BUG=468583

Review URL: https://codereview.chromium.org/1029233002

Cr-Commit-Position: refs/heads/master@{#322284}

This CL replaces all uses of IsSupportedKeySystemWithMediaMimeType() with the new KeySystems method, IsSupportedCodecCombination(). This new method implements the unprefixed algorithm more faithfully.

BUG=457386,417461

Review URL: https://codereview.chromium.org/1022823008

Cr-Commit-Position: refs/heads/master@{#322283}

Propagate OnMedia{Playing,Paused}Notification to WebContentsObserver and use
this to track Chromecast metrics.

BUG=417000

Review URL: https://codereview.chromium.org/1037593003

Cr-Commit-Position: refs/heads/master@{#322282}

Use ExtensionRegistryObserver in Uber
since ExtensionRegistry replaces chrome::extension notifications.

BUG=411568
R=estade@chromium.org
TEST=browser_test --gtest_filter=UberUIBrowserTest.HistoryOverride

Review URL: https://codereview.chromium.org/1012773010

Cr-Commit-Position: refs/heads/master@{#322281}

BUG=466848

Review URL: https://codereview.chromium.org/1031133003

Cr-Commit-Position: refs/heads/master@{#322280}

Move MdSettingsUi to its own directory. There will be additional settings-related files in the near future, so this directory will be used to organize them.

BUG=

Review URL: https://codereview.chromium.org/1015533019

Cr-Commit-Position: refs/heads/master@{#322279}

The API will be defined in a follow-up Blink CL. Unlike the existing,
Service Worker-specific API, this one passes ownership of the new
object to the caller. The origin is specified by a database identifier
derived from the SecurityOrigin on the Blink side.

BUG=439389

Review URL: https://codereview.chromium.org/1031063002

Cr-Commit-Position: refs/heads/master@{#322278}

BUG=462677, 469652

Review URL: https://codereview.chromium.org/1034803002

Cr-Commit-Position: refs/heads/master@{#322277}

We've seen a bunch of reports in the field that the audio thread is
getting hung for significant (perhaps indefinite) amounts of time;
to help debug these reports, add a hang monitor which will crash the
browser process and ensure we get a thread dump of what's going on.

The hang timer is set extremely conservatively right now, at 1 minute,
which is insanely long for audio tasks. I'll monitor crash reports and
adjust it as necessary to find culprits.

The hang monitor uses the browser I/O thread for hang checks, which is
similar to what other hung task monitors seem to do. To do this I had
to move AudioManager and MidiManager creation to after the browser
threads have been spun up. Which shouldn't be an issue...

BUG=422522, 469827
TEST=hang time exceeded ==> crash.

Review URL: https://codereview.chromium.org/1036703002

Cr-Commit-Position: refs/heads/master@{#322276}

All html_viewer entry points now have Mojo C thunks.

R=piman@chromium.org
BUG=453591

Review URL: https://codereview.chromium.org/1035813002

Cr-Commit-Position: refs/heads/master@{#322275}

This patch modifies the wallet datatype to always have a datatype controller,
and give that datatype controller the responsibility of enabling and disabling
the datatype as necessary. If the sync experiment pref is disabled, the datatype
will not start up, and if it's already started will turn itself off. Similarly, if the
experiment is enabled, the datatype is capable of starting itself up.

BUG=470362

Review URL: https://codereview.chromium.org/1024553010

Cr-Commit-Position: refs/heads/master@{#322274}

R=nednguyen@google.com
BUG=453131, 455292

Review URL: https://codereview.chromium.org/1029423002

Cr-Commit-Position: refs/heads/master@{#322273}

Ensure that the DXVA decoder for VP8 and VP9 picks up the path for the HMFT correctly on non WOW64 environments

The DXVA decoder incorrectly assumes that the ProgramW6432 environment variable exists on vanilla 32 bit Windows
OS'es which is not the case. This causes the HMFT load to fail.

Fix is to only use the DIR_PROGRAM_FILES6432 directory type for a WOW64 environment which is 32 bit chrome on a 64
bit OS. In the normal case we use the vanilla DIR_PROGRAM_FILES type.

BUG=470193

Review URL: https://codereview.chromium.org/1031263002

Cr-Commit-Position: refs/heads/master@{#322272}

BUG=470393

Review URL: https://codereview.chromium.org/1018353003

Cr-Commit-Position: refs/heads/master@{#322271}

BUG=309849

Review URL: https://codereview.chromium.org/1038743002

Cr-Commit-Position: refs/heads/master@{#322270}

Currently any overlay ContentViewCore added to the Tab is
automatically added to the Tab CC layer.

This CL introduces a new parameter to allow romaing overlays.

BUG=453121

Review URL: https://codereview.chromium.org/1026983002

Cr-Commit-Position: refs/heads/master@{#322269}

The viewport is made up of two scrolling layers now, the inner
and outer viewport scroll layers. These layers do not follow the
usual scroll bubbling logic since they're supposed to appear as
one viewport to the user (i.e. we should rail). Forcing it to
be scrolled via LayerTreeHostImpl::ScrollBy caused that method to
become increasingly complex.

This patch creates a Viewport class that allows LTHI::ScrollBy to
call Viewport::ScrollBy and scroll the viewport as a unit. I've
tried to simplify the logic in both these methods as much as I
could without changing behavior.

BUG=443724

Review URL: https://codereview.chromium.org/986443003

Cr-Commit-Position: refs/heads/master@{#322268}

BUG=470647

Review URL: https://codereview.chromium.org/1006583003

Cr-Commit-Position: refs/heads/master@{#322267}

The refactor in https://codereview.chromium.org/23983047 removed a
trace event that monitored y scroll offset. This CL restores that event.

BUG=468304

Review URL: https://codereview.chromium.org/1013753014

Cr-Commit-Position: refs/heads/master@{#322266}

This is a stub for now; eventually it will report invalid certificate
chains on SSL interstitials to a server endpoint. Right now it logs the
report but doesn't actually send it anywhere. The checkbox is
tied in with Safe Browsing Extended Reporting.

BUG=461588

Review URL: https://codereview.chromium.org/935663004

Cr-Commit-Position: refs/heads/master@{#322265}

Also change some logging to VLOG. To see logs, use --vmodule="*/autofill/*=2" --enable-logging=stderr

BUG=470232

Review URL: https://codereview.chromium.org/1016033009

Cr-Commit-Position: refs/heads/master@{#322264}

In this change:
- Add AttachmentStoreForSync class. It has functions that will be called by AttachmentServiceImpl to manage sync’s references to attachments.
- Change AttachmentServiceImpl to call those functions. The rule is that for all attachments that we start uploading call AddSyncReference, for all attachments that we no longer upload (for whatever reason) call DropSyncReference.

Couple of notes:
- There is no storage implementation for those functions, it will come in the next change.
- There is growing confusion between AttachmentIdSet and AttachmentIdList. I’ll resolve this next week in a separate change.

BUG=457735
R=maniscalco@chromium.org
TEST=No user facing behavior. Change covered by sync_unit_tests.

Review URL: https://codereview.chromium.org/1002263005

Cr-Commit-Position: refs/heads/master@{#322263}

Add error message text label between CVC input row and Verify/Cancel
buttons. Error messages passed to
CardUnmaskPromptViewBridge::GotVerificationResult() are displayed.

Dialog will re-layout to fit entire message if a multiline message is
set. Previous to this CL the layout was done exactly once per dialog,
upon dialog creation. This CL refactors the layout code out into
-performLayout and calls it whenever the error message text changes.

Screenshot attached to bug: https://code.google.com/p/chromium/issues/detail?id=448572#c14

BUG=448572

Review URL: https://codereview.chromium.org/1024553004

Cr-Commit-Position: refs/heads/master@{#322262}