GitLab

Review-Url: https://codereview.chromium.org/2193073004
Cr-Commit-Position: refs/heads/master@{#408783}

TBR=brettw@chromium.org
NOTRY=true
BUG=623659

Review-Url: https://codereview.chromium.org/2192303002
Cr-Commit-Position: refs/heads/master@{#408782}

This converts presentation.mojom to use the new (std::) Mojo wrapper types:
mojo::String => std::string
mojo::Array => std::vector

No behavior changes should ensue.

Optional values are represented as base::Optional<Foo> with the new wrapper
types requiring some additional changes.

This work will simplify further changes for crbug.com/627655.

BUG=627655

Review-Url: https://codereview.chromium.org/2181163003
Cr-Commit-Position: refs/heads/master@{#408781}

BUG=632761
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2198443003
Cr-Commit-Position: refs/heads/master@{#408780}

Better name and it matches the concept in the spec.

Review-Url: https://codereview.chromium.org/2170043004
Cr-Commit-Position: refs/heads/master@{#408779}

R=rockot@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2192263002
Cr-Commit-Position: refs/heads/master@{#408778}

Review-Url: https://codereview.chromium.org/2193073003
Cr-Commit-Position: refs/heads/master@{#408777}

BUG=

Review-Url: https://codereview.chromium.org/2163393002
Cr-Commit-Position: refs/heads/master@{#408776}

Unqualified page transitions are treated as link-clicks, which can get
sent to android via the arc intent mechanism.  This can result in
infinite-looping if the URL that is being opened originated from android
in the first place.

Marking this as an API-generated page transition ensures that the arc
intent code does not forward this URL back to android.

BUG=632360

Review-Url: https://codereview.chromium.org/2189063002
Cr-Commit-Position: refs/heads/master@{#408775}

The linux kernel stores and prints the data associated with /proc/vmstat
as unsigned longs, so increase Chrome's storage of these fields
accordingly.
https://github.com/torvalds/linux/blob/e4fba88d00d21f50239eac7d653027bfaf844296/include/linux/vmstat.h#L25

Review-Url: https://codereview.chromium.org/2188043003
Cr-Commit-Position: refs/heads/master@{#408774}

BUG=632809
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2198523003
Cr-Commit-Position: refs/heads/master@{#408773}

This removes some native references to ContentViewCore
from the embedder, which were mostly unnecessary indirections
and can use WebContents directly.

BUG=626764

Review-Url: https://codereview.chromium.org/2179563003
Cr-Commit-Position: refs/heads/master@{#408772}

On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.

BUG=613198

Review-Url: https://codereview.chromium.org/2192093002
Cr-Commit-Position: refs/heads/master@{#408771}

https://chromium.googlesource.com/skia.git/+log/5db44aa2aa4a..848904e5b356

$ git log 5db44aa2a..848904e5b --date=short --no-merges --format='%ad %ae %s'
2016-07-29 egdaniel Fix vulkan build
2016-07-29 dvonbeck Added distance vector support for CircleGeometryProcessor
2016-07-29 mtklein Tidy up SkNx_neon.
2016-07-29 jcgregorio perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm.
2016-07-29 bungeman Conditionally define SK_SUPPORT_LEGACY_DATA_FACTORIES.
2016-07-29 egdaniel Properly recycle uniform buffers in vulkan
2016-07-29 mtklein Add some GN builders to the CQ.
2016-07-29 halcanary SkPDF: PDFStream has-a not is-a PDFDict
2016-07-29 mtklein SkNx: add Sk4u
2016-07-29 dvonbeck GrFP can express distance vector field req.,  program builder declares variable for it

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2199433002
Cr-Commit-Position: refs/heads/master@{#408770}

This updates the ManifestUpdateDetector after CL
(https://codereview.chromium.org/2193683003/) landed.

BUG=631063

Review-Url: https://codereview.chromium.org/2189413002
Cr-Commit-Position: refs/heads/master@{#408769}

BUG=553459

Review-Url: https://codereview.chromium.org/2195813002
Cr-Commit-Position: refs/heads/master@{#408768}

The comment states that although the field is marked as repeated, in practice it
can only contain 0 or 1 values.

BUG=543161

Review-Url: https://codereview.chromium.org/2195043002
Cr-Commit-Position: refs/heads/master@{#408767}

BUG=627607

Review-Url: https://codereview.chromium.org/2194893003
Cr-Commit-Position: refs/heads/master@{#408766}

  In order to roll GN 15e0e74f..da21696c (r407852:r408676) and pick up
  the following changes:

  da21696c GN: only write targets that should be generated.
  1c27131e [GN] Prefer explicit pool to automatic link_pool for link targets.
  8293c354 GN: don't write separate files for non-binary targets

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2193873002
Cr-Commit-Position: refs/heads/master@{#408765}

Revert of Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots. (patchset #1 id:1 of https://codereview.chromium.org/2097923002/ )

Reason for revert:
Regression was reverted, so tests can be re-enabled

Original issue's description:
> Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots.
>
> BUG=623105
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
>
> Committed: https://crrev.com/582209c397ef25fb75bd8fdf58ff74c291172247
> Cr-Commit-Position: refs/heads/master@{#402060}

TBR=eakuefner@chromium.org,sullivan@chromium.org,prasadv@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623105

Review-Url: https://codereview.chromium.org/2191413002
Cr-Commit-Position: refs/heads/master@{#408764}

Previously to this CL the code was only considering the focused window
when calculating scale for the overview mode transform. It needs to
consider the bounding rectangle of the whole transient parent's tree.

BUG=632694

Review-Url: https://codereview.chromium.org/2197773002
Cr-Commit-Position: refs/heads/master@{#408763}

BUG=402536

Review-Url: https://codereview.chromium.org/2188523005
Cr-Commit-Position: refs/heads/master@{#408762}

This patch updates the code to prevent auto deducing to a raw pointer.

R=asvitkine@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2195503002
Cr-Commit-Position: refs/heads/master@{#408761}

BUG=630475

Review-Url: https://codereview.chromium.org/2193933002
Cr-Commit-Position: refs/heads/master@{#408760}

Skia histograms are generating invalid data. Disable them until we have
time to debug further.

Review-Url: https://codereview.chromium.org/2185263002
Cr-Commit-Position: refs/heads/master@{#408759}

This fixes an issue with the source color picker where undo-ing the color text did not
always remove the color swatch. CodeMirror findMarks() is not inclusive, so we also need
to check the line endpoints.

The additional newline added to the string in _updateColorSwatches allows
color text to be matched when it is located at the start of a line.

R=lushnikov

Review-Url: https://codereview.chromium.org/2187173002
Cr-Commit-Position: refs/heads/master@{#408758}

This CL addresses the problem in the bug, i.e. android webview
not finding the Geolocation classes after moving to //device.

BUG=632777

Review-Url: https://codereview.chromium.org/2195783002
Cr-Commit-Position: refs/heads/master@{#408757}

It appears we lost support for --class when we stopped using gtk for our
windowing.  This CL adds that feature back.

BUG=118613

Committed: https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520
Review-Url: https://codereview.chromium.org/2186813002
Cr-Original-Commit-Position: refs/heads/master@{#408709}
Cr-Commit-Position: refs/heads/master@{#408756}

BUG=NONE

Review-Url: https://codereview.chromium.org/2195003002
Cr-Commit-Position: refs/heads/master@{#408755}

Now that RequestFinishedListener doesn't depend on NQE's executor, the
rest of this API can go away.

BUG=618034

Review-Url: https://codereview.chromium.org/2188553002
Cr-Commit-Position: refs/heads/master@{#408754}

R=tommycli@chromium.org
BUG=629604
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2195793003
Cr-Commit-Position: refs/heads/master@{#408753}

NOTRY=true

Review-Url: https://codereview.chromium.org/2193373002
Cr-Commit-Position: refs/heads/master@{#408752}

WebAPK process is not guaranteed to terminate when Chrome gets updated. The
WebAPK code assumes that it is always using the latest version of runtime
library. In order to guarantee this, the ClassLoader must be re-created if Chrome
is updated but the WebAPK is still running.

BUG=627950
TEST=HostBrowserLauncherTest.*
TBR=hanxi (TBR for DEP on testing/ by JUnit test)

Review-Url: https://codereview.chromium.org/2179163002
Cr-Commit-Position: refs/heads/master@{#408751}

Not sure why it is missing. Probably related to this CL: https://codereview.chromium.org/2007133006

This fix is to add a style to .remove-warning-button.

BUG=631975

Review-Url: https://codereview.chromium.org/2197653003
Cr-Commit-Position: refs/heads/master@{#408750}

Credit goes to @dbeam.

BUG=632674
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2194823004
Cr-Commit-Position: refs/heads/master@{#408749}

This CL only changes the default for the --ash-max-previews-to-use-mask
runtime flag to 0 (from 10). Not using masks seems to improve animation.

BUG=632825
TEST=None

Review-Url: https://codereview.chromium.org/2193403002
Cr-Commit-Position: refs/heads/master@{#408748}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/317e984a87db..28aad26a05ee

$ git log 317e984a8..28aad26a0 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2191383003
Cr-Commit-Position: refs/heads/master@{#408747}

BUG=632488

Review-Url: https://codereview.chromium.org/2195773003
Cr-Commit-Position: refs/heads/master@{#408746}

AKA "lazy logging".

This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.

This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.

This CL also changes the few instances of _log.warn to
_log.warning for consistency.

Note, most of the changes were done with sed:
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % (\(.*\)))/\.\1(\2, \3)/
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % \(.*\))/\.\1(\2, \3)/

BUG=598897

Review-Url: https://codereview.chromium.org/2188623002
Cr-Commit-Position: refs/heads/master@{#408745}

This change adds a PageLoadMetricsProvider, which implements the new
OnAppEnterBackground hook, and informs all MetricsWebContentsObservers
and in turn all PageLoadTrackers when the app enters the background.

On Android (and iOS), when an app enters the background, it may be
killed without further notifications. Thus, having this callback
will allow us to persist metrics before the app may be killed.
Our page load metrics subsystem isn't used on iOS, so we only target
Android in this change.

Unfortunately, we can't use the existing WebContents hidden callback,
as this gets invoked after the UMA subsystem has already flushed
metrics to disk. Thus, we need to add this explicit callback which
allows us to persist metrics as part of the UMA subsystem handling
the backgrounding callback.

For now, we log a debugging histogram in PageLoadTracker to help
understand how often trackers enter the background, and how often
those trackers are destroyed without running their destructors. In a
subsequent change, we'll add support for informing PLMObservers that
the app entered the background. This will allow any PLMObsevers that
implement OnComplete or OnFailedProvisionalLoad to also get called back
in cases where the tracker may be destroyed before its destructor runs,
due to the application being killed.

BUG=608360

Review-Url: https://codereview.chromium.org/2189543002
Cr-Commit-Position: refs/heads/master@{#408744}