- 21 Jul, 2020 40 commits
-
-
https://crrev.com/c/2304672Fergal Daly authored
Change-Id: I445c53ad6bc4c23617dfa09a8ace832df28e7519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308442Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790321}
-
Tanmoy Mollik authored
This cl creates the preference and layout for creating a button in ManageSyncSettings that will be used to sign the user out using SignOutDialogFragment Screenshot: https://crbug.com/1092410#c1 Bug: 1092410 Change-Id: If66793a3c7f2a965c68b441a32d47718bd943c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264338 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#790320}
-
Ewann Pellé authored
This reverts commit df86a3d6. Reason for revert: Toolbars remain displayed when they shouldn't. Original change's description: > [iOS] Makes bottom toolbar visible when modal view disappears > > This Cl makes the bottom toolbar visible when initiating a drag down > to close a modal setting view. > > Bug: 1106665 > Change-Id: I519fac84a18c36c6838384241af01f1c57a824b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302633 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789454} TBR=sdefresne@chromium.org,ewannpv@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106665 Change-Id: Ic0e6dc70ea878deb0b0be852fa84bab32b4124f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309691Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#790319}
-
Yuki Shiino authored
Replaces base::internal::DereferencedPointerType with the std templates in <type_traits>. Bug: 1073933 Change-Id: I108fc52d5f3834b0749f95342a76578ef1c10306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302880Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790318}
-
Victor Hugo Vianna Silva authored
Chrome won't be able to decrypt the passwords for those users since they have no way of entering their passphrase, so opt-in should not be offered. We also use the occasion to remove some unnecessary clutter in passwords_section_test and passwords_device_section_test: the names in simulated stored accounts are unnecessary and irrelevant for the tests. Bug: 1106350 Change-Id: Ic349ec3088d4e829c033c48c29e65654f1dfbe54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304809 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790317}
-
David Jean authored
Bug: 1106689 Change-Id: I9239398fc5ed9462d6c7fff4f08c2a718cfe5f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303442Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#790316}
-
Yutaka Hirano authored
This is aligned with the spec. Bug: 1097231 Change-Id: Id93081fa764431917e4f6d3c3313df17535186a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309612Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#790315}
-
Abhijeet Kandalkar authored
In this CL, WritingDirection {kNatural, kLeftToRight, kRightToLeft} is replaced by TextDirection {UNKNOWN_DIRECTION, RIGHT_TO_LEFT, LEFT_TO_RIGHT} and dependant files are ported to use |TextDirection| enum. Bug: 1088377 Change-Id: Iac185f2d34eddd78127c3f59b7dc90fe380b5f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306127Reviewed-by:Koji Ishii <kojii@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#790314}
-
Kateryna Prokopenko authored
Bug: chromium:1082628 Change-Id: I485e0f9e5653794fbf2b8eec54496ee44a580ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302110Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> Cr-Commit-Position: refs/heads/master@{#790313}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68e5f29d849a..e687db2bbe11 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 08c4d09493bf to 20eb9be55299 (17 revisions) 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d0dd661f1805 to c4cebc7efae1 (3 revisions) 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ea6f21a052c9 to 97f9923235cf (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1100599 Tbr: robertphillips@google.com Test: Test: Test: CQTest: Test: Manual script execution and building in AOSPTest: Test: NBA 2K20 game playTest: Test: NBA2K20 MEC Change-Id: Ife4d9c31bafd41ca2d0f32f57c0244c3591a799c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790312}
-
Kushagra Sinha authored
Some tests cannot create a proper task environment for running a real instance of Chrome OS Account Manager. Allow the creation and initialization of Chrome OS Account Manager in ephemeral mode where it will not require a task environment for initialization. Bug: 1100833 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Change-Id: I181dbde347f91530ded431d4f8a505f9c6c30be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283305Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#790311}
-
Matthias Körber authored
The CL introduces a data structure to manage address components that must support the duality of an structured and unstructured representation. This is a reland with a fixed DCHECK statement. Change-Id: I95ec6b67bb6681b1dec9c1eb951439e916e932ec Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307375Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#790310}
-
Kent Tamura authored
It was behind the "LayoutNGForControls" flag, of which status is "experimental". Note that this feature depends on the "LayoutNGFlexBox" flag. If the flag is disabled, menulist SELECTs are rendered with the legacy layout. Bug: 1040826 Change-Id: I30e30d1fef26adb2b661ffbbf7a5e1ad2afd7d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303735Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#790309}
-
Makoto Shimazu authored
ServiceWorkerFetchDispatcher now dispatches a fetch event without waiting for an ACK of start worker message when ServiceWorkerOnUI is enabled. However, due to the change, ServiceWorkerFetchDispatcher can invoke a callback twice when starting a worker fails - one for a failure of start worker and the other for a failure of dispatched event, and this caused crashes. This CL added a branch to ignore the latter callback when starting a worker fails because the error status for starting a worker is more detailed. Bug: 1106977 Change-Id: I4cc408a850f40fb3db101584e71eb2164a90c28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309525Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790308}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I5b5fa1c64e4d04697424a54840a52aba5bfe7a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309809Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790307}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/539e8783de62..7a9b96ff8e9f 2020-07-20 jianj@google.com AV1: set error_resilience to 0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I748fe6d52639ec4e21141dc0b73008bc83f8fd64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309567Reviewed-by:
-
Jan Wilken Dörrie authored
This change disallows saving empty passwords in the edit password dialog within the Password Check. It does so by introducing checks to both JavaScript and C++. Fixed: 1107401 Change-Id: Ib84ec706743d837464aba977bc2c08b83e83e7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307256Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790305}
-
Kenichi Ishibashi authored
It was used only from DidReadInfo() in service_worker_disk_cache.cc to convert an HttpResponseInfo to URLResponseHead. Since service_worker_disk_cache.cc will be moved to the storage service it wouldn't be able to depend on content/. Move conversion logic to DidReadInfo() and remove ResourceResponseHeadAndMetadata. Bug: 1055677 Change-Id: I379fc52fcb41fb97f67045492cc8b4d743813398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309609Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790304}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eef54b2513c..b99a6a727318 2020-07-21 johnkslang@users.noreply.github.com Merge pull request #2352 from ben-clayton/vs2015 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Ib70496a201a721e08f60c6e85db718bf3f41aea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309568Reviewed-by:
-
Bret Sepulveda authored
If a user uninstalls multiple extensions simultaneously, where the first one has an extension popup open, the second notification will cause a crash because the bubble will try to access |host_|, which is already nullptr. To fix this, we unregister from further notifications when destroying |host_|. Also adds a test. Bug: 1099456 Change-Id: Ia89e5d1e25e801d83bae49c858ff8f95488cd311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292330 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790302}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df4466ba..f75b12bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id424da990e2c38c07be3b31ecd5eba059e8a48dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308752Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790301}
-
Guido Urdaneta authored
This is in preparation to move content/renderer/media/audio to Blink Bug: 787252 Change-Id: Ifce6820b435d55bf2c577ff7b5cbe6ad969d5af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308329 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790300}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I6f834bf9cfffb3862a42b2d9f48517a5c39d445c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309665Reviewed-by:
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1TV-gYNJkIQ99opvaY3YanKGfPYeKUHle/view?usp=sharing Bug: 1063856 Change-Id: I40675ec609fb2a1cd358e72be17b982ebe663779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302904 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#790298}
-
Koji Ishii authored
r789656 crrev.com/c/2302984 added a few DCHECKs to |PostLayout| based on our existing assumptions, but they did hit in DCHECK-enabled Canary. While not all reasons are clear, we've got 20 crash logs in a few days. This patch removes these DCHECKs. Bug: 1107204 Change-Id: I78e247675278a5c9944bbc0d153a6d1543a8e033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309494Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#790297}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9a3f345ba7c4..f6437f54c9f0 2020-07-21 thestig@chromium.org Roll third_party/depot_tools/ 68978076f..9949ab7a4 (26 commits; 8 trivial rolls) 2020-07-21 dhoss@chromium.org Split path construction and painting in content generation 2020-07-20 tsepez@chromium.org Move CFX_XMLNode::EncodeEntities() to WideString. 2020-07-20 tsepez@chromium.org Fix nits in GCedTreeNode<>. 2020-07-20 tsepez@chromium.org Remove unreachable code in ~CFXA_Object(). 2020-07-20 thestig@chromium.org Roll v8/ 65a118899..343030c9f (582 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ida2d752b4b988f34a2abf5291115c97f1a6a7b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309656Reviewed-by:
-
Guido Urdaneta authored
This is in preparation to move content/renderer/media/audio to Blink Bug: 787252 Change-Id: I00649891b8340aa7f66241229787d8133436f856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307989Reviewed-by:
-
Abhijeet Kandalkar authored
|ax::mojom::TextDirection| indicates writing mode in CSS. The current name of an enum is misleading and doesn't define the exact explanation of its content. This CL renames |TextDirection| to meaningful name |WritingDirection|. Bug: 1088377 Change-Id: I826d65f5a6049b31b69331fa71bad394c1fbf6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307024Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#790294}
-
Andrei-Laurențiu Olteanu authored
idle_time_user_hz is measured in USER_HZ (clock ticks), a system constant accessible via sysconf(_SC_CLK_TCK) (clock ticks / second). Dividing the two results in the number of idle seconds and multiplying by 1000 gets the result in milliseconds. Add a wrapper around LogicalCpuInfoPtr::UncheckedConvertPtr to make unittesting of the function easier without mocking the system call sysconf(). Add tests for checking LogicalCpuInfoPtr::UncheckedConvertPtr. Bug: b:161219494 Change-Id: I0c01f63100beea5315e1cc8f215eeb2fac6e76ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301144Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#790293}
-
Jan Wilken Dörrie authored
This change implements the ranges algorithms from alg.reverse, alg.rotate and alg.shuffle. alg.sample is skipped due to the lack of std::sample in C++14, but might be added in a future CL. Bug: 1071094 Change-Id: I8195c62aa21b99bc8b60ed8a98c492d4b2d5edd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308150 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#790292}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595289228-e5c2a2241b190531533d778f2dcf9ff98ced1901.profdata to chrome-mac-master-1595310726-5356636057416b4e4d905dcd6e997d2e9409d66f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8caa11364e54e130f948b748e396885e3c7190ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309792Reviewed-by:
-
Mikel Astiz authored
Late creation of keyed services in TestingProfile is problematic and runs into use-after-free and other issues in practice, due to tests overriding keyed services after other (dependent) keyed services have already grabbed references to previously existing instances (freed during replacement). Dynamic manipulation of keyed services after profile creation is a bad practice anyway, so let's annotate these TestingProfile APIs as deprecated (there was already a big warning about it) and instead introduce default factories in BookmarkModel and HistoryService factories themselves, in a way that can be conveniently used with TestingProfile::Builder. This approach is analogous to how other keyed services do it, including FaviconService. In this patch, a few test cases adopt the new API. Future patches will adopt them more broadly and eventually remove the old APIs. Change-Id: I8cc0d8ffe3c140398bd583b1d42a31c90f4b0f8b Bug: 1106699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306048Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790290}
-
Karel Král authored
Add helper to trace mojo autogenerated struct parameters. Thus provide more information for local debugging. Bug: 1103623 Change-Id: I4729a92dff39670f1d88136fb0c2f7887b2d334b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302892 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790289}
-
Clemens Arbesser authored
Before this change, consecutive showcasts with identical element areas did not work unless the user somehow changed the area (e.g., scrolling). This was because the last showcasted viewport and element was cached and not properly reset. Bug: b/161471176 Change-Id: I746cd365c2b1bcdf2fcf7271cbc7666d83bea0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306096Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#790288}
-
Anders Hartvoll Ruud authored
This reverts commit 339e6581. Reason for revert: *Probably* broke Android Cast builders. Original change's description: > Android: Updates to warnings-as-errors when building > > * Delete java_warnings_as_errors > * Use treat_warnings_as_errors for android rules > * warnings-as-errors is now default true for debug builds > * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py > so that these warnings can all be turned off locally. > * Made build_utils.CheckOutput fail by default when stderr or stdout is > printed. This should prevent build logs from creaping in. > * Added "you should use treat_warnings_as_errors=false" into error > message when builds fail due to warnings. > > Bug: 1029357 > Change-Id: Ia69e545a110554d76e190cb2da8b20fe10d4d6e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232809 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790225} TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org Change-Id: Id123fab1cdcbbd99c137ea5750719fe68b05440c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308411Reviewed-by:
-
Ewann authored
Bug: 1073831 Change-Id: Ib4d61f98b55ab6c2311cd1627ce12391d0c97e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279974Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#790286}
-
Benoit Lize authored
This significantly shortens the fast path in the allocator: See the annotated assembly dump below for the fast path (release build, x86_64): - Before: 5 tests (and branches, shown with "***"), epilogue at offset 0x8c - After: 3 tests, epilogue at 0x46 BEFORE: 0000000000d385c0 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)>: [...] // Prologue d385c7: 48 83 ec 10 sub $0x10,%rsp d385cb: 41 89 d6 mov %edx,%r14d d385ce: c6 45 ef 00 movb $0x0,-0x11(%rbp) d385d2: 48 8b 16 mov (%rsi),%rdx d385d5: 48 8b 1a mov (%rdx),%rbx *** d385d8: 48 85 db test %rbx,%rbx d385db: 74 7b je d38658 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x98> d385dd: 48 8b 03 mov (%rbx),%rax d385e0: 48 0f c8 bswap %rax d385e3: 48 89 02 mov %rax,(%rdx) d385e6: 66 83 42 18 01 addw $0x1,0x18(%rdx) *** d385eb: 48 85 db test %rbx,%rbx d385ee: 74 5c je d3864c <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x8c> d385f0: 48 89 d9 mov %rbx,%rcx d385f3: 48 81 e1 00 00 e0 ff and $0xffffffffffe00000,%rcx d385fa: 48 89 da mov %rbx,%rdx d385fd: 48 c1 ea 09 shr $0x9,%rdx d38601: 81 e2 e0 0f 00 00 and $0xfe0,%edx d38607: 48 8d 04 11 lea (%rcx,%rdx,1),%rax d3860b: 48 05 00 10 00 00 add $0x1000,%rax d38611: 0f b7 8c 11 1c 10 00 movzwl 0x101c(%rcx,%rdx,1),%ecx d38618: 00 d38619: 48 c1 e1 05 shl $0x5,%rcx d3861d: 48 89 c2 mov %rax,%rdx d38620: 48 29 ca sub %rcx,%rdx d38623: 48 8b 52 10 mov 0x10(%rdx),%rdx d38627: 8b 72 18 mov 0x18(%rdx),%esi *** d3862a: 48 81 fe 01 00 01 00 cmp $0x10001,%rsi d38631: 73 48 jae d3867b <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0xbb> d38633: 48 89 f2 mov %rsi,%rdx *** d38636: 41 f6 c6 02 test $0x2,%r14b d3863a: 74 10 je d3864c <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x8c> *** d3863c: 80 7d ef 00 cmpb $0x0,-0x11(%rbp) d38640: 75 0a jne d3864c <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x8c> d38642: 48 89 df mov %rbx,%rdi d38645: 31 f6 xor %esi,%esi d38647: e8 54 e2 43 00 callq 11768a0 <memset@plt> d3864c: 48 89 d8 mov %rbx,%rax [...] // Epilogue d38657: c3 retq AFTER: 0000000000d385c0 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)>: [...] // Prologue d385ca: 49 89 cf mov %rcx,%r15 d385cd: 41 89 d6 mov %edx,%r14d d385d0: c6 45 e7 00 movb $0x0,-0x19(%rbp) d385d4: 48 8b 0e mov (%rsi),%rcx d385d7: 48 8b 19 mov (%rcx),%rbx *** d385da: 48 85 db test %rbx,%rbx d385dd: 74 35 je d38614 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x54> d385df: 8b 56 18 mov 0x18(%rsi),%edx d385e2: 48 8b 03 mov (%rbx),%rax d385e5: 48 0f c8 bswap %rax d385e8: 48 89 01 mov %rax,(%rcx) d385eb: 66 83 41 18 01 addw $0x1,0x18(%rcx) *** d385f0: 41 f6 c6 02 test $0x2,%r14b d385f4: 74 10 je d38606 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x46> *** d385f6: 80 7d e7 00 cmpb $0x0,-0x19(%rbp) d385fa: 75 0a jne d38606 <base::PartitionRoot<true>::AllocFromBucket(base::internal::PartitionBucket<true>*, int, unsigned long)+0x46> d385fc: 48 89 df mov %rbx,%rdi d385ff: 31 f6 xor %esi,%esi d38601: e8 9a e2 43 00 callq 11768a0 <memset@plt> d38606: 48 89 d8 mov %rbx,%rax [...] // Epilogue d38613: c3 retq Bug: 998048 Change-Id: Ib9698e635b459b90c86a2dabadb3e4536f1d2219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307333Reviewed-by:
-
Hiroki Nakagawa authored
WebSharedWorkerImpl accesses WorkerScheduler from the main thread to take a task runner, and then dispatches a connect event to SharedWorkerGlobalScope using the task runner. This causes a race condition if close() is called on the global scope on the worker thread while the task runner is being taken on the main thread: close() call disposes of WorkerScheduler, and accessing the scheduler after that is not allowed. See the issue for details. To fix this, this CL makes WebSharedWorkerImpl capture the task runner between starting a worker thread (initializing WorkerScheduler) and posting a task to evaluate worker scripts that may call close(). This ensures that WebSharedWorkerImpl accesses WorkerScheduler before the scheduler is disposed of. Bug: 1104046 Change-Id: I145cd39f706019c33220fcb01ed81f76963ffff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308550 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790284}
-
Christopher Cameron authored
Now that most of the functional changes are done, the classes that have been accumulating together can get separate files. TBR=geofflang Bug: 1092155 Change-Id: Ic9f31557cbd2144bf4de643640ae05be3a60ae10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309130 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#790283}
-
Boris Sazonov authored
No behavior change. This is a follow-up to https://crrev.com/c/2289972 that clarifies a comment in AndroidSyncSettingsTestUtils. Bug: 1093998 Change-Id: I5eba992467c15e26de67cd5ea4f411ddb033be9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308151 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#790282}
-
