GitLab

We are converting Android WebView Safe Browsing interstitials to
committed interstitials, so that interstitials work more like other
error pages. In WebView, existing error pages don't need to run JS,
but interstitials do. This CL forces images and scripts to be enabled
for error pages so that interstitials work properly (e.g., clicking on
buttons works) even if the app has disabled JS for web content. Images
and script are force-enabled by allowlisting the underlying error page
URL in AwContentSettingsClient, similar to how content settings are
allowlisted for error pages in ContentSettingsAgentImpl for Chrome
(https://cs.chromium.org/chromium/src/chrome/renderer/content_settings_agent_impl.cc?type=cs&sq=package:chromium&g=0&l=616).

I have not added tests in this CL because this will already be covered
by existing Safe Browsing WebView tests once they are switched over to
use committed interstitials
(https://chromium-review.googlesource.com/c/chromium/src/+/1909276/). This
CL can be manually tested by visiting a link on
https://testsafebrowsing.appspot.com in an app that has Javascript
disabled for WebView and clicking the "Details" link and observing
that the interstitial UI changes.

Bug: 1018809
Change-Id: I46f71738a2af3ff7361922ef0cde1522bcfb6e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017987Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734964}

TBR=asvitkine

Change-Id: I068e575c8ed7b49a3ce009545a4e6c7790a15340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019702Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734963}

USE_CHROMEOS_MEDIA_ACCELERATION should be used with BUILDFLAG() and not
with defined(). This CL corrects that.

Change-Id: Ib8807a7b282799eecc37bf32ed78519307b230ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018154
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734962}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/15d104be0c75..4ccfb08a648f

git log 15d104be0c75..4ccfb08a648f --date=short --first-parent --format='%ad %ae %s'
2020-01-24 mmortensen@google.com Use goma env variable for goma-created temp log dir.
2020-01-24 vapier@chromium.org cbuildbot: drop blamelist code
2020-01-23 bpastene@chromium.org cros_chrome_sdk: Don't set a default val for target readelf.

Created with:
  gclient setdep -r src/third_party/chromite@4ccfb08a648f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I185e588008561da36fe0c566146291af4a31ffea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019074Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734961}

https://boringssl.googlesource.com/boringssl/+log/89730072b81077cc3e3a973963015b2494d36b1a..1cc95ac07c17d61bea601832bbdc1f8d13d313db

Bug: none
Change-Id: I4adf059483b2ec474303f9c9ba1d7857102bb7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017935
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734960}

This reverts commit e5eb732c.

Reason for revert: https://crbug.com/1045466

Original change's description:
> Roll src/third_party/webrtc 760fd5249488..9bac68c0cc44 (1 commits)
> 
> https://webrtc.googlesource.com/src.git/+log/760fd5249488..9bac68c0cc44
> 
> git log 760fd5249488..9bac68c0cc44 --date=short --first-parent --format='%ad %ae %s'
> 2020-01-23 kron@webrtc.org Reland "Reland "Distinguish between send and receive codecs""
> 
> Created with:
>   gclient setdep -r src/third_party/webrtc@9bac68c0cc44
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/webrtc-chromium-autoroll
> Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> Bug: chromium:1029737
> Tbr: webrtc-chromium-sheriffs-robots@google.com
> Change-Id: Ia45c015c7d76de3c5fb72044f26a6c1457d9c74d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018041
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#734895}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com

Change-Id: I255b09e0446b71e7146f09d0250b5962e6cd9f25
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737, chromium:1045466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019407Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734959}

This CL is one of many refactoring CLs that would split the
ManagePasswordsBubbleModel into different controllers one per view.

Bug: 1044034
Change-Id: Id42888f911937e2eaf9241fd89c9257f042a48c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016650Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734958}

[ios] Fix uses of ios::ChromeBrowserState in /ios/chrome/browser/ui/browser_view/browser_view_controller.h

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=gambard@chromium.org

Bug: 1042208
Change-Id: I93ed83ef713fb87dcf730a8a40c28a7df9428c1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017523Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734957}

The issue when using multiple shared images was that a `ScopedAccess`
was destroyed after it's `SharedImageRepresentation`.
The code was similar to the following:

  struct Pair {
      unique_ptr<Representation> representation;
      unique_ptr<Access> access;
  };

  base::flat_map<Key, Pair> map;
  map.erase(some_iterator);

In the Pair destructor C++ guarantees that `access` is destroyed before
`representation` but `erase` can move one element over another, causing
the move-assignment operator to be called. In this case the defaulted
move-assignment would first move `representation` then `access`. Causing
incorrect member destruction order for the move-to object.

Thanks to senorblanco@ and amaiorano@ for figuring out this wasn't a
compiler bug by jumping in the flat_map internals!

Bug: chromium:1038210
Change-Id: Ida90804a9840d1acba96a37c7cad17cf6bcc46ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014927Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734956}

This implementation still lacks the serial number and lock screen status
extraction but provides the rest of the information similar to the other
platforms' implementations.

BUG=1037702
TEST=unit_tests

Change-Id: I459eeafe02b495962c5d9f2a6e5eddc7ba90b974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012956
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734955}

Bug: 1043711
Change-Id: I0e5bd6986c9c1a26d80c7605cdff1192d37b39f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014901
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734954}

This is the follow up for CL:2010449. The order of the AppContextMenu's
functions is reordered to align with the definition.

BUG=1038487

Change-Id: I2a979a32fe1b9ac2a18d1fda26097312027f7037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016684Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734953}

We have now discovered fidl::Equals, so instances of individually
checking each field in fidl objects can be replaced with fidl::Equals.

An additional test cleanup in frame_impl_unittests.

Test: CQ
Bug: 1039849
Change-Id: Ifcb4e2fb87000fed558ef50aa786c77ea04b5ad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995742
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734952}

Using wpt-import in Chromium 2691925b.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: Id7d3143604673d4fe9b7c565a12d13f6a8010c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019502Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734951}

Change-Id: I5716c032afe345989397e655370c3b294a251f2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018172Reviewed-by: Tom McKee <tommckee@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734950}

Phase 1 of ChromeVox custom annotations project.

This change adds a new file to the ChromeVox codebase called
node_identifier.js. This file contains objects and methods used to
uniquely identify AutomationNodes. Several basic tests have also been
implemented in node_identifier_test.js.

This file is being added to support ChromeVox custom annotations.
For more details on that project, please see the following design

document: 
https: //docs.google.com/document/d/1K6Sg0wLOjUdz7ycJqxPnFWNvie7yaJ3enlss10cXKqM/edit
Change-Id: Id5c60ec9257bef0738366d045100915e26d19e6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992594
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734949}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a6d9d08d..781941ba

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I014d5875dad8247a539b7499f76c952a8e2e54fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019522Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734948}

Since we're not using any of the notification permission prompt flavors,
this CL cleans up all the code that was introduced to experiment with
them.

Bug: 1029718
Change-Id: I40e29f1ff5efad30a76b532ff2184561a06d4882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949363
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734947}

Screenshot:
https://screenshot.googleplex.com/AUtrErL2i6g.png

Bug: b/145898741
Change-Id: I5aa981e76f448738a2cbc78c52cc35c10d598714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019343Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Luca Hunkeler <hluca@google.com>
Cr-Commit-Position: refs/heads/master@{#734946}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a922e78b53d..e2a36ca29e3d

git log 5a922e78b53d..e2a36ca29e3d --date=short --first-parent --format='%ad %ae %s'
2020-01-24 tvanderlippe@chromium.org Migrate heap_snapshot_worker/ to import cross-module
2020-01-24 tvanderlippe@chromium.org Migrate mobile_throttling/ to import cross-module
2020-01-24 tvanderlippe@chromium.org Migrate har_importer/ to import cross-module
2020-01-24 aerotwist@chromium.org [Global] Updates refs to SDK.networkLog
2020-01-24 tvanderlippe@chromium.org Update replace-internal-references to accept multiple folders
2020-01-24 aerotwist@chromium.org [Global] Update refs to Workspace.fileManager

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@e2a36ca29e3d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I38761f7994e37a33af6c8b72358b36802acabc84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019072Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734945}

Split out GetHighlightedGame API on GamesService to two functions:
 - SetHighlightedGameCallback
 - GenerateHub

In the future, when we have more feature stores, we'll add more
Set*Callback, and hookup the functionalities in the GenerateHub
processing function.

Bug: 1018201
Change-Id: I18a7eec15cd9b907f0c087aea00bec364e830cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008013Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734944}

https://webrtc.googlesource.com/src.git/+log/9bac68c0cc44..159c414ff8f6

git log 9bac68c0cc44..159c414ff8f6 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 danilchap@webrtc.org Detach LossNotificationController from RtpGenericFrameDescriptor
2020-01-24 ivoc@webrtc.org Improvements for NetEqControllers

Created with:
  gclient setdep -r src/third_party/webrtc@159c414ff8f6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Idb63c193d4bc7428c06b34d1e3462a88c9955fae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019071Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734943}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=gambard@chromium.org

Bug: 1042208
Change-Id: I365945a5812c354b0a24f935a0b6b564fd34dceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017222Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734942}

Change-Id: I9e3ed7d6272b9ee5321e6be76754b41d91ab295d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013620Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734941}

Bug: 1045050
Change-Id: I5528ade693cf383553c65fff229663dfc5a13740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019403
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734940}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=droger@chromium.org

Bug: 1042208
Change-Id: I5ba779b975bc8f784419d1eb7c3b40504a3bffdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017442Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734939}

Some chromeos OS settings pages use elements from the browser
settings. However they do not copy the flags from settings_ui.cc,
this flag needs to be duplicated over into the
chromeos/os_settings_ui.cc file manually.

Bug: 1045167
Change-Id: I310b65886bbc6830b2d552085a1c2ab6cdadbc36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019342Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Sean Harrison <harrisonsean@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734938}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=rohitrao@chromium.org

Bug: 1042208
Change-Id: I2ca981b7006701923494747c7cc07e024cb4c627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017223Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734937}

Bug: 1040894
Change-Id: Ifbc2521ab0cd6b8308b6b5da81d3f1a4a68a790d
TBR: miu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019345Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734936}

This metric was previously reported as
Scheduling.Renderer.BeginMainFrameQueueDurationNotCritical. This change
adds this under compositor latency as part of blink breakdown.

Bug: chromium:976030
Change-Id: I2423f6b67aaf7246c69d7bf1a16b3b4ad39a01a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013461
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734935}

This CL adds a new test for off-screen main thread animations.

TBR=sadrul@chromium.org

Bug: 1021963
Change-Id: I78bf2eba1c1c5abb63151f26be61daa228bea4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008351Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734934}

This CL implements CompositorFrame submission inside
HardwareRendererViz to reuse frame delivery over old webview path.

Bug: 805739
Change-Id: I7d76016c060e3e3bd174b27f3bcfef6988546925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016326Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734933}

Switch from Process/ThreadDescriptors to TrackDescriptors and from
TrackEvent timestamps to TracePacket timestamps.

Async events still continue to use LegacyEvent and its IDs.

This also enables emitting process/thread names in the
Process/ThreadDescriptors, now that we can detect pid/tid reuse in
trace processor during proto2json conversion.

Bug: 928738, 1040525, 991126
Change-Id: I8c1fa5b9c8db57d145c6886956b325e7d7e54993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002518
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734932}

This is a partial reland of 4189e014
The original change removed both shadow-call-stack and safestack
overrides, which broke Blink heap unit-tests under x64, but was not
caught by CQ due to issue 1044935.

Fuchsia builds have been orcibly enabling shadow-call-stack in
advance of it becoming the toolchain default, to gauge size impact.

Enabling shadow-call-stack under x64 is not recommended and breaks code
which uses C++ exceptions, which is true of some V8 code & tests.

Since the toolchain default for shadow-call-stack should now correctly
enable it under ARM64 but not x64, remove the override.

Bug: 1028617, 821951
Change-Id: I8784d8fc24d81716e27a53d41f0548343621ad75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014908
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734931}

Replacing optparse with argparse since optparse is deprecated.

Bug: 1032064
Change-Id: Idf55d7e83f885a3d2e664661eccf33ba671070d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007285
Commit-Queue: Anina Koehler <aninak@google.com>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734930}

When LayoutNGBlockFragmentation is enabled, r718532
<crrev.com/c/1930287> added a branch to use |NGPaintFragment|
directly, without using |NGInlineCursor|. This patch fixes to
use |NGInlineCursor|.

There's no virtual tests for this combination, but tests fail
if both of these two flags are enabled. Caught in a manual
review.

Bug: 982194
Change-Id: Ic22ebc68d6e9d24896c3686d5797ce248c2d0a3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016803
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734929}

Untrack entities from ClientTagBasedModelTypeProcessor by client tag
hash properly. Removes entity even if it has storage key.

Bug: 947044
Change-Id: I820bb173629ccb3d181a8e79d5bf5c9fe3ab9a08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015054Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#734928}

When running tests from device_cloud_policy_manager_chromeos_unittest.cc, GMOCK warnings about uninteresting mock function calls are appearing. Since the mock functions OnDeviceCloudPolicyManagerConnected and OnDeviceCloudPolicyManagerDisconnected are only used in one of the tests, a subclass that contains the mock functions was created for this test.

Bug: 654758
Change-Id: Iaf3f8b17b017523b41bb044eacce59de6d4384ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012162
Commit-Queue: Anina Koehler <aninak@google.com>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734927}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=msramek@chromium.org

Bug: 1042208
Change-Id: Ib9e10374af72f00ed43e7461190ae717d5471a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017328Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734926}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=mmenke@chromium.org

Bug: 1042208
Change-Id: I6f032084a5bfa72b018906ba98cecf096283c878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014918
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734925}