- 12 Oct, 2019 6 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bbf0ce28f06a..d192e933eb69 git log bbf0ce28f06a..d192e933eb69 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 cnorthrop@google.com Vulkan: Support binding texture levels as a rendertarget Created with: gclient setdep -r src/third_party/angle@d192e933eb69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: If86a17d6f9247035c33f2176401074ca949b7016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705327}
-
Caroline Rising authored
This change also updates margins within the tab hover card. See screenshots of this change here: https://screenshot.googleplex.com/12Re7Q6NX2N Bug: 1007459 Change-Id: I50cdb0b94928cad5b4187a1ec4d6e4c90ea0ebf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854165Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#705326}
-
Peter Boström authored
When the WebUI-based tab strip replaces the views-based one no caption buttons are drawn there's no content to be drawn in the browser frame. The changes are restricted to BrowserView::IsBrowserTypeNormal() as other window types might need draw something else (like PWA titles). Bug: chromium:1005563 Change-Id: I5251a002ffd301d30a1db524ec560dd0aa3288c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854804 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#705325}
-
Dan Beam authored
This is an outcome of a Privacy Working Group review. Bug: 1003508 Change-Id: Idfba7d00a965bbe89d2213281633554dc90c65ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854799Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#705324}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/07295b9bedc6..1fce7657a2fd git log 07295b9bedc6..1fce7657a2fd --date=short --no-merges --format='%ad %ae %s' 2019-10-11 akeshet@chromium.org infra_builders: disable puppet pre-cq testing for chromeos-admin Created with: gclient setdep -r src/third_party/chromite@1fce7657a2fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I13c8148eab57027533f59726edbc50804c8cce21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857560Reviewed-by:
-
Henrique Nakashima authored
https://chromium-review.googlesource.com/c/chromium/src/+/1634695 renamed FaviconCache#(get|put)SyncedFaviconImage() methods into (get|put)ForeignFaviconImage() but never called the new versions, instead calling (get|put)LocalFaviconImage(). This effectively causes the caches to be unified. This CL split the caches into two, as I believe the author intended. Change-Id: If461911620c83a901b9d8c89af3fc3acf48293ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852422 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#705322}
-
- 11 Oct, 2019 34 commits
-
-
Lei Zhang authored
external/wpt/cookie-store/idlharness.tentative.https.any.serviceworker.html virtual/omt-worker-fetch/external/wpt/fetch/api/idlharness.any.html TBR=nhiroki@chromium.org NOTREECHECKS=true NOPRESUBMIT=true Bug: 990900 Change-Id: Ied41d78123a64620b9b17a636f7e6668a452a7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856877 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705321}
-
Gavin Williams authored
Reland "Prevent settings search icon from flashing when a search is cleared" This reverts commit 0021fdd7. Reason for revert: Adding new code fix for this bug Original change's description: > Revert "Prevent settings search icon from flashing when a search is cleared" > > This reverts commit 0ac392fe. > > Reason for revert: Settings search bar loses focus on search cancel. crbug/1011752 > > Original change's description: > > Prevent settings search icon from flashing when a search is cleared > > > > Bug: 1001056 > > Change-Id: I326b21b3e25e472fa15dc9bd9d9c97feb688ad4f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815542 > > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > > Commit-Queue: Gavin Williams <gavinwill@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#699457} > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1001056 > Change-Id: I1bcad3ef2b08fdb130d289a9c9619337078570c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847796 > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703783} Change-Id: I65cdc25c3c3652f84f2a328152edff29995e84e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847900Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#705320}
-
Lei Zhang authored
PromptForXHRWithoutOnSubmit and PromptForFetchWithNewPasswordsWithoutOnSubmit are flaky. TBR=vasilii@chromium.org Bug: 1013743 Change-Id: I04af692b1def0971da8fcd418840c6acef326167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857088Reviewed-by:
-
Sergey Ulanov authored
Now web-engine respects playready_key_system flag in CreateContextParams and cast_runner sets this flag when creating web.Context. Bug: 1009755 Change-Id: I718cc105068a06a6c99b2f51180fd3e88b1a1fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848415 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705318}
-
Klaus Weidner authored
Instead of partially initializing this in arcore_device, just pass the initial object and let the GL thread take care of setting it up. This also makes it possible to simplify mailbox_to_surface_bridge, it can now assume that all post-creation methods are used on a single GL thread. Add logic to enforce that at most one frame is allowed to be in "processing" state, deferring the next frame in case of attempted overlap. This matches the current logic used in GVR's immersive-vr mode. Also update some stale comments and make simplifications that are now possible due to the new lifecycle. Bug: 1012972, 836524 Change-Id: I9b85bb6dd261c0c2fa41f443222e34b76a64c5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854506 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#705317}
-
Lei Zhang authored
TBR=lfg@chromium.org Bug: 1013552 Change-Id: Id611e5b94fc593b6fc48602d4bebbb7b4a35549d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857540Reviewed-by:
-
Xianzhu Wang authored
TBR: wangxianzhu@chromium.org Bug: 1013779 Change-Id: Ic73c788b4930af325bf0d52df57089275f48d9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857183Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705315}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/666b243afa28..dbb94e26f650 git log 666b243afa28..dbb94e26f650 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 primiano@google.com Merge "Docs: add links to discord chat" Created with: gclient setdep -r src/third_party/perfetto@dbb94e26f650 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I386be6a0b8d23642b5530c416b9b30cbc7149b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856956Reviewed-by:
-
Adrienne Walker authored
Until WebView supports this feature, I think this flag needs to continue to live, if only for easy testing. Also change its ownership. Bug: 746182,1013777 Change-Id: Ifa71a41b7f5be7de369664083af0e53566bf9c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857340 Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#705313}
-
Manas Verma authored
Previously the FIDO authentication toggle would not be visible, even if the device was capable of user verification. This was because the IPC call to check whether or not a platform authenticator is available would not return on time. This CL changes the implementation of that check to use native javascript instead. Bug: 949269 Change-Id: I6307a7e54889178582ae12dd174599c441957812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850596 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#705312}
-
David Dorwin authored
Change-Id: I4c363e5895e8a434c8a550ccd9f6e7473dca2b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846820 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705311}
-
Regan Hsu authored
Do not show "Center" and "Center Cropped" if the wallpaper is of type 'OemDefaultWallpaper'. These buttons should only be shown when the Currently Set image is the user's. Bug: 973011 Change-Id: Ib1899f430854fa928d807af552b79c51ed3b8ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854797 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#705310}
-
Evan Stade authored
Bug: 171406 Change-Id: I79eca17dea775445ffcc8a056cc8cd069310c6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857206Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705309}
-
minch authored
Put the arrow of the affrodance 64dips below of the touch point if the affordance is outside of the display. Bug: 1002733 Change-Id: I2d889fa271f008be54d57300de207c3d82dcf4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847907 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/27c4369651a8..8c6c8b0c42e2 git log 27c4369651a8..8c6c8b0c42e2 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-11 halcanary@google.com docs/fiddle: add "incomplete" fiddle. 2019-10-11 halcanary@google.com SkPDF/tests: add regression test for crbug/494913 2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-11 egdaniel@google.com Remove GrPixelConfig version of CompressedDataSize. 2019-10-11 halcanary@google.com Docs: Update docs to point at named fiddles Created with: gclient setdep -r src/third_party/skia@8c6c8b0c42e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:494913 Change-Id: I40b8e8a73836d46931cea02ebd773acebb722c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856955Reviewed-by:
-
jonross authored
Add in Release_64 as an exception for them. This will allow skia_renderer_gl_blink_web_tests to actually run on the new "Win10 FYI x64 SkiaRenderer GL (NVIDIA)" bot TEST=skia_renderer_gl_blink_web_tests Bug: 1011512 Change-Id: I80812d258a579db6735ffe58eb7c70f94abdd62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856260Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705306}
-
Amr Aboelkher authored
Add the organisation name instead of Administrator to the message. Bug: 552439 Change-Id: I763e3fa3a2438350a17a64028f33dc5c9ba2167c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850431Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#705305}
-
John Lee authored
Bug: 1010349 Change-Id: I796809b063a92cfca1cfdf243b8aee66b51e283d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854217Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#705304}
-
Maksym Onufriienko authored
Add handling to prevent potential timeouts in suprocess.check_call We're observing some timeouts in some of the bot runs, so we're trying to add some preventative guardrails in test_runner in places that have blocking calls to prevent potential timeouts. Handling freezes in blocking calls will allow for more graceful recoveries and/or even just better data collections in the case of time outs if they happen. This CL specifically is adding some handling around suprocess.check_call in tear_down. Since this is a blocking call, if it should freeze, it would cause the entire tear_down to timeout instead of gracefully recovering and completing the rest of teardown, which would include data collection.e.g. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8900250401157621888/+/steps/base_unittests__iPhone_X_iOS_13.1___with_patch__on_iOS-13.1/0/stdout Bug: 1011851 Change-Id: Ib5a955551e209648b9982593b9e2c1ee4a71f7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845774 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#705303}
-
Xiyuan Xia authored
Make perf test generate LUCI test result json when trace is enabled so that performance test script could pick it up and extract metrics out of the trace file. Test result json follows the TestResultEntry spec in LUCI Test Results format (go/luci-test-results-design). Outputting in this format will allow reusing the code for results processor ( https://docs.google.com/document/d/1GYiqUJGxdUWtg9YQMXEXSILylG4J2wpiGIZM8F-HD_U ) for gtest perf tests. Bug: 945711 Change-Id: I405b3aeab1217d5f87a9c7d3eba8f5e8eabac4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790122 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#705302}
-
Darin Fisher authored
Bug: 1006919 Change-Id: Ib0fb43411215bfba48ece94323f9167588f7adeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856847Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705301}
-
Robert Liao authored
This is still currently used for testing. BUG=979530 TBR=weili@chromium.org Change-Id: Ie837afa0f996faf22303459ffbfdb03c3182b938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857204Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#705300}
-
Marc Treib authored
After recent cleanups, HasEntry(), GetUrlForEntry(), and ViewEntry() didn't do anything useful anymore. Bug: 1007942 Change-Id: I14cfaf0804bed1f280c9710b470e81968090d639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855982 Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705299}
-
Lei Zhang authored
TBR=lukasza@chromium.org Bug: 988938 Change-Id: If76ccad83da2685a82d06f6dfda5c9850879abaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857478Reviewed-by:
-
Jan Wilken Dörrie authored
This change makes base::CheckedContiguousIterator's API constexpr and updates base::span's begin and end member functions. Furthermore, this change makes the various CHECK_* macros usable in a constexpr context (given that the condition actually is true), and makes more use of them in CheckedContiguousIterator. Bug: 817982, 828324 Change-Id: I012941d31237559a7776948c613c45e9ff60b2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856519Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This test tests UA-specific behavior; see https://github.com/web-platform-tests/wpt/pull/19557 Bug: None Change-Id: I650dfa3c59488ad44c4b91f70be5144fd56f6024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856860Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#705296}
-
Mike Jackson authored
This change ensures that we only run best-practice and wcag2a rules, and disables low value or performance impacting rules. These are the net new rules enabled: - duplicate-id-active - duplicate-id-aria - input-button-name - role-img-alt This change does not disable any rules that were previously running prior to the axe-core upgrade. Change-Id: I3b1942e09b29aed6e1055e5159d2d52eb2aa260d Bug: 1013391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854561 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705295}
-
Lei Zhang authored
Also disable TabStackTraceTest.testCrashMinimalSymbols for the same reason. TBR=crouleau@chromium.org Bug: 820282 Change-Id: Ib7096d1fdb97b3e870b82b3d41deb188989d8727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856850Reviewed-by:
-
Guido Urdaneta authored
This system permission is currently checked using a heuristic due to lack of a specific API. However, this heuristic might not be 100% reliable. This CL adds a feature flag as a precaution in order to make it easier to disable the heuristic. Bug: 993692 Change-Id: Ie07ff1eef930e0e42f14392abf1cddcbcfb8dfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857120 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ec08b81b4fde..07295b9bedc6 git log ec08b81b4fde..07295b9bedc6 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 ahassani@chromium.org auto_updater: Fix payload properties file for very old payloads Created with: gclient setdep -r src/third_party/chromite@07295b9bedc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8fe39d157b2c054669e5912098dbaa5c5fb632d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856953Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/12265a8f7de0..5c869191c19f git log 12265a8f7de0..5c869191c19f --date=short --no-merges --format='%ad %ae %s' 2019-10-11 ehmaldonado@chromium.org Reland "depot_tools: Use vpython to execute fetch." 2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@5c869191c19f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I6bcad588c3870892f9cf38fb60e1612e0f5377f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857163Reviewed-by:
-
Lukasz Anforowicz authored
Main change =========== Site Isolation and process allocation should work correctly even in absence of a cooperating renderer process - there should be no need for the renderer-side ChromeContentRendererClient::ShouldFork. This CL removes the NTP-related parts of that method. Treating NTP navigations as browser-initiated ============================================= After removal of NTP-related ShouldFork, NTP navigations won't go through OpenURL, but will go through the regular BeginNavigation code path. The NTP relies on ChromeContentBrowserClient::OverrideNavigationParams to treat clicking NTP links as browser-initiated, bookmark-like navigations. Before this CL OverrideNavigationParams would be only applied to OpenURL-like code paths. To address this, the CL moves the call-sites of OverrideNavigationParams from 1) before OpenURL calls to 2) NavigationRequest::StartNavigation. This aspect of desirable behavior is covered by the LocalNTPTest.NtpNavigationsAreTreatedAsBrowserInitiated test. Allowing navigations to non-web-accessible-extension-resources from NTP ======================================================================= ExtensionNavigationThrottle excludes 3 schemes from web-accessible-resource checks: - content::kChromeUIScheme (chrome://) - content::kChromeDevToolsScheme - chrome::kChromeSearchScheme (NTP) The checks need to be added to ResourceRequestPolicy::CanRequestResource. They need to be added because CanRequestResource wouldn't run before this CL (it doesn't run in OpenURL code path; only in BeginNavigation code path). This aspect of desirable behavior is covered by the ExtensionBrowserTest.NavigateToInaccessibleResourceFromChromeURL test. Deleted tests ============= The CL deletes the following NTP/ShouldFork tests: - InstantProcessNavigationTest.ForkForNavigationsFromInstantProcess - InstantProcessNavigationTest.ForkForNavigationsToNewTabURLs These tests were tightly coupled to the ShouldFork implementation and are not applicable anymore after the NTP-specific parts of ShouldFork implementation have been removed. The CL deletes the following prerender tests: - PrerenderBrowserTest.PrerenderCancelReferrer - PrerenderBrowserTest.PrerenderCancelReferrerPolicy This is okay because: - Prerender is not used in production (e.g. see https://crbug.com/755921 opened in August 2017). Supporting prerender tests carries a significant burden (over the last few months multiple non-prerender-related CLs had to tweak //chrome/browser/prerender/prerender_browsertest.cc). - The tests were tautological. The test were verifying that prerender ends with FINAL_STATUS_CANCELLED, but this status was not a result of how production code behaves, but rather a direct consequence of how the test used an TestContentBrowserClient::OverrideNavigationParams (earlier ShouldAllowOpenURL before r702175). Bug: 1003957, 883549 Change-Id: Ib7c1e18173a861704589959f5e1aff904ee3eb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842112Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#705290}
-
Pavel Shmakov authored
This fixes an error due to which AppCompatDelegate.setLocalNightMode wasn't always triggered on CCT startup Bug: 1012755 Change-Id: I5dce526db679ba36b667f6330bd94c577aef02a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857318 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#705289}
-
Victor Costan authored
Bug: 1010273, 1001838 Change-Id: Ic7a490640f44fe3d449462c974737f71d20c76a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853847 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#705288}
-
