GitLab

TBR=nona@chromium.org
BUG=106862
TEST=CandidateWindowViewTest.MozcUpdateCandidateTest

Review URL: http://codereview.chromium.org/8879023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113624 0039d316-1c4b-4281-b951-d872f2087c98

The screen locker window manager refuses to map most windows over the screen locker layer. This is for good reason to be safe about not allowing content to show up on top. To be able to see the status area window over the lock screen we can override the window type to be TYPE_POPUP. This must only be done for the lock screen as it does not allow focus to this window which is used on the login screen but not allowed on the lock screen due to the GTK grab.

BUG=105572
TEST=Lock screen and check if status area is visible.


Review URL: http://codereview.chromium.org/8770012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106842
Review URL: http://codereview.chromium.org/8888014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113621 0039d316-1c4b-4281-b951-d872f2087c98

pp_macros.idl.

Now, PP_ALLOW_THIS_IN_INITIALIZER_LIST macro is provided for not only tests
but also C++ api implementation in NaCl.

BUG=87310
TEST=ui_tests


Review URL: http://codereview.chromium.org/8885012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113615 0039d316-1c4b-4281-b951-d872f2087c98

This initialization must have been implicit with gtk. On ChromeOS we go down a different code path for these tests.

TBR=phajdan.jr@chromium.org
BUG=106725
TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux.


Review URL: http://codereview.chromium.org/8889002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113614 0039d316-1c4b-4281-b951-d872f2087c98

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Some tests are disabled under XP, see:
http://crbug.com/106450

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113075
Review URL: http://codereview.chromium.org/8575020

TBR=asvitkine@chromium.org
Review URL: http://codereview.chromium.org/8872024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113613 0039d316-1c4b-4281-b951-d872f2087c98

- Add missing includes
- Inline function.


BUG=63656
TEST=HostContentSettingsMapTest*, 
     ContentSettingsProviderTest*


Review URL: http://codereview.chromium.org/8804016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113610 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113609 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8856002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113608 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113607 0039d316-1c4b-4281-b951-d872f2087c98

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Some tests are disabled under XP, see:
http://crbug.com/106450

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113075
Review URL: http://codereview.chromium.org/8575020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113606 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106850
TBR=nona@chromium.org

Review URL: http://codereview.chromium.org/8889015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79331
TEST=collected cookies test


Review URL: http://codereview.chromium.org/8836006

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/8872017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113604 0039d316-1c4b-4281-b951-d872f2087c98

This change has resulted in severe regressions in keyboard event dispatching -
the keydown and keypress events are no longer dispatched synchronously. Reverting as suggested by Darin Fisher.

BUG=106224
TEST=manual
TBR=darin


Review URL: http://codereview.chromium.org/8885009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23640
TEST=run unit_tests


Review URL: http://codereview.chromium.org/8833008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113601 0039d316-1c4b-4281-b951-d872f2087c98

It was failing with a "_cur_testcase not defined" error.
TBR=eugenis
Review URL: http://codereview.chromium.org/8872016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113598 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22840
TEST=None

Review URL: http://codereview.chromium.org/8883013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113597 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113591 - Revert 113579 - Content settings: allow scripts on interstitial pages even if JavaScript is blocked.


BUG=104700
TEST=ChromeRenderViewTest.ContentSettingsInterstitialPages


Review URL: http://codereview.chromium.org/8773035

TBR=marja@chromium.org
Review URL: http://codereview.chromium.org/8889008

TBR=dgozman@chromium.org
Review URL: http://codereview.chromium.org/8873015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106709
TEST=none


Review URL: http://codereview.chromium.org/8848001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113593 0039d316-1c4b-4281-b951-d872f2087c98

Additionally, downloaded profile image is no more saved to file every time it is downloaded after login.

BUG=chromium-os:23684
TEST=Manual: see bug description

Review URL: http://codereview.chromium.org/8822015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113592 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113579 - Content settings: allow scripts on interstitial pages even if JavaScript is blocked.


BUG=104700
TEST=ChromeRenderViewTest.ContentSettingsInterstitialPages


Review URL: http://codereview.chromium.org/8773035

TBR=marja@chromium.org
Review URL: http://codereview.chromium.org/8889008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104291
TEST={ChromeAppCacheServiceTest, DOMStorageTest, IndexedDBBrowserTest, DatabaseTrackerTest}.SaveSessionState


Review URL: http://codereview.chromium.org/8820009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113590 0039d316-1c4b-4281-b951-d872f2087c98

Also, improve the comment and add a link to the bug
BUG=106829
TBR=cbentzel
Review URL: http://codereview.chromium.org/8889006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113587 0039d316-1c4b-4281-b951-d872f2087c98

The new name would be more consistent since other functions that return a Unicode code point use ui::GetCharacterXXX. For example, keyboard_code_conversion.h has ui::GetCharacterFromKeyCode.

BUG=None
TEST=ran try


Review URL: http://codereview.chromium.org/8802002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Manual.


Review URL: http://codereview.chromium.org/8851001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113585 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104700
TEST=ChromeRenderViewTest.ContentSettingsInterstitialPages


Review URL: http://codereview.chromium.org/8773035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8659002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101399
TEST= Navigate inside the avatar menu using keyboard.
Tab key and down arrow key to navigate forward.
Shift-Tab key and up arrow key to navigate backward.
Enter key to open/edit a profile.

Review URL: http://codereview.chromium.org/8834010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113577 0039d316-1c4b-4281-b951-d872f2087c98

We should instead use the new ui::InputMethodIBus implementation.

BUG=97261
TEST=try


Review URL: http://codereview.chromium.org/8800002

TBR=yusukes@chromium.org
Review URL: http://codereview.chromium.org/8890004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113576 0039d316-1c4b-4281-b951-d872f2087c98

SQL_FROM_HERE cannot be used in places where the corresponding SQL statement is
not unique.

BUG=NONE
TEST=NONE


Review URL: http://codereview.chromium.org/8856005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113575 0039d316-1c4b-4281-b951-d872f2087c98

We should instead use the new ui::InputMethodIBus implementation.

BUG=97261
TEST=try


Review URL: http://codereview.chromium.org/8800002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113574 0039d316-1c4b-4281-b951-d872f2087c98

Also added a little hack to make session_manager restart chrome.

BUG=chromium-os:23763
TEST=All pyautos/autotests still work

Review URL: http://codereview.chromium.org/8852002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113573 0039d316-1c4b-4281-b951-d872f2087c98

This will allow for IME/omnibox coordination, as the omnibox can observe when
the candidate window is open.

Currently, there is no distinction between the suggest window and candidate
window in these events, but it can be changed later.

BUG=chromium-os:17763
TEST=


Review URL: http://codereview.chromium.org/8840002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113572 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary solution for Lion key-repeat + popup issue.
When Pepper IME API is exposed to NaCl apps, each apps should
set the text input type apporpriately.

BUG=chromium:102808
TEST=Run any NaCl app on Lion and hold 'a' key for a while to see the variant selector popup will not show up.


Review URL: http://codereview.chromium.org/8815008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106665
TEST=see bug.

Review URL: http://codereview.chromium.org/8872008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113570 0039d316-1c4b-4281-b951-d872f2087c98

replace with add/remove

BUG=102610
TEST=manual (for those strings I actually know how to trigger)


Review URL: http://codereview.chromium.org/8835003

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/8872009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113569 0039d316-1c4b-4281-b951-d872f2087c98

replace with add/remove

BUG=102610
TEST=manual (for those strings I actually know how to trigger)


Review URL: http://codereview.chromium.org/8835003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113568 0039d316-1c4b-4281-b951-d872f2087c98

Sub chunks for kDownloadWhiteList are just a bunch of
(add_chunk_number, prefix) pairs, with no leading host/count.

Additionally, shift the buffer-overrun checks before the buffer is
overrun rather than after, and add DCHECKs to make sure this is
honored.

BUG=106165


Review URL: http://codereview.chromium.org/8873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST='ObfuscatedFileUtilTest.TestDirectoryTimestamp'


Review URL: http://codereview.chromium.org/8728029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113565 0039d316-1c4b-4281-b951-d872f2087c98