- 03 Apr, 2020 40 commits
-
-
wutao authored
This is a reland of e77cef6b No changes, submit after the internal code submitted. TBR=xiaohuic@chromium.org,xiyuan@chromium.org Original change's description: > ambient: Add Get/Update Settings APIs > > This patch adds the Get/Update Settings APIs so that we can show and > update it in the Chrome OS Settings ambient mode page, which will be > implemented in a follow up cl. > > Bug: b/148483925 > Test: manual > Change-Id: Ia74d875813860a6abbfdc01479a67fed0c029fb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125685 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755531} Bug: b/148483925 Change-Id: I40f57d6e2cfe267a2ff27513e3702273e87d9434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135417Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#756159}
-
Meredith Lane authored
This reverts commit a0d18c16. Reason for revert: Deterministically fails on Mac10.10, first failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/52676 Original change's description: > [shapedetection] Upstream TextDetection tests to WPT > > This CL upstreams the reset of shapedetection tests(mainly > TextDetection tests) to WPT. > > - Moves tests under > third_party/blink/web_tests/shapedetection/, > third_party/blink/web_tests/fast/shapedetection/, > third_party/blink/web_tests/http/tests/shapedetection/, > to third_party/blink/web_tests/external/wpt/shape-detection. > - Moves third_party/blink/web_tests/shapedetection/resources/mock-textdetection.js > to third_party/blink/web_tests/external/wpt/resources/chromium/. > - Removes third_party/blink/web_tests/fast/shapedetection/shapedetection-creation.html > as which should be covered in idlharness tests. > - Introduces simulateClosedPipe() to MockBarcodeDetectionProvider to simulate > 'no implementation available' case for > third_party/blink/web_tests/external/wpt/shape-detection/detection-getSupportedFormats.https.html > - Improves third_party/blink/web_tests/external/wpt/shape-detection/detection-options.https.html > by using assert_throws_js BTW. > > Bug: 932382 > Change-Id: I2f795e4fa4f23b33c49b7924cdbcbccde5ac6ed4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131154 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > Cr-Commit-Position: refs/heads/master@{#756131} TBR=reillyg@chromium.org,mcasas@chromium.org,wanming.lin@intel.com,foolip@chromium.org Change-Id: Iabb63b96afc3f4eba5b3ba9708dd04296ccf86cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 932382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134030Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#756158}
-
Daniel Hosseinian authored
Bug: 226176 Change-Id: Ie9d4cf97a2f0d977fb9955b5e7ab33516e0cbf02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131217Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#756157}
-
Alexandre Courbot authored
Getting the currently set format on a queue is a frequent operation. Add a dedicated method for this so we can factorize the code across the various users. BUG=b:149663704 TEST=vdatest passing on Kukui. TEST=vdatest passing on Hana. Change-Id: Ie98b86db7a40d277adaab04703327340c61dfddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131430 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756156}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dd29370cdd41..1cc49bb2e230 git log dd29370cdd41..1cc49bb2e230 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 jmadill@chromium.org Squash State::mContext and State::mID. Created with: gclient setdep -r src/third_party/angle@1cc49bb2e230 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ic35baefef08c7f98645c2639f9d94147edd51818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756155}
-
Frank Tang authored
The code record the metrics is in https://chromium-review.googlesource.com/c/chromium/src/+/2109133 Bug: 1062057 Change-Id: I4dd593526319a32c5bd40b991dbdbbf572256965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134909Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756154}
-
Andrew Xu authored
It is an issue reported by Fuzz. However, I cannot reproduce the issue through Fuzz on my work station although following the reproduction instructions (attached to the issue page) very carefully. Based on the call stack, the story should be: When destructing ash::Shell, all windows are destructed as well via Shell::CloseAllRootWindowChildWindows(). However, TabletModeController is destructed before window's destruction. Meanwhile, during window's destruction (like Hotseat), it may utilize TabletModeController. This CL serves as a quick fixing for M-83. Another issue (1067490) is created for the real fixing. Bug: 1066265 Change-Id: I43a2f809facaad2254bd288716ca4742e76d471e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132841 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#756153}
-
Omid Tourzan authored
Bug: 1054319 Change-Id: I42e0444600ce27cf9cf6068b6ee690e1e69d8099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134748 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#756152}
-
John Z Wu authored
Bug: 1066690 Change-Id: I3fdf503aceb45dd93d51187ab30f38c887c2ccdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134958 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#756151}
-
John Z Wu authored
Change-Id: I52458ffd53e414fd191ba1705670102d55fe6908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134934Reviewed-by:
-
Kent Tamura authored
Intent: https://t.co/osaFPo0Obe * Rename '-webkit-appearance' to 'appearance' in some data files. * Add '-webkit-appearance' as an alias of 'appearance'. - Add ParseSingleValue() for 'appearance' so that we can warn about non-standard keywords. CountKeywordOnlyPropertyUsage() is called for both of CSSPropertyID::kAppearance and |CSSPropertyID:: kAliasWebKitAppearance|. Usually aliases are not passed to this function. * Remove appearance-button-bevel-001.html and webkit-appearance-button-bevel-001.html. 'button-bevel' keyword was removed from the specification. * Fix the initial value of 'appearance' in WPT css/css-ui/inheritance.html * Add 'const' to Document::AddConsoleMessage() because we'd like to call AddConsoleMessage() with a const Document. Bug: 963551, 968164 Change-Id: Iad251b73a30e2dec4056af4dd5832a1edfb9060b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084776 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#756149}
-
Rakina Zata Amni authored
Since subtree-visibility: auto subtrees gets unlocked when on screen, we should add spacer to accessibility tests to make sure the locked elements are offscreen and not get viewport-activated. This way, the tests are actually testing whether the functions that should activate the locked elements actually activates them. Change-Id: Ia38217af0777a478539a752a7a353e4c4daeedc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123691 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756148}
-
Toby Huang authored
If a supervised user tries to install an extension, the parent approval dialog appears requiring the parent's password. Currently, if the supervised user signs out and signs back in, the parent approval is not remembered. On the chrome://extensions page, all installed extensions go back to being force-disabled. If the supervised user clicks on the enable toggle, the parent approval dialog appears again asking for the parent's password. This behavior is undesirable. This CL fixes this bug by using a Chrome pref instead of SupervisedUserSettingsService to sync and persist the map of approved extensions across sessions. Bug: 1065765 Change-Id: Ia92ec980b6eccf9381e3645ddf55a5cc7be09ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127986 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756147}
-
Adrian Taylor authored
Adding CPEPrefix lines which will allow Vomit to report crbugs for known vulnerabilities in these components. See docs/adding_to_third_party.md for information about CPEPrefix. Notes about how some of these were figured out: * libxml: deduced by looking through the history from the git hash given in the latest git commit. * fontconfig: Went through git history to last tag; matches README * jsoncpp: Used latest tag. * Flash is marked as 'unknown', since it's not the real Flash player. * The Camino Cocoa extensions don't have a corresponding OSS project any longer so are also marked as 'unknown'. Bug: 895969 Change-Id: Iadcd9fff258c18d759d564f15fe4fa334c98b441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128971Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#756146}
-
Jiewei Qian authored
This CL adds additional test logic to check SWA can read and write to sensitive directories (and their files) received from File Handling API. Fixed: 1066370 Change-Id: Ibc83d9c2c25d6a68f30afe9c802717b945050491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129729 Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#756145}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I2b93a21cd325c3c74804302c2652503835c0eed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134921Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756144}
-
rbpotter authored
Bug: 1026426 Change-Id: I4cee85cb67f6944fcf88e35138529b4c8f1937f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135052Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#756143}
-
Xianzhu Wang authored
This fixes fragment data LogicalTopInFlowThread for overflowing contents under clip under multicol. Previously the overflowing parts created phantom fragments as if they were overflow:visible. Now the overflowing parts are under the last fragment of the clipping element. They will be painted correctly when they scrolls into the container clip rect. Bug: 1063043, 1064015 Change-Id: Ie8d60250736b0a5074872e7ef8d021c5731f9b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132934Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756142}
-
rbpotter authored
Bug: 1026426 Change-Id: Ic3c0f3f8da20702d380b6e808c78ec83096f00a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134855 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Hiroki Sato authored
When user press tab in ListView, VIEW_SELECTED event is dispatched. This event is not only dispatched from the newly selected node but also from List itself and child nodes of it. Previously filtering out these event were took place in Android AccessibilityService side. This CL migrates the event handling to Chrome side. Also, this type of event was converted to chrome selection event, but focus event is more appropriate. This CL also fixes it. Bug: b/148837372 Bug: b/146916101 Bug: b/143336586 Bug: b/139645142 Bug: b/152374820 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual with ag/10901596. tab navigation works in PlayStore hamburger menu and talkback test appp list menu. Change-Id: Ia8d2f3bb71dcb5a9b9b796dc89e4d8d2a733a940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129381 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#756140}
-
Andrew Grieve authored
Still need to work through some size regressions before enabling in release. Bug: 1032609 Change-Id: I842052f81642f1e99371102a3d3b9c9876a20148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133880 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#756139}
-
Gyuyoung Kim authored
This CL moves stretch-input-in-column[-expected].html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Additionally, stretch-input-in-column-expected.html is renamed to stretch-input-in-column-ref.html. Bug: 1063749 Change-Id: If9fa79e6cd85d15b0c29daea6aecdaae1b27d580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131816Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756138}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some os and browser routes had the same name. This was a bit confusing. If some c++ code called the route '/printing', it is not clear if this url is a chrome or browser subpage. A distinction needed to be made. This CL renames OS specific route PRINTING, which is shared with browser routes to a more distinguishable name OS_PRINTING. Allowing this bug(990169) to be unblocked. Bug: 990169 Change-Id: I71eea6ecea249c20ef0c3083aaddd3fb714a2162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126332 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756137}
-
Andrew Grieve authored
This involved: 1) Tweaking R8 to include the outer class name in the lambda name for method references. This increases dex size by ~2kb, but is needed for attribution (without this they all show in $APK). 2) Updating supersize to unmangle lambda names. This patch also re-works how R8 local modifications are stored. It changes from a single .patch file to multiple format-patch files. This allows each patch to be applied separately (easier conflict resolution), and allows a description to live right allon each patch (via the commit messages) Bug: 1032609 Change-Id: I34c356b542fd665e3b81f7a6d43e0e1dbbf38886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132668 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#756136}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04c1b445019e..cb70daa3fa9a git log 04c1b445019e..cb70daa3fa9a --date=short --first-parent --format='%ad %ae %s' 2020-04-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b0ab5b8b..3eea752c (755896:756022) Created with: gclient setdep -r src/third_party/webrtc@cb70daa3fa9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I37118e2c879ed8291833ec8e5c8a8e870bcb1b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135182Reviewed-by:
-
rbpotter authored
Migrate these tests to Polymer 3. Note: ignoring several lines in sync_account_control_test.js that validate text content that relies on i18nPolymer with single quotes, as this is not yet working in Polymer 3 (see https://crbug.com/1063530). Bug: 1026426 Change-Id: Ibbba49b676f19c959161ef2c60da479941f791a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133417 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6fff1b9fabd..c3968223894a Created with: gclient setdep -r src-internal@c3968223894a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1057234 Tbr: jbudorick@google.com Change-Id: If3a6299cdd336a9efd72c485872bff2578896bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135179Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756133}
-
Anupam Snigdha authored
On Windows, dictation comes as a composition and in some cases the underline style is set as TF_LS_NONE to differentiate between high confidence and low confidence words. This patch removes the default initialization of underline style to solid so the dictation composition could also apply none style when it wants to. Bug: 1033764 Change-Id: I41f5904129686858c5d729fe26e6a312fd9beaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134918Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756132}
-
Wanming Lin authored
This CL upstreams the reset of shapedetection tests(mainly TextDetection tests) to WPT. - Moves tests under third_party/blink/web_tests/shapedetection/, third_party/blink/web_tests/fast/shapedetection/, third_party/blink/web_tests/http/tests/shapedetection/, to third_party/blink/web_tests/external/wpt/shape-detection. - Moves third_party/blink/web_tests/shapedetection/resources/mock-textdetection.js to third_party/blink/web_tests/external/wpt/resources/chromium/. - Removes third_party/blink/web_tests/fast/shapedetection/shapedetection-creation.html as which should be covered in idlharness tests. - Introduces simulateClosedPipe() to MockBarcodeDetectionProvider to simulate 'no implementation available' case for third_party/blink/web_tests/external/wpt/shape-detection/detection-getSupportedFormats.https.html - Improves third_party/blink/web_tests/external/wpt/shape-detection/detection-options.https.html by using assert_throws_js BTW. Bug: 932382 Change-Id: I2f795e4fa4f23b33c49b7924cdbcbccde5ac6ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131154Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#756131}
-
Gyuyoung Kim authored
This CL moves relayout-align-items.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Bug: 1063749 Change-Id: I9cc13f9902080279b39bd62a9d9f9a3c8cf5b02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131824 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cafccfd0e563..a10679ba4c58 git log cafccfd0e563..a10679ba4c58 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 jalyn@microsoft.com Fix maybeLinkifyScriptLocation fallback strategy Created with: gclient setdep -r src/third_party/devtools-frontend/src@a10679ba4c58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061379 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4d7e3775d0d61a803ef0c6f08abd2e15b933cfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135137Reviewed-by:
-
Xinghui Lu authored
This is the first setup of safe_browsing_url_checker_impl unit tests. Use MockSafeBrowsingDatabaseManager, MockUrlCheckerDelegate and MockRealTimeUrlLookupService as helper classes for the tests. The current tests are mostly for verifying the overall workflows. They don't check every parameters in details. More value checks will be added in followup CLs. Bug: 1054660 Change-Id: I7a91bef4e9f307992080351a3a463d367669655d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128937 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#756128}
-
nancy authored
ChromeNewWindowClient::OpenFileManager should open the file app, based on the previous code before the CL:2121518 is landed. This CL fix the issue caused by CL:2121518. TBR=xiyuan@chromium.org BUG=1067447 Change-Id: Icfd83c629760ff0913cf18801540c5374370efb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133991 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#756127}
-
Brandon Wylie authored
Bug: 1066642 Change-Id: Ice49aa71ce66b2c9586d676255c7593eea484525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131220 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756126}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/daabea6ba6c0..1575b47cd3bd git log daabea6ba6c0..1575b47cd3bd --date=short --first-parent --format='%ad %ae %s' 2020-04-02 thestig@chromium.org Funnel CPDF_NameTree creation through Create(). 2020-04-02 thestig@chromium.org Add CPDF_Dest::Create(). 2020-04-02 thestig@chromium.org Move name tree internal structure creation code into CPDF_NameTree. 2020-04-02 thestig@chromium.org Fix nits in CPDF_NameTree. 2020-04-02 thestig@chromium.org Add CPDF_NameTree::CreateForTesting(). 2020-04-02 thestig@chromium.org Use FX_AllocUninit() in outline_aa::allocate_block(). Created with: gclient setdep -r src/third_party/pdfium@1575b47cd3bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ideda12527f45085493446d5dd9ab4775069a1ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135135Reviewed-by:
-
dpapad authored
These changes have been mostly generated with a local script, followed by some manual editing. Execute the following target locally ninja -C out/gchromeos/ chrome/browser/resources/settings/chromeos:polymer3_elements or just the following with optimize_webui=false (for now) ninja -C out/gchromeos/ chrome Problematic *_module targets that are causing build errors to be thrown from polymer.py have been commented out and a TODO has been added for each of them. For example - wherever cr.define() calls exist, they need to include the contents of the entire file - A single <script> tag is expected in an HTML file Bug: 1045266 Change-Id: I6a9c98fe55d6d270e36d620b1aef1fef2fe8b8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133048 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
-
Meredith Lane authored
TBR=rsorokin Bug: 1067461 Change-Id: I33b0cdd8823610da319870bfa1c8167fb0c847d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133992Reviewed-by:
-
Orin Jaworski authored
This CL starts preparing popup handlers for changes to either line index or line state, instead of only considering line and assuming the NORMAL state. The interface is changed, but not behavior. Bug: 1046523 Change-Id: I1cdf5e288b6be2c488795be2bfba0b276327326e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132769Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#756122}
-
chrome://media-appDavid authored
Bug: b/138961540, 996088 Change-Id: I514e5d4834beeaaf0eeb0062e53cbbbf4950cdad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132020 Auto-Submit: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#756121}
-
S. Ganesh authored
* This is a skeletal implementation of the legacy Omaha3 interfaces as expected by Chrome's on-demand client. * All the methods that Chrome calls return S_OK, and unused methods return E_NOTIMPL. * When Chrome calls on-demand, we return "noupdate" for now. Bug: 1067348 Change-Id: I860492c5674a3f20ef74e432d344b065a9056aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134690Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#756120}
-
