GitLab

While the flag for limiting windows to the current active desk is
enabled, if a user swaps desks while the window cycle list is open, the
contents will not update to the new active desk.

This CL makes the window cycle list reset if it is open and a desk
swap occurs while the aforementioned flag is enabled.

Test: LimitedWindowCycleControllerTest.CycleShowsActiveDeskWindows
Bug: 1067327
Change-Id: I9d940ad82a2f05ab1d2fd9e8c5115d5f3eda9826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398559
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806749}

Bug: None
Change-Id: I9a4fd6ff2c68bc228efda58d6e332218c729193a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410667Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806748}

- DiscoverFeedService is now in charge of creating and owning a single
instance of FeedMetricsRecorder.
- Add the FeedMetricsRecorder to DiscoverFeedConfig
- Adds engagement recording events

Bug: 1085419, 1127557
Change-Id: Iaf3cdcca850babb54bc8149050a4ebd6c3f8d68c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406715
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806747}

This CL adds and option to the TabGridDialog toolbar menu to update
the group name. Also, this CL cleans up a bit the dependency
relationship between title text focus and keyboard visibility, so that
keyboard visibility is controlled by title text focus. When title gains
focus, we try to show the keyboard; when title text loses focus, we
hide the keyboard.

Apart from the above rule of thumb, we handle three cases specifically:

* When "Edit group name" item is selected in dialog menu, we request
  focus programmatically which also shows the keyboard.
* When keyboard hides but the title still has focus, we manually clear
  the focus.
* When dialog hides, we always clear focus on dialog title.

This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled. This CL is verified by the
formal equivalence tool in http://crrev.com/c/1934235 to be completely
behind flag.

Bug: 1116644
Change-Id: I208807435cc27ffb3536e6ccbc30f96380f1e766
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386376Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806746}

Also fixing a minor issue with a preprocessor define, see bug 10322.

https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/a8c51df76caa..995c0b844144

$ git log a8c51df76..995c0b844 --date=short --no-merges --format='%ad %ae %s'
2020-08-28 tuexen Fix explicit EOR mode, thanks to Taylor Brandstetter for reporting.
2020-08-26 tim constants: increase SCTP_DIAG_INFO_LEN to accommodate longer file paths (#521)
2020-08-18 tuexen Fix two bugs I introduced in https://github.com/sctplab/usrsctp/commit/e954753202890c9681eb82c7bcc9d6b37e276360
2020-08-16 tuexen Improve concurrent send() calls
2020-08-15 tuexen Sync with FreeBSD
2020-08-13 yuquanw2 Yuquan2 (#515)
2020-08-11 yuquanw2 add tests for nr sacks (#514)
2020-08-06 yuquanw2 new fuuzer for data fragmentation and connect corpus (#512)
2020-08-01 jmillan Provide ulp_info pointer on send_callback() (#511)
2020-07-30 lennart.grahl Fix oversight: Don't not undefine platform specific defines (#510)
2020-07-23 tuexen Clear the pointer to the socket when closing it also in case of an ungraceful operation. This fixes a use-after-free bug found and reported by Taylor Brandstetter from Google by testing the userland stack.
2020-07-23 tuexen Detect and handle an invalid reassembly constellation, which results in a memory leak.
2020-07-22 weinrank Sync master with OSS-FUZZ (#505)
2020-07-19 tuexen Add reference counts for inp/stcb/net when timers are running. This avoids a use-after-free reported for the userland stack. Thanks to Taylor Brandstetter for suggesting a patch for the userland stack.
2020-07-18 tuexen Cleanup
2020-07-17 tuexen Improve address list locking
2020-07-16 weinrank add fflush() (#502)
2020-07-14 tuexen Improve the error handling in generating ASCONF chunks. In case of errors, the cleanup was not consistent. Thanks to Felix Weinrank for fuzzing the userland stack and making me aware of the issue.
2020-07-10 tuexen Remove program used only locally.
2020-07-10 tuexen Sync with FreeBSD
2020-07-10 tuexen Fix a use-after-free bug for the userland stack. Thanks to Mark Wodrich from Google for finding and reporting the bug.
2020-07-09 tuexen Optimize flushing of receive queues. This addresses an issue found and reported for the userland stack in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21243
2020-07-08 tuexen Improve consistency
2020-07-08 tuexen Fix description in error cause
2020-07-08 tuexen Don't accept FORWARD-TSN chunks when I-FORWARD-TSN was negotiated and vice versa
2020-07-08 tuexen Improve handling of PKTDROP chunks. This includes the input validation to address two issues found by ossfuzz testing the userland stack: * https://oss-fuzz.com/testcase-detail/5387560242380800 * https://oss-fuzz.com/testcase-detail/4887954068865024 and adding support for I-DATA chunks in addition to DATA chunks.
2020-07-07 yuquanw2 Yuquanw4 branch (#500)
2020-07-03 tuexen Fix compilation since last debug output cleanup.
2020-07-03 tuexen Simplify conditions and don't send ERROR chunks when not ready.
2020-07-01 tuexen Fix a bug introduced in recent cleanup
2020-06-30 weinrank Improve debug logging (#498)
2020-06-26 tuexen Remove dead assignment.
2020-06-26 tuexen No need to use a non-default C compiler on FreeBSD.
2020-06-26 tuexen Fix error handling.
2020-06-26 tuexen Fix error message.
2020-06-26 yura.yaroshevich GitHub Actions: Make builds more verbose to help understanding what went wrong. (#497)
2020-06-26 tuexen Another Windows build failure...
2020-06-26 tuexen Add missing include. This possibly fixes the builds on Windows
2020-06-26 weinrank Ekr loop refactoring (#491)
2020-06-26 timo.voelker tsctp: add parameter to get the current throughput periodically (#490)
2020-06-26 yura.yaroshevich GitHub actions: CMake is preinstalled. CPU count is fixed. (#495)
2020-06-26 lennart.grahl Clean Meson build file (#494)
2020-06-26 tuexen Fix syntax error.
2020-06-24 yura.yaroshevich GitHub Actions: switch to Ninja from "Unix Makefiles" (#489)
2020-06-24 tuexen Fix the accounting for fragmented unordered messages when using interleaving. This was reported for the userland stack in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19321
2020-06-24 tuexen Don't use an AF_INET6 address on a AF_CONN socket in the fuzzer.
2020-06-23 yuquanw2 Adding tests for ASCONF chunks (#487)
2020-06-24 yura.yaroshevich Enable GitHub actions to perform "sanity" compilatoin of new changes. (#475)
2020-06-24 tuexen Fix alignment issue
2020-06-23 timo.voelker tsctp: add partial reliability with parameters -P and -t (#485)
(...)
2020-05-10 tuexen Only drop DATA chunk with lower priority as specified in RFC 7496.
2020-05-05 tuexen Avoid underflowing a variable, which would result in taking more data from the stream queues then needed.
2020-05-05 tuexen Undo earlier change, since it is incorrect.
2020-05-05 tuexen Fix the computation of the numbers of entries of the mapping array to look at when generating a SACK. This was wrong in case of sequence numbers wrap arounds. Thanks to Gwenael FOURRE for reporting the issue for the userland stack: https://github.com/sctplab/usrsctp/issues/462
2020-05-05 ystreet00 user_recv_thread: set fd to -1 when closing (#461)
2020-04-29 tuexen Fix #458
2020-04-22 tuexen Improve input validation when processing AUTH chunks.
2020-04-22 tuexen Improve input validation when processing AUTH chunks.
2020-04-20 tuexen Honor sysctl variable sctp_no_csum_on_loopback not only for SCTP/IPv4.
2020-04-11 tuexen Zero out pointers for consistency.
2020-04-06 tuexen Be more pedantic when starting / stopping a timer.
2020-03-28 tuexen Deal with AF_CONN address in SCTP_STATUS.
2020-03-28 tuexen Fix build.
2020-03-28 tuexen Fix time to ticks conversion and vice versa. Overflows were not handled correctly.
2020-03-27 tuexen More uint32_t cleanups.
2020-03-27 tuexen Use uint32_t where intended.
2020-03-25 tuexen Don't optimize for timers when the socket is gone. This fixes another bug where the COOKIE was not retransmitted if the socket was closed.
2020-03-25 tuexen Fix handling of accepted sockets.
2020-03-25 tuexen Fix FreeBSD vnet stuff and cleanup debug output.
2020-03-25 tuexen Fix lock name in Windows.
2020-03-25 tuexen Only call panic() when building with INVARIANTS.
2020-03-24 tuexen Cleanup the timer code and also stricly check the arguments used when starting or stopping a timer.
2020-03-24 tuexen Add some lock asserts, which will be used shortly.
2020-03-23 tuexen More timer cleanups.
2020-03-21 deadbeef Get rid of unnecessary include in fuzzer (#449)
2020-03-20 tuexen Remove a set, but unused variable. This should fix https://github.com/sctplab/usrsctp/issues/447
2020-03-20 tuexen Fix a NET_EPOCH bug.
2020-03-19 tuexen Cleanup starting and stopping timers.
2020-03-19 tuexen Cleanup stream reset and asconf timer.
2020-03-19 tuexen MTU candidates must be a multiple of 4.
2020-03-19 tuexen First pass on cleanup timer code.
2020-03-18 weinrank Fuzzer (#446)
2020-03-16 tuexen Get changes in again I accidently took out.
2020-03-16 tuexen Set default MTU for an endpoint to 9000 bytes.
2020-02-18 tuexen Epochify SCTP for FreeBSD.
2020-02-17 tuexen Fix the non-default stream schedulers such that they don't interleave user messages when it is not allowed.
2020-02-12 tuexen Sync with FreeBSD.
2020-02-11 tuexen Use bool for boolean variables.
2020-02-11 tuexen Don't start a timer on a net, which has been removed.
2020-02-11 tuexen Use int instead of bool.
2020-02-09 tuexen Stop the HB and PMTU timer when removing the net, not freeing it.
2020-02-09 tuexen Cleanup timer handling.
2020-02-06 tuexen Let sctp_os_timer_start return if the timer was rescheduled. This will be used in a follow-up commit.
2020-02-04 tuexen Remove unused timer.
2020-02-04 tuexen Fix iterator.
2020-02-04 tuexen Sync FBSDIDs.
2020-02-03 tuexen Prepare location information in preparation for integrating #417.
2020-02-03 tuexen Remove trailing whitespaces.
2020-02-03 weinrank ekr_loop - Fix bug (#425)
2020-02-03 weinrank Handle usrsctp_sendv EWOULDBLOCK (#424)

Created with:
  roll-dep src/third_party/usrsctp/usrsctplib

Bug: webrtc:11899, webrtc:10322
Change-Id: I85cff712ac96f60ab06ea524e614bf458e48e7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387140Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Taylor <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806745}

Bug: b:153364303
Bug: b:153659559
Change-Id: I0a7ecedbcf043b93473334e666c93532586eca3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399122
Auto-Submit: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806744}

https://webrtc.googlesource.com/src.git/+log/8452ea86c5cb..295570eb332d

2020-09-14 tommi@webrtc.org Use PostTask instead of MessageHandler for cert generation.
2020-09-14 tommi@webrtc.org Make StunRequest not use auto cleanup.
2020-09-14 tommi@webrtc.org Avoid deallocating the async invoker when clearing the transport.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ic8089c1bd8a28722a7de49a8ecc0e27000b2f563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410608Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806743}

Allow WebView developers to disable the GPU blocklist via the dev ui for
testing purposes.

Bug: 810928
Change-Id: I4faa0bec2a2c5fa26f84e780f7505ce6e832fab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404809
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806742}

Roll Chrome Win64 PGO profile from chrome-win64-master-1600041484-a30af8f2a2acd0d94a4d04ce1984e089b193fca0.profdata to chrome-win64-master-1600084447-f1bad6c3f3b8af9e95e3b8f79a7a1df8147866eb.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I7adfa1aa97f11ee1b6407f6b4ebc73a3d511e335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410320Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806741}

When an enterprise policy disallows editing bookmarks, or a given node,
disable the Edit and Move context menu actions.

Bug: 1128028
Change-Id: Idd26a17b7201e2ffb5f67cbeb2cafd17ab577f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410824Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806740}

Roll Chrome Mac PGO profile from chrome-mac-master-1600084447-6a3b264d40de14a9dcaaf57db5d6240ab2f7fff3.profdata to chrome-mac-master-1600106373-3f2d5522687006211c1d2309732780d5029afbab.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com
Change-Id: I20a769835efe61b20be11320a5ffced879e6acb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410811Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806739}

Previously download manager may not have been initialized before we
attempted to restore downloads to holding space. This resulted in
downloads not being restored.

Bug: 1111995
Change-Id: Ie52832ff798d32a466192926302519e0c93a05da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398483
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806738}

Bug: 1119567
Change-Id: I78ce53c8fb7255315588bfd64b7044cc0c69d94c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365363Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806737}

Bug: b/167462026
Test: added new test
Change-Id: I8397cf381dffc8c7698f987a79f5b7edae5f3b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410802Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806736}

The standalone ANGLE GTest-based tests run as isolated scripts.
This change adds support to the Android test_runner.py to store the
result in the "base_test_result" format then convert these base test
results back to the JSON test result format.

Bug: 931731
Bug: angleproject:3162
Change-Id: I4d05902db0ce60c259d7127776eafc5d7864b43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407181
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806735}

These metrics were used to successfully launch https://crbug.com/875110.
They are no longer actively tracked so this patch removes them. This is
essentially a revert of https://crrev.com/767560.

Bug: 1125653
Change-Id: I1de0ad10a7fe1019989f4a02052313c95b5fbd32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408629Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806734}

Experiment enabled on canary and dev
https://critique-ng.corp.google.com/cl/330618197

This CL prepares for beta rollout

Change-Id: I21a714b24a6119856963064bb155ab6b421cef45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405905Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806733}

This change refactors PasswordsTableViewController, by adding
PasswordsCoordinator. All code related to the presenting/dismissing of
the controllers was moved to the coordinator. Mediator moved to the
coordinator as well. Cleaned includes and deps.

Bug: 1128025

Change-Id: I240cc3ff658c26ff6d9f44fada7313885dff98bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398686
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806732}

Please see bug for design doc.

Bug: 1121806
Change-Id: I9c67bc3487a64eb1b07b4d0334a63081f85c66fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404947Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#806731}

It seems possible that a race condition to happen between WebViewImpl's
CloseWindowSoon() schedules a call to DoDeferredCloseWindowSoon() and
that method actually being called: even though WebViewImpl will be
alive (otherwise the weak pointer would have prevented that callback
from being called), WebViewImpl::DidDetachRemoteMainFrame() might have
been called in between those two points, unbinding the remote and
causing the issue reported as part of crbug.com/1127329.

Bug: 1127329
Change-Id: I189fc1b38f315dc420d97eda5b5c01d346db8033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409499Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#806730}

Rollup now always reads resource files from the "preprocessed"
directory. Modify the test to account for this. Also remove the test
importing action link as there is now no manually curated list of non
generated files in rollup_plugin.js, and everything is simply read
from the preprocessed directory directly.

Change-Id: I588959f5a28f105c0006112f16be4af6dcf0819c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410443Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806729}

There are some tests there that cover parts of the spec
not covered anywhere else.

Change-Id: If853e66c6367da5ec37252177dbb911c7ffd3608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408277
Auto-Submit: Aleks Totic <atotic@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806728}

This CL adds a flag to enable and disable adding a context menu item
that allows a user to copy a URL to the clipboard that links to the page
with the selected text highlighted.

Bug: 1105862
Change-Id: I6cd57bfbb1881f4c4f7d5dd5fcbb95de7f470b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406697Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806727}

This CL makes sure that:
- flags are reset properly
- `kKnownCredentialsFetched` value is correct if already known
compromised credentials were loaded during scripts refreshment.

Bug: 1127856

Change-Id: Ia63cfd21de34bdb39265de2da81056d3966f7dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410022
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806726}

Due to required data this CL also changes
|AutofillClient::GetPageLanguage()| into |GetLanguageState()|.
This allows autofill code access to the translation state of
the page, which might be useful for future features as well.

Change-Id: I7f3333bbd5b73f71f693cbef752ab17728a59548
Bug: 1121990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377727Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Martynas Sinkievič <marsin@google.com>
Cr-Commit-Position: refs/heads/master@{#806725}

This reverts commit 077d63da.

Reason for revert:

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak

is constantly failing on

* virtual/module-top-level-await/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-order-4-tla.html
* virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html
* virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-immediate-promise.html
* virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html


Original change's description:
> [blink] Fix top-level-await error reporting
> 
> - Enable tests with TLA enabled
> - Fix top-level error reporting with TLA
> 
> Based on the discussions on the spec, we fire error events on rejection
> of the result promise:
> https://github.com/whatwg/html/pull/4352#discussion_r435178136
> 
> Bug: 1022182, 1096455c, 1127215, v8:9344
> Change-Id: I16e83cb4e279c1e44be7fa70a51a103ee94aacc3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228881
> Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Dominic Farolino <dom@chromium.org>
> Reviewed-by: Domenic Denicola <domenic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806593}

TBR=hiroshige@chromium.org,kouhei@chromium.org,cbruni@chromium.org,dom@chromium.org,domenic@chromium.org

Change-Id: I66b085b05ad30020772e80324e226275e41a8782
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1022182
Bug: 1096455c
Bug: 1127215
Bug: v8:9344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410725Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806724}

Roll Chrome Linux PGO profile from chrome-linux-master-1600084447-654ce493c2d2b8d13e6243ff3cb852a603e3ef72.profdata to chrome-linux-master-1600106373-71253587ca194e48d78c58c419f94bf1bf8da7c5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: I8e2f385bd9e256d11f99c07456cc23b0e61a6b2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410807Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806723}

This is a no-op CL that adds an ID needed by http://crrev.com/2386376.

TBR=yusufo@chromium.org

Bug: 1116644
Change-Id: If1826bf79adfc78364a0897d1719dae5a41cbcf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406836
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806722}

Session restore uses history.pushState to inject URLs and titles into
each WKWebView session.  For large numbers of pages, this can generate
a very large number of IPC calls. iOS 12.2 introduced IPC throttling
that can delay the async pushState calls before the sync history.go
call. This was worked around via a check to see when all the push state
calls are correctly processed.

iOS14 introduced an optimization which breaks the above mentioned
workaround.  Instead, this change uses our own IPC call to native code
(which will be enqueued to the end of the IPC queue) to finalize session
restore.

The effect is faster restore for the average case, but slightly slower
restore for the edge case of a large numbers of pages.

Bug: 1127521, 1126863
Change-Id: Ibb70008afef312897e8165e06f16ed5c03808b38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407332
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806721}

The string-based version of this function takes const inputs, but the
vector-based one did not. Align them so that the vector-based function
is more general.

Change-Id: I25ee663cc1d35fa9b0bb6cffc33dd0cd8b460423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404067Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806720}

This CL adds the following a11y support to the GTS:
  * Requests focus to the currently selected tab after GTS is finished
    showing.
  * Updates the close button content description for individual tabs and
    tab groups with or without group name.

This CL also updates the placeholder for the
accessibility_close_tab_group_button_with_group_name string.

Note: set `Skip-Translation-Screenshots-Check: True` to bypass error
since the screenshot is the same before and after editing the string.

Everything introduced in this CL is gated by by Finch parameter
"enable_launch_polish" under flag "enable-tab-grid-layout". The changes
in TabSwitcherCoordinator is also gated by the Finch flag
"enable-tab-groups-continuation". Most of the code is verified to be
behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled
by formal equivalence checking tool here: http://crrev.com/c/1934235.
The changes in following files can't be verified by the tool, but it is
expected and no-op without both flags:
  * new property in TabProperties
  * StartSurfaceLayout#canHostBeFocusable is the only diff
  * Lots of diffs in language files due to the string placeholder
    change

Skip-Translation-Screenshots-Check: True
Bug: 1124921
Change-Id: If665464d82f83596c93449e8910878b4c00d02cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402302
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806719}

These files, from
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-00*,
have ~20 test cases each. Chrome fails some of them but not others. With
check-layout we can use -expected.txt files to prevent regressions for
the cases that we pass.  With the current ref tests, we have to disable
an entire file if we fail even one case in it.

No expectations were changed in the porting. You can see exactly which
lines changed at [1], because it doesn't rename the files.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2387420

Change-Id: I6fa59df56599c15cccddba4c77afcad6668b9f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387148Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806718}

Bug: 1127518
Change-Id: I9639b5b047033ec92331a2dc5bb8541e4e08546c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406667
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806717}

Currently, Removable Media is watched at the top-level directory under
/media/removable. Unfortunately, this only works if the removable media
was attached before the inotify is attached (since inotify does not
detect mount event).

This changes listen to the mount events from cros-disks through
ArcVolumeManager (to synchronize with Android volume mounting) and
create a FilePathWatcher per removable media.

BUG=b:150883493
TEST=Mount invisible removable media, the media changes are indexed.
TEST=Reboot DUT with non-visible removable media attached, still indexed.
TEST=Change the removable media to be visible, still indexed.
TEST=Reboot DUT with visible media attached, still indexed
TEST=Change the removable media to be invisible, still indexed.

Change-Id: Ia02012676681e025431d74f2c3f9b951a77ca783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362376
Auto-Submit: Risan <risan@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Risan <risan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806716}

mini_installer recursively deletes directories left behind from previous
runs. As it recurses through them, it may delete files with reparse
points in those dirs. This is bad, since such files may actually be
maliciously-created links to other entities on the filesystem. This CL
skips anything with a reparse point during deletion -- since Chrome
never creates files/dirs with reparse points, it shouldn't try to delete
them.

BUG=1125018
R=wfh@chromium.org

Change-Id: I9897947ed883a91758c31990ed0b9648c38d2942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409698
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806715}

Using wpt-import in Chromium 91b2c272.
With Chromium commits locally applied on WPT:
0cd6359d "Modify failing cookie WPTs to use HTTPS"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: If882f7400fbbf9e8d5778bae83d01037ad18fee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409923Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806714}

This CL is a refactor with no intended behavior change. It updates the
method parameter from Callback -> OnceCallback.

Bug: 1127505
Change-Id: I8848dbf345db44a278e9a9cd59e0cebb20b0e5c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406590
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806713}

This allows small raster scales like we see for some directly
composited images to not trip over this particular DCHECK. Since these
raster scales are all chosen by inverting the minimum dimension of the
layer bounds, these minimum values round trip, and the resulting tiles
won't be empty as they are doing a EnclosingContentsRectFromLayerRect
to compute the tiling (and tile) size.

Bug: 1124342
Change-Id: Ifb364e7d569d66903a04f9e4c80d56fc3ef8b9da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398985Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#806712}

The window containers for wallpaper all have fill layout, there is no
need to set the bounds manually.

Bug: None
Test: manual and unit test
Change-Id: I60cd9940ec64ab4afe924377cabe8dd7b6b6e908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406670Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806711}

These targets fail to build if depended upon without
`enable_media_drm_storage`, so prevent that from being possible.
Split out from crrev.com/c/2383400

Bug: 898837
Change-Id: I7e0b94d81d2a722d93e41188812d532533a0255c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407420
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806710}