GitLab

Mash browser tests do not support this test (see patch set #2 trys) so
disable it in mash.

No-Tree-Checks: true
Bug: 836254,701924
Change-Id: I3266d131b84c261e5bb6b9358b7c9132172bbabf
Reviewed-on: https://chromium-review.googlesource.com/1029470Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553877}

This reverts commit 116dd7c3.

Reason for revert: broke https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac%20Builder/240835

Original change's description:
> Replace hermetic Xcode installation with CIPD-based flow.
> 
> The 'API' to the scripts remains the same, only the delivery mechanism changes.
> 
> BUG=797051
> R=​erikchen@chromium.org, justincohen@chromium.org
> 
> Change-Id: I8ee5486b107061f9fb6e64354463ac51de53d4cc
> Reviewed-on: https://chromium-review.googlesource.com/887819
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553871}

TBR=erikchen@chromium.org,justincohen@chromium.org,sergeyberezin@chromium.org,jbudorick@chromium.org

Change-Id: Icdd25e048a8ed6de19b7a98e41a438c1c7c6ed2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 797051
Reviewed-on: https://chromium-review.googlesource.com/1029630Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553876}

Using DecoderBuffer removes the need to provided SharedMemoryHandles in
cases that SharedMemory is not already allocated (in particular, when
VDAs are used through MojoVideoDecoder+VdaVideoDecoder). Since
base::SharedMemory is not an interface, a new type is required, and
DecoderBuffer already implements a suitable interface for this use case.

This CL adds:
  - A VideoDecodeAccelerator::Decode() overload for decoding
    DecoderBuffers, which VDAs may optionally implement.
    Note that VdaVideoDecoder will require this, and therefore all VDAs
    will be updated to support DecoderBuffers over time.
  - Support for SHM in DecoderBuffer. This eases the transition by
    allowing BitstreamBuffers to be easily converted to equivalent
    DecoderBuffers.
  - An implementation of the new VideoDecodeAccelerator::Decode()
    overload in VTVideoDecodeAccelerator.
  - Calling the new overload from VdaVideoDecoder.

Originally landed as 4596c802. This
reland removes a DCHECK() in unaligned_shared_memory_unittest.cc so that
SHM is still allocated when DCHECKs are disabled.

Bug: 522298
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id5d6bb103070dfcb23e3db82c68d2ead23b9e3b5
Reviewed-on: https://chromium-review.googlesource.com/1028834
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553875}

The icon itself lives in //third_party/libapps/nassh/images/dev
and is only used in chromeos. We allow chromeos to scale the icon from 192
to the device-appropriate size.

Bug: 813699
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I01385219919686915abbfddbc7032adff6aab3a0
Reviewed-on: https://chromium-review.googlesource.com/1025470Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553874}

Add UpdateSettings API for update settings ui request.

Bug: 819782
Test: Manual Test
Change-Id: Ibd7c303da98f0bc95b53ac08c365cc4276ac605f
Reviewed-on: https://chromium-review.googlesource.com/1016039
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553873}

See go/closure-compile-gn for details.

This CL converts the Closure Compilation of the file manager from GYP to
GN, and fixes a number of type-checking issues that were somehow
suppressed due to the way the compiler used to be run.

A local closure compile can be run by setting closure_compile = true in
args.gn, and then running ninja -C out/Default webui_closure_compile.
A more localized compile may look like:
ninja -C out/Default ui/file_manager:closure_compile

Bug: 632206
TBR=tbreisacher@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic95ae50ee2e61cb6b5432cb4c5e13a8ac3b2bb44
Reviewed-on: https://chromium-review.googlesource.com/1018684
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553872}

The 'API' to the scripts remains the same, only the delivery mechanism changes.

BUG=797051
R=erikchen@chromium.org, justincohen@chromium.org

Change-Id: I8ee5486b107061f9fb6e64354463ac51de53d4cc
Reviewed-on: https://chromium-review.googlesource.com/887819Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553871}

Change-Id: Iab1194d9b98a6460847627e94fb385ce31db43ea
Reviewed-on: https://chromium-review.googlesource.com/1028456Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553870}

It's not used anymore.

Bug: 672962
TBR: tsepez@chromium.org
Change-Id: I7e1485259d42a3396337db0d54a1c9f4ab561b01
Reviewed-on: https://chromium-review.googlesource.com/1029128Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553869}

Bug: 831585
Change-Id: I3436ca3abe39a648a150d703173715f69756e508
Reviewed-on: https://chromium-review.googlesource.com/1028009
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553868}

BUG=836858

Change-Id: I34333a72501129fd40b5a9aa6378c9f35f1e7fc2
Reviewed-on: https://chromium-review.googlesource.com/1028511Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553867}

Restructured and updated doc on content scripts.
Included more code samples and further explained
different script insertion types.

Change-Id: I93bf8d111078eb34e78ffd1a1fbae696c521c019
Reviewed-on: https://chromium-review.googlesource.com/698290
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553866}

SearchResultMetadata holds the information that shared between Chrome
and Ash. It'll act as the basic data structure to represent a search
result over IPC.

This commit also:
- adds missing stuff in app_list_struct_traits.h;
- adds more result types since we'll not pass kUnknown type over IPC;
- adds a display score to SearchResult, which is currently mixed with
  relevance.

Bug: 733662
Change-Id: I6b29d2d7bc4f7287f373c6c1083f382f5f0f781b
Reviewed-on: https://chromium-review.googlesource.com/998681
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553865}

This coordinator manages the BrowserContainerViewController, which
displays the main web page content view.  This is in preparation for
a new fullscreen implementation experiment where the container will
conform to FullscreenUIElement.  The coordinator can setup and tear
down FullscreenUIUpdaters for the BrowserContainerViewController upon
starting/stopping.

Bug: 836400
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4054c279dcabe2a8f88ebb769ae40d1d15f07b67
Reviewed-on: https://chromium-review.googlesource.com/1026564Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553864}

StartupHelperBrowserTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: Ib11500da4e22cd74f60193e5fd3d3c0368fb686f
Reviewed-on: https://chromium-review.googlesource.com/1024600Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553863}

According to the updated UnfiiedSystemTray spec, #F1F3F4 is the correct
color for icons and label texts instead of #F1F2F3.

TEST=manual
BUG=836255

Change-Id: I7e12ac297e69cebe8db7704ef59f99dec9845729
Reviewed-on: https://chromium-review.googlesource.com/1027571Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553862}

This CL adds SystemNotificationController that owns notification
controllers that are recently splitted from SystemTrayItems.
This CL also fixes initialization and destruction ordering of
SystemTrayModel and SystemNoticationController.

Other notification controllers might be added to
SystemNotificationController later.

TEST=ash_unittests
BUG=none

Change-Id: I13ac5e4f77ca7afbfe6f53753d207f29861448bf
Reviewed-on: https://chromium-review.googlesource.com/1025433Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553861}

Remove Extension::ScopedAllowLegacyExtensions and
ExtensionBrowserTest::ShouldAllowLegacyExtensionManifests(). These are
both unused now that all the affected tests have been updated.

Leave in the commandline flag kAllowLegacyExtensionManifests. This can
still be useful as a last resort for loading a v1 extension, and
there's no harm in leaving it in since we've removed all manifest
v1-specific handling (that is, all extensions loaded will effectively
be treated as v2).

Bug: 816679
Change-Id: I673bee01d00eaf7b82e1996da84f9b44e090aaf9
Reviewed-on: https://chromium-review.googlesource.com/1029000Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553860}

Add native validation for bindings when passing the response back to
the caller that the response fits the values specified in the schema.
Do this by adding the expected callback signature to the type
reference map, and then matching the returned values against that
signature.

Given the performance cost, we don't want to check these values by
default. Instead, only do so if response validation is enabled. Outside
of testing, this is currently only true for debug builds; this matches
current behavior for JS bindings as well. However, this is easily
tweakable by a boolean, which could be linked to a finch feature if we
so desired.

Additionally, tweak matching against expected signatures for responses
to be stricter than signature matching for callers. This is because we
want to ensure that extensions are invoked with the appropriate
arguments at the appropriate indices, rather than needing them to do
our own complicated signature matching. This is a behavior change (and
and improvement) over current JS response validation, since it will
require that every response is truly valid, rather than being able to
be mutated into something valid.

Add unittests for all affected systems, including response validation,
signature matching, and callback signature parsing.

Bug: 829913

Change-Id: Ib630b3bee935f54e252f66bba7bccf14724adfa9
Reviewed-on: https://chromium-review.googlesource.com/1011407
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553859}

This is consistent with public/platform/modules/cache_storage and
content/*/cache_storage.

Change-Id: Idb67f16bccfce3f035a9375e10a5ea5f4a99647f
Reviewed-on: https://chromium-review.googlesource.com/1028998Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553858}

Show all processes and threads for generic traces.

BUG=836030

Change-Id: Ib8486667328a726f771f888c0ccf6f2e269c37f8
Reviewed-on: https://chromium-review.googlesource.com/1025136
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553857}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/47b24cc1ce35..ad0b2d2757e8

$ git log 47b24cc1c..ad0b2d275 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 dgarrett config_lib: Add luci_builder build config value.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:832747


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ida61a24a67a28c35a7f9faa2ab4262fafe948a40
Reviewed-on: https://chromium-review.googlesource.com/1029178
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553856}

Marks common callbacks that produce no JS-observable side-effect, yet
may update Blink's style, layout, or scroll subsystem.

Bug: 829571
Change-Id: I0c0ef5766bdf3f246b2e7889ba70acc955a1a44b
Reviewed-on: https://chromium-review.googlesource.com/1024865
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553855}

Bug: 764474
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5816500cce7477784e948636e5f5f8a5b48c1062
Reviewed-on: https://chromium-review.googlesource.com/1028976Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553854}

Move the files to ash and ownership to Shell.

Bug: 647781
Change-Id: I1efe7dec0d9cd429f3ed9ff2295c612c90ffa800
Reviewed-on: https://chromium-review.googlesource.com/1028980
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553853}

This roll has only one change as recorded in
 https://chromium.googlesource.com/chromium/deps/icu/+/e4194dc7 .

It's to update language tags/subtags handling.

TBR=gsathya@chromium.org

Bug: v8:7669, v8:5693
Test: v8 - test262/intl402/language-tags-canonicalized.js
Test: v8 - test262/intl402/Intl/preferred-variants.js
Test: v8 test will be added and updated.
Change-Id: Iad79448fa85bc621232edcae1aec375b3265b2ef
Reviewed-on: https://chromium-review.googlesource.com/1028719Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553852}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=eugenebut@chromium.org

Bug: 825327
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic89cc4297947534db6418c8c1b65f18a9528c71f
Reviewed-on: https://chromium-review.googlesource.com/1024872
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553851}

Bug: b/78590993
Test: On device, with another change.
Change-Id: I5d76e2dc4c6915b28db84bb868fcc1e23bf48d34
Reviewed-on: https://chromium-review.googlesource.com/1029196Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Tommy Li <litommy@google.com>
Cr-Commit-Position: refs/heads/master@{#553850}

The APN list UI incorrectly assumes that the user specified APN would
never match any APN found in shill's mobile operator database. If a user
specifies an APN that matches an existing APN provided by shill, the UI
goes into a weird state as described in b/78199279. To help resolve the
ambiguity situation, we leverage the fact that APNs are case sensitive.
This CL changes the APN list UI to store the user specified APN in all
upper case, while CL:1028794 normalizes all APNs in shill's mobile
operator database to all lower case.

      in the APN list. Verify that the user specified APN is stored in
      all upper case and the issue described in b/78199279 is not
      observed.

Bug: b/78199279
Test: Specify a custom APN with value that matches an existing one found
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I51994c87442c6e0a34e1637a8bf98b143f497059
Reviewed-on: https://chromium-review.googlesource.com/1028971Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553849}

This makes Refresh use the trailing NTB for high-contrast RTL on Windows, where
we draw with the native frame and the caption buttons are on the right (i.e.
leading) edge.

BUG=822063
TEST=none

Change-Id: I92b58e1db4aef83d76e6e64abb93f9549db84067
Reviewed-on: https://chromium-review.googlesource.com/1029197Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553848}

It's not a valid test case. According to the spec, SVG elements are
considered monolithic and are not supposed to be fragmented. The current
"slicing" behavior will be fixed in layout_ng.

https://www.w3.org/TR/css-break-3/#end-block

Bug: 807382
Change-Id: I3cd1c8f09341952fd981fabfe8a81d2873665a1e
Reviewed-on: https://chromium-review.googlesource.com/1028933Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553847}

Change-Id: I67162d0c055d49e29e0e22687db8c56e7d8f850c
Reviewed-on: https://chromium-review.googlesource.com/1028757
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553846}

If the AdTracker sees an ad script in the stack when a frame is created,
or its parent frame is thought to be an ad, label the LocalFrame as an
ad frame. The subresource filter will then label subsequent requests in
that frame as ad requests.

A future CL will handle situations where the frame changes processes.

Bug: 807640
Change-Id: Ie4d3bab747c3158d310652f6376cc79f6da38b7a
Reviewed-on: https://chromium-review.googlesource.com/1019743
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553845}

Following bot results are included.
4953 4958 4961 4966 4967 4969 4971 4977 4978 4982 4985 4986
4990 4992

5 lines were removed and 10 lines were deflaked by consecutive
results since 4905.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I14beab6e153fac6095ff47d01ad657e8dfb47223
Reviewed-on: https://chromium-review.googlesource.com/1025538
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553844}

Highlight the first search result immediately after finding it while the
search continues onwards. Instead of waiting for all the search results
to return before highlighting the first search result.

BUG=764635

Change-Id: I445ffb88527bd592fc5a51d499ea90d752a88918
Reviewed-on: https://chromium-review.googlesource.com/1013748
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553843}

Pass receiver list to Android to restricted packages which can receive
the USB event.

Bug: b/78231419
Test: Manual
Change-Id: I3938fb5b105eb95017ee0e34136ad78a70fd03c6
Reviewed-on: https://chromium-review.googlesource.com/1017809Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#553842}

The app no longer renders the first frame after we recreate the renderer
context when the app resumes. User has to move the cursor or viewport
to get the frame rendered. That's because we didn't set the transformation
matrix after the renderer context is recreated.

This CL makes GlRenderer cache the viewport matrix and set it on the
canvas when the canvas is recreated.

Bug: 836975
Change-Id: I3d4bb2575aa59f9148181104f320cf7a72770ad5
Reviewed-on: https://chromium-review.googlesource.com/1028848
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553841}

Disabled test, but fixed in issue 829310. Running this test locally in
DEBUG, no flakes. Re-enable this test on all chrome-os bots.

Mash browser tests do not support this test (see patch set #2 trys) so
disable it in mash.

Bug: 836254,711290
Change-Id: Ieac0fea5b568f738fda04bddc8c8dcc488f83887
Reviewed-on: https://chromium-review.googlesource.com/1028534
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553840}

`ThisExpression` is not considered an `Identifier`, but it should
similarly have no side effects.

Change-Id: I894869716541dd9692d96938db76b2b3a1d3b1a1
Reviewed-on: https://chromium-review.googlesource.com/1028187Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553839}

Kim points out in the bug that the current logic (see
https://chromium-review.googlesource.com/c/chromium/src/+/991073)
doesn't allow dev tools to be focused, so it's not possible to trigger
webauthn requests from the dev tools console.

Nasko thought that the addition of a ContentBrowserClient API was too
large a hammer too. I've not been able to come up with any cleaner
solution however, but this change perhaps makes the hammer more
reasonable:

In order to address the devtools issue, this change switches the focus
check to requiring that the tab be active in the focused window. (This
also matches what the cryptotoken extension does.) This means that it
has to chrome/ logic, rather than content/ logic, but we already had to
add an API to ContentBrowserClient for this and we can reuse that to
solve this problem too.

Additionally, this change adds an interactive_ui_test to ensure that we
don't regress.

Bug: 827266,836203
Change-Id: I62226fc0366a83dc69d9cb32016108bdbe590d29
Reviewed-on: https://chromium-review.googlesource.com/1007637
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553838}