GitLab

This release contains a bugfix required to generate Android
app bundle APKs archives that can be installed on all devices.

For more context, see:
https://buganizer.corp.google.com/issues/110777526

BUG=846633,820459
R=agrieve@chromium.org, bensmason@chromium.org, yfriedman@chromium.org

Change-Id: Ic71445f49a4548c8610f5d18598cdd3d3d5692c4
Reviewed-on: https://chromium-review.googlesource.com/1135127Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574608}

Temporarily add missing deps to the depfile. Will no longer be necessary
once all downstream targets are fixed.

Bug: 843562
Change-Id: Id797ea032a6a3818dac6013dcacb6f68baef2b6b
Reviewed-on: https://chromium-review.googlesource.com/1134884
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574607}

This CL also makes ExtensionMsg_Load_Params non-copyable. There
shouldn't be any behavior change in this CL.

Bug: 556939
Change-Id: If7d11919f8fee0442578371d44d6b715d08efe3a
Reviewed-on: https://chromium-review.googlesource.com/1132572Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574606}

https://webrtc.googlesource.com/src.git/+log/58c79f66dd3a..798ee75d2365


git log 58c79f66dd3a..798ee75d2365 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 kthelgason@webrtc.org Always disable RED when ULPFEC is disabled.
2018-07-12 hta@webrtc.org Buffer ICE candidates that can't be added immediately.


Created with:
  gclient setdep -r src/third_party/webrtc@798ee75d2365

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia3faf57f19146a8b08a9a5cbe8915a9750b91210
Reviewed-on: https://chromium-review.googlesource.com/1135226Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574605}

All unified consent services are enabled when the unified
consent is given through the OneClickSigninSyncStarter.

Bug: 862202
Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
Reviewed-on: https://chromium-review.googlesource.com/1135001Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574604}

This reverts commit 8e9dbcd3.

Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which will mean doing the plumbing that the below CL was looking to avoid. This is all sad-making, but c'est la vie.

Bug: 856771, 794105

Original change's description:
> Have Device Service observe MessageLoop destruction
>
> The Device Service needs to clean up parts of its internal state as part
> of browser shutdown. However, it also needs to run on the UI thread,
> and embedded services that run on the UI thread are not guaranteed to
> be destroyed as part of browser shutdown (tasks to destroy these
> services are posted from the IO thread by
> ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
> typically shut down before these posted tasks are run).
>
> To solve this issue we discussed adding plumbing wherein embedded
> services could inform //content that they wanted to be notified when
> shutdown was occurring on the main thread. However, on investigation
> this plumbing would be painful to implement: it is only
> EmbeddedInstanceManager that has direct information of these service
> instances, and that object lives far away from //content's
> ServiceManagerContext, the object that knows when shutdown is occurring
> on the main thread.
>
> This CL takes an alternative approach of having the Device Service
> implementation observe the destruction of its MessageLoop. I have
> verified that the observation is triggered on shutdown of Chrome.
>
> Bug: 794105
> Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
> Reviewed-on: https://chromium-review.googlesource.com/1099245
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567260}

TBR=rockot@chromium.org,blundell@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 794105
Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
Reviewed-on: https://chromium-review.googlesource.com/1134887
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574603}

This is a follow-up CL per comments at:
https://chromium-review.googlesource.com/c/chromium/src/+/1120955

This CL adds comments to //components/variations/variations_http_header_provider.cc
to document how adding/removing http headers for web content requests are
implemented differently when Network Service is enabled or not enabled.

Bug: 841309
Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
Reviewed-on: https://chromium-review.googlesource.com/1134408Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574602}

AutofillProfileEnabled was added as a preference setting in 1127344.
This CL creates a policy flag for AutofillProfileEnabled that can
overwrite the user preference.

Bug: 860526
Change-Id: I5d4848c26a53cf163fc4557d9b2da5f597bd98cf
Reviewed-on: https://chromium-review.googlesource.com/1127463Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574601}

Tbr: tkent@chromium.org
Bug: 863067
Change-Id: I9f043eec8363dbb26ccaa8d901321e0d579f1a4f
Reviewed-on: https://chromium-review.googlesource.com/1135433
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574600}

After tapping Download this test opens a separate tabs and loads the URL
there. Then closes the tab and waits for the download completion.

Bug: 854232
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id05c9344d1da80a57b6c7cc663b2b8a835f18e82
Reviewed-on: https://chromium-review.googlesource.com/1111916
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574599}

When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
prematurely and landed the change without my changes that addresed
review comments. Landing them separately.

Bug: 856416
Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
Reviewed-on: https://chromium-review.googlesource.com/1133968Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574598}

+ Implement NewTabPageLayout.ScrollDelegate to the FeedNewTabPage
+ Refactor snap scroll logic to a new class to make it reusable
+ Add top padding for the FeedNewTabPage to display correctly on tablet
+ Fix a small bug that search box is not enabled after auto snap scroll

Bug: 860028, 860032, 862470
Change-Id: I5bda9696a4515281378c1effe47b6ad47fdd4c49
Reviewed-on: https://chromium-review.googlesource.com/1133594Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574597}

These were added during android swarming bring-up.  We shouldn't use
per-bot exceptions for this.

Also remove a random sharding setting for base_unittests on ToTMac
that doesn't look necessary.

Bug: 843511
Change-Id: Ia20771786f1b4106cd86d24d446e0a66f319dbff
Reviewed-on: https://chromium-review.googlesource.com/1134531Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574596}

Table's min-content already honored it.

We'd apparently never been bitten before by tables occasionally having
min-content > max-content. A new DCHECK in LayoutNG exposed it.

Bug: 857185
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I49009a4988fbf38c1bf745a4f028e4e8b050804b
Reviewed-on: https://chromium-review.googlesource.com/1121251
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574595}

The cleaner success string now has HTML in it, and the JS i18n
function strips it off. i18nAdvanced allows us to let the <a> through to
the string, but the way the cleanup result page works is it simply sets
the card text variable ("title") to the result message string. This
would result in the raw string (with HTML) getting displayed, so the
title variable needs to also be set to be the inner-h-t-m-l.

Bug: 853339
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
Reviewed-on: https://chromium-review.googlesource.com/1134191
Commit-Queue: Nick Burris <nburris@google.com>
Reviewed-by: proberge <proberge@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574594}

Bug: 850512
Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
Reviewed-on: https://chromium-review.googlesource.com/1128839
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574593}

Bug: 863042
Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
Reviewed-on: https://chromium-review.googlesource.com/1135288
Commit-Queue: Mike Reed <reed@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574592}

Add a flag to force showing the disclosure for developer convenience.
Also trigger even when there isn't an active tab yet.

Bug: 813100
Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
Reviewed-on: https://chromium-review.googlesource.com/1116922Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574591}

Bug: none
Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
Reviewed-on: https://chromium-review.googlesource.com/1134499
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574590}

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1127565
I didn't understand filecmp.dircmp.

Changed to use md5_check.CallAndRecordIfStale instead.
Also let ExtractAll create directory even when it is empty.

Bug: 810298, 860251
Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
Reviewed-on: https://chromium-review.googlesource.com/1132818Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574589}

Simplifying the FakeGaiaCookieManagerService API by not requiring to
call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
instead a member of the FakeGaiaCookieManagerService.

This API simplification is in preparation for switching GaiaAuthFetcher
to use the SimpleURLLoader (network service).

Bug: 840396
Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
Reviewed-on: https://chromium-review.googlesource.com/1114226Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574588}

The only place where it was actually used was in
GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
call to the GraphicsLayerClient.

BUG=823365
R=pdr@chromium.org,skobes@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
Reviewed-on: https://chromium-review.googlesource.com/1132536
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574587}

The "latency" category looks like a perfect event category for ETW
tracing. In particular, TabSwitching::Latency indicates when Chrome
thinks that tab switching has started and stopped which allows it to be
profiled in detail. This has revealed where CPU time is going, and how
long the delay is from when the keyboard event is generated to when
Chrome starts officially processing it. This was helpful in
investigating tab switching latency in bug 858944.

This will require an update to UIforETW to fully enable, which I have
done locally for testing purposes.

Bug: 858944
Change-Id: I4797b804ea6d35458aa3b4e876a78172a29d5131
Reviewed-on: https://chromium-review.googlesource.com/1134516Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574586}

This was a computed by constructing the border path and computing the bounding
box.  However, it was only used for the ink drop, and ink drops are only used in
newer material mode, where the border path is a square.

Instead, we can use GetContentsBounds(), as long as those are actually
positioned correctly.  The new tab button has empty space at the top, which is
included (by the tabstrip) in its size and accounted for when doing painting and
hittesting.  By adding an empty top border of this thickness, a lot of this code
can be simplified.  (Further simplifications are coming in a subsequent CL.)

Bug: none
Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe
Reviewed-on: https://chromium-review.googlesource.com/1134399Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574585}

This is a follow-up of crrev.com/c/1131680 and replace a custom view
to simulate a separator with a views::Separator view.

Change-Id: I0dc1db9c31039ce0959fa4aa4d37e4e99745a2d1
Reviewed-on: https://chromium-review.googlesource.com/1133328
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574584}

Remove a redundant URLPatternSet comparison method from
ScriptingPermissionsModifier unittests, instead leveraging the
string comparison and gmock utilities. These are slightly less code
and offer better failure messages.

Bug: None

Change-Id: Ic8b99f0c9294658d6bdd16738f179a2e352eb408
Reviewed-on: https://chromium-review.googlesource.com/1134496
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574583}

- Sets the fallback monogram and background colors to a constant color.

Collections flag off screenshot: https://drive.google.com/file/d/10fYA9oHwx_o3cGWXBSR5P4qXKIPDTcfm/view?usp=sharing
Collections flag on screenshot: https://drive.google.com/file/d/1WtAYb-fPE6QdR4rIpcWxuZtLjGr7iPNQ/view?usp=sharing

Bug: 851390

Change-Id: I7d67a4129263b2deed52eb7603b3f84aa8b8a201
Reviewed-on: https://chromium-review.googlesource.com/1125271
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574582}

To gather some stability enable it for experimental features before
we do the origin trial.

BUG=348877

Change-Id: I7598f35ac87b719305c6efa98c37de2eec8031a4
Reviewed-on: https://chromium-review.googlesource.com/1134883Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574581}

Switch from --full being optional to --fast being optional. Quite a few
users of generate_gradle.py have found it unintuitive to have red
underlines by default.

Bug: 620034
Change-Id: I24a19e16ed21baa19bde97bb2f3077430a73d148
Reviewed-on: https://chromium-review.googlesource.com/1134882
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574580}

These tests are flaky on Debug builds and *San bots. These tests sends
synthetic gesture event and measure scroll offset. It should be fine
without coverages on Debug and *San builds.

TBR=sahel@chromium.org, tdresser@chromium.org

Bug: 855979, 833015
Change-Id: I009d3557454e0aab960d35fc5256ed487c2e47fe
Reviewed-on: https://chromium-review.googlesource.com/1135195Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574579}

Two different bubbles needed the same time constant and when
they got copies of the constant that broke certain jumbo
builds. This merges the constants to a single constant.

It also changes type to base::TimeDelta which is the actual
type needed and since the addition of constexpr can be used
in global constants.

Bug: 852904,862397
Change-Id: I52a63d3301efb1c7aec55541c15427c5d96ba524
Reviewed-on: https://chromium-review.googlesource.com/1134998
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574578}

This reverts commit bcae87b0.

Reason for revert: This didn't actually fix the problem and
I didn't catch it due to a mistake in testing. The real
problem is that the restore_session request started in 
WKBasedNavigationManager::Restore() was not run, because
|_containerView| is not yet initiated in the new CWVWebView.

Original change's description:
> [Nav Experiment] Add a wait after restore session.
> 
> This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
> enabled. A better approach would be to turn this test into a
> programmatic test so both navigation managers implementations are
> tested, but web::features symbols are not exposed in ios/web_view.
> 
> Bug: 862714
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
> Reviewed-on: https://chromium-review.googlesource.com/1134046
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574367}

TBR=eugenebut@chromium.org,danyao@chromium.org

Change-Id: Ia9d2d127e18264fbf69786c58b71706e0b34ead5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862714
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1135346Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574577}

This class was renamed from Scroller here: crrev.com/c/1087641. Update the
conditionals so that Scroller is only used on non-Android Cast builds,
and MobileScroller is used on Android Cast builds.

Bug: internal b/111287588
Test: Compiles

Change-Id: I19dc01e1339016e3db2ab3b7d81a95efc5c6a0f3
Reviewed-on: https://chromium-review.googlesource.com/1133761Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574576}

For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.

Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.

In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.

The following CL will be solve the triggering logic with the imported_credit_card_record_type.

Bug: 852904
Change-Id: I01191cb8a9d0a3bf954874e6c8beb62d3b02c1ea
Reviewed-on: https://chromium-review.googlesource.com/1134388Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Cr-Commit-Position: refs/heads/master@{#574575}

This might not be the case in general. Not only could a output directory
exist elsewhere altogether (though this only fixes one issue that breaks
when you do that), but it could be a symlink or another filesystem; in
such cases git does not consider it part of the repository.

This can be addressed by explicitly giving the path to src.git when issuing
git commands.

Change-Id: Ibf62466548e15d6ef57ed1e959d507ff70076352
Reviewed-on: https://chromium-review.googlesource.com/1131842
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574574}

ContextMenu interaction with other events is a suspected cause of
flakiness of the original test. This CL is separating it from the
rest as a potential fix.

Bug: 846750
Change-Id: I3d452388be65984ca82238d55a938d7a273fcf3f
Reviewed-on: https://chromium-review.googlesource.com/1134180Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574573}

Undo revert in https://crrev.com/c/1134144 which didn't end up being
needed. Revert was in response to FindIt and failures in
SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest but that problem
had already been addressed.

TBR: jonross@chromium.org
Bug: 848825, 848348
Change-Id: Ie00ce45db8b380847dddf4fb099a120ce7ada987
Reviewed-on: https://chromium-review.googlesource.com/1135146Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574572}

Updates the logic to switch between larger and smaller fonts, replaces
security state and voice/share icons.

Bug: 856542
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecc5da700dd9b3004e8480abaa842dc6e143bdca
Reviewed-on: https://chromium-review.googlesource.com/1135128Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574571}

Using wpt-import in Chromium d18929b4.
With Chromium commits locally applied on WPT:
a9045946 "Add a fail-fast for longtask layouttests"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21188

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
jsbell@chromium.org:
  external/wpt/encoding
kojii@chromium.org:
  external/wpt/css/css-writing-modes
mlamouri@chromium.org:
  external/wpt/screen-orientation

TBR=foolip

No-Export: true
Change-Id: Ib04131d32533fd3a6687cc2999f6a0b409f08165
Reviewed-on: https://chromium-review.googlesource.com/1134875
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574570}

Also rewrite FakeConsentAuditor to implement the interface instead of
inheriting from the implementation. This unblocks enabling the separate
datatype feature by default.

Bug: 862186
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I474f74f12278221ef6278c120576f1ff1a224c4a
Reviewed-on: https://chromium-review.googlesource.com/1131508Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574569}