- 29 Jul, 2019 40 commits
-
-
Guido Urdaneta authored
This CL: 1. Moves content::MediaStreamDeviceObserver to blink/renderer/modules/mediastream, including the header. This type implements a Mojo interface, so its header cannot be on blink/public. 2. To allow existing content clients to interact with MediaStreamDeviceObserver, a thin wrapper called WebMediaStreamDeviceObserver was added to blink/public (header) and blink/renderer (implementation). 3. Blink-specific bindings for MediaStream typemaps are now generated. 4. The MediaStream typemap is updated to account for dependent media types. 5. MediaStreamDeviceObserver is updated to register with the frame's mojo interface registry instead of using its own registry. This allowed breaking the dependency on RenderFrameObserver, which was used to detect requests for interfaces made to the frame. Bug: 704136 Change-Id: Iaa191c0e990910dd2fcb512d4655abc91d56a2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718379Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#681881}
-
Dominic Battre authored
This CL makes the logging of table rows easier to comprehend and shaves off a few characters of each line logging table rows. Bug: 928595 Change-Id: I35db6d7ddd06d184a6c14fc28847888ee3390b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722951 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#681880}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If18912933ab3e45af55ab052654c5a3d6389e298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700911Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681879}
-
Becca Hughes authored
Add a color type to MediaImageBitmap. The default color type (N32) is platform specific and is an alias for either RGBA_8888 or BGRA_8888. When deserializing we will convert all images to the platform default. The color type tells us the original color type of the image which may be different if it came from ARC or Chrome. ARC only supports RGBA_8888 and images from ARC will fallback to RGBA_8888 which is the default value. BUG=987814 Change-Id: I9fed118c85e29a24c232bc3adc52cdf64988bd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717168 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#681878}
-
Chase Phillips authored
As part of this change, also remove IDBCallbacks.SuccessValue and IDBCallbacks.SuccessCursor which are no longer used. Bug: 717812 Change-Id: I5bb3b5d77ba7248b2286dc579d8d25805b72cd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626660 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#681877}
-
kylechar authored
Both helper functions just wait for hit test data now so rename them appropriately. Bug: 810128 Change-Id: Ia04933ee35a526a11766a5c1fbd9f75b43985bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721239Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681876}
-
Stepan Khapugin authored
Disable Site Info on the NTP to avoid user's confusion. Bug: 977056 Change-Id: Ia47495580d8ec7a3eee3347e22f91d7c63647026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719009 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#681875}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8d269bac7c4a..b51a6f0c4638 git log 8d269bac7c4a..b51a6f0c4638 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 bclayton@google.com Revert "Temporarily disable warnings-as-errors" 2019-07-29 bclayton@google.com Merge changes I10d66439,I6bd62e7b,Iec85e0df,If16c5d11,If803398e, ... 2019-07-29 bclayton@google.com LLVMReactor: Build fixes for REACTOR_EMIT_DEBUG_INFO Created with: gclient setdep -r src/third_party/swiftshader@b51a6f0c4638 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I50bb0719e5bab6d777966140d28669868ac2faa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681874}
-
Natalie Chouinard authored
This reverts commit 5a08e77e. Reason for revert: Suspected cause of Android build failures with: Class "org/chromium/net/impl/JavaUrlRequestUtils$CheckedRunnable" not found on any classpath. Used by class "org/chromium/net/impl/JavaUrlRequest$10" Original change's description: > Move Java classes needed by all Java Cronet implementations to utils. > > To minimize code duplication, code that can be shared between the > JavaUrlRequest and the FakeUrlRequest should be moved to a new shared > file: JavaUrlRequestUtils. > > Context:https://chromium-review.googlesource.com/c/chromium/src/+/1703325 > > Bug: 669707 > Change-Id: Id0dda127694090504f26b083bf4c561ee902cef4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721771 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Commit-Queue: Benjamin Kirchman <kirchman@google.com> > Cr-Commit-Position: refs/heads/master@{#681835} TBR=pauljensen@chromium.org,caraitto@chromium.org,kirchman@google.com Change-Id: Iee84334296aa6508ee2696a9f97385a00e12924e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 669707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724576Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681873}
-
Vladimir Levin authored
This patch adds more early outs that were missed during paint. That is we still paint the self element, but also need to skip child paint, particularly inline only children which was not done previously. R=chrishtr@chromium.org Change-Id: Ib2442ab361447940c1c0e1b4c54b1ee8273d9563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720795 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681872}
-
Gabriel Charette authored
In a recent refactoring we opted to switch to microseconds because that's TimeDelta's finest resolution but results are now 0 or 1 us always and it makes the dashboard useless. I think it's okay to yield results in nanoseconds because it's an effective average of 0-1 us samples. The common perf test solution to this is to measure a batch of, e.g., 1000 calls but this is tricky with WaitableEvent because we want to measure Signal/Wait() from multiple threads but not the dead time in between. R=kylechar@chromium.org, skyostil@chromium.org Bug: 905412 Change-Id: I30daf41535d36ff59b19a64523f0a558c3fa1b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724699 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#681871}
-
Xiyuan Xia authored
This reverts commit 2b2428c1. Reason for revert: Having issues with google chrome branched build. - Missing google chrome icon files; - TranslateBubbleView::CreateViewAdvancedTabUi needs to refer to correct icon resource; Original change's description: > Google Translate branding on desktop translate bubble > > This CL adds the new UI to incorporate Google Translate branding > into the new Button_GM2 and Tab translate bubble UI. Bug 987962 is filed > to track this new feature request. > > Bug: 963148, 987962 > Change-Id: Ia648f322cea5dae55bd9e21a537775bf74c772a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708843 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Commit-Queue: anthonyvd <anthonyvd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681812} TBR=oshima@chromium.org,anthonyvd@chromium.org,frechette@chromium.org,hhw@google.com Change-Id: Ib830bc733233cbba4ddb42222e8ecc8eecea0e29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963148, 987962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724575Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681870}
-
Geoff Lang authored
ANGLE's libGLESv2.so and libEGL.so have started shipping on Linux but symbols were not available to help debug crashes. BUG=988444 Change-Id: I89edc315c05cfe0dad785e386c643e44b56af72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724491Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681869}
-
Brian Sheedy authored
Merges various parts of the GPU Gold documentation from gpu_pixel_testing_with_gold.md into the other parts of the GPU documentation. Also removes references to the legacy pixel tests and their triage process since the code for them has been removed. Bug: 985007 Change-Id: I19d5480de77f1066046ef8fe0f076264cff01ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721523 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681868}
-
Nico Weber authored
Also fix the definition of CHROMIUM_BRANDING; putting a negated condition there doesn't work. Thanks to Yngve Petterson for pointing that out. No behavior change. Bug: 961769 Change-Id: I8c6ba4b6c11c8b488aa27a3cbfdd78f29079f6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724692 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#681867}
-
Max Moroz authored
Bug: 539572 Change-Id: I4965b3acbcd92650575595942c955017f75f90fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717910 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#681866}
-
Vasilii Sukhanov authored
The dropdown should not open directly after construction. Bug: 987360 Change-Id: I15fe1a319cc00308c926e4d5adac7db1126bd822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718328Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#681865}
-
Avi Drissman authored
This was broken by the new window level machinery CL. BUG=988214 TEST=as in bug Change-Id: Ifd6c132e160d6a2e29aa663ecaf87b2330322c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723749Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#681864}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c5656169e42b..c0758331ea12 git log c5656169e42b..c0758331ea12 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 ehmaldonado@chromium.org Revert "depot_tools: Make gclient_utils Python 3 compatible." Created with: gclient setdep -r src/third_party/depot_tools@c0758331ea12 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: Iea2a0dcf180612a093631c1a00c702c713959447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681863}
-
Richard Knoll authored
We need to notify the recycler view that our list content has changed when switching between search / non-search as the top item is the (hidden) select all button if we're in non-search mode. Bug: 985715,985711 Change-Id: Id1d8d18f8b71aea05f5ca1fb634ea54323ef6cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724085Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681862}
-
chrome://autofill-internalsDominic Battre authored
This CL adds logging information about autofill votes sent to the crowd sourcing server to chrome://autofill-internals. It adds a simplification of logging repeated fields to log_buffer.h. TBR=pkasting@chromium.org Bug: 928595 Change-Id: I84ca78022afa6372b77d9433351fa267694639b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722790Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#681861}
-
Bo Liu authored
Viz for webview architecture will only support calling ScheduleTask from viz thread at limited times (initialization, tear down, DrawAndSwap). In order to avoid violating this requirement, add a DCHECK for the existing ScheduleGpuTask to ensure it is only called during allowed times. Also add a ScheduleOrRetainTask method for the cases where existing code violates this requirement. In viz for webview, such tasks may be delayed indefinitely, until the next DrawAndSwap or tear down. There are only two cases, EnsureBackbuffer and ReleaseCachedResources, that violate the requirement. Convert them to ScheduleOrRetainGpuTask. Only enable the DCHECK for SkiaRenderer since that's the only case relevant for viz for webview. Bug: 805739 Change-Id: Ic9ba91d85958fbe8ff0d8e30d1bc9095fd8cf62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713871Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681860}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7fc868349143..f04f1f93a70f git log 7fc868349143..f04f1f93a70f --date=short --no-merges --format='%ad %ae %s' 2019-07-29 johnkslang@users.noreply.github.com Merge pull request #1857 from Roy-AMD/automapping-opengl-location Created with: gclient setdep -r src/third_party/glslang/src@f04f1f93a70f The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I55c5a8276edf59f0f2040d3fcbd540a583c7d075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681859}
-
Daniele Castagna authored
gl_tests can't currently be run on ChromeOS devices since is missing Ozone initialization. This patch fixes that. It can now be run on Chromebooks (with some failing tests). Change-Id: I713633ccfc4b830ad99baf3566a3502205cde172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722972Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#681858}
-
Katie Dillon authored
This cl add a new experiment to the CompositorPriorityExperiments class which will prioritize compositing if no compositing task has occurred for 100ms. Once a compositing task finishes running, we queue a delayed task Delayed task which will run after 100ms. This task raises compositor priority to kVeryHigh. Once a compositing task is run, we cancel the delayed task and queue a new one. Bug: 966177 Change-Id: Ic872b66ca81f08631355280126724786ef6046ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699218 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681857}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6b0c26cbd13b..51f067298563 git log 6b0c26cbd13b..51f067298563 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 mmortensen@google.com Refactor artifacts.BundleVmFiles. Created with: gclient setdep -r src/third_party/chromite@51f067298563 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie298c5e687da437725e7d5c0ad02f6057fd69df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681856}
-
Tomasz Wiszkowski authored
This code removes no longer used code from basic suggestion MVC. Bug: 987020 Change-Id: Ifb2e4b27ef5586d0be1ffe68b8039d36aac8aef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717184 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#681855}
-
James Cook authored
https://chromium-review.googlesource.com/c/chromium/src/+/1719450 added //chrome/browser/resources/settings/chromeos/ This adds the same people to OWNERS for tests of the above code. Bug: 987786 Change-Id: I4dd698aceb690c551c95d5bfbb24fa4fe40b2015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720747Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#681854}
-
Tobias Sargeant authored
The aim is to turn (e.g.) libmonochrome.so into monochrome, but in the secondary abi case the path passed has a directory component, which means that an incorrect library name is generated. This CL changes the implementation to be more robust to directory components and the length of the extension. Bug: 988041 Change-Id: Idfca8a38bbb4fdd2a136a64f14c9f00b675776c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720876Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#681853}
-
Andrew Grieve authored
This reverts commit 8f06819d. Reason for revert: Fixed missing file.close() The new script makes it easy to measure a set of archived .apks. Add to resource_sizes.py the ability to output to stdout and fixes up some warning messages it was showing. Bug: 988127 Change-Id: Ifed112d594ba53073167627e01a446f85b6233c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724444Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#681852}
-
Mia Bergeron authored
This CL creates a MediaControlsProgressView class and adds an instance to the CrOS lock screen media controls UI. LockScreenMediaControlsView uses MediaSessionPositionChanged to pass the playback/position info to MediaControlsProgressView. The progress view then continually updates the progress bar/time as time progresses. The placement of this view on the UI isn't critical right now as it will be changing in the near future. Bug: 965573 Change-Id: I2da5e864130ec371a58c623006ab7773f9bbe09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721321Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#681851}
-
Rayan Kanso authored
The feature is currently Android only. Restricting the Runtime flag on Android would make it easier to feature detect. Bug: 986296 Change-Id: Ie2ccda494cbdedf62cfd18bf105db97c522eaa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722965Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#681850}
-
Scott Violet authored
gfx::Rect holder_bounds(bounds().size()); holder_bounds.Inset(GetInsets()); is equivalent to GetContentsBounds(). BUG=none TEST=none Change-Id: I1d49e0e8c3d1b421d44802001ec8a123e26fd7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724789Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#681849}
-
gogerald authored
Bug: 982018 Change-Id: I04d91296f3115848e75e6e6af80a03c5cb826a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719167 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#681848}
-
Omer Katz authored
One existing remaining usage of ObjectResurrectionForbiddenScope was replaced with NoAllocationScope. Bug: 981414 Change-Id: Ie5bf7ba2c92206a397482040c47e8840b624f5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722844Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681847}
-
Peter Kotwicz authored
- This CL changes the back button when a user is in a WebAPK from using Activity#finish() to using Activity#finishAndRemoveTask() - Activity#finishAndRemoveTask() is still used if the user pressed back while the splash screen is up because WebApkActivity is still translucent at this point and Activity#finish() causes an ugly transition when WebApkActivity is translucent. BUG=982956 Change-Id: Ie39b2c6902bef2d22e6052a47013f15975fbb611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717556 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#681846}
-
Raymond Toy authored
Thsi method is defined but never used anywhere. Remove it. Bug: 987776 Change-Id: I2a4cd6fb3e9f15f1fc8c65cccef0bcb6aef51359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719002Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681845}
-
Leonard Grey authored
Bug: 982477 Change-Id: I679756c46806d98f2348f33618b4737c36d8083a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724690Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#681844}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bac9d6cd..db2b6ca2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If049698f87e148974523fd45766a09abbcd347f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724653Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681843}
-
Andrew Grieve authored
Identified as unused by Android's ResourceShrinker tool. Code Search seems to agree. Bug: 988047 Change-Id: I46153fe72089491a50b71d0b503af2e9719851c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721323 Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#681842}
-