GitLab

Details in bug.

TBR=kkania@chromium.org
BUG=136875
TEST=

Review URL: https://chromiumcodereview.appspot.com/10704162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146188 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dyu@chromium.org
BUG=136875
TEST=

Review URL: https://chromiumcodereview.appspot.com/10702153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146187 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126093
TEST=Unit test, manual testing.


Review URL: https://chromiumcodereview.appspot.com/10636019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146186 0039d316-1c4b-4281-b951-d872f2087c98

These should belong to CacheEntry as non-static member functions.

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10692154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146183 0039d316-1c4b-4281-b951-d872f2087c98

Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of metro-specific code, already have a navigator. By moving the browser::FindTabbedBrowser call there, it's clear that in that spot we need to use the metro-specific context.

BUG=129187
Review URL: https://chromiumcodereview.appspot.com/10692164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=asan bots are now happy

Review URL: https://chromiumcodereview.appspot.com/10736021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146181 0039d316-1c4b-4281-b951-d872f2087c98

The underlying issue is that the GR expects individual touch events (one touch per event) while javascript expects composite events (containing information on each touch point in a single event.)

BUG=130205
TEST=


Review URL: https://chromiumcodereview.appspot.com/10702096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146180 0039d316-1c4b-4281-b951-d872f2087c98

Change GDataCache::UpdateCacheWithSubDirectoryType() and
GDataCacheMetadata::UpdateCache() to take CacheEntry.

This is in preparation for removing IsCache/SetCache/ClearCache*
functions from GDataCache.

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10735049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146179 0039d316-1c4b-4281-b951-d872f2087c98

The transaction-abort test was flaky in Chromium, fixed by WK90412/r122291. The others were
disabled to allow landing WK89379/r121492 which renamed the tests.

BUG=83226
TEST=browser_tests --gtest_filter='IndexedDBLayoutTest.TransactionTests'


Review URL: https://chromiumcodereview.appspot.com/10736036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123998
R=asanka@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10689093

TBR=rdsmith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10702151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146177 0039d316-1c4b-4281-b951-d872f2087c98

tiny framework, a few tests of adding key-value pairs, and the mechanism to run
it all and report results.  This won't yet run on the bots.

If this looks good, I'll start adding tests to cover more of the API.

BUG=none
TEST=self


Review URL: https://chromiumcodereview.appspot.com/10575043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146173 0039d316-1c4b-4281-b951-d872f2087c98

If the path of chromium source is a symbolic link,
os.getcwd() returns the real path but __file__ will include
the symbolic link. It causes gyp failures due to the inconsistency.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10692086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10752006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146170 0039d316-1c4b-4281-b951-d872f2087c98

Mihai, might need help landing this. Getting presubmit errors even after a recent sync and a proper build.

Meggin

Review URL: https://chromiumcodereview.appspot.com/10775002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125875
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10758015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=git cl presubmit

Review URL: https://chromiumcodereview.appspot.com/10704150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136430
Review URL: https://chromiumcodereview.appspot.com/10736019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146165 0039d316-1c4b-4281-b951-d872f2087c98

Always query for the latest RenderViewHost from WebContents before sending the NOtBlacklistedMessage, since RenderViewHost can be changed if users navigate to a different site. We have seen crashes (highly possibly) because of this (http://code.google.com/p/chromium/issues/detail?id=134191)


BUG=134191
TEST=PasswordFormManagerTest

Review URL: https://chromiumcodereview.appspot.com/10704147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146164 0039d316-1c4b-4281-b951-d872f2087c98

For context see this thread:
  https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II

TBR=thakis,pkasting,jam

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123998
R=asanka@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10689093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146162 0039d316-1c4b-4281-b951-d872f2087c98

Update smoke test accordingly.

R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10748009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98

they pass on beta/stable builds even if the features are restricted to
dev/trunk.

BUG=136629
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10704149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136603
TEST=Verify bubble arrow is drawn correctly when arrow location is BOTTOM_LEFT and RIGHT_TOP.


Review URL: https://chromiumcodereview.appspot.com/10689145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146155 0039d316-1c4b-4281-b951-d872f2087c98

With the update of the WebSurroundingText API and layout tests the currently
exposed initialize methods can be simplified into one. Update Chromium to allow
this happening without breaking the build.


BUG=125390
TEST=end to end Android UI tests, not ready to be upstreamed yet.


Review URL: https://chromiumcodereview.appspot.com/10736031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146154 0039d316-1c4b-4281-b951-d872f2087c98

These tests are failing since the MS 2008 - 2010 switch.  Turning them off to make the tree green until someone takes the bug and figures out how to fix it.

BUG=132133
TEST=gpu win release bots
TBR=nduca
Review URL: https://chromiumcodereview.appspot.com/10540111

TBR=zmo@google.com
Review URL: https://chromiumcodereview.appspot.com/10704161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146150 0039d316-1c4b-4281-b951-d872f2087c98

If a browser is running, and the service process is running the connector, the
connector will occasionally start up a chromium process to check the connector
enablement policy. The flag to do so would get passed to a running browser, if
present, and there is a path through the policy check code that could cause the
browser to quit.

This patch prevents the policy check flag from being passed on; the started
process will be very short lived and does a silent launch.

BUG=134252
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10666010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146149 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133957
TEST=unit tests pass.

Review URL: https://chromiumcodereview.appspot.com/10696131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134578
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10700058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146147 0039d316-1c4b-4281-b951-d872f2087c98

to LoginUIService. This will be used by the extension API to show
login UI in a popup and then obseve when it is closed and respond back
to the extension accordingly.

Review URL: https://chromiumcodereview.appspot.com/10699013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146143 0039d316-1c4b-4281-b951-d872f2087c98

No code change.

Apply comment on code review for r145479.

R=cmp@chromium.org
NOTRY=true
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10703140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146142 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 331b803f.

TBR=ericu@chromium.org

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10696173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146141 0039d316-1c4b-4281-b951-d872f2087c98

Do not add actual touch-only tracing implementation yet. Instead, add the smoke
test to make sure touch-only access is *not* logged at the moment.

R=cmp@chromium.org
NOTRY=true
BUG=
TEST=Tested manually on each OS.


Review URL: https://chromiumcodereview.appspot.com/10772002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146140 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135673
TEST=Disable a pinned app either from extension settings page or admin policy and app should automatically unpinned from launcher instead of pulsing.


Review URL: https://chromiumcodereview.appspot.com/10693128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146139 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies a few code paths.
Add unit test to make sure the behavior is consistent accross platforms.

Fixes test regressions.

R=cmp@chromium.org
NOTRY=true
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146137 0039d316-1c4b-4281-b951-d872f2087c98

Use an ExternalData for the cases where we still need to distinguish save page downloads. Eventually, this should not be necessary.

Review URL: https://chromiumcodereview.appspot.com/10695087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134696, 117261


Review URL: https://chromiumcodereview.appspot.com/10665053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146134 0039d316-1c4b-4281-b951-d872f2087c98

This change essentially moves internally buffered network data from WebURLLoader to BufferedResourceLoader as soon as there's capacity instead of waiting for an arbitrary threshold.

There's no fear of spamming progress events at a higher frequency since progress events are limited to firing at a minimum interval of 350ms.

BUG=124719
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10694098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146133 0039d316-1c4b-4281-b951-d872f2087c98

For example, when Ctrl is remapped to Alt, Ctrl+LeftButton should be handled as a RightButton click.

BUG=133510
TEST=mostly covered by existing unit_tests for key_rewriter. Also checked that crbug.com/126529 does not reproduce with this CL.

Review URL: https://chromiumcodereview.appspot.com/10756003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146132 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123739
TEST=try


Review URL: https://chromiumcodereview.appspot.com/10696161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146131 0039d316-1c4b-4281-b951-d872f2087c98