GitLab

by ThreadSanitizer. We don't need the suppression anymore.

BUG=106197
Review URL: http://codereview.chromium.org/8800012

TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/8819017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106531
TBR=glider
Review URL: http://codereview.chromium.org/8815009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113193 0039d316-1c4b-4281-b951-d872f2087c98

We don't run it yet it's slow and fails due to too-big PDB files on the bot
TBR=glider
Review URL: http://codereview.chromium.org/8816018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113192 0039d316-1c4b-4281-b951-d872f2087c98

Fix rare logdir races by adding "_logdirfilecount" to the 'PID' when generating a unique logdir path
TBR=bruening
Review URL: http://codereview.chromium.org/8816017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113191 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for the Windows bots to have the suppression hashes available in
the build view as unique failures.
TBR=glider
Review URL: http://codereview.chromium.org/8816016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113190 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113183 - Revert 113177 - process all ui events before posting closure because menu depends on ui events to quit.
 Add new RunClosureAfterAllPendingUIEvents for toolkit views.

BUG=104359
TEST=BookmarkBarViewTest in interactive_ui_tests will pass


Review URL: http://codereview.chromium.org/8799020

Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/1514
Reason for un-revert: The test succeeded before the original revert, looks like it's just flaky.

TBR=oshima@chromium.org
Review URL: http://codereview.chromium.org/8821012

TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/8820010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106529
TBR=miket@chromium.org

Review URL: http://codereview.chromium.org/8820008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113188 0039d316-1c4b-4281-b951-d872f2087c98

We don't run sync_unit_tests now and it's so big and slow it affects both the
performance and the stability of building.
For example, it doesn't build on the Dr.Memory trybot now.

TBR=bruening
Review URL: http://codereview.chromium.org/8816015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113187 0039d316-1c4b-4281-b951-d872f2087c98

Make ShelfLayoutController a ShelfLayoutManager for launcher, status windows.

BUG=105661
TEST=Manual. Status area is represented with all icons on Aura.

Review URL: http://codereview.chromium.org/8743014

TBR=nkostylev@chromium.org
Review URL: http://codereview.chromium.org/8817016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113186 0039d316-1c4b-4281-b951-d872f2087c98

Make ShelfLayoutController a ShelfLayoutManager for launcher, status windows.

BUG=105661
TEST=Manual. Status area is represented with all icons on Aura.

Review URL: http://codereview.chromium.org/8743014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113185 0039d316-1c4b-4281-b951-d872f2087c98

This is a function for the bookmark manager, which wants to show the "Open in Incognito mode" option only if the incognito mode is available.

BUG=none
TEST=no


Review URL: http://codereview.chromium.org/8662008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113184 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113177 - process all ui events before posting closure because menu depends on ui events to quit.
 Add new RunClosureAfterAllPendingUIEvents for toolkit views.

BUG=104359
TEST=BookmarkBarViewTest in interactive_ui_tests will pass


Review URL: http://codereview.chromium.org/8799020

Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/1514

TBR=oshima@chromium.org
Review URL: http://codereview.chromium.org/8821012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105332
TEST=Manual

Review URL: http://codereview.chromium.org/8821011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113182 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
Review URL: http://codereview.chromium.org/8816013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113181 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: http://codereview.chromium.org/8805005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113180 0039d316-1c4b-4281-b951-d872f2087c98

 Add new RunClosureAfterAllPendingUIEvents for toolkit views.

BUG=104359
TEST=BookmarkBarViewTest in interactive_ui_tests will pass


Review URL: http://codereview.chromium.org/8799020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113177 0039d316-1c4b-4281-b951-d872f2087c98

Not the final UI yet.
Additional improvements:
- file name is selected in save-as dialog at start;
- new folder moved to context menu, button deleted.

BUG=chromium-os:20168,chromium-os:22106,chromium-os:22105,chromium-os:22032,chromium-os:20547,chromium-os:20549
TEST=Manual

Review URL: http://codereview.chromium.org/8554003

Reason for revert:  http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/1508

TBR=dgozman@chromium.org
Review URL: http://codereview.chromium.org/8818006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113176 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113175 0039d316-1c4b-4281-b951-d872f2087c98

This CL does not change anything for any other audio client but the WebRTC clients.
All other clients can ignore this new functionality and will still use the default
input device as before.

BUG=none
TEST=special version of content_unittests --gtest_filter=WebRTCAudioDeviceTest*
Review URL: http://codereview.chromium.org/8770005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113173 0039d316-1c4b-4281-b951-d872f2087c98

PPB_{TCP|UDP}Socket_Private interfaces are exposed to Browser process. Added shared (between NaCl and Pepper) tests for both interfaces.

BUG=105859
TEST=ui_tests

Review URL: http://codereview.chromium.org/8804006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106522
TBR=bruening
Review URL: http://codereview.chromium.org/8819012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96703

Review URL: http://codereview.chromium.org/8659007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113170 0039d316-1c4b-4281-b951-d872f2087c98

by ThreadSanitizer. We don't need the suppression anymore.

BUG=106197
Review URL: http://codereview.chromium.org/8800012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8789017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113168 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org,csilv@chromium.org
BUG=92912
TEST=Drag a [removable] app over the trash in either LTR or RTL and be greeted
by a sweet trash can lid opening animation.

Review URL: http://codereview.chromium.org/8786010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113167 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate NativeWidgetGtk specifics, remove extra files.

This supersedes http://codereview.chromium.org/8811001/
This supersedes http://codereview.chromium.org/8774022/

See Issue 106230 for a list of some BubbleWindow users.
The save and open SelectFileExtensionDialog instances look good.
Bookmark All Tabs dialog looks good on non-aura, blocked on aura by crbug.com/106474.

BUG=106230
TEST=BubbleWindows look the same on CrOS, and now similar on Aura. Ensure no regressions of crosbug.com/9065, crosbug.com/8538.


Review URL: http://codereview.chromium.org/8800032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113166 0039d316-1c4b-4281-b951-d872f2087c98

Allow the user of the utility process to specify whether the zygote
should be used on Linux. This allows to sandbox all the uses
of the utility process that don't do FS access, which right now are all
except extension unpacking and NPAPI plugin listing.

This is the first step to get the utility process sandboxed 
on Linux. Since most of the uses of the utility process 
don't do file access, launching all of those from the zygote 
will simplify sandboxing the one that does: extension 
unpacking.

BUG=93109
TEST=Try installing an extension from the web store.


Review URL: http://codereview.chromium.org/8770025

TBR=jorgelo@chromium.org
Review URL: http://codereview.chromium.org/8817013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113165 0039d316-1c4b-4281-b951-d872f2087c98

Fix the app notify channel setup for the case where the user may have explicitly revoked permission and hence the OAuth2
access token generation may fail. In that case, prompt the user.
add unit tests and modify existing tests.

TBR=asargent
Review URL: http://codereview.chromium.org/8822006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113164 0039d316-1c4b-4281-b951-d872f2087c98

The unit test was causing a DCHECK to fail. IsDefaultProfileImageURL() doesn't expect an invalid URL so I remvoed the invalid URL.

TBR=ivankr@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8821007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105028
TEST=none


Review URL: http://codereview.chromium.org/8800010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93950
TEST=none

Review URL: http://codereview.chromium.org/8818002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113160 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=changed certificate_types struct in local copy of nss selfserv,
reloaded, checked "echo .dump | sqlite3 'Origin Bound Certs'" to see if
new cert was generated.


Review URL: http://codereview.chromium.org/8821002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113159 0039d316-1c4b-4281-b951-d872f2087c98

Ordinal IME shows candidate window under the cursor, but Mozc should show
"suggest window"(same view but different location) and it's location is sent
by mozc-engine.

BUG=chromium-os:21356
TEST=manually confirmed it works fine and no conflict with other CJK engine.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112452

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112965

Review URL: http://codereview.chromium.org/8505051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113158 0039d316-1c4b-4281-b951-d872f2087c98

This removes NOTIMPLEMENTED()s for platform_util's
ShowItemInFolder(), OpenItem(), and OpenExternal().  We now
use the native Chrome OS, Windows, or Linux versions of
these functions.

BUG=99712
TEST=manual: checked that we use the file manager extension to open downloaded files on Chrome OS and that we use XDG on linux


Review URL: http://codereview.chromium.org/8808003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113157 0039d316-1c4b-4281-b951-d872f2087c98

- Remove search box until we have decided how to approach it;
- Show apps pagination dots;
- Dismiss app list UI on escape or click on non-app and non nav dots;
- Defer widget showing further until apps are loaded by webui;
- Add a container div to limit apps page height so that the gap between apps icons and nav dots are not too big;
- Passing bounds when requesting app list widget to avoid resizing;

BUG=98308,105794,106451
TEST=Verify search box is gone, nav gots show up on bottom and could switch pages by clicking on it;


Review URL: http://codereview.chromium.org/8747021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113156 0039d316-1c4b-4281-b951-d872f2087c98

were attempting shutdown before destroying the compositor.

BUG=104360
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/8800030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113155 0039d316-1c4b-4281-b951-d872f2087c98

Previously, each Expose event (caused e.g. when you move the host window) would
trigger an immediate redraw, which can take a long time (vsyng, GPU load, ...).
Instead, schedule a redraw so that multiple expose can get gathered into a
single redraw.

BUG=None
TEST=launch chrome/aura, move the window around for a few seconds, check that things are interactive again right away.


Review URL: http://codereview.chromium.org/8815004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8804027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113153 0039d316-1c4b-4281-b951-d872f2087c98

Not the final UI yet.
Additional improvements:
- file name is selected in save-as dialog at start;
- new folder moved to context menu, button deleted.

BUG=chromium-os:20168,chromium-os:22106,chromium-os:22105,chromium-os:22032,chromium-os:20547,chromium-os:20549
TEST=Manual

Review URL: http://codereview.chromium.org/8554003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91241
TEST=

Review URL: http://codereview.chromium.org/8772055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113151 0039d316-1c4b-4281-b951-d872f2087c98