GitLab

R=dmazzoni@chromium.org
BUG=419272
TEST=hold delete on history page => no assertions or double messages

Review URL: https://codereview.chromium.org/643013002

Cr-Commit-Position: refs/heads/master@{#299064}

BUG=None
TEST=None
TBR=sky

Review URL: https://codereview.chromium.org/639183004

Cr-Commit-Position: refs/heads/master@{#299063}

This step is a giant search and replace for OVERRIDE to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/644903002

Cr-Commit-Position: refs/heads/master@{#299062}

A histogram entry is emitted each time a browser window enters fullscreen. Each
entry has 3 associated parameters:
  - Whether the mechanism used was AppKit or Immersive.
  - Whether the window was on a primary or secondary screen.
  - Whether the "Displays have separate spaces" option in mission control was
  enabled.

BUG=

Review URL: https://codereview.chromium.org/600303003

Cr-Commit-Position: refs/heads/master@{#299061}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/232f6b0..8f1f7f8

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/639973003

Cr-Commit-Position: refs/heads/master@{#299060}

Cleaning up weak_ptr_factory destruction order.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/612783003

Cr-Commit-Position: refs/heads/master@{#299059}

This patch adds:
1. Flag supports_notify_tag to chrome.fsp.mount().
2. Method chrome.fsp.Notify() to notify about changes of observed entries.
3. Events chrome.fsp.OnObserveDirectory and OnUnobserveEntry.

Missing things, to be added in a separate patch:
1. Glueing chrome.fsp.Notify to the C++ layer properly, not with fake data.
2. Saving and restoring observed entries together with tags from preferences.

TEST=unit_test: *FileSystemProviderProvidedFileSystem*,
     *FileSystemProvider*Observe*, *FileSystemProvider*Unobserve*
BUG=248427

Review URL: https://codereview.chromium.org/625463002

Cr-Commit-Position: refs/heads/master@{#299058}

BUG=421767
TEST=Open Gallery.app; In slide mode, delete all images by clicking bottom-right delete button.

Review URL: https://codereview.chromium.org/638383002

Cr-Commit-Position: refs/heads/master@{#299057}

This step is a giant search and replace for OVERRIDE to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/631683002

Cr-Commit-Position: refs/heads/master@{#299056}

Move geometry, input_event and surfaces TypeConverters.
Move conversion-related helpers and tests as well.

Flatten lib sub-directories into their parents.
Update includes, guards, DEPS, GYP, and GN.
Add mojo_converters.gypi to avoid a false-positive cycle.

BUG=421234
TEST=No GYP, GN, compile, or link problems.
R=jamesr@chromium.org
TBR=reed@google.com,sadrul@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/640893003

Cr-Commit-Position: refs/heads/master@{#299055}

The IPC that is used to send tooltip text to BrowserPlugin was sent on every mouse movement, and unnecessarily sent the same text repeatedly. This is now checked and only new text is actually sent.

Review URL: https://codereview.chromium.org/638253004

Cr-Commit-Position: refs/heads/master@{#299054}

BUG=421840
TEST=manually

Review URL: https://codereview.chromium.org/644883002

Cr-Commit-Position: refs/heads/master@{#299053}

This implements proper out-of-process support for SurfaceTexture backed
GpuMemoryBuffers using our generic GPU service side GpuMemoryBuffer
allocation mechanism. Both renderer and browser compositor usage is
supported.

BUG=368716,418553
TBR=jln@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/634643002

Cr-Commit-Position: refs/heads/master@{#299052}

As we are removing webkit/ glue, we need a new home for these scripts.

BUG=338338
TEST=None
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/629083002

Cr-Commit-Position: refs/heads/master@{#299051}

We'll come up with better names later on.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/644793002

Cr-Commit-Position: refs/heads/master@{#299050}

This does not change the current behavior, it simply opens a tab
by using chrome::Navigate().

However https://codereview.chromium.org/640103002/ will introduces
app-list search to Athena, then the direct use of chrome::Navigate()
is problematic. Athena will handle this method.

BUG=380875
R=xiyuan@chromium.org
TEST=no functional changes

Review URL: https://codereview.chromium.org/644863002

Cr-Commit-Position: refs/heads/master@{#299049}

BUG=421831
TBR=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/645703002

Cr-Commit-Position: refs/heads/master@{#299048}

This CL adds a test which verifies that we read and change HTTP headers.

BUG=352293
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/640603005

Cr-Commit-Position: refs/heads/master@{#299047}

R=stevenjb@chromium.org
BUG=401640

Review URL: https://codereview.chromium.org/599723002

Cr-Commit-Position: refs/heads/master@{#299046}

TBR=burnik@chromium.org
BUG=422164

Review URL: https://codereview.chromium.org/645793002

Cr-Commit-Position: refs/heads/master@{#299045}

No functionally should be changed.

BUG=422155
TEST=manually tested
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/642093002

Cr-Commit-Position: refs/heads/master@{#299044}

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/647553004

Cr-Commit-Position: refs/heads/master@{#299043}

This step is a giant search and replace for OVERRIDE to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/630603003

Cr-Commit-Position: refs/heads/master@{#299042}

BUG=None
R=cmasone@chromium.org, achuith@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/639253002

Cr-Commit-Position: refs/heads/master@{#299041}

The default implementation of SetProperty in the plugin (inside
ScriptableObject) will throw an exception. This can result in an
unexpected exception in JS when properties are set on the plugin
element. We should only call SetProperty if the plugin has that
property.

BUG=414842
TBR=dmichael@chromium.org

Review URL: https://codereview.chromium.org/640033003

Cr-Commit-Position: refs/heads/master@{#299040}

Started replacing the current WebsiteSettings dialog with a simple
implementation of the upcoming PageInfo dialog. Currently, the dialog
only contains the URL, a short message about the site and a 'Done'
button to close the dialog. Later, it will also contain individual
dropdowns to configure permissions for the website's content settings.

The new dialog is hidden behind the flag
--enable-new-website-settings. Without the flag, the old dialog will
be displayed.

BUG=365528

Review URL: https://codereview.chromium.org/516703002

Cr-Commit-Position: refs/heads/master@{#299039}

Use a proper WebMouseWheelEvent instance when validating the ToString
behavior for events of type WebInputEvent::MouseWheel.

BUG=422083

Review URL: https://codereview.chromium.org/642483003

Cr-Commit-Position: refs/heads/master@{#299038}

On dragging and dropping an item on a folder that is
currently showing its folder menu; the menu moves upwards
by an offset, regardless of its parent button moved or not.
This CL fixes the issue that the folder menu is moved only
when its parent button is moved. Also, the offset value
should be kBookmarkFolderButtonHeight.

BUG=311155
R=asvitkine@chromium.org

TEST=
1) Launch chrome and add a bookmark folder(folder1) to Bookmarks Bar
2) Add two folders(folder2 and folder3) within folder1.
3) Open folder1, now drag folder3 and hover it on folder2,
   wait until folder2 opens its folder menu, now drop the
   folder i.e release the mouse, and observe.
4) folder2's folder menu should not shift upwards, it
   should horizontally align with its button's frame.

Review URL: https://codereview.chromium.org/606593002

Cr-Commit-Position: refs/heads/master@{#299037}

So the core of the mojo spy can travel to new, exciting destinations.

BUG=none

Review URL: https://codereview.chromium.org/648573002

Cr-Commit-Position: refs/heads/master@{#299036}

BUG=

Review URL: https://codereview.chromium.org/614213003

Cr-Commit-Position: refs/heads/master@{#299035}

For SyncExponentialBackoffTest.OfflineToOnline, methods were added to
simulate and reset a network failure. The old (Python server) way of
doing this has been deleted from SyncTest.

For SyncExponentialBackoffTest.TransientErrorTest, a TRANSIENT_ERROR
is now triggered on FakeServer. The old way of doing this,
SyncTest.TriggerTransientError(), has been deleted.

BUG=406545

Review URL: https://codereview.chromium.org/642613002

Cr-Commit-Position: refs/heads/master@{#299034}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1598899..232f6b0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/641113006

Cr-Commit-Position: refs/heads/master@{#299033}

This allows us to clearly distinguish between entry
points that are part of termios and the top level
ones which are trying eliminate (by moving them to
the C libraries).

Review URL: https://codereview.chromium.org/639113002

Cr-Commit-Position: refs/heads/master@{#299032}

BUG=402671
TEST=udp_socket_unittest.cc (this CL hasn't run that on the bots)

Review URL: https://codereview.chromium.org/596383002

Cr-Commit-Position: refs/heads/master@{#299031}

We should initialize the |client_| pointer before launching the host process,
as the OnHostProcessLaunched() callback dereferences the |client_| pointer.

BUG=421500

Review URL: https://codereview.chromium.org/642163002

Cr-Commit-Position: refs/heads/master@{#299030}

BUG=128035

Review URL: https://codereview.chromium.org/562273008

Cr-Commit-Position: refs/heads/master@{#299029}

BUG=421665

Review URL: https://codereview.chromium.org/634413002

Cr-Commit-Position: refs/heads/master@{#299028}

Two tile-size cleanups in this patch:

- Fixes a bug where the minimum tile-height for GPU-raster
  pages is 512 until any amount of zoom is applied (all
  layers we being considered 'long-and-skinny' by the old
  logic).

- Reserves default_tile_size/max_untiled_layer_size for
  software-raster. GPU-raster now computes both of these,
  leaving only tile-grid-size which re-uses the setting.
  That will be removed in my next patch.

BUG=365877

Review URL: https://codereview.chromium.org/605773004

Cr-Commit-Position: refs/heads/master@{#299027}

This blacklisting allowed certain cameras to be manipulated
using the QTKit API side by side to the AVFoundation API.
This is not needed anymore since the only blacklisted cameras,
namely the Blackmagic ones, are manipulated via third_party
Decklink SDK.

Note that not all traces of blacklisting disappear: QTKit
Blackmagic must avoid certain resolutions that would
otherwise crash the browser (see http://crbug.com/396812).

BUG=408493, 408089

TEST=After running Chrome, plug in a thunderbolt Blackmagic
device, for instance an UltraStudio Mini. Wait 4 seconds or so,
then enumerate devices, e.g. using http://goo.gl/r0lnFQ. There
should be a number of Blackmagic/UltraStudio mini entries but
no "QTKit " prefixed camera (those are the removed ones).

Review URL: https://codereview.chromium.org/633373009

Cr-Commit-Position: refs/heads/master@{#299026}

BUG=422077

Review URL: https://codereview.chromium.org/644813003

Cr-Commit-Position: refs/heads/master@{#299025}