- 11 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fea01bf21b37..721ef456ee27 2020-12-11 sigurds@chromium.org Refactor ApplicationPanelTreeElement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1157484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie332f48ad59eace2343ac01578e7960fc939a532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836056}
-
Aya ElAttar authored
- Removed DlpRulesManager::IsRestrictedAnyOfComponents given that it's no longer needed after replacing kGuestOs with {kCrostini, kPluginVm}. Change-Id: I9730cc7eb1f20d16a6ac8e1e47c16afe62598fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577780 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836055}
-
Leo Lai authored
we are migrating tpm status calls to TpmManagerClient. BUG=b:172748724 TEST=build ok. Change-Id: I3cee2889e8bb17ac1b39f9dc973d1bf94cbf1558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580974 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#836054}
-
Alice Wang authored
This CL moves SigninView to signin.ui target. Bug: 1157052 Change-Id: I2211e6f6592dccbe4d73edeb8b6e18f173a92c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582324 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836053}
-
arthursonzogni authored
[Bug] showed there was a mismatch in between Chrome and Firefox about the referrer sent during a navigation, when initiated from a document with an opaque origin. Chrome: No referrer sent for both subresources and main resources. Firefox: No referrer sent for subresources, but a referrer is sent for main resources. This patch is meant to help making web browser to eventually converge. We believe the correct behavior is not to send the referrer: - 3.1.2 of [determine-requests-referrer] - 6.9 of [http-network-or-cache-fetch] [Bug]: https://crbug.com/1109065 [determine-requests-referrer]: https://w3c.github.io/webappsec-referrer-policy/#determine-requests-referrer, [http-network-or-cache-fetch]: https://fetch.spec.whatwg.org/#http-network-or-cache-fetch). Fixed: 1109065 Bug: 1109065 Change-Id: I15c80d52d963fc8e8a1318e4bf89fe72234c5fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584029 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#836052}
-
Eugene But authored
Bug: 688063 Change-Id: I4cef9ed86a096fe6035ef5a11b4eb02b29c047bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585679 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#836051}
-
Colin Blundell authored
This CL moves the implementation of ChromeSubresourceFilterClient::OnAdsViolationTriggered() to ProfileInteractionManager, with the former now just calling through to the latter. In subsequent work we will eliminate the callthrough to the client altogether, thus having this logic be shared with WebLayer. In this CL, however, there is no behavioral change. Bug: 1116095 Change-Id: Ic315394b20e107d3eb0180bbf157a2a8cdb23118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578838 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#836050}
-
arthursonzogni authored
If the first navigation is same-origin and the previous document was the initial empty document, the 'window' object is sometimes reused for the new document. It means the initial empty document and the new documents will both reuse the same LocalDomWindow. Weirdly, sandbox_flags are stored on the LocalDomWindow, instead of the Document. I don't know why. As a result, Chrome apply sandbox twice. It gets the union of sandbox flags defined for the initial empty document and for the new document. Firefox doesn't, see [WPT test]. The patch makes Chrome to converge toward Firefox. Chrome also stop reaching a DCHECK about sandbox flags computed from the browser and the renderer not matching. [WPT test]: https://wpt.fyi/results/html/browsers/sandboxing/sandbox-initial-empty-document-toward-same-origin.html?sha=009fb03561&label=master&max-count=1 Fixed:1156632 Bug:1156632,1041376 Change-Id: Ic8eaa5409ce3affdfee3e75bb12c4dad3cf84ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578902 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#836049}
-
Josiah K authored
Screenshot: https://screenshot.googleplex.com/8NAe4DWRAsTKipU Design: go/switch-access-setup-ux-select-switch AX-Relnotes: In Switch Access, disallow removal of select switch if it's the only one remaining, to prevent users from getting into a bad state. Fixed: 1157268 Change-Id: I69358685f8cf389675875a1558c71591a6e6e921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583150 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836048}
-
Philipp Hancke authored
and reactivate test BUG=webrtc:12194 Change-Id: Ie71da8834182ea458654d7b802dcdccd39fcd482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580532 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#836047}
-
Benoit Lize authored
Freelists must be null-terminated. This is currently not enforced in the code. This commit removes all "reinterpret_cast<>"s for the freelist, and enforces null termination. Bug: 998048 Change-Id: I0593a337ef36693e4ffe08ce8ec04ba679e24183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584764Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836046}
-
Rakina Zata Amni authored
There are currently some known cases where url_is_unreachable sent by the renderer is different than the one currently calculated in the browser with CalculateURLIsUnreachable(), such as when a data: URL navigation happens in a subframe, or when the browser tries to commit an error page with an empty GURL. This CL makes sure the browser and renderer-calculated values match and adds a DCHECK to ensure this holds for all tests. Bug: 1155414, 1154753 Change-Id: I46750ccfdd3619c0665f71fbfebe1ecb9651d234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574040 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836045}
-
Sreeja Kamishetty authored
This reverts commit 9b07e5e0. Reason for revert: Failing following pdf_unittests on Linux MSan Test builder AccessibilityTest.TestSelectionActionHandling More details: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26576/overview Original change's description: > [a11y] Add scrolling action to PP_PDF_SET_SELECTION > > This CL adds scrolling when PDFiumEngine::HandleAccessibilityAction > is called with PP_PDF_SET_SELECTION and the selection is not > visible since Blink triggers also scrolling with setting selection. > So, this change makes PDF document scroll the page when a selection > is set. > > AX-Relnotes: When SetSelection action is handled on pdf, it also > triggers scrolling if the selection is not in the visible area. > For instance, atk_text_set_caret_offset() on pdf scrolls the page > if the text is not in the view port. > > Bug: 993456 > Change-Id: I8323eff293b3216e2b862f8df3e896380b1c9945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573975 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: K. Moon <kmoon@chromium.org> > Reviewed-by: Martin Robinson <mrobinson@igalia.com> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#835994} TBR=dmazzoni@chromium.org,mrobinson@igalia.com,jkim@igalia.com,kmoon@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I524b4c3d27265923e8ef4b2508582f08e38b3582 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586413Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836044}
-
Aya ElAttar authored
- Removed EndpointType::kGuestOs which was used to refer to both; Crostini and PluginVm. - Added more granular endpoint types; kCrostini, and kPluginVm, kBorealis, and kUnknownVm. Bug: 1103217 Change-Id: I23020d8937a47bc649b5bae45ebacc80214165a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577209 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836043}
-
Saurabh Nijhara authored
This CL adds error code for update download canceled due to DeviceAutoUpdateTimeRestrictions policy to the enum so that it can be reflected in the histogram. This error code is already added in update engine code in the following CL - https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2567121 Bug: chromium:1117450 Change-Id: I69d109553c28a4948d725183293640d8eb044731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584984Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#836042}
-
dpapad authored
- Remove unused Polymer3 migration stuff (auto_imports, namespacee_rewrites) from settings.gni. - Move stuff that appeared in settings.gni but only used in OS Settings to os_settings.gni. - Make Polymer.dom() and Polymer.dom.flush() rewrites more robust (previously depending on the order these rewrites were processed incorrect code "dom.flush()" could be produced) Bug: 1045266 Change-Id: I8ff5a94241be2b346ac4680186d6c1a49b687005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582645Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836041}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607644656-0b01fdecc754de80a3c2ac369c5f084aa20b4340.profdata to chrome-linux-master-1607666365-bbaa45b634e1691b87709d169151bc6605a0f202.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I578d6271dbc1394a0fbe5c5cabd092269a7da824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836040}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607644656-0a2d12ddbaae1d8a16ffb54f7cbbe55ff04a272a.profdata to chrome-mac-master-1607666365-8c1e3ea09225831030a16a3eef7156247263dd6d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I66ee80c5296d76607ed9bf3ef88555a5304ccce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836039}
-
Sreeja Kamishetty authored
This reverts commit 583f52a3. Reason for revert: Following browser_tests failing on Linux MSAN bot All/SearchPrefetchServiceEnabledBrowserTest.OmniboxNavigateToMatchingEntryStreaming/1 All/SearchPrefetchServiceEnabledBrowserTest.OmniboxNavigateToNonMatchingEntryStreamingCancels/1 More details: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26573/overview Original change's description: > Search Prefetch Streaming requests can be cancelled after headers > > The goal of this CL is to allow unneeded requests to be cancelled > when they are unlikely to be navigated to. This is achieved through > a few avenues of change: > > -- When the user navigates to something in omnibox, the URL is reported > to Search Prefetch Service to be able to mark it as likely to be served > (using kCanBeServedAndUserClicked when the request is kCanBeServed). > This occurs before the omnibox is closed and all results are wiped. > -- kCanBeServed are wiped when omnibox closes. > -- Streaming requests will no longer pause the mojo channel, so they can > witness the Complete event to be able to make the request as complete. > -- As part of above, we store the response body in memory instead of > just handing off the data pipe. Data pipes have a 500k data limit, which > search requests typically go over. Net won't send the complete event > until all data is in the pipe. Therefore we store the data and create a > pipe to navigation if needed. > -- Full body implementation now reports kComplete where it used to > report kCanBeServed. > > Bug: 1156325 > Change-Id: Ied70a3eafd896801e263f631cb4d80556e762180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583112 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835897} TBR=tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I130213d5d9d72641b12be31192f51461957cd15b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584426Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836038}
-
David Van Cleve authored
Downside of writing comments in strings: Tricium doesn't catch typos! TBR=csharrison@chromium.org Change-Id: I06aa20fb9369f0e6d5ef43e9a3cae3a5b8d27934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586316Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836037}
-
Satoshi Niwa authored
Design doc : go/arc-project-quota BUG=b:171847983 TEST=Check if valid value is returned Change-Id: I808fa4d5da78858a7f7d7266c7caf08fee21e579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546503Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#836036}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4d774788..59248a61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1436d7dcb42e75cef95cf5e3b72240600a931119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586015Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836035}
-
Marc Treib authored
- Remove getNumberOfSyncedDevices which was unused. - Merge init() into the constructor. - Add a few comments/TODOs where the Java PSS still diverges from the native version. - Add warning comments to some potentially dangerous methods (notably getChosenDataTypes and getPreferredDataTypes). - Mark getPreferredDataTypes as deprecated. Its only usage was an error (see crbug.com/1157046). Bug: 1135552 Change-Id: I8d0d1e8165086ef6af498a2010a887ba25ae7efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582083Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#836034}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/19bfdf4583d4..fea01bf21b37 2020-12-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic1e54ef858ca01fd3b9db23dfd263898f36a5779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836033}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607612331-9abd6632cfb32a4e513da1b46025c0e77c15ae02.profdata to chrome-win64-master-1607644656-7adc1a9108854fa8e662531b0c0fa8127d30765c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2ec17bcc877d146aa1f601679a9e6c4c65857718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836032}
-
Alice Wang authored
This CL moves ConfirmSyncDataStateMachineDelegate to signin.ui target. Bug: 1155132 Change-Id: Icea2dc2f77573d55e6cccfe8e7a73e425871995a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582325Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836031}
-
Ramin Halavati authored
Extensions will be disabled in the first experiments of ephemeral Guest profiles. WebStore private APIs are updated to treat ephemeral Guest profiles similar to the off the record ones. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: If4b4711d133f8e429b2ced09fdf6747cb0c31491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580805Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#836030}
-
Noel Gordon authored
Add PopulateLoadTimeData helper to setup files app load time data. Add CreateTrustedAppDataSource to add trusted resources and load time data and initialise security policy for the metadata Shared Worker. Bug: 1113981 Change-Id: Ic507af120de1a8c8ff19429bcfe864291a0f2a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586637 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#836029}
-
Hirokazu Honda authored
No existing ChromeOS arm device supports non 8 bit stream decoding. VaapiVideoDecodeAccelerator implementation doesn't support non 8 bit stream decoding. We have relied on underlying implementations (e.g. drivers and firmware) to filter non 8 bit streams. AcceleratedVideoDecoder has a getter function for the bit depth of an input stream. This CL filters out non 8 bit streams in chrome by calling the getter function. Bug: b:174798524 Test: video_decode_accelerator_tests test-25fps.vp9_2 on scarlet and atlas Change-Id: I9071649740cd0ddab889887f09cabf598d38ec09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576298 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836028}
-
Jan Wilken Dörrie authored
This change removes the PRESUBMIT check for NULL, since it is rendered obsolete by the modernize-use-nullptr clang-tidy checked introduced in r709137. The latter check produces less false positives, since it only runs on changed lines, rather than across changed files. Bug: None Change-Id: I0ee29c95e1e53a6f421377932a85edff1466b6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584162 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836027}
-
Leo Lai authored
We are replacing tpm status APis by cryptohome with tpm manager service. Though the change to the workflow is implemented UserSessionManager is supposed to operate almost the same way, before and after this CL. Below the behavioral changes are highlighted: 1. TpmIsBeingOwned is removed as a factor from the state machine. TpmIsBeingOwned is no longer supported and always returns `false` now. Removing it is a trivial change. 2. As for execution order, `PrepareFinalizeProfile()` is separated totally from the preparation of TPM device. The justification comes from the fact that `CryptohomeClient::CanAttemptOwnership()` only triggers TPM initialization by tpm manager w/o waiting for it to complete; it doesn't make sense to just wait for a trigger w/o checking its result. Clearing owner password is in best effort and the result is not checked even in cases where any remaining owner password dependencies stops the password from being cleared. 3. TPM status checking is made asynchronous after this CL to make sure UI thread doesn't get blocked. 4. Upon failure of calling tpm_manager, `DCHECK` is replaced by logging error message. It doesn't make sense to just crash upon the error, and in production it doesn't make any difference anyway. BUG=b:172748724 BUG=b:172775884 TEST=unit_tests (filter: *UserSessionManager*) TEST=browser_tests (filter: *ExistingUserController*) TEST=asan + msan builder trybot passes. TEST= perform first login, check if the password exists/gets wiped before/after the login. Change-Id: I66c5ef3faae8c78d9f2cb304ccf59ca7a8f80c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560087 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#836026}
-
Frédéric Wang authored
According to [1], URLs whose scheme is "data" should be treated as potentially trustworthy. This CL performs the change to align with the specification and remove unnecessary special handling in various places of the code. This CL does not contain significant behavioral changes, and has no web-facing API changes. However, an intent email has been sent [2] and a chromestatus page created [3]. Owners of the files from which network::IsUrlPotentiallyTrustworthy is called were informed and indicated the change is fine: - NetworkFetcherImpl::DownloadToFile: Not exposed to the web at all. Used by an automated software updater which checks with a hardcoded Google endpoint for updates to certain Chrome modules. - IdpNetworkRequestManager::Create: This code has been implemented recently and is not released yet. - content_security_policy.cc's UpgradeInsecureRequest: already exits early for non-HTTP schemes. - security state's GetSecurityLevel: already exits early for data scheme. - password_manager_ios_util.mm: data URLs are not supported on other platforms so it should be excluded on iOS too. This is already the case since only localhost hosts, file: and cryptographic schemes returns true. - CookieChangeSubscription, CookieAccessDelegateImpl: should be fine because code excludes data schemes (on non-iOS platforms) as well as opaque origins (like data:). Moreover, data: doesn't go over http. - InsecureInputTabHelper: used to include data schemes in the past [4], uploaded [5] to preserve current behavior. - sec_header_helpers.cc: Only matters for HTTP requests. - TouchToFillController: Removed in [6]. - RemoteCopyMessageHandler::HandleImage: This is guarded by IsImageSourceAllowed. kRemoteCopyAllowedOrigins, defaults to "https://googleusercontent.com" and having a real use case where someone adds a "data:" host seems unlikely. [1] https://w3c.github.io/webappsec-secure-contexts/#potentially-trustworthy-url [2] https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/Hb1-VLwq54Y [3] https://chromestatus.com/feature/5634194258526208 [4] https://chromium-review.googlesource.com/c/chromium/src/+/1986072 [5] https://chromium-review.googlesource.com/c/chromium/src/+/2580067 [6] https://chromium-review.googlesource.com/c/chromium/src/+/2574743 Bug: 1119740, 1153336 Change-Id: I4db1b71ab0dc4d7a0635e8524a3757dc4388edf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563683Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#836025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/311cd5bfef93..dd549ceda1d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144858 Tbr: calamity@google.com Change-Id: I9146e60e5c4caf083d12fc0bc2edb8a06aea9799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586773Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836024}
-
Danan S authored
- Add Family Management scope - Remove scopes irrelevant to EDU Coexistence Bug: 1157119 Change-Id: I0964a956aefa0d7361f10946c42aa0ba9da3aa98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581884 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#836023}
-
Tal Pressman authored
MojoBindingContext encapsulates the necessary information for binding Mojo interfaces, enabling parts of platform/ that provide them to associate the interfaces with the correct context(e.g., ExecutionContext). The CL also uses the MojoBindingContext to convert the FileUtilitiesHost interface to be associated with an ExecutionContext. Change-Id: Ia89cdfb728a9b5473478df2abceb68ce60d9564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575304Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#836022}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8e3a4ab1fe23..5a9d7eaa74ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I878ce51479ab25304cc6679c88da5a9d4cdd2937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586754Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836021}
-
Anthony Polito authored
this was generated by an automated workflow Bug: 1113033 Change-Id: I13dcc051e303800bf993bf4d5a372ef366adefb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585958 Auto-Submit: Anthony Polito <apolito@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836020}
-
Daniel Cheng authored
This is a problem even without RenderDocument. Bug: 1148793 Change-Id: Ia8e3dd7a78c07a512ad9d862b3f6fca61866b272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561790 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836019}
-
Lei Gao authored
When invoking MediaPlayer's setDataSource() API, cookies may not retrieved. In some case the media will playback failed if the required cookies absent. This CL will check whether the cookies are retrieved before call this API. API call will be pending until cookies retrieved. Bug: 1157376 Change-Id: I43f04461af86c83e53a169bb4df35cbe20419b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584203 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#836018}
-
Maxim Kolosovskiy authored
Reason: the launch was deferred. Bug: 1153757, 1095627 Change-Id: I7d0bf7257a721c0be9e46d7f0706d8985df50637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584022 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836017}
-