- 06 Mar, 2019 37 commits
-
-
David Jacobo authored
Adding forward declarations when needed so we can remove duplicated includes. Removing unnecessary prefix for code already declared inside the chromeos namespace. Bug: None Change-Id: If9e7d04fbb282ce9badbc08908490d7e8d634627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504392 Commit-Queue: David Jacobo <djacobo@chromium.org> Auto-Submit: David Jacobo <djacobo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637941}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e57f10e4041d..4c84dbdce271 git log e57f10e4041d..4c84dbdce271 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 bclayton@google.com Kokoro: Don't use verbose logging for make Created with: gclient setdep -r src/third_party/swiftshader@4c84dbdce271 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5a13cc96ea7059610fbfe4e65bcfa2e9ce93eeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637940}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6ce450029683..3a9f8f45de46 git log 6ce450029683..3a9f8f45de46 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 evanhernandez@chromium.org cros branch: Log notice instead of info. 2019-03-05 dgarrett@google.com chromeos_config: Change packages for old factorybranches. Created with: gclient setdep -r src/third_party/chromite@3a9f8f45de46 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ieeb57d4b5f417f54792995066d2d286ede901407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637939}
-
Yun Liu authored
Bug: 728297 Change-Id: I563b49e1c6d37b3c3e2a408be46920ab3f7f87e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504306Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#637938}
-
Tomasz Wiszkowski authored
This change removes outstanding references to file removed under crrev.com/c/1503344 Bug: 472729 Change-Id: I1d84279a316d8ccd9ebc99c93a466d0dbb57bc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504338 Auto-Submit: Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637937}
-
Lambros Lambrou authored
This is a simple change to allow VP9 to work reasonably well without crashing, when connecting via the website with VP9 experiment enabled. Future work will optimize VP9 encoding, and remove large-picture detection in the frame scheduler (as it's not needed for VP9). Change-Id: Id80297dd9a0abf420ccf0e22251fca23200c32e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489711Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#637936}
-
Patrick Noland authored
When a site is suspended, SuspendedTab is shown in place of the actual contents of the page. Showing a SuspendedTab stops loading on the associated tab. Logic for showing a SuspendedTab flows through PageViewObserver, which already has the knowledge of which domains are being navigated to and shown. The SuspendedTab will eagerly remove itself on a new page load, which means every page load on a suspended site will create a new SuspendedTab. The alternative ended up being much more complex to code. We don't actively reload a page when a site is un-suspended, although this would be fairly easy to add in a follow-up. Bug: 902568 Change-Id: Ibc7099eafbab65f583d5989436c8831366a9b040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1435623 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#637935}
-
Lei Zhang authored
- Use range-based for loops. - Add a GetPrintPreviewUIForDialog() helper function. Change-Id: Ib571f575d53f8f8b6ad857e61f2b1111cf2ab5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497857 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637934}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6752606a395..624cec68e43a git log e6752606a395..624cec68e43a --date=short --no-merges --format='%ad %ae %s' 2019-03-05 khushalsagar@chromium.org remote fonts: Ensure consistent gamma usage with remote and gpu fonts. 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8e3cddfd..2f034a6e (426 commits) 2019-03-05 michaelludwig@google.com Support per-entry transforms in image-set API 2019-03-05 csmartdalton@google.com Make mixed samples detection automatic 2019-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e57f10e4041d..4c84dbdce271 (1 commits) 2019-03-05 herb@google.com Pointer to GrStrikeCache on GrTextBlob Created with: gclient setdep -r src/third_party/skia@624cec68e43a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I337f2e33667e5beefca194028b755e0909f0ae94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637933}
-
Sam McNally authored
It's been disabled for a few years without any action and passes locally so try on the bots again. Bug: 577332 Change-Id: If5b9cd5857e9940f891ce104e9bb2694698b25aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481174 Auto-Submit: Sam McNally <sammc@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637932}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8fdf9af7..3e8a733a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5451f69c939d64b3ecabb8a730751b6cd1d7759b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504292Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637931}
-
Becky Zhou authored
+ Add override configuration for Tab themed application context so that the UIs inflated from it don't get night mode from application UI mode + Change color resources access to use activity/view context instead of application context Bug: 936983 Change-Id: I08135f7bd2c54540d1516bd3dd68dfa11a3fd264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503902Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#637930}
-
Jamie Walch authored
This fixes our top crasher for M74 Chrome Remote Desktop. It is probably not the right long-term fix, but it is suitable for merging in the short term. Bug: 938648 Change-Id: Iad763e8b17f7355105f74bdd89e9d32a37a532f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504147Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#637929}
-
Darren Shen authored
This reverts commit 9deda679. Reason for revert: Seems to be causing failures in ASAN due to dangling pointer (crbug.com/938699). Original change's description: > Delay querying for printers list until the policy file is parsed > > A list of enterpise printers is not ready immediately after creation of > CupsPrintersManager. It caused a problem for testing procedure since from the > level of autotest_private_api we do not know if the final list is ready or > there are still some ongoing calculations. A new method called > OnEnterprisePrintersInitialized() was added to the observer of > CupsPrintersManager to solve this issue. Also whole code related to > enterprise printers were refactored, large part of functionality was moved > from SyncedPrintersManager to new class EnterprisePrintersProvider. Classes > ExternalPrintersPrefBridge and DeviceExternalPrintersSettingsBridge have been > merged into one class called CalculatorsPoliciesBinder. > This is reland of CL:1220547, it fixes the problem detected by the test > AutotestPrivateApiTest.AutotestPrivate (method execution after destruction > of CupsPrintersManager object). > > BUG=chromium:816996 > TEST=Tested on cave with the use of CL:1451591 > TBR=achuith@chromium.org > > Change-Id: I70958421aadd9fab9a2401555bef0dbb28ad5a6a > Reviewed-on: https://chromium-review.googlesource.com/c/1491909 > Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636618} TBR=achuith@chromium.org,emaxx@chromium.org,skau@chromium.org,pawliczek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:816996 Change-Id: I22e41f42fe812f6d1f080585ee8cc40e51a2dd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504652Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#637928}
-
Lei Zhang authored
Add new owners and remove inactive owners. Change-Id: I4dc7dc5317ea7b261ef7794072f85c58db1b33a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504305 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637927}
-
kdillon authored
This cl upstreams the tests that were translated in this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1475004 It also deletes some of the redundant tests in wpt/workers as a result of the move. Bug: 795636 Change-Id: Ic5678837dd9314c064f9e8a25bdb62468bfcb49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500938Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#637926}
-
Robbie McElrath authored
These recently started failing. See the bug. Bug: 938672 Change-Id: I259afc8c760f4153b095f1041a68109666a24cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504454Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#637925}
-
Steven Bennetts authored
The constants subdirectories were inadvertently defined as source sets, even though they are included by mulitiple libraries. This causes ODR violations in asan component builds. Sinces these are just constants it should not affect any runtime behavior. This CL also adds a BUILD.gn file to each subdir and cleans up a few unnecessary dependencies. For mechanical BUILD.gn changes: TBR=sky@chromium.org Bug: 933063 Change-Id: I05195779ddd606c4ad33ae7c1c713044a8cb089e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495862Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637924}
-
Tao Bai authored
This patch Instantiates the ContentCapture in ChromeAndroid and WebView if the feature is enabled. Bug: 924681 Change-Id: Id4da70b57d66e60680c3f605a9a76548457a2caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495436Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637923}
-
Khushal authored
Enable AImageReader and VizDisplayCompositor if SurfaceControl is enabled. Bug: 889328 Change-Id: Ief585c25563c9224cb9c8f77dccb4c6eb1548135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504225 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#637922}
-
Lei Zhang authored
Bug: 61248 Change-Id: Ib3a23abaa3ad6772c2af7cba6b333c33f901eb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503905 Commit-Queue: dstockwell <dstockwell@chromium.org> Auto-Submit: Lei Zhang <thestig@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637921}
-
Reid Kleckner authored
I wrote many words. Please skim them. We can put more things here as time passes. R=hans@chromium.org, inglorion@chromium.org, thakis@chromium.org Change-Id: I1e248446bad423bcb537373bf6c08994fd8e2c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496321 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#637920}
-
Stefan Zager authored
For the javascript IntersectionObserver class, when new notifications are generated, a task is posted to deliver the notifications (i.e., run the javascript callback). Because the task is put in the regular task queue, there's no guarantee when it will run. For blink-internal users of IntersectionObserver, it doesn't make sense to post a task to deliver the observations -- and this may even lead to correctness issues or other bugs. The bug link on this CL refers to an old bug of this kind which was previously fixed using a gross but necessary hack. This patch changes IntersectionObserver so that non-javascript observers will deliver notifications synchronously as they are generated. R=chrishtr@chromium.org,mlamouri@chromium.org Bug: 590856 Change-Id: I2f91f23a01288214209f901bc582717678312dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501655 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#637919}
-
Matt Menke authored
Merge ClientSocketPoolManager's SocketPools into a single map. Also refactor calls to request a socket from the socket pools to take advantage of the new map. BUG=472729, 921369 Change-Id: Ibef6944c627587832060d95ef1d26aa7915eace7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497351 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#637918}
-
Thomas Guilbert authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/493155af054c..86ce4a3c50c0 $ git log 493155af0..86ce4a3c5 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 martin arm64: cdef: Clarify a slightly confusing comment 2019-03-05 martin arm64: cdef: Use a smarter padding constant 2019-03-05 martin arm64: cdef: Do saturating subtractions to avoid max operations with 0 2019-03-05 kylesiefring Utilize a better CDEF constant for avx2 2019-03-04 jb On the road to 0.2.1 2019-03-03 kylesiefring Remove unused data from x86/cdef.asm 2019-02-15 fcvlcdev x86: add SSSE3 mc prep_8tap implementation 2019-03-03 kylesiefring Speed up finding the best cost in avx2 cdef 2019-03-01 jamrial windres: fix the version number string Created with: roll-dep src/third_party/dav1d/libdav1d Bug: 924370 Change-Id: I55c2f35e6afb8910e3ae1c85c15ed58a948b6989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504337 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#637917}
-
Ken Rockot authored
Corrects string payload size computation to use the actual UTF8-encoded byte length rather than string length. Bug: 935332 Change-Id: I8be84c165312bda1755762ff1876825021f885ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494314Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#637916}
-
Chris Cunningham authored
Originally reviewed-on: https://chromium-review.googlesource.com/c/1292605 No change to the files in the reland. Added new web test. The issue that caused the revert is addressed in dependent CLs (crbug/911823). -- begin original commit msg -- Without the ffmpeg decoder configured, libavformat is unable to get the codec profile and chromium ffmpeg wrapper code choose some defaults. This will mess up the decode scenarios where non-ffmpeg decoders like vaapi are in use. Fortunately, we can still get hold of the ffmpeg's AVStream extradata param which should contain the H264 AVCDecoderConfigurationRecord (ISO/IEC 14496-15). So we use internal parser for extracting profile information from this AVCDecoderConfigurationRecord. BUG=784610,911823 TEST=media_unittests:FFmpegCommonTest.VerifyH264Profile TBR=tguilbert@chromium.org Change-Id: I021fb2c92e56846824a9e362d8f3ec8665724fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1362468Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#637915}
-
Miyoung Shin authored
- short -> int16_t except layout_theme_mac.mm. - int -> uint8_t, short -> float in layout_theme_mac.mm. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I2d8beb79720350f14c99f82a8d53acdd5833e99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501773Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637914}
-
Hiroshige Hayashizaki authored
Previously, ScriptLoader::IsValidScriptTypeAndLanguage() returns false for "importmap" type if import maps are not enabled. However, when import maps can be enabled via origin trials, checking whether import maps are enabled requires ExecutionContext, which is not trivial in IsValidScriptTypeAndLanguage(), especially because it is called from HTMLTreeBuilderSimulator used by background parsers. Therefore, this CL removes the check and makes "importmap" always valid in IsValidScriptTypeAndLanguage(). Instead, import maps are ignored subsequently in PrepareScript() (in ParseAndRegisterImportMap()). There are slight behavior changes that are probably acceptable as these affects only pages with <script type="importmap"> on browsers where import maps are not enabled. - UseCounter in HTMLScriptElement::InsertedInto() - HTMLTreeBuilderSimulator considers <script type="importmap"> always as kValidScriptStart. - In PrepareScript(), <script type="importmap"> is rejected slightly later. Bug: 829084 Change-Id: Iebdfe158ecebee4c310ffca88fd77f3133856035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502000 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#637913}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/heap with the macros of Allocator. After some analyzes, it was concluded that for the case of GlobalPool, View, PrefinalizerRegistration, BlinkGCObserver, ThingWithDestructor, and AtomicEntryFlag classes, they make sense to use DISALLOW_NEW because they have been used as a member variable with a reference type. In ThreadHeap, HeapCompact::MovableObjectFixups, ThreadHeapStatsCollector, KeyWithCopyingMoveConstructor, ThreadMarker, OffHeapInt, Visitor classes, they make sense to use USING_FAST_MALLOC because they're used with new or smart pointers. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED or STATIC_ONLY. Bug: 919389 Change-Id: Ib3e5c90650f35370cbb2041b46042b8aa0db37c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502254Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#637912}
-
Takuto Ikuta authored
For better build throughput. Also I think we don't need this copy here introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1403335 Bug: 938011 Change-Id: I1351f46451bd67d2b9095b6b16c97495311c732c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503175 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#637911}
-
Miyoung Shin authored
- short -> uint16_t to refer to https://codereview.chromium.org/1653973005 - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I4d3129762881a430ce2eb18bd826e89fd0017d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502260Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637910}
-
Kevin Marshall authored
Change the FIDL interface QueryableData::GetAllEntries() to GetChangedEntries(), which is identical to the current implementation on the first invocation but on, but for subsequent invocations it uses hanging callbacks to send incremental changes to the client. The change is necessary for allowing QueryableData values to change at page runtime. Implementation of support for incremental change events are reserved for a followup CL. Bug: 929291 Change-Id: I7af7e77130eff55699a90fd5aff0a581bf3e3dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500021 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#637909}
-
Thomas Tangl authored
- Associate the sync-setup row on the people page to the sync-controls page to make the sync controls searchable. - Hide the sync controls when not available, so they don't show up during a search. Additional: - Fix syncStatus update for settings-sync-controls when unified consent is disabled. (syncStatus wasn't used before.) Bug: 916988 Change-Id: I5cc73cc32a03fb3960fe57e9075a16a6b31d2afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498531 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#637908}
-
Shakti Sahu authored
Added calls to android DownloadManager (AddCompletedDownload and RemoveCompletedDownload) from native offline content provider. Also added a feature to selectively disable the native path for now. Bug: 933854 Change-Id: I178ab17063f6914b523219c308a6abaa3133452c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1422747 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#637907}
-
Aaron Colwell authored
Temporary workaround for avoiding crash reporting when BlobURLStoreImpl::Revoke() is called after the RPHI associated with the object has already been destroyed. This is similar to the behavior allowed before http://crrev.com/c/1409732 and is intended to be a minimal fix that can be merged to M73. Bug: 933089 Change-Id: I734d752f1fb10a882361c7e6af0716df08ac00f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501494 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#637906}
-
Jeremy Apthorp authored
<asm/ptrace-abi.h> doesn't exist in the arm sysroots, and <sys/ptrace.h> defines PTRACE_GET_THREAD_AREA as an enum, not a #define: /* Get the thread pointer of a process. */ PTRACE_GET_THREAD_AREA = 22, On aarch64, neither PT_GET_THREAD_AREA nor PTRACE_GET_THREAD_AREA are defined. This changes the include trigger to check for !arm && !aarch64 as well as defined(PTRACE_GET_THREAD_AREA) to catch the arm and aarch64 cases. Change-Id: I9044d9f315cbb15011f397a06d03d4bec7396985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496448Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#637905}
-
- 05 Mar, 2019 3 commits
-
-
Nate Chapin authored
The spec says to use the target window, not the source window, but we have some bugs around this targeting that may be breaking real websites. Temporary go back to the spec-violating way, as the breakage appears to be smaller. Bug: 935064 Change-Id: Ie1fd3030cbe8700820d1b8631bb3d318259e3380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504160 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#637904}
-
Nigel Tao authored
This HSL shift effect is used to present disabled or grayed-out versions of app icons and tab favicons. Changing this (from 0.75) in two places: chrome/browser/ui/app_list/arc/arc_app_icon_loader.cc:61 chrome/browser/ui/extensions/icon_with_badge_image_source.cc:85 makes it consistent with four other places (which already used 0.6): chrome/browser/extensions/chrome_app_icon.cc:83 chrome/browser/extensions/extension_icon_manager.cc:77 chrome/browser/favicon/favicon_utils.cc:26 chrome/browser/ui/app_list/chrome_app_list_item.cc:48 Change-Id: I67fbf5e0522ec17f8a248868091a8a624241e62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496131Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637903}
-
Pete Williamson authored
The MediaColorTest is failing on ChromeOS. https://crbug.com/938618 Bug: 938618 TBR: timvolodine@chromium.org Change-Id: I59db4abec0b91b0a3f93687b2face2babcd4b5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504260Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Auto-Submit: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#637902}
-