GitLab

Tests communication between WebUI page and the native code.
When page is loaded it sends "syn" message to the native code,
when native code receives "syn" it replies back with "ack",
when page receives "ack" it replies back with "fin". Once "fin" is
received the test succeeds.

BUG=567809

Review-Url: https://codereview.chromium.org/2006273005
Cr-Commit-Position: refs/heads/master@{#396972}

BUG=600908
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2010333004
Cr-Commit-Position: refs/heads/master@{#396971}

1) Lazy loading of Polymer was causing flakiness in a set of tests.
2) It also fixes the bug where the overflow menu icon was not appearing on hover.

BUG=610362, 611619, 615085
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2007133006
Cr-Commit-Position: refs/heads/master@{#396970}

Note that the actual samples to each multisamples renderbuffer is actually
implementation dependent - they could be upgraded. So in theory, a framebuffer
with attachments of samples 1,2,4 could still be complete, whereas a framebuffer
with attachments of samples 2,2,2 could be incomplete even if no other violations exist.

However, to ensure consistent behaviors across platforms, it's better we use
passed-in samples to do this validation.

BUG=429053
TEST=gpu_unittests,fbocompleteness.html in webgl2 conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2024133003
Cr-Commit-Position: refs/heads/master@{#396969}

Review-Url: https://codereview.chromium.org/2024693002
Cr-Commit-Position: refs/heads/master@{#396968}

The RequestPicker is responsible for choosing which request from the
request queue to process next.  It will apply policies from the policy
class to the data returned by the request queue, pick a likely
candidate, and call back to the request coordinator so it can start
offlining the candidate.  If there is no candidate, it will call back
to the request coordinator to let it know processing is done for this
cycle.

BUG=610521

Review-Url: https://codereview.chromium.org/2020833002
Cr-Commit-Position: refs/heads/master@{#396967}

This isn't the perfect fix, but it's easy and doesn't require us to
figure out how to draw shadows.

This also uses the DecorView's height instead of the WindowManager's Display's height in order to work well in multi-window mode.

BUG=614300,603536

Review-Url: https://codereview.chromium.org/2018213002
Cr-Commit-Position: refs/heads/master@{#396966}

Revert of Re-enable InfoBarTest#testInfoBarForPopUp (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2020853002/ )

Reason for revert:
The renderer issue is causing the test to fail even on the bots.  Bleh.

Original issue's description:
> Re-enable InfoBarTest#testInfoBarForPopUp
>
> Looks like a renderer issue on debug builds and not a real test failure.
>
> BUG=593003
>
> Committed: https://crrev.com/7b6931415d9cb570158a84ef4acb2e3e99d2c8e9
> Cr-Commit-Position: refs/heads/master@{#396899}

TBR=yusufo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593003

Review-Url: https://codereview.chromium.org/2030433002
Cr-Commit-Position: refs/heads/master@{#396965}

I would add a test for this, but one already exists, it's just disabled:
BrowserCommandControllerBrowserTest.NewAvatarMenuEnabledInGuestMode

BUG=471953,614607

Review-Url: https://codereview.chromium.org/2023523002
Cr-Commit-Position: refs/heads/master@{#396964}

This is necessary to ensure flush callback is called outside of
VideoRenderer::lock_ thus allowing the callback code to access
VideoRender methods. AudioRendererImpl already does the same thing.

Review-Url: https://codereview.chromium.org/2012903002
Cr-Commit-Position: refs/heads/master@{#396963}

BUG=590856
R=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2022013004 .

Cr-Commit-Position: refs/heads/master@{#396962}

Refcounted object is initialized to have zero refcount and will be increased
to 1 in RefCountedThreadSafe::operator=(). There is a chance that
ConnectToHost finishes earlier than operator=(), which drops the refcount to
0 and triggers the d'tor.

Adding sleep(1) after PostTask() shows stable repro of this problem.

This CL fixes this problem by pulling the PostTask code out of the ctor.

BUG=615288

Review-Url: https://codereview.chromium.org/2023113002
Cr-Commit-Position: refs/heads/master@{#396961}

https://chromium.googlesource.com/skia.git/+log/18c4943e90db..ce8ea4c55b6e

$ git log 18c4943e9..ce8ea4c55 --date=short --no-merges --format='%ad %ae %s'
2016-05-31 jcgregorio skiaserve: Add /quitquitquit handler. Will be used in the hosted debugger.
2016-05-31 robertphillips Make use of new SkLights class
2016-05-31 scroggo Fix build error
2016-05-31 mboc SkTypeface::MakeFromName to take SkFontStyle.
2016-05-31 halcanary SkXPS: clean up SkConstexprMath
2016-05-31 halcanary SkEncodedInfo: simplify
2016-05-31 bsalomon Fix bug where SkPath will convert an arc to an oval and change the starting point.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2026893002
Cr-Commit-Position: refs/heads/master@{#396960}

This broke because menuItems are not the descendants of the currently focused item.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2028793002
Cr-Commit-Position: refs/heads/master@{#396959}

This will shift it to using a GN config, without x64/x86 specified
explicitly. It uses the exact same mixins as the 'win_clang_debug_bot'
mixin, except with the additional GPU-specific configs as well.

BUG=angleproject:1311

Review-Url: https://codereview.chromium.org/2020993003
Cr-Commit-Position: refs/heads/master@{#396958}

If the security icon state changes faster than the time it takes for
Android to relayout, hide animation might be called even before the
security icon's visibility has been flipped. This CL fixes the bug in
this scenario.

BUG=612939

Review-Url: https://codereview.chromium.org/2024173003
Cr-Commit-Position: refs/heads/master@{#396957}

Use the prediction type and max length attribute of the field to determine the number (if any) of character to truncate from the start of the expiration year when filling an input field.

BUG=616174
TEST=AutofillFieldTest

Review-Url: https://codereview.chromium.org/2025063002
Cr-Commit-Position: refs/heads/master@{#396956}

Summary of changes:
- We actually have 3 places where GlassPanes are instantiated [Dialogs, Options
in Toolbar, DraggingElements (e.g. Colorpicker)]
- DefaultFocusedViewStack is not necessary and is removed.  Previously, it was
only used by Dialogs anyways.  Dialogs are the only GlassPanes that will save
the previously focused element and call .focus() when the dialog closes
- Showing a different tab (switching to a drawer panel) will now focus on the
new tab, if no previous focus was set
- DeviceMode's toolbar previously depended on .setSelectionRange() to keep focus
in its size input field while resizing.  Now, dragging the splitter won't steal
focus at all, so DeviceMode doesn't need to force focus on itself
- When using the Command Menu to open a panel/file, it will close the GlassPane
first (which may call .focus() on the previous element) before calling .show()
on the new panel/file, so that the new panel/file gets the final focus

BUG=604427, 609013, 612397

Review-Url: https://codereview.chromium.org/2016963002
Cr-Commit-Position: refs/heads/master@{#396955}

R=bradnelson@chromium.org
BUG=605732

Review-Url: https://codereview.chromium.org/2001163003
Cr-Commit-Position: refs/heads/master@{#396954}

This reverts https://codereview.chromium.org/7655040

We don't use ATS any more, and we don't support OS X 10.7 any more.

BUG=93191,579255
TBR=avi

Review-Url: https://codereview.chromium.org/2025133002
Cr-Commit-Position: refs/heads/master@{#396953}

Review-Url: https://codereview.chromium.org/2000253006
Cr-Commit-Position: refs/heads/master@{#396952}

As a side-effect, this patch changes the system to no longer invalidate both the scrolling contents layer and m_graphicsLayer, since they now have different coordinate systems. (This has been a long-standing bug.)

BUG=529938,416535

Review-Url: https://codereview.chromium.org/2019583002
Cr-Commit-Position: refs/heads/master@{#396951}

The KeyboardDevice class is a subclass of InputDevice that adds no new
functionality. This makes it unnecessary and adds additional burden when
designing Mojo structs to move around input device information.

Remove the KeyboardDevice class and replace all uses with InputDevice
instead.

BUG=601981

Review-Url: https://codereview.chromium.org/2019413002
Cr-Commit-Position: refs/heads/master@{#396950}

A new message-loop is created for each test, and when the message-loop dies
after a test, it takes down the all connections to mojo:mus from
WindowManagerConnection (and other places). So it is necessary to recreate the
WindowManagerConnection for each test.

BUG=none

Review-Url: https://codereview.chromium.org/2023933002
Cr-Commit-Position: refs/heads/master@{#396949}

Often times dbus dependencies get added without proper guards.
By guarding the component with assert(use_dbus) it forces proper guarding
when depending on dbus. This prevents downstream breakages in
chromecast.

BUG=internal b/28962923

Review-Url: https://codereview.chromium.org/2009983002
Cr-Commit-Position: refs/heads/master@{#396948}

This reflects the change in ag/1087804.

BUG=616159

Review-Url: https://codereview.chromium.org/2026913002
Cr-Commit-Position: refs/heads/master@{#396947}

BUG=chromedriver:1387
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2016403002
Cr-Commit-Position: refs/heads/master@{#396946}

BUG=470311

Review-Url: https://codereview.chromium.org/2015303002
Cr-Commit-Position: refs/heads/master@{#396945}

This deletes the update_layer_list that gets constructed but
never used in ComputeVisibleRects.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2022203003
Cr-Commit-Position: refs/heads/master@{#396944}

Each time your finger moved we were interrupting and speaking the same
object again.

BUG=613694
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2010493004
Cr-Commit-Position: refs/heads/master@{#396943}

StringView no longer owns the string passed into it, and can now wrap
a raw ptr to some characters.

This allows us to leverage the inline strlen optimization where the
compiler will embed the length of literal strings into the binary. It
also allows the deletion many overloaded methods that used to take
an LChar*, UChar* or String and can now just take a StringView instead.

For example the two constructors in TextRun are now a single one that
takes a StringView. This needed to be done in this patch to avoid
ambiguous constructors.

Future patches will replace CSSParserString with StringView, and also
vastly simplify the huge number of overloads on various methods. We'll
also expand the API surface of StringView to include the many useful
operations that StringPiece has.

This was originally committed as:
https://crrev.com/330deea56e27bc760fa52101040a51428bb7f582 but was
reverted due an incorrect assert in the
StringView(const UChar*, unsigned length) constructor. The assert
was incorrectly calling lengthOfNullTerminatedString on the UChar
in the assert, but this constructor is used for byte sequences which
are not null terminated.

BUG=615174

Review-Url: https://codereview.chromium.org/2007103003
Cr-Commit-Position: refs/heads/master@{#396942}

BUG=611802
TBR=danakj@chromium.org for cc/test
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2023973002
Cr-Commit-Position: refs/heads/master@{#396941}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5897bfeb..f36d9c4e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2024703004
Cr-Commit-Position: refs/heads/master@{#396940}

quic_protocol.h clean of chromium only code.

BUG=

Review-Url: https://codereview.chromium.org/2028803002
Cr-Commit-Position: refs/heads/master@{#396939}

Currently, the External Estimate Provider (EEP) may get
called multiple times per connection change. This CL ensures
that EEP is called exactly once per connection change.

This CL also updates the callback to UpdatedEstimateDelegate.
The callback now contains the updated estimates. This means
that the delegate does not have to query for those estimates
on receiving the callback. It makes the logic easier to
understand.

BUG=604417

Review-Url: https://codereview.chromium.org/2010003002
Cr-Commit-Position: refs/heads/master@{#396938}

BUG=606985

Review-Url: https://codereview.chromium.org/2026793002
Cr-Commit-Position: refs/heads/master@{#396937}

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Review-Url: https://codereview.chromium.org/2018223002
Cr-Commit-Position: refs/heads/master@{#396936}

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2025893003
Cr-Commit-Position: refs/heads/master@{#396935}

This CL completes ScreenWin's migration to be multiple DPI capable. Scaling
functions now attempt to resolve the DPI context based off of the HWND or
argument location if the HWND is unavailable.

An example of this is in ScreenWin's unittests. All calls that could change the
global default device scale factor have been removed.

The last remaining step is to hook up the monitor DPI specific info to ScreenWin
once multiple DPI mode is enabled.

The visual behavior of Chrome should not change with this CL.

BUG=426656,501259

Review-Url: https://codereview.chromium.org/2012083002
Cr-Commit-Position: refs/heads/master@{#396934}

Plumb unmodified HTTP/2 stream weight value through SPDY framing code
(SpdyHeadersIR and SpdyFramerVisitorInterface::OnHeaders()).

This CL lands server changes 116592396 by mpw and 123319972 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2018513002
Cr-Commit-Position: refs/heads/master@{#396933}