- 08 Nov, 2019 40 commits
-
-
Sylvain Defresne authored
BrowserViewControllerTest just want to fake TabModel and provide stub implementation for webStateList and browserState properties so implement this with a nice mock & OCMStub(...).andReturn(...). Bug: none Change-Id: I64f3ddcef206f9ba6f9ce78b2827f37e984746b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903360 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713778}
-
Sylvain Defresne authored
At initialisation, ios_web_unittests.app tries to load resources and prints the following error because the file cannot be found: [xxxx:ERROR:memory_mapped_file.cc(60)] Couldn't open .../ios_web_unittests.app/resources.pak Add a dependency on //ios/web/test:packed_resources to ensure that the resources are shipped with the application and thus can be found at runtime (currently it is not a problem because none of the test depends on the resources, but having them does not hurt). Bug: none Change-Id: Ic7b6194c3b6f0240bc12091e8cf944c9e76261a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903139 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Javier Fernandez authored
This CL changes the runtime flag to stable and enables the feature by default. The intent-to-ship request [1] has been approved, under the condition of improving the test suite and increasing the testing coverage of the feature. These tests has been added already in a different CL [2]. [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/8qesjfh0a80/xrruWrixBwAJ [2] https://crrev.com/c/1904077 Bug: 905315 Change-Id: I1e78599777436989fefcd988c04074f33cbf452d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900002 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713776}
-
Mihai Sardarescu authored
Support for channel ID binding was removed from Chrome a while back. This CL removes some boolean that was referring to channel ID binding from uber token fetcher. Fixed: 1021455 Change-Id: I195056e7b3a2446afc1714c7394040b0171b6602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899851Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713775}
-
arthursonzogni authored
This is a preparatory CL for step 1.a from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Step 1.a is about merging the CSPSource strucs into one. This patch aligns the CSPSource struct. This moved "allow_self" and the implicit "allow_star" into the CSPSourceList. This is already what content/ and blink/ are doing. Follow-ups: https://chromium-review.googlesource.com/c/chromium/src/+/1899450 Bug: 1021462 Change-Id: I894bdcb8fbc5bd64b87b9a60334ec21874f5e8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901041Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#713774}
-
Mohamed Amir Yosef authored
Bug: 831123 Change-Id: Idbf82649bb3cf8fa66d9576c6f9ae34c37bae9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900997 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#713773}
-
Armando Miraglia authored
While testing locally I have encountered and issue such that an interface would be bound while already bound. This fixes that behavior so that the related DCHECK is not triggered. Similar issue and fix: http://crbug.com/817873#c7 Bug: 997661 Change-Id: Ifcd1342bd9cbf2c2895e5b7f2c1967c06b2a84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903197Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#713772}
-
Friedrich Horschig authored
Add a show_confirmation_button parameter. The current default and wanted behavior is "false". Bug: None Change-Id: I13f368e6822e3d26d041c671f2ab650976500ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904069Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#713771}
-
Friedrich Horschig authored
Change title case buttons to sentence cases. Bug: None Change-Id: I670aa17ce81ab1fa7bebe3897af005ea7621f88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904066Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#713770}
-
Marc Treib authored
ChromeBrowserSyncAdapter was an old implementation of Sync invalidations which is not needed anymore, and hence was removed. However, it *also* caused Chrome to show up as a "syncable" app in Android settings. This CL brings back the required parts of ChromeBrowserSyncAdapter (and the corresponding ..Service and manifest entry) so that Chrome shows up in (and honors) Android's sync settings again. This is a partial revert of crrev.com/c/1821784 and crrev.com/c/1829201. Bug: 1021873 Change-Id: I13cb78fa2391f289763629620c69cf3a6c19e494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903198Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#713769}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f9004ee81c43..5758cc96a5f3 git log f9004ee81c43..5758cc96a5f3 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 perezju@chromium.org Reland "[Telemetry] Hand over trace aggregation to Results Processor" Created with: gclient setdep -r src/third_party/catapult@5758cc96a5f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:981349 Change-Id: I7530a2bd445dc225e3efb7f82d385614d8b28b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713768}
-
James Cook authored
store_factory_ is moved into then immediately moved out of. There are no other references other than the constructor, so remove it. Bug: none Change-Id: I5deb48f781937ef86c419c86d4aa3621f1e8ce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903834 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#713767}
-
Armando Miraglia authored
This reverts commit b4f53fc9. Reason for revert: [WebRTC Sheriff] It looks like this has broken all webrtc bots (see https://ci.chromium.org/p/chromium/g/chromium.webrtc/console?limit=200). Original change's description: > Stop building frame_analyzer in gn_all. > > Building WebRTC's frame_analyzer when is_component_build=true will > fail after [1] lands. It is possible to build it only for release > builds but this CL tries to remove it since probably this is not > needed. > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 > > Bug: webrtc:9419 > Change-Id: I6da6973b8a50ea08b60f0eea0da57014cce830e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904072 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713590} TBR=dpranke@chromium.org,ehmaldonado@chromium.org,mbonadei@chromium.org Change-Id: Ie9f312a7ac1e5d75acfd49f10fa648cbd9291876 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904174Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#713766}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/652dbfc63e70..7f9c9a7fc001 git log 652dbfc63e70..7f9c9a7fc001 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src dc59b4b075e9..041f0a02493d (4 commits) Created with: gclient setdep -r src/third_party/angle@7f9c9a7fc001 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: Ia517435cb28a3d2f33c8ff754662217736c40364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905277Reviewed-by:
-
Rob Buis authored
Make display:contents compute to display:none for MathML elements as specified here: https://drafts.csswg.org/css-display/#unbox-mathml Bug: 6606 Change-Id: Ifb68940dd345a41ca5fe083dc5b5ba9ace1af506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903136Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#713764}
-
Michael Lippautz authored
The idea of the bailout during incremental marking is correct. Unfortunately, the query used just returns whether local processing with the current set of buffers is done. This is wrong as we still may be marking incrementally. This CL switches to the proper accessor for incremental marking. Bug: 1019839, 1021171 Change-Id: I798ba08b8c491543095dd5018325812f7de0d6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904169Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713763}
-
John Budorick authored
Bug: 1022534 Change-Id: I60b30c79b20698e06fa2548af373498db68ac6fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904490 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cc4b158ee494..8c6f1f9af3f4 git log cc4b158ee494..8c6f1f9af3f4 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 vapier@chromium.org dev-install: stop including the Chrome milestone 2019-11-08 vapier@chromium.org dev-install: stop including canary- version prefix Created with: gclient setdep -r src/third_party/chromite@8c6f1f9af3f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I58e3adf5a0743cd9c5d31d1725f111f415c49f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904237Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Icc586bb214f2198e96e9f7027066f1c7028d3990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903243 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#713760}
-
Austin Tankiang authored
Bug: 1003238 Change-Id: I88ec141acd23900f7be259a34d27a8bc118e43ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896492 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#713759}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |NGCaretPosition::CurrentPaintFragment()| for improving code health. This is follow-up of the pathc[1] which introduce |CurrentPaintFragment()|. [1] http://crrev.com/c/1866101 Utilize NGInlineCursor in NGCaretPosition Bug: 982194 Change-Id: I20b4c332476462d3c0fdb079e4600f14580f6dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905294 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/76eaab6b8cef..99b558b594a1 git log 76eaab6b8cef..99b558b594a1 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cc0919dcb64b..652dbfc63e70 (7 commits) 2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 27a3d31d7a9d..d9ed1c2732ba (1 commits) Created with: gclient setdep -r src/third_party/skia@99b558b594a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None,chromium:None Change-Id: I1756c32d56fcbc2aff8858857bf69871d8b861d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905269Reviewed-by:
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I3197389c82d969e96490d2ecbb2600a0332528e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901080 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713756}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/29e8c96f..2af5f573 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib80a22e220bcdd8e8f7abd1e6cf213fb938a1d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905008Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713755}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibf47e8d539b96bba0860d200fca913f27f59064d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904345Reviewed-by:
-
Alan Cutter authored
This CL updates the PWA manifest update check to compare with a WebApplicationInfo generated from the page's blink::Manifest instead of the manifest directly. PWA installation uses the blink::Manifest -> WebApplicationInfo conversion so we must also use the same when comparing for differences. At the moment we only check theme_color which doesn't undergo any transformations at install time so it's fine. This is in preparation for comparing on other fields e.g. icon URLs which may go through sanitisation. This CL is a refactor with no changes in behaviour. Bug: 926083 Change-Id: I477f5e4ff936f4d4fee078be0e830b39730bf06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905041 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#713753}
-
Hiroki Nakagawa authored
This enables 'module' type option, static import, and dynamic import on dedicated workers. let worker = new Worker('worker.js', { type: 'module' }); Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hnIOyxASKFU Chrome status: https://www.chromestatus.com/feature/5761300827209728 Bug: 680046 Change-Id: I463d3dcac57694415f815e3c81f2618ab8baf4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844524Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#713752}
-
Austin Tankiang authored
This removes the code that handles the underlying operations of the file system. Bug: 1003238 Change-Id: I9ddfbc98d57837ca4c4e9df71a68048fdddf673e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896487 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
To reduce disk space usage and disk IO during startup. In Chrome OS, chromeos-chrome ebuild installs chrome.conf busconfig file whose only contents is: <includedir>/opt/google/chrome/dbus</includedir> concat_dbus_conf_files.py concatenates busconfig files in /opt/google/chrome/dbus by merging each conf file's <busconfig> into one. This is exactly the same thing as what <includedir> tag in chrome.conf does so there should be no functional changes. Before this CL: chrome.conf includes 17 busconfig files in /opt/google/chrome/dbus After this CL: chrome.conf includes only 2 files (i.e. chrome_dbus_services.conf and ash_dbus_services.conf). BUG=1020044 TEST=Manually confirmed the contents of out.conf after running chromeos/tools/concat_dbus_conffiles.py out.conf ash/dbus/*.conf TEST=Chrome boots after replacing the contents of /opt/google/chrome/dbus TEST=Can call org.chromium.LivenessServiceInterface.CheckLiveness with dbus-send Change-Id: Id0e572c2834a6ebec8f2e385bfbe6d1ee67fc37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895021 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713750}
-
Alexey Baskakov authored
Fix: Remove DCHECK in WebAppDatabase::Write. There can still be metadata changes even if there are no local data updates. Add follow up tests for MergeSyncData. See this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1830494 In next CL: 1) Add WebAppSyncBridge::ApplySyncChanges unit tests. 2) Add WebAppSyncBridge::CommitUpdate unit tests (UpdateSync). Bug: 860583 Change-Id: Ibba871c29034f928eba846d1e4973ac2c900d803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903173 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Test: Test tab navigation behavior manually. Bug: None Change-Id: Ifa963b2f234017357f1dcb61be726a2e2c421fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905036 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#713748}
-
Austin Tankiang authored
Bug: 1003238 Change-Id: I4034c4e4da85818cf9959e1d3204ef81b36a19c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896489Reviewed-by:
-
Keith Lee authored
The TextInputClients are responsible for updating the committed text correctly, as TextInputClients should be aware of the current composition and text selection. Currently, the TextInputClient::ConfirmComposingText() implementation says that clients have to confirm the composing text, but it does not specify what should happen to the selection. It makes sense to add a new keep_selection parameter to indicate if we want to leave the selection range unchanged when committing text. Modified the TextInputClient::ConfirmComposingText() to have a keep_selection parameter and use it in the RenderHostWidgetViewAura::ConfirmCompositionText() function implementation. Modified InputMethodEngineBase::ConfirmCompositionText(bool reset_engine) and InputMethod::ConfirmCompositionText(bool reset_engine) to also pipe the parameter to the API layer. This allows us to easily implement a new API chrome.inputMethodPrivate.finishComposing which will commit the text currently being composed, without changing the selected text This API will not work correctly until all TextInputClient::ConfirmComposingText() have been updated to not modify the selection when the keep_selection param is set, but those changes will be made in a separate CL to avoid this CL becoming too big. Changes to third_party/closure_compiler/externs/input_method_private.js were generated by running: ``` python tools/json_schema_compiler/compiler.py /usr/local/google/home/keithlee/chromium/src/chrome/common/extensions/api/input_method_private.json --root=. --generator=externs > /usr/local/google/home/keithlee/chromium/src/third_party/closure_compiler/externs/input_method_private.js ``` Change-Id: Ieb5daac3cc3bf890c7062394c64ec53976c7d64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885149Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#713746}
-
Aaron Colwell authored
Bug: 1021779, 1016711 Change-Id: I77763126e83505a49f086de87a4e4dd08304ca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904813 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#713745}
-
Rob Schonberger authored
Should be similar to the Heuristic flag. Note the comment intended to strongly discourage usage. Bug: 1009290 Change-Id: I0e4e60f77e94b727573cdaeacaae6de6d2704459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903110 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713744}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e471df3c9154..f34cdc70ca1b git log e471df3c9154..f34cdc70ca1b --date=short --no-merges --format='%ad %ae %s' 2019-11-08 johnkslang@users.noreply.github.com Merge pull request #1968 from dneto0/reclaim-web-codespace 2019-11-08 johnkslang@users.noreply.github.com Merge pull request #1967 from kainino0x/fix-dot-free Created with: gclient setdep -r src/third_party/glslang/src@f34cdc70ca1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I6cc9bc386b1df9f356cd6281666fd8ec2398dfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905107Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLTemplateElement> and DynamicTo<HTMLTemplateElement> as new downcast helper 2. Use IsA<HTMLTemplateElement>(element) in place of IsHTMLTemplateElement(element) Bug: 891908 Change-Id: I4220214482d1c4a78b3f5ef2cd450fabdf00c823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901150 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#713742}
-
Takashi Sakamoto authored
This reverts commit 448ec6f6. Reason for revert: suspect causing 20 test suites failure on LinuxCFI bot. Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/15552 20 Test Suite(s) failed. blink_platform_unittests failed because of: HarfBuzzShaperTest.PositionForOffsetArabic ShapeResultBloberizerTest.SubRunWithZeroGlyphs ShapeResultTest.CopyRangeLatinMultiRunWithHoles HarfBuzzShaperTest.ResolveCandidateRunsArabicThaiHanLatinTwice ...169 more failure(s) (173 total)... extensions_browsertests failed because of: UsbApiTest.InvalidTimeout PrinterProviderApiTest.GetCapabilitySuccess URLLoaderFactoryManagerBrowserTest.ContentScriptMatching_CssIsIgnored WebViewAPITest.TestPartitionChangeAfterNavigation ...168 more failure(s) (172 total)... vr_pixeltests failed because of: UiPixelTest.DrawVrBrowsingMode gfx_unittests failed because of: Glyphs/GetFallbackFontTest.GetFallbackFont/SDeseretL ...653 more failure(s) (654 total)... ...16 more test(s)... Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8897418562831814688/+/steps/content_browsertests/0/logs/Deterministic_failure:_AXImageAnnotatorTest.OnImageUpdated__status_CRASH_/0 Original change's description: > Build internals of Skia with c++17 > > Change-Id: I7fedc818b6fad5c08f37c8002268c65eefdf57a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757345 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713492} TBR=bsalomon@google.com,mtklein@chromium.org Change-Id: I898336f850b4303b8777b1e916a7f251aff4d9c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905042Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#713741}
-
Marina Sakai authored
The function |V8SetReturnValue| supports only data properties, and this CL makes it support accessor properties, too. Bug: 809011 Change-Id: Idb94d1b5129e3313b3e67a4b2f573dbd22588872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904561 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Austin Tankiang authored
Bug: 1003238 Change-Id: I7dd421fd8d8e91fd37289df898f6481d51aad9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896488Reviewed-by:
-
