- 17 Apr, 2018 40 commits
-
-
Xianzhu Wang authored
For now partial raster invalidation of SPv175+ is buggy. Disable it first to fix regressions. Pinpoint job for smoothness.tough_canvas_cases benchmark doesn't show performance regressions of this CL: https://pinpoint-dot-chromeperf.appspot.com/job/14b05086c40000 Bug: 833338, 833598 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I52545c5cc757f045afa3df1c98221a28f25d5689 Reviewed-on: https://chromium-review.googlesource.com/1013298Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551435}
-
Yang Guo authored
V8 introduced a new API that no longer requires the source string. Change-Id: If09c25a2892633a4aedadb62e963c50ffa291cbe Reviewed-on: https://chromium-review.googlesource.com/1013519 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#551434}
-
Vaclav Brozek authored
password_form_conversion_utils.cc used the constructor of std::unique_ptr explicitly. This is to be avoided in Chromium's code (//PRESUBMIT.py has a check against introducing new instances) and nullptr and std::make_unique are preferred. form_autofill_util.cc used a raw owning pointer and base::WrapUnique to convert it to std::unique_ptr. Instead, the owned object should be wrapped in unique_ptr since construction, to avoid the risk of introducing a leak later. This CL fixes both issues mentioned above. Bug: 833838 Change-Id: Id62f146e69a659bd594678989310f2d212151572 Reviewed-on: https://chromium-review.googlesource.com/1013716 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#551433}
-
rbpotter authored
Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I01397a7c4b94a2a3d3f71ef80d0fb38abd7f29dd Reviewed-on: https://chromium-review.googlesource.com/1011324Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551432}
-
Vaclav Brozek authored
SyntheticForm's data member fieldsets is only set and used once, in the same function. Therefore this CL reduces the size of SyntheticForm and extracts the fieldsets data member as a local variable in said function. Bug: 833838 Change-Id: Ie5970adf3b0a2c52c783e599b658d1d0f27473eb Reviewed-on: https://chromium-review.googlesource.com/1014043 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/130fd7666d42..30a2b933e3a0 $ git log 130fd7666..30a2b933e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icb5791b7c4cee1c7997ee59134506e426c08e836 Reviewed-on: https://chromium-review.googlesource.com/1015082 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551430}
-
Xiaocheng Hu authored
This patch deduplicates code in the function to improve code health, and also as a preparation for implementing NG version of bidi adjustment. Bug: 822575 Change-Id: Ia975338ff11d2e53d73f084e4b55419b03c2938c Reviewed-on: https://chromium-review.googlesource.com/997134 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551429}
-
Jennifer Apacible authored
BUG: 726619 Change-Id: I17314a2e1989cf2f2b760d9f931fd53272730440 Reviewed-on: https://chromium-review.googlesource.com/1013683Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#551428}
-
Daniel Erat authored
Enable mode-specific power button behavior by default. In short, tapping the power button turns the display off on devices that are in tablet mode but is ignored on devices that are in laptop mode. Bug: 819276, 783164 Change-Id: Ic658e034366a32066940c647a73b8c61ecec2840 Reviewed-on: https://chromium-review.googlesource.com/1014486 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#551427}
-
Steven Bennetts authored
Using a separate name div breaks dragging when the name is dragged and isn't necessary. Bug: 833036 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia9bcc8556018e9dd6d76e0dac6221ecbf85997c7 Reviewed-on: https://chromium-review.googlesource.com/1014624 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551426}
-
Vaclav Brozek authored
A SyntheticForm is an object created specifically for the GetPasswordForm function to consume. Yet, the function only takes a const reference of a SyntheticForm. This prevents the function from sparing some copies in moving data from a SyntheticForm to a PasswordForm. This CL changes the const reference to a plain value, moves the SyntheticForm via std::move on the callsites, and ensures that SyntheticForm has a move constructor. Bug: 833838 Change-Id: Iaee54b092c7f12b91b2afd35f4882b9d451ce668 Reviewed-on: https://chromium-review.googlesource.com/1013983 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/69a36a622381..055c0339565a $ git log 69a36a622..055c03395 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ulan Use top-level scheduler tasks in EQT metric. Created with: roll-dep src/third_party/catapult BUG=chromium:832651 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I47174a35e3658f1e5d17302f9cb3be9292bba63e Reviewed-on: https://chromium-review.googlesource.com/1014705Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551424}
-
Vaclav Brozek authored
SyntheticForm is an abstraction of a collection of form input elements for the purpose of creating PasswordForm objects based on DOM tree. It currently stores a reference to the web document, only to derive the form's origin from it later. This CL drops the reference to the web document and replaces it with the computed origin. This way, SyntheticForm does not keep an unnecessary amount of data alive. It does introduce one GURL copy, but that will be addressed in a separate CL by making GetPasswordForm consume a SyntheticForm instead of looking at its const reference. Bug: 833838 Change-Id: I33011146289b60bb50898f70f8001af6668a4203 Reviewed-on: https://chromium-review.googlesource.com/1014130 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Christopher Grant authored
Stale size is a risky element accessor that we no longer use (it's last remaining case was unused SnackBar code, which if reintroduced, should be reworked to use proper layout methods). BUG= R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ida852a9c7cfba668020d09824fa0a79ef12ddb63 Reviewed-on: https://chromium-review.googlesource.com/1007631 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551422}
-
bsheedy authored
Reduces the flakiness of testControllerClicksRegisteredOnDaydream in two ways: 1. Adds code to handle GVR briefly disconnecting then reconnecting the controller, which caused us to receive multiple gamepadconnected events. 2. Ensures any input that was sent to register the gamepad is drained before actually starting the test, as slow intents could be received later and cause the test to end earlier than expected. Bug: 831589 Change-Id: I8041030ef6ec177ad47216eb1c1ea9e0f875e7c4 Reviewed-on: https://chromium-review.googlesource.com/1012439Reviewed-by:Yash Malik <ymalik@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551421}
-
Benjamin Pastene authored
This thing has a pretty big effect on our cros bots. TBR=jbudorick@chromium.org Change-Id: Ic63ae04d448b0cf6e9328226d518779f102a5686 Reviewed-on: https://chromium-review.googlesource.com/1015627Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#551420}
-
Jiaquan He authored
This commit skips some logic when the AppListClient pointer is not set in AppListControllerImpl. This makes clusterfuzz happy at this point, and avoids potential crashes in the future. Bug: 824104 Bug: 733662 Change-Id: I82612d59ae23e843e47192a4254080f4a8fa67fd Reviewed-on: https://chromium-review.googlesource.com/1015220 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551419}
-
Erik Chen authored
This CL has no intended behavior change. This CL cleans up test structure and updates some comments. Change-Id: I3b5ed07813ec416dd67098d9f93b702a115cee09 Bug: 827545 Reviewed-on: https://chromium-review.googlesource.com/1014371 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551418}
-
Dave Tapuska authored
Mojo Input messages for all platforms except Android Webview shipped in Chrome 64. Mojo Input messages for Android Webview shipped in Chrome 66. BUG=722928 Change-Id: I3e085b401beb2ef394e4a6ce257ed1566b12fe8a Reviewed-on: https://chromium-review.googlesource.com/998803Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#551417}
-
Nektarios Paisios authored
Browsers don't use only the HTML lang attribute to compute document language. We rely on the layout engine to compute language if a layout object is available, , otherwise we use our own logic. We also use our own logic if the layout engine cannot figure out the language. Our own logic first looks at the lang attribute on the current object, or any of its ancestors, followed by the "content-language" meta tag, the accept language header and the browsers default UI language. The latter two steps provide a mere guess, but are better than simply returning en-US, which is our current implementation for IAccessible2. This certainly is an improvement over the current situation, though not perfect by all means. R=dmazzoni@chromium.org Bug: 831186 Tested: Manually using foreign language sites without lang attributes and Chrome's the "--lang" command line flag, automatically using layout tests Change-Id: Ia80c31cc6dabdcea2aeec177aeda6b29d695019e Reviewed-on: https://chromium-review.googlesource.com/1011332 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#551416}
-
Garret Kelly authored
In the near future zx_port_{wait,queue} will not accept a count of zero. Change all callers to call these functions with a count of one. Change-Id: I1a3fbcbb051c1da674fd6080685abd8c26067170 Reviewed-on: https://chromium-review.googlesource.com/1015481 Commit-Queue: Garret Kelly <gdk@chromium.org> Reviewed-by:Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551415}
-
Joe Mason authored
R=csharp Bug: 830892 Change-Id: I8ebbeabc201571e754b8905aff9ba1b88598b48c Reviewed-on: https://chromium-review.googlesource.com/1003061Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#551414}
-
Henrik Boström authored
WebRtcMediaStreamTrackAdapterMapStressTest added due to https://crbug.com/813574. This continuously creates and destroys local and remote track adapters concurrently in an attempt to cause a deadlock if possible (hopefully not). This also removes some invalid thread checks at the destructor of ~WebRtcMediaStreamTrackAdapter and ~WebRtcMediaStreamAdapterMap. The first of which made the stress test flaky (https://crbug.com/826365). The adapter's DCHECK was invalid because the remote audio track's Dispose (which properly DCHECKs that it is invoked on the main thread) can jump to the signaling thread and back with a reference to the adapter. It is possible for the signaling thread's task to be the last reference to the adapter. Similarly, WebRtcMediaStreamAdapterMap is reference counted and tasks referencing on different threads could make which thread references it last racy. We don't care which thread was the last reference as long as it is empty (which it is if and only if all adapters have been destroyed on the appropriate threads). Bug: 827450 Change-Id: I5f819948fc2148e810f343e027fa8011b03d2335 Reviewed-on: https://chromium-review.googlesource.com/983553Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#551413}
-
Elly Fong-Jones authored
HungRendererController autoreleases itself, which doesn't work well when it doesn't actually hold a reference to the containing window (which it doesn't in MacViews builds). This fixes the HungRendererController interactive UI test. Bug: 823517 Change-Id: I5fc14faa8eeaba7b20f5e922a43d4817ca2c810a Reviewed-on: https://chromium-review.googlesource.com/1015261Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#551412}
-
Qiang Xu authored
changes: To serve decoding icon for app shortcut plumbed from android, this class shouldn't be scoped to app_list namespace. Bug: 803291 Test: compiles & covered by tests Change-Id: Ia7c8e69a69a610769ae3e049921205200d2c577e Reviewed-on: https://chromium-review.googlesource.com/1014567Reviewed-by:
-
Elly Fong-Jones authored
Accept() can be called more than once on the same MenuController, via context menus; in this situation, it's important to clear the animation so that input events get handled after the animation completes. Bug: 833048 Change-Id: Id3ac92ce91e78b57f2120d4527e35e597ea03067 Reviewed-on: https://chromium-review.googlesource.com/1012876Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#551410}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0cd1c432. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15712 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2f718a4bdc8986b13086c22436ff18a6f374fa15 Reviewed-on: https://chromium-review.googlesource.com/1015320 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551409}
-
Xiaocheng Hu authored
As a half-baked utility function, ComputeInlineBoxPosition() used to return null for positions after linebreak. Some callers have ad hoc hacks to fix up such null returns. r547639 added such a fixup in LocalCaretRectOfPosition(). This patch merges the fixup into ComputeInlineBoxPosition(), since LocalCaretRectOfPosition() is supposed to be a wrapper of CIBP(). For changes in SelectionModifierCharacter: the class has code handling positions after linebreaks, but misses the case of '\n' in 'white-space: pre' style, and handles the case by other fixup path. With the merge, we no longer hit the fixup path, and have to fix the linebreak handling in it. Bug: 812535 Change-Id: I9308dcd2bd911b63b0d2268a2db7a0cb94e63d4c Reviewed-on: https://chromium-review.googlesource.com/1014606 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Mostyn Bramley-Moore authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/1013118 added a HoldRefCallback function to print_job_worker.cc which conflicts with an identically named function in print_job.cc in jumbo builds. Let's rename this one. Change-Id: I41d6c064c968bd72c736d648439a372cc4ca64a1 Reviewed-on: https://chromium-review.googlesource.com/1013495Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#551407}
-
Miguel Casas authored
This reverts commit 51b5b7bc. Reason for revert: This CL landed on master so that it could be cherry-picked on M66 branch, which it did on crrev.com/c/1013755, so it can be reverted now. Original change's description: > kUseMonitorColorSpace: mark DISABLED_BY_DEFAULT > > Mark kUseMonitorColorSpace disabled by default to avoid > the blue-color-looks-purple problems detailed in the bug. > This is just a temporary CL to allow cherry-picking it > into the beta branch. > > TBR=dcastagna@chromium.org > > Bug: 809909 > Change-Id: I35bb8cc48c26091cb1752d3d7709a48d23fb4c6e > Reviewed-on: https://chromium-review.googlesource.com/1012305 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551152} TBR=mcasas@chromium.org Change-Id: Ie1f6d2eae27e1332374f696a5d17a8dacebac3e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809909 Reviewed-on: https://chromium-review.googlesource.com/1015142Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551406}
-
Vasilii Sukhanov authored
The default search engine is stored in both prefs and TemplateURLService memory. An extension can override the DSE and hide the user prefs. Currently if this is the case, the user prefs are not updated while the user defined search engine can change in TemplateURLService memory. When the DSE extension is disabled the following happens: - Pref value change. - TemplateURLService gets an update with potentially obsolete used-defined DSE values. - kSyncedDefaultSearchProviderGUID is overriden. - As a result of the callback the DSE pref is overwritten too. - TemplateURLService gets an update again and some objects from the first update do not exist anymore. - Crash when the first update is handled. With this CL the user defined DSE prefs are kept up to date with TemplateURLService model in memory. Thus, when TemplateURLService gets an update, all the preferences are correct and the second update won't happen. Bug: 711508 Change-Id: I7e62a95c481e08853b438ccc276db5a61e520811 Reviewed-on: https://chromium-review.googlesource.com/1012116 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#551405}
-
Robert Liao authored
kWebEffectiveConnectionTypeMappingCount is size_t while EFFECTIVE_CONNECTION_TYPE_LAST is from an enum BUG= Change-Id: Ifba51d317a5557a5c83139d4ab0d54065c262d11 Reviewed-on: https://chromium-review.googlesource.com/1013149Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551404}
-
Miguel Casas-Sanchez authored
This CL s/const/constexpr/ in a few locations in vaapi/ folder. No new code intended, just that substitution. TBR=dcastagna@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4ec733806feff58a70e8e9ab1c0d7f4565f1733c Reviewed-on: https://chromium-review.googlesource.com/1012949 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
Nick Harper authored
TBR=elawrence@chromium.org Change-Id: I737f0e0d058452bbfef3955e31637bb261bedab4 Reviewed-on: https://chromium-review.googlesource.com/1013685Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#551402}
-
Kai Ninomiya authored
Rebaseline needed for Nexus 9 and NVIDIA Shield bots after https://chromium-review.googlesource.com/c/chromium/src/+/1013279 NOTRY=true TBR=kbr@chromium.org Bug: 833463 Change-Id: I700c61696bf656f12f05f095b78b33131c0ce46f Reviewed-on: https://chromium-review.googlesource.com/1014352 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#551401}
-
Ted Meyer authored
The MP4 spec specifies a matrix stored in both the movie header as well as individual track headers. A final matrix is created by composing and transforming a track header with the movie header. A rotation value can be extracted from this final matrix. This is defined in ISO-14496-12. Bug: 830575 Change-Id: If788e4492a082096b36796a3cbf22105a4d57d3f Reviewed-on: https://chromium-review.googlesource.com/1006177 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551400}
-
Sergey Ulanov authored
Now MessagePumpFuchsia runs AsyncDispatcher to handle IO events. This will allow to use async lib and libraries that depend on it (such as FIDL) on UI and IO threads. Bug: 831384 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I981d18f9e07d25a5cd4f6006714af91557c0c795 Reviewed-on: https://chromium-review.googlesource.com/985648 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Qiang Xu authored
changes: Follow up with crrev.com/c/1007891, |braille_display_connected_| is no longer needed by TrayAccessibility. We don't need it for tray visibility either, since when connected it always guaranteed that spoken feedback is enabled, so that spoken feedback enabled state could reflect on behalf of braille display connected state. Bug: 800270 Test: covered by tests Change-Id: I33f0d7b9d53a41e7ff1ed5160207b9d5fb603188 Reviewed-on: https://chromium-review.googlesource.com/1014746 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
-
David Reveman authored
We need call wl_client_flush in order to ensure that these events are transmitted to the client. Bug: 824449 Test: gtk-demo --gdk-debug=misc show that output event is received Change-Id: I18e74339b306ed56c85563628fc8b6af7886fd82 Reviewed-on: https://chromium-review.googlesource.com/1014908Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551397}
-
Penny MacNeil authored
Only mark PEImageSafe instance as NTLoader memory mapped via the new HMODULE constructor. R=grt@chromium.org Bug=769590 Test=chrome_elf_unittests.exe, ThirdParty* Change-Id: I6615a00a04ad667cb4676f21769598aca1f659b5 Reviewed-on: https://chromium-review.googlesource.com/1003143 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#551396}
-
