GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238964
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/14895011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198851 0039d316-1c4b-4281-b951-d872f2087c98

Broke both windows clobber and official builders' compile with this error:

771>Link:
771>     Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and
object ..\..\..\build\Release\lib\gcp_portmon64.exp
771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86'
conflicts with target machine type 'x64'
771>
771>Build FAILED.

> Move FileEnumerator to its own file, do some refactoring.
> 
> It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
> 
> BUG=175002
> R=rvargas@chromium.org
> 
> Review URL: https://codereview.chromium.org/13165005

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/14824006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98

Reverting revisions that rely on r198820 so to unbreak the build.

> Export FileInfo

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/14824005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198849 0039d316-1c4b-4281-b951-d872f2087c98

Reverting revisions that rely on r198820 so to unbreak the build.

> Move sequenced_task_runner to base/task
> 
> BUG=
> R=akalin@chromium.org
> 
> Review URL: https://codereview.chromium.org/14927008

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/14985007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198848 0039d316-1c4b-4281-b951-d872f2087c98

These script names were extracted from data/lang/en.txt in ICU.

BUG=
TBR=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/14660004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=akalin@chromium.org

Review URL: https://codereview.chromium.org/14927008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198844 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198842 0039d316-1c4b-4281-b951-d872f2087c98

R=simonjam@chromium.org

Review URL: https://codereview.chromium.org/15019009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198839 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen@chromium.org
BUG=238737

Review URL: https://codereview.chromium.org/14892006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198838 0039d316-1c4b-4281-b951-d872f2087c98

> Add chrome_split_dll gyp variable, and duplicate chrome_main_dll target
> 
> Currently contains chrome_browser_dll target. Removes some paths from browser->webcore
> via content that are there due to single process mode, and removes dependency of content
> on content_renderer.
> 
> Current remaining paths from chrome_browser_dll to webcore: http://i.imgur.com/7WWRvpA.jpg
> 
> R=cpu@chromium.org
> BUG=237249
> 
> Review URL: https://chromiumcodereview.appspot.com/14682014

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/14882004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198837 0039d316-1c4b-4281-b951-d872f2087c98

Currently contains chrome_browser_dll target. Removes some paths from browser->webcore
via content that are there due to single process mode, and removes dependency of content
on content_renderer.

Current remaining paths from chrome_browser_dll to webcore: http://i.imgur.com/7WWRvpA.jpg

R=cpu@chromium.org
BUG=237249

Review URL: https://chromiumcodereview.appspot.com/14682014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198834 0039d316-1c4b-4281-b951-d872f2087c98

This is a bit tricky scenario, but the current code may lead to
a mismatch of increment/decrement by calling Close(). See the bug
for how the mismatch happens.

BUG=238477

Review URL: https://chromiumcodereview.appspot.com/14820016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198829 0039d316-1c4b-4281-b951-d872f2087c98

* Remove duplicated comments.
* Rename main .cc/.c file to the name of the example.
* Remove _module.cc files

BUG=none
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/14607005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237354

Review URL: https://chromiumcodereview.appspot.com/14670013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198827 0039d316-1c4b-4281-b951-d872f2087c98

This moves a clear per picture into a clear-to-background color
per picture pile. We need this to ensure that a solid color
page in low res is considered solid, since all the draws are
of the same color.

BUG=233622

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198272
"

TBR=reveman

Review URL: https://chromiumcodereview.appspot.com/14322017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198826 0039d316-1c4b-4281-b951-d872f2087c98

Updates an existing suppression (filed for bug 222876) to reflect
new function signature. (Part of PKS using BrowserContext now)

NOTRY=true
TBR=thestig@chromium.org,phajdan@chromium.org
BUG=222876

Review URL: https://chromiumcodereview.appspot.com/14823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198825 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198824 0039d316-1c4b-4281-b951-d872f2087c98

The current code seems to generate '/\foo' for a given path '\foo'

BUG=238212
TEST=FileSystemUtilTest.GetNormalizedFilePath
TBR=grv@chromium.org

Review URL: https://codereview.chromium.org/14588006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198822 0039d316-1c4b-4281-b951-d872f2087c98

R=samarth@chromium.org
TBR=samarth@chromium.org
BUG=238863

Review URL: https://codereview.chromium.org/14819011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198821 0039d316-1c4b-4281-b951-d872f2087c98

It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.

BUG=175002
R=rvargas@chromium.org

Review URL: https://codereview.chromium.org/13165005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree

Review URL: https://codereview.chromium.org/14722016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198818 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr, piman
BUG=179896

Review URL: https://codereview.chromium.org/15043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198817 0039d316-1c4b-4281-b951-d872f2087c98

The documentation was out of date, as there is now no way to have default
versus specific bounds. Instead all supplied bounds are default. 

BUG=230606

Review URL: https://chromiumcodereview.appspot.com/14037005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198815 0039d316-1c4b-4281-b951-d872f2087c98

R=rdsmith@chromium.org
TBR=rdsmith@chromium.org
BUG=238831

Review URL: https://codereview.chromium.org/14660016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198814 0039d316-1c4b-4281-b951-d872f2087c98

Allow "--top-symbols <n>" as an argument for "waterfall match".

Will list the top <n> symbol occurrences in all unsuppressed reports.

NOTRY=true
R=thestig@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/15039007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198813 0039d316-1c4b-4281-b951-d872f2087c98

Previously, this test was based on whether the Me2Me host
plugin was loaded. But if Native Messaging is supported, this
NPAPI instance will not get loaded, so the Share button test
should not depend on it.


BUG=173509
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15017006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198812 0039d316-1c4b-4281-b951-d872f2087c98

The synthesized mouse move events when a menu is closing could cause the selection to change, which would notify the RenderWidgetHostViewBase twice, triggering a DCHECK.

BUG=118872,237819

Review URL: https://chromiumcodereview.appspot.com/14818007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238487
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/14786021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198810 0039d316-1c4b-4281-b951-d872f2087c98

> Reland 198495 for Windows.
> 
> > Build libpeerconnection as a loadable module for win, mac and linux by default. Also remove the allocator shim variable since it's no longer needed.
> > 
> > This requires updating .isolate files for some try bots.
> > In practice, I've only seen failures in interactive_ui_tests because of this change, but I'm being a bit proactive here and making sure that libpeerconnection.so exists with test hosts that have tests that depend on it.
> > 
> > BUG=238207
> > R=csharp@chromium.org, ronghuawu@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/14907003
> 
> TBR=tommi@chromium.org
> 
> Review URL: https://codereview.chromium.org/14767016

TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/14615011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176596
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/14779007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198808 0039d316-1c4b-4281-b951-d872f2087c98

29 is the atomic number of copper.
"$29.00" is a song on the album Blue Valentine by Tom Waits.
29 is a prime number.
29 is a Lucas Number.
The Human skull is made-up of 29 bones.
The alphabet of the Phoenicians had 29 cuneiform signs.
The Turkish and Norwegian alphabets contain 29 letters.
Saturn takes 29 years to orbit our Sun.
In the United States of America, Interstate 29 is a freeway 
   which runs from Missouri to North Dakota. 
Also in the USA there is a place in California called 29 Palms.
The probability of being born on 29th February is 1 in 1,461.
A polygon made up of 29 sides is called an icosikaienneagon, enneacosagon or a nonacosagon.

R=laforge@chromium.org

Review URL: https://codereview.chromium.org/15017011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198807 0039d316-1c4b-4281-b951-d872f2087c98

To allow generating a graph of linkage information that gyp-explain
outputs. Output example: http://i.imgur.com/7WWRvpA.jpg

R=thakis@chromium.org
BUG=237249

Review URL: https://codereview.chromium.org/15026004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198806 0039d316-1c4b-4281-b951-d872f2087c98

> Speed improvements to SubstringSetMatcher
> 
> The main one is coputing the Aho-Corasick tree size in advance.
> 
> Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.
> 
> This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.
> 
> BUG=236368
> 
> Review URL: https://chromiumcodereview.appspot.com/14780003

TBR=vabr@chromium.org

Review URL: https://codereview.chromium.org/15045002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198805 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=thestig@chromium.org,phajdan@chromium.org
BUG=238339

Review URL: https://chromiumcodereview.appspot.com/14800010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198804 0039d316-1c4b-4281-b951-d872f2087c98

The main one is coputing the Aho-Corasick tree size in advance.

Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.

This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.

BUG=236368

Review URL: https://chromiumcodereview.appspot.com/14780003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198803 0039d316-1c4b-4281-b951-d872f2087c98

Synced notifications tried to access a null pointer, make
sure we don't crash when we do.

Also add logging so we can determine how the code got into a
bad state.

BUG=235979

Review URL: https://chromiumcodereview.appspot.com/14862004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198801 0039d316-1c4b-4281-b951-d872f2087c98

Linux: Change dump_app_syms script to pass -r to dump_syms. This option was added in Breakpad r1163.

BUG=230995
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14188058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224248

TEST=net_unittests --gtest_filter=HostResolverImplTest.EmptyListMeansNameNotResolved
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14760008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198799 0039d316-1c4b-4281-b951-d872f2087c98