GitLab

is enabled. This fixes the case where restoring a previously-hidden accelerated
tab would not actually show its contents without mouse-moving within the tab's
contents.

Patch by Nat Duca (nduca@chromium.org)
R=darin
BUG=51306
TEST=Load the two URLS specified in original bug report into seperate tabs.
Switching tabs should show the content of the correct tab.

Originally reviewed at: http://codereview.chromium.org/3161023/show

Review URL: http://codereview.chromium.org/3176025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56814 0039d316-1c4b-4281-b951-d872f2087c98

This change just catches up with the recent clean-up of base (r55400).

BUG=none
TEST=make the "Chromium Mac (valgrind)" bot greener.
Review URL: http://codereview.chromium.org/3119032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56813 0039d316-1c4b-4281-b951-d872f2087c98

BUG=37375
TEST=updated StatusIcon unit tests

Review URL: http://codereview.chromium.org/3189003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56812 0039d316-1c4b-4281-b951-d872f2087c98

It changes to fetch https://www.google.com/searchdomaincheck?format=domain&type=chrome
instead of checking http://www.google.com/ redirection.

Also show infobar if google domain has been changed to new domain and ask
user to switch new domain.

Fix Win IO Perf regressions:
- GoogleURLTracker::RequestServerCheck() is not called in headless mode
 (CHROME_HEADLESS=1) nor in Chrome Frame (--chrome-frame).

Fix leaks in TestingProfile::CreateRequestContext(): 52562
- Add TestURLFetcher::set_request_context() do nothing, because TestURLFetcher
 might miss to release core_->request_context_getter_.

Fix GoogleURLTracker observer removal DCHECK: 52608
- call RemoveAll(), instead of calling Remove()s

BUG=48688,15141,52477,52562,52608
TEST=unit_tests passes

Review URL: http://codereview.chromium.org/3171019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rolandsteiner


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rolandsteiner

Review URL: http://codereview.chromium.org/3167029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none 
TEST=none 

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56808 0039d316-1c4b-4281-b951-d872f2087c98

closing. Here's the sequence that triggers the closing:
. go to a page.
. go to a new page, preferably one that takes a while to resolve, such
  as one on a site that doesn't exist.
. After this step is_waiting_for_unload_ack_ has been set to true on
  the first RVH.
. click stop before the page has been commited.
. click reload.
  . is_waiting_for_unload_ack_ is still true, and the if the hang monitor
    fires the tab gets closed.

I've changed the code to always set is_waiting_for_unload_ack_ when we
initiate a load.

BUG=52003
TEST=see bug

Review URL: http://codereview.chromium.org/3115020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56804 0039d316-1c4b-4281-b951-d872f2087c98

language_preferences.h exports lots of constants hence polutes chromeos
namespace.

TEST=compiles. try bots.
BUG=chromium-os:5848

Review URL: http://codereview.chromium.org/3132023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56803 0039d316-1c4b-4281-b951-d872f2087c98

It creates a variable and copy the value all around. Instead use pointer so the other places where the variable is used
just point to the orignal variable instead of copying the value.

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=EnvironmentTest.*

Review URL: http://codereview.chromium.org/3186017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56802 0039d316-1c4b-4281-b951-d872f2087c98

Use ScopedPK11Slot.
Move common test functionality into functions.
Move common test conditions into SetUp/TearDown.
Move common test variables into attributes of the test class.

BUG=19991
TEST=tests still pass

Review URL: http://codereview.chromium.org/3189014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56801 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration test logs do not reveal when different sync events
occur on the ProfileSyncServiceTestHarness objects. This checkin adds
logging for sync events so that failures are easier to debug.

BUG=52761
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3169028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19991
TEST=builds

Review URL: http://codereview.chromium.org/3104022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56799 0039d316-1c4b-4281-b951-d872f2087c98

Tests failing on vista 

BUG=52682
TEST=included


Review URL: http://codereview.chromium.org/3142022

TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/3122031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rolandsteiner

Review URL: http://codereview.chromium.org/3119029

TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/3111021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52682
TEST=included


Review URL: http://codereview.chromium.org/3142022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56796 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52723

Review URL: http://codereview.chromium.org/3126023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56795 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3169029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56794 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56792 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rolandsteiner

Review URL: http://codereview.chromium.org/3119029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56790 0039d316-1c4b-4281-b951-d872f2087c98

New hooks allow the user to pause/resume/cancel/remove downloads and more.

Review URL: http://codereview.chromium.org/3176016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56789 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3116019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56788 0039d316-1c4b-4281-b951-d872f2087c98

In browser_resources.grd, both IDR_SYNC_SETUP_FLOW_HTML and
IDR_REMOTING_SETUP_FLOW_HTML are point to setup_flow.html although they
are different files in different folders. ResourceBundle gets confused
and always return the later one when asked for IDR_SYNC_SETUP_FLOW_HTML.
This problem only happens on Windows but not Linux.

This patch tries to avoid this problem by renaming remoting files with
a remoting_ prefix.

BUG=52777, 52625
TEST=Setup sync now loads the correct setup_flow.html

Review URL: http://codereview.chromium.org/3191013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56787 0039d316-1c4b-4281-b951-d872f2087c98

I'd like to see how common it is to use a network file system for
your home directory.  This would help evaluate how important it is
to support these users.

See also:
  http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/b43d2905f079fa1c

Review URL: http://codereview.chromium.org/3187011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3157027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56785 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56781 0039d316-1c4b-4281-b951-d872f2087c98

This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.

TEST=ui_tests in Release mode
BUG=49838

Review URL: http://codereview.chromium.org/2805100

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3169031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56778 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56776 0039d316-1c4b-4281-b951-d872f2087c98

This will make them browsing them easier in Keychain Access and certutil.
It also gives them a more useful name in Keychain permission dialogs.

The friendly name is currently just the hostname which requested
the key. It would be nice to have some surrounding text with
localization, but this works for now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2806045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56774 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46981
TEST=none
TBR=glen
Review URL: http://codereview.chromium.org/3108035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56773 0039d316-1c4b-4281-b951-d872f2087c98

I considered ASCII, but it's producing what is intended to be a
human-readable string.  For example, in theory the "bytes/s" annotation
could be localized into a language where the "b" is non-ASCII.

Review URL: http://codereview.chromium.org/3107021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56771 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3146024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56769 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Put signal handlers in alphabetical order.  Group a couple other things in a way that seems better to me.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3135034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56767 0039d316-1c4b-4281-b951-d872f2087c98

This makes one behavioral change: a mouse release with a successful HitTest and |canceled| true will set the state to HOT instead of NORMAL.  This seemed more correct to me.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3175027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56766 0039d316-1c4b-4281-b951-d872f2087c98

There were a bunch of TODO comments whose action items were already
completed. Removing said comments.

BUG=50306
TEST=none

Review URL: http://codereview.chromium.org/3143031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56765 0039d316-1c4b-4281-b951-d872f2087c98

-Allow automagic links to types in API descriptions, using "$ref:TYPE_ID"
-Fix syntax error in callback code
-Fix a couple other small nits

BUG=52616
TEST=none

Review URL: http://codereview.chromium.org/3117029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56764 0039d316-1c4b-4281-b951-d872f2087c98

- Remove debugging cruft from an old bug that has been closed.
- Make it UI-thread only. This complicates ResourceMessageFilter a little, but
makes the EMS lifetime a lot easier to reason about.

BUG=no
TEST=covered by unit tests

Review URL: http://codereview.chromium.org/3117024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56761 0039d316-1c4b-4281-b951-d872f2087c98

TBR=phajdan.jr@chromium.org,
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3149026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56757 0039d316-1c4b-4281-b951-d872f2087c98

Revert 56742 - A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion. 

BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous 
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.

Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com

TBR=brettw@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56754 0039d316-1c4b-4281-b951-d872f2087c98

worked correctly.

I think there might still be a place for this, but it is in
Browser::AdjustWindowOpenDispositionForTab(), which is a much more
constrained use case, and also isn't working correctly, because
it lacks knowledge of apps.

BUG=52442

Review URL: http://codereview.chromium.org/3199004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56752 0039d316-1c4b-4281-b951-d872f2087c98