- 16 Apr, 2018 40 commits
-
-
https://chromium.googlesource.com/angle/angle.git/+log/a4fa9c2782da..aa8b3982aeeb $ git log a4fa9c278..aa8b3982a --date=short --no-merges --format='%ad %ae %s' 2018-04-16 tobine Roll (1/2) LVL version forward and disable VANGLE 2018-04-16 jmadill Vulkan: Fix texture descriptor set alloc count. 2018-04-15 jmadill Optimize ValidateDrawAttribs: Part 1. 2018-04-13 jmadill Vulkan: Rename StagingStorage to PixelBuffer. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org No-try: True Change-Id: Ie22e822e0e4688b255c641ca2c3ea378f4f843dc Reviewed-on: https://chromium-review.googlesource.com/1014465 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551162}
-
Jennifer Apacible authored
This change allows the user to close the Picture-in-Picture window. Temporarily, right clicking the window will close the player. Future work includes adding UX affordances for media controls and consolidating with the Picture-in-Picture teardown in WebMediaPlayerImpl. BUG: 726619 Change-Id: Ia60d9153e53f4ae3dd7cf53c7ec505cee33e5b60 Reviewed-on: https://chromium-review.googlesource.com/976263 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#551161}
-
Joel Einbinder authored
Bug: 832175 Change-Id: I8723a8d5e92d1439760ae6a40b0cb444aad00531 Reviewed-on: https://chromium-review.googlesource.com/1014253Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#551160}
-
Min Chen authored
Bug: 799524 Change-Id: If76472261a452021e0bc883a89d944d87e26dabc Reviewed-on: https://chromium-review.googlesource.com/1013291Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#551159}
-
Tommy C. Li authored
Previously, when the user placed the cursor in the URL and unelided the URL, and then pressed Alt-Tab to switch windows, and then to switch back, the URL would be re-elided. This is not desirable. The Omnibox state should not change merely from switching windows. It should re-elide only if the user focuses something else in the same window. This CL fixes the bug and adds a test for this behavior. It also updates the test to make failure messages more clear about which line has the failing condition. Bug: 797354 Change-Id: I43905e1248c439651bd6b6a66d57d46dff0989e2 Reviewed-on: https://chromium-review.googlesource.com/1014347 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551158}
-
Filip Gorski authored
* This only adds a command line for enterprise policy bypass (no flag is added in about flags) * Adds a policy bypass code in the bridge. Bug: 832797 Change-Id: I9bca2c54dbfff37b52cb56ece5bd3632a5e0ec9c Reviewed-on: https://chromium-review.googlesource.com/1014467Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#551157}
-
Wojciech Dzierżanowski authored
The first time we know the Demuxer initialization is complete is when Pipeline::Start() completes (asynchronously). Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7451187be2d141780d5aa514fb3a1ec4abe8fbbe Reviewed-on: https://chromium-review.googlesource.com/1000858 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#551156}
-
Marina Ciocea authored
Looks like it was accidentally removed in https://crrev.com/2577573002. Bug: 673494 Change-Id: Ibb73e8ff0c8a1b3a222446b002eb5b7560e9fe31 Reviewed-on: https://chromium-review.googlesource.com/1012079Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#551155}
-
Lei Zhang authored
FPDF_PageToDevice() and FPDF_DeviceToPage() now return results. Change-Id: I2f49fa37d295ea7ee4bc3dcd8cdcebaa085f5b23 Reviewed-on: https://chromium-review.googlesource.com/1013283 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#551154}
-
spqchan authored
Bug: 832631 Change-Id: I211b693337c93a53fabd5aacd41bc4024cefc7c2 Reviewed-on: https://chromium-review.googlesource.com/1013877Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551153}
-
Miguel Casas-Sanchez authored
Mark kUseMonitorColorSpace disabled by default to avoid the blue-color-looks-purple problems detailed in the bug. This is just a temporary CL to allow cherry-picking it into the beta branch. TBR=dcastagna@chromium.org Bug: 809909 Change-Id: I35bb8cc48c26091cb1752d3d7709a48d23fb4c6e Reviewed-on: https://chromium-review.googlesource.com/1012305Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551152}
-
Mike Wittman authored
Fixes occasional crashes seen in render thread profiling when attempting to unwind from the sigtramp function in non-leaf frames. Bug: 831793 Change-Id: Ie07b9679c288262d8409904d4f4fe818324339bf Reviewed-on: https://chromium-review.googlesource.com/1013337 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551151}
-
Fady Samuel authored
This reverts commit 79605d54. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink"" > > This reverts commit 79edda64. > > Reason for revert: We have branched into M68. > > Original change's description: > > Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink" > > > > This is a reland of 119455cb > > > > Original change's description: > > > Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink > > > > > > There's a race in cc somewhere from commit to draw. I don't know exactly > > > how to repro the race yet even though I have a high probably fix. This > > > CL is intended to catch the race in the wild and produce a stack trace > > > in a crash log. Hopefully from there we can acertain repro steps. > > > > > > Once repo steps are produced locally (either via user interaction or > > > unit test) then this CL will be reverted. > > > > > > Bug: 672962 > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > > > Change-Id: I3bce066591e15d5c3aac7d4c8685dce411e284b7 > > > Reviewed-on: https://chromium-review.googlesource.com/973987 > > > Reviewed-by: Saman Sami <samans@chromium.org> > > > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#544834} > > > > Bug: 672962 > > TBR: samans@chromium.org > > Change-Id: I880540f3f00c419efb4055007787e86f4722d675 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > > Reviewed-on: https://chromium-review.googlesource.com/981154 > > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#545994} > > TBR=fsamuel@chromium.org,samans@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 672962 > Change-Id: I02cc346dddda60a02e9233ec6fcb7c9df50e1d8a > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/1008610 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550171} TBR=fsamuel@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 672962 Change-Id: Ib3730fc78117cbaac36d141bfe03430a665bb3ea Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1012785Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551150}
-
Aga Wronska authored
Bug: 832919, 831251 Change-Id: I113dbedec6ee9b79f109aff876a2ccc97e057b73 Reviewed-on: https://chromium-review.googlesource.com/1014283Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#551149}
-
Dmitry Gozman authored
This reverts commit 90c5a257. Reason for revert: flaky leaks on WebKit_Linux_Trusty_Leak. See crbug.com/833609. Original change's description: > Onion-soupify blink leak detector > > - Expose LeakDetector interface in render process, remove unneeded plumbing. > - Switch from IPCs to Mojo in layout test runner. > - Move implementation to controller. > - Migrate inspector usage to browser. > - Merged two methods of LeakDetector into a single one. > - Fixed leaks in existing tests. > > Needs a followup to not register fetchers in leak detector, > but instead have a collection in ResourceFetcher. > > Change-Id: Iba0ffc95de5b8beb27409b4eb51435c5e1397951 > Reviewed-on: https://chromium-review.googlesource.com/999170 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Yuzu Saijo <yuzus@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551012} TBR=dgozman@chromium.org,dcheng@chromium.org,haraken@chromium.org,kolos@chromium.org,yuzus@chromium.org Change-Id: I1c7471b3b910ab9a3cbd34794307dd5e0fecca41 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1014520Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551148}
-
James Cook authored
This is another step toward out-of-process ash (go/mustash). * Create the Widget in FirstRunController in chrome * Move escape key handling into chrome * Stop using OverlayEventFilter in ash. The old code wasn't actually relying on it for blocking event propagation, just for escape key handling and detecting screen lock and shutdown. The old code was also watching for LoginStatus changes, but that dates back to the use of OverlayEventFilter for partial screenshots (no longer used) and isn't relevant to first-run. * Add mojo interfaces to tell ash to start/stop tutorial Bug: 756057 Test: ash_unittests, browser_tests Change-Id: Icfd88e3541f1393b6a2309120c74bbe6a69b967f Reviewed-on: https://chromium-review.googlesource.com/1000395 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551147}
-
Anita Woodruff authored
- The legacy IPC pathway was checking the max data size *before* the IPC call, and rejecting if it was exceeded. - This patch reinstates the check for the new mojo pathway, so that we don't risk crashing the renderer (thanks to verification in struct traits) if max data is exceeded. - This involved moving the max data constant to mojo so it can be accessed from both blink and content. R=peter@chromium.org Bug: 798742,796991 Change-Id: I14ae782c9265411da1374beb7ae7312cb265b07e Reviewed-on: https://chromium-review.googlesource.com/1011602Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#551146}
-
Koji Ishii authored
Following bot results are included. 4797 4801 4802 4804 4805 4806 4812 4817 Rebaseline for editing/unsupported-content/table-delete-001 was deleted as the test was changed to testharness. 3 lines were removed and 1 lines were deflaked by consecutive results since 4749. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I389bdc815aab7c97e4c90ee3508b8429c0d9eb9f Reviewed-on: https://chromium-review.googlesource.com/1013669 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#551145}
-
Stuart Langley authored
The current link is a 404. Bug: 715355 Change-Id: Id31bb3b61e468b948f4ccdc0dd553321d67f3808 Reviewed-on: https://chromium-review.googlesource.com/1013361Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#551144}
-
Avi Drissman authored
This reverts commit 39b4e33b. Reason for revert: https://ci.chromium.org/buildbot/chromium/Android/84236[32116/66287] In file included from gen/services/network/public/mojom/network_service.mojom-shared.h:23: gen/services/network/public/mojom/network_service.mojom-shared-internal.h:26:10: fatal error: 'services/network/public/mojom/websocket.mojom-shared-internal.h' file not found #include "services/network/public/mojom/websocket.mojom-shared-internal.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > [subresource_filter] Move test-only JNI calls out of binary > > Before, the JNI shim called into native code that was compiled into > Chrome proper. > > Now, due to r517541 there is a better way to do this by including the > JNI code in libchromefortest. > > Bug: None > Change-Id: I9f34f5105366b927d6dd6676d97a9da6d2540385 > Reviewed-on: https://chromium-review.googlesource.com/997877 > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551131} TBR=yfriedman@chromium.org,csharrison@chromium.org,jbudorick@chromium.org Change-Id: If96fd947654bd36763943de4302f5a820a467f22 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/1013344Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551143}
-
Hector Carmona authored
Bug: 27175 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2fed4c16cf0406ea5361413840fe5ab2f5968f69 Reviewed-on: https://chromium-review.googlesource.com/1003056 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551142}
-
Jao-ke Chin-Lee authored
Builders: * Win x64 Builder * Win10 Tests x64 * Win 7 Tests x64 (1) BUG=790642,790660,790638 Change-Id: I24b17ca255dcb127f20d2ce9ab1078afb5bd919d Reviewed-on: https://chromium-review.googlesource.com/1014329Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#551141}
-
xlai authored
Would like to see if the tests are no longer flaky after https://chromium-review.googlesource.com/1010466. TBR=kbr@chromium.org Bug: 735228,735171 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic2bdeb13f52f4fff4f94cc7f7ee46f503c7646f3 Reviewed-on: https://chromium-review.googlesource.com/1012985 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#551140}
-
https://chromium.googlesource.com/catapult.git/+log/0371983030f2..5d0c16d725ca $ git log 037198303..5d0c16d72 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 crouleau [Telemetry] Explain when no browsers available for a device Created with: roll-dep src/third_party/catapult BUG=chromium:830834 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I89bb2ef6dda43a6c723fc7686e01f9278876c1d3 Reviewed-on: https://chromium-review.googlesource.com/1014276 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551139}
-
Yuqian Li authored
bug: chromium:821353 Change-Id: If1c7bb0daf8b9c295e7ec2d58145fabdee17bcff Reviewed-on: https://chromium-review.googlesource.com/1010511 Commit-Queue: Yuqian Li <liyuqian@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#551138}
-
Tommy C. Li authored
When Steady State Elisions is on, there's currently the following bug: When the user clicks the Omnibox (and selects everything), then Alt-Tabs out of the window, and Alt-Tabs back in, the selection changes from select-all to a cursor at the beginning of the Omnibox. This CL fixes the bug and adds a test to prevent regression. The bug was caused by some old code in OmniboxEditModel that should have been deleted a while ago. It also refactors the test a bit to make the focus and blur fake events more robust. It also updates the OmniboxViewViews::OnFocus method to be suitable for usage within tests (rather than overriding and defining a fake one). Bug: 797354 Change-Id: I4516455cf81e4097f27605f52a669f01f7c17f61 Reviewed-on: https://chromium-review.googlesource.com/1013209 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551137}
-
Colin Blundell authored
Update comments in //services/identity/public/cpp to better reflect the current reality of IdentityManager. Change-Id: I20fef4d73aec6737927bdc0dc398dd366fccbd9a Reviewed-on: https://chromium-review.googlesource.com/1013479Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#551136}
-
Dmitry Gozman authored
These were exposed by leak detector change, dgozman@ is going to fix them. Bug: 833609 Change-Id: I068afd816b67158a0d1ee5aef515525685398069 Reviewed-on: https://chromium-review.googlesource.com/1014462 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551135}
-
Tom Anderson authored
BUG=833179 R=dpranke Change-Id: Ie9fa320c6d532844f85d34f5d6f8a1195a9eb107 Reviewed-on: https://chromium-review.googlesource.com/1014263 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551134}
-
Andres Calderon Jaramillo authored
This CL corrects two erroneous byte positions during EDID parsing, namely for Green and White LSByte positions. Affected unit tests are fixed. Bug: 821393 Change-Id: Ica3c54258e0d58b55bd5c5779e9ef6b6f5e4a610 Reviewed-on: https://chromium-review.googlesource.com/1005534 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551133}
-
Jao-ke Chin-Lee authored
BUG=731502 Change-Id: I12565be7b445c34d2ac16a3b1fca7feb9c88a2b4 Reviewed-on: https://chromium-review.googlesource.com/1014403Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#551132}
-
Charlie Harrison authored
Before, the JNI shim called into native code that was compiled into Chrome proper. Now, due to r517541 there is a better way to do this by including the JNI code in libchromefortest. Bug: None Change-Id: I9f34f5105366b927d6dd6676d97a9da6d2540385 Reviewed-on: https://chromium-review.googlesource.com/997877 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#551131}
-
Nathan Parker authored
Bug: 755418 Change-Id: I6265cc98f0f70d9387275cb1e346acdc1978f488 Reviewed-on: https://chromium-review.googlesource.com/994276 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551130}
-
Avi Drissman authored
This migrates some usage of notifications. BUG=170921 Change-Id: I2c824659f50d3838d65842fc4bec5db9a4c1a7df Reviewed-on: https://chromium-review.googlesource.com/1011682 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#551129}
-
Xiaohan Wang authored
- Clarify lifetime model. - Clarify thread model. - Remove GetClassIdentifier(). Moving foreard, we should add virtual methods to CdmContext to support platform-specific interfaces, instead of using static_cast. TBR=jrummell@chromium.org,rkuroiwa@chromium.org Bug: 821288 Test: No functionality change. Change-Id: I13e30ed2c508855727219edd3975abf5d67e6721 Reviewed-on: https://chromium-review.googlesource.com/1014284Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551128}
-
Mohammad Refaat authored
Accessing cookies from WKHTTPCookieStore doesn't work correctly when there is not a WKWebView object alive. previously a work around was created, but it seems to not solve the problem. The problem always existed but to be able to WKHTTPCookieStore as the main cookieStore, it had to be addressed. Bug: 661630, 746947 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie5f67102a7cfb804a47b8aa5c1316c25be5d9609 Reviewed-on: https://chromium-review.googlesource.com/1011584Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551127}
-
Fady Samuel authored
This reverts commit fc9d1583. Reason for revert: Now that we've branched for M68, I'm relanding this. Original change's description: > Revert "Surface synchronization: Add diagnostic CHECK" > > This reverts commit 3fb6e543. > > Reason for revert: This is blocking branch cut. We know we hit this case and we've collected some crash logs to sift through now. > > Original change's description: > > Surface synchronization: Add diagnostic CHECK > > > > Current evidence points to a race in cc that is causing surface invariants > > violations (No invariants violations detected in LayerTreeHost but detected > > in ClientLayerTreeFrameSink). > > > > My suspicion is viewport is updated out of sync with LocalSurfaceId and > > device scale factor. > > > > This CL adds a diagnostic CHECK between the pending and active LayerImpls to > > attempt to detect the race and produce a better stack trace. The invariant > > we want to test here is if active tree has an invalid viewport (viewport has > > changed), then the LocalSurfaceId MUST change. > > > > Bug: 672962 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2 > > Reviewed-on: https://chromium-review.googlesource.com/989851 > > Reviewed-by: enne <enne@chromium.org> > > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#547457} > > TBR=enne@chromium.org,fsamuel@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 672962 > Change-Id: Id1ad5997e12b7f966df5f7b034bd5a30baa5ae60 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1008642 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550175} TBR=enne@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 672962 Change-Id: I7e460b4177d7690cc324d0feadeed7aacbcb24ec Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1012407Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551126}
-
Dan Sanders authored
This adds VdaVideoDecoder, an adapter that implements the media::VideoDecoder interface using a media::VideoDecodeAccelerator. VdaVideoDecoder expects to run in the GPU process, with access to a command buffer stub, as will be the case for decoders created by MojoVideoDecoder. VdaVideoDecoder runs on the (mojo) IO thread as much as possible, but the VDA interface is inherently tied to the GPU thread. Compared to the original landing (commit e192695d), this change casts kMaxPlanes to uint32_t before using it as a parameter to DCHECK_LE() in PictureBufferManager::CreatePictureBuffers(). Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie3e1b346f9b88692bcb2be12434fb0b6b81ef025 Reviewed-on: https://chromium-review.googlesource.com/1012936 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#551125}
-
Shenghua Zhang authored
The current .yaml files are wrapping duplicate directory names like 'public/tools', which cause downloaded packages as 'public/public/tools'. This cl fixed that issue by add the root directory info to yaml files. TBR=jbudorick@chromium.org Bug: 659808 Change-Id: I3be84d33cff2974c7bea481349aef04a45b9548f Reviewed-on: https://chromium-review.googlesource.com/1013389 Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551124}
-
Mike Klein authored
See https://skia-review.googlesource.com/c/skia/+/121582 Bug: skia:7810 Change-Id: Ibc32853736c539e76d84e135e3ef45201056026b Reviewed-on: https://chromium-review.googlesource.com/1014249Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#551123}
-