- 22 Nov, 2019 40 commits
-
-
Aran Gilman authored
The main goal of the CL is to separate the desktop-specific HTML from the shared HTML to make testing more straightforward. Since this was already a refactoring CL, I also applied the fixes surfaced by the presubmit checks. Bug: 952034 Change-Id: I963dff8ef49ef3b78b585aa2040876953a2de004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925688 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717963}
-
Ryan Hamilton authored
Bug: 1027274 Change-Id: I6013524cc2864f53d7d3f88f9ed7c21cbb87e6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930092 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#717962}
-
byoungkwon ko authored
As below spec[1],[2], NDEFRecordType was deleted. And it replaced as USVString. So we need to update it. [1] https://w3c.github.io/web-nfc/#dom-ndefrecord [2] https://w3c.github.io/web-nfc/#the-ndefscanoptions-dictionary Bug: none Change-Id: I55b38a1ce16f2e9b59fad3bb1a819619506f02b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923214 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#717961}
-
John Z Wu authored
UIAlertControllerStyleActionSheet requires additional configuration when used in ipads. In particular, it needs to know where to anchor when being presented. Bug: 1026664 Change-Id: I3925f7dae1ecfede6f879c4c5a451ad155e11a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929649Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#717960}
-
Chris Palmer authored
Fix by 0xdade, proposed at https://github.com/chromium/chromium/pull/32/files. Thank you! Bug: None Change-Id: Id1ade1985c83aec49ad4bf6431ab25e3c20c2705 TBR: awhalley Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928241 Auto-Submit: Chris Palmer <palmer@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#717959}
-
Dan Harrington authored
This change addresses some lint errors that will be triggered if the code is moved outside of third_party. After this change, we can more cleanly move files out of third party. TBR=carlosk@chromium.org Bug: 1024945 Change-Id: I300303cbfe40035ace5c4526fdc102af6bff9903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927051Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#717958}
-
Rakina Zata Amni authored
Test that we don't match elements that we've replaced with the max code point in the buffer when searching for the max codepoint unicode Bug: 1020105 Change-Id: I056500efe6c6eb6198d5e1dabd03e52d0e826324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928097 Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#717957}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/65f6b45d6d3f..c50b0963e3f2 git log 65f6b45d6d3f..c50b0963e3f2 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 tandrii@google.com git_cache: don't lose options in upload_bootstrap. Created with: gclient setdep -r src/third_party/depot_tools@c50b0963e3f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I66841200f8f8d73f4fbefb1281f381b52816e722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717956}
-
shrekshao authored
https://pinpoint-dot-chromeperf.appspot.com/job/17af1011220000 Reported by pinpoint: thread_total_rendering_cpu_time_per_frame: 27.56 → 28.79 (+1.228) (+4.454%) https://pinpoint-dot-chromeperf.appspot.com/job/142f245a220000 Optimize attempt for this performance regression shows a -3.4% improvement for thread_renderer_main_cpu_time_per_frame Bug: 1026774 Change-Id: I35cc020411ebe033a9b77a80be49b7ecac8d96b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929756Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#717955}
-
James Cook authored
It's common to open a URL in a tab, but ignoring the path of the URL, and overwriting the New Tab Page. Introduce a utility function for this. Bug: none Change-Id: Ib900497f143eba2738a8ec4b15b187c55ce4cc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928162 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#717954}
-
John Lee authored
Bug: 1023492 Change-Id: I0ef55c4dabb379efa73758372d45db4f28351fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925442 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#717953}
-
Stephen Chenney authored
The StyleUpdate step was missing from the set of suffixes for CompositorLatencyStages. Bug: 1026707 Change-Id: I678b8889e9735cd8efc0964fa0cb3de8c4960c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928192 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#717952}
-
Wenyu Fu authored
Previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1900305 To enable Homepage Location Policy on Android, add an API that will managed the Homepage Preference change, and provide API for other class to check if the Homepage Policy is enabled, and what the homepage is set to. This is the first batch of the implementation for the HomepagePolicyManager. There will be integration with UI and associated test coming in the following CL. Bug: 978197 Change-Id: I7ab10997c25c0501af18c946afcd2749a06af578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919940Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#717951}
-
Clark DuVall authored
This removes all weblayer specific asset files from Monochrome bundles, and allows us to directly use Monochrome's chrome locale assets. A workaround for loading assets from split APKs is necessary because prior to Android Q WebViewDelegate.addWebViewAssetPath() does not support adding split APK assets. Bug: 1025600 Change-Id: I1bf7a91c2239fe6b2f58ae7bf2b9fba5e440224b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924919 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#717950}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=yoshiki@chromium.org Bug: 1023677 Change-Id: Ic71e5db0199fa6fe2cd582b50939dd43db3dfd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926939 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717949}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4539eec8ead1..ef065e36264e Created with: gclient setdep -r src-internal@ef065e36264e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:141127636,chromium:b/141127636 Change-Id: I9463fad91e3761c516588b8122e07b30516d6766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929894Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717948}
-
Wei-Yin Chen (陳威尹) authored
TBR=yusufo@chromium.org Bug: 1027315 Change-Id: Idb90624c1dfb42520e66d15b7f0548930fe561fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928305Reviewed-by:
-
Chris Cunningham authored
Intent thread: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/0yw8CuNaQEw/ppTxJme2EQAJ Bug: 961885 Change-Id: I0b066a66288e00e27354a21d382500fe2dd838e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915824 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#717946}
-
Timothy Loh authored
This CL adds chrome.autotestPrivate.installPluginVM(), which will install and then launch Plugin VM. The arguments to this function would be set by policy under normal operation, but we manually set these as we cannot yet set policy from tast. Bug: 1006664 Change-Id: Ia3556f960b6f4cdccf8012eaff1ff16e9cdc7ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900524Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#717945}
-
Gang Wu authored
1. Add feature highlight for tab switcher button 2. Change the colors for text color/alpha in feature highlight bubble. 3. Add background for feature highlight. Bug: 1021967 Change-Id: I8932c67367fbe3b30677e8123dcc593dcd938988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922448Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#717944}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 1023677 Change-Id: I2d08844e19bedaa0d85d7a0ae3a2afaaa03e5d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926829 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717943}
-
Sophie Chang authored
This removes the checks for max ECT for a preview and session Bug: 1022532 Change-Id: Ic695e249e972548981115955ebb08f80db8268cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925702Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#717942}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jam@chromium.org Bug: 1023677 Change-Id: I261ccc105df9968d29dbe90d62aeb670bb403b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926913 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717941}
-
Clark DuVall authored
Bug: 1027306 Change-Id: I4dca0bf6d95b7f8926899411a3faeafa2a9f8f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930095Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9c2b7cfe9080..aad4e6e19e18 git log 9c2b7cfe9080..aad4e6e19e18 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-21 benjaminwagner@google.com Remove Build-Ubuntu18-GCC job 2019-11-21 benjaminwagner@google.com [infra] Add service_account_json option to asset utils 2019-11-21 rosasco@google.com Slim down .far by ~45 MB. 2019-11-21 reed@google.com Revert "Use flat version of path-direction enum" 2019-11-21 halcanary@google.com [reland] public.bzl: update to replace Gif with Wuffs 2019-11-21 mtklein@google.com all-constant peepholes 2019-11-21 reed@google.com Use flat version of path-direction enum Created with: gclient setdep -r src/third_party/skia@aad4e6e19e18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I233dbf23158614d1071f5b6e36da040fe963af7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929912Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 1027292 Change-Id: Ibc119e0b324079306c96e12261da5ef420fac565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929777Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#717938}
-
Ken Rockot authored
This reverts commit 45cef59a. Reason for revert: breaks a fuzzing tool compile Original change's description: > Move Renderer processes off Service Manager > > Migrates Renderer processes to use the simpler ChildProcess IPC > interface in place of deprecated Service Manager IPC. > > Support for preloaded files in service manifest definitions is > effectively removed in favor of explicit parameters on > BrowserChildProcessHost and ChildProcessLauncher. The only use case (V8 > snapshot files) has been migrated from manifest data to a simple map > definition, and it's used during renderer and utility process launching. > > After this CL, only utility processes remain to be moved off of Service > Manager IPC. > > NOPRESUBMIT=true > > Bug: 977637 > Change-Id: I1d8205cb73ead904aa21b85d6cbee11cb3fc84f5 > Tbr: boliu@chromium.org > Tbr: yucliu@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918375 > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#717920} TBR=avi@chromium.org,rockot@google.com,mbarbella@chromium.org,rsesek@chromium.org Change-Id: I3fa67ad894cd5725ff71d59cadec2cebc4917952 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930102Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#717937}
-
nancy authored
AppServiceAppModelBuilder is used to replace ArcAppModelBuilder. AppService integration to ui/app_list has been enabled for a couple of months, so it should be safe to remove ArcAppModelBuilder. Related unit tests have be updated to use AppService related functions. BUG=1016159 Change-Id: I59bc82e33b48249299768943b689226a93df9442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919537 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#717936}
-
Reilly Grant authored
Bug: 1007653 Change-Id: Ief3fa58f744ec8ec8e12e9acd96882dce9937d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924869 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#717935}
-
Daniel Hosseinian authored
Remove an 'else' after a return. Add a |testonly| flag to the "base32_test_util" target. Add dcheng@ to components/base32/OWNERS. Change-Id: I4872604b9b211d0c6c8e5f8b9136e3aa24dbebd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925209 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#717934}
-
Lin Sun authored
Remove fixed failures, add platform tag or driver tag to some failures to restrict the scenario, also add a few new failures. Bug: 478572, 835364, 931006, 949249, 963450 Bug: 979444, 1023745, 1023747, 1025652 Bug: angleproject:1179, angleproject:1465, angleproject:2291 Bug: angleproject:2394, angleproject:2672, angleproject:2722 Bug: angleproject:2885, angleproject:2887, angleproject:2897 Bug: angleproject:2898, angleproject:2902, angleproject:2903 Bug: angleproject:2904, angleproject:2905, angleproject:2909 Bug: angleproject:2916, angleproject:3469, angleproject:3742 Change-Id: I462381d9112d7d88ff58927766102b1c654f17a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916301Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
Jenny Zhang authored
Bug: 916422 Change-Id: I8affa8d4f2b90475311861a5571dd9bd91fc9cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928079 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#717932}
-
James Cook authored
After discussions with PM/UX we want the toggle to control the OS app list layout and ARC++ apps. Legacy Chrome apps and PWAs continue to be controlled by browser sync. See go/split-settings-apps Add "app list" to syncer::UserSelectableOsTypes similar to how we handle the "printers" type. Name the pref kSyncOsAppList to differentiate it from the obsolete kSyncAppList. Rename the printer pref to kSyncOsPrinters to match. Rename the printers pref constant for consistency -- normally I would have to obsolete the old pref and add a new one, but split settings sync has not shipped yet and printers did not have a separate user control before, so I think I can just rename it. Fix SyncUserSettingsImpl not to include "OS" data types in the list of available model types when the flag SplitSettingsSync is off. This allows us to remove workarounds in the "EnableDisable" sync integration test suite. Also add DCHECKs for the feature flag for all OS type methods in SyncUserSettings. Add a missing JS method to os_sync_controls.js so the toggle state is reliably pushed to browser C++ code. I missed this when I cloned the browser's sync_controls.js. Bug: 1013466 Test: unit_tests, browser_tests, sync_integration_tests Change-Id: I5b606db9347694bfc75bbeb1476b20a01e972aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925694 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
Alex Newcomer authored
Bug: 1027326 Change-Id: I4e75dae2e3d35252735407d5e39b5fbc51141cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930053Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#717930}
-
Elly Fong-Jones authored
TBR=avi@chromium.org Bug: 1011446 Change-Id: Id7d024a9e5c5971f874c187f07fa2b80863c9dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929973Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#717929}
-
Raphael Kubo da Costa authored
* std::move() both |typed_key| and |typed_value|. * Use V8AtomicString() rather than V8String() to allow V8 to reuse the string "enumerate" if possible. * Pass kConvertStrings to the GetOwnPropertyNames() call so that we do not need to manually convert numeric indices to strings. Change-Id: Ia59aa9953439b8022a0d87339e4f3a98885cb43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928709 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#717928}
-
Hwanseung Lee authored
Use enum class instead of enum for InitParams::WindowOpacity enum class is more type safety. Bug: 940736 Change-Id: I71b4de234848d9a0465f48b47c3adcc2b53ab5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924095Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#717927}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::ContentDecryptionModule with using Receiver instead of Binding. Bug: 955171 Change-Id: I90549211683b36eaad909ed91688750e40431874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924093Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#717926}
-
Xinghui Lu authored
This CL obsolete the following metrics: PasswordProtection.CacheVerdictDuration PasswordProtection.GetCachedVerdictDuration It turns out that caching is not the root cause of the timeout issue. Bug: 1025879 Change-Id: I91067b2fda8526ca485916c9d1bff1fc095a6c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924606 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#717925}
-
Sergey Talantov authored
BUG=1026180 Change-Id: Ib93eb4668b62a88f41603b6104060e69a91f0fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928771Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#717924}
-
