1. 07 Apr, 2011 19 commits
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · dcb51b1e
      tkent@chromium.org authored
              [Chromium] Update test expectation.
              xhr-breakpoints.html and detailed-heapshots-summary.html are flaky.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83142 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dcb51b1e
    • abarth@webkit.org's avatar
      2011-04-06 Adam Barth <abarth@webkit.org> · 463f252b
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              CSP object-src should block plugin loads
              https://bugs.webkit.org/show_bug.cgi?id=57283
      
              This change is pretty straight-forward.  It's slighly unclear to me
              whether this patch is correct w.r.t. the code in DocumentWriter.  I've
              added a FIXME comment, and I'll investigate that case more in the future.
      
              Test: http/tests/security/contentSecurityPolicy/object-src-none.html
      
              * loader/DocumentWriter.cpp:
              (WebCore::DocumentWriter::begin):
              * loader/SubframeLoader.cpp:
              (WebCore::SubframeLoader::requestPlugin):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowObjectFromSource):
              (WebCore::ContentSecurityPolicy::addDirective):
              * page/ContentSecurityPolicy.h:
      2011-04-06  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              CSP object-src should block plugin loads
              https://bugs.webkit.org/show_bug.cgi?id=57283
      
              * http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/object-src-none.html: Added.
              * http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83141 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      463f252b
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=58009 · 4ac73696
      bdakin@apple.com authored
      Frame::scalePage() results in visual artifacts with scale factors less than 1
      -and corresponding-
      <rdar://problem/8683230>
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore: 
      
      Fall into the case where we fill with a background base color when there is a page 
      scale factor that is less than 1.
      * rendering/RenderView.cpp:
      (WebCore::RenderView::paintBoxDecorations):
      
      LayoutTests: 
      
      * fast/repaint/scale-page-shrink.html: Added.
      * platform/gtk/Skipped:
      * platform/mac/fast/repaint/scale-page-shrink-expected.checksum: Added.
      * platform/mac/fast/repaint/scale-page-shrink-expected.png: Added.
      * platform/mac/fast/repaint/scale-page-shrink-expected.txt: Added.
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83140 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4ac73696
    • commit-queue@webkit.org's avatar
      2011-04-06 Chang Shu <cshu@webkit.org> · 51a16591
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              Unskip passed tests.
      
              * platform/mac-wk2/Skipped:
      2011-04-06  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
              (WKBundlePageSizeAndMarginsInPixels):
              * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
              * WebProcess/InjectedBundle/InjectedBundle.cpp:
              (WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
              * WebProcess/InjectedBundle/InjectedBundle.h:
      2011-04-06  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83139 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      51a16591
    • crogers@google.com's avatar
      2011-04-06 Chris Rogers <crogers@google.com> · 15c9564c
      crogers@google.com authored
              Reviewed by Tony Chang.
      
              Add web audio support to DumpRenderTree (mac port)
              https://bugs.webkit.org/show_bug.cgi?id=57969
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (setEncodedAudioDataCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::dumpAsAudio):
              (LayoutTestController::setDumpAsAudio):
              (LayoutTestController::encodedAudioData):
              (LayoutTestController::setEncodedAudioData):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (dumpAudio):
              (dump):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83138 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      15c9564c
    • benjamin.poulain@nokia.com's avatar
      2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com> · 0965409e
      benjamin.poulain@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              * platform/qt/Skipped: Remove the skipped test which required numberOfPendingGeolocationPermissionRequests.
      2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
              from the LayoutTestController.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              Add the missing method.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83137 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0965409e
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · cac4e2ff
      tkent@chromium.org authored
              [Chromium] Update expectations for Geeza Pro and so on.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83136 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cac4e2ff
    • jer.noble@apple.com's avatar
      2011-04-06 Jer Noble <jer.noble@apple.com> · 5dc0a1e0
      jer.noble@apple.com authored
              Reviewed by Darin Adler.
      
              AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
              https://bugs.webkit.org/show_bug.cgi?id=57982
      
              Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83135 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5dc0a1e0
    • jer.noble@apple.com's avatar
      2011-04-06 Jer Noble <jer.noble@apple.com> · 7ef6838a
      jer.noble@apple.com authored
              Reviewed by Eric Carlson.
      
              MediaPlayerPrivateAVFoundation does not change rate due to setRate().
              https://bugs.webkit.org/show_bug.cgi?id=57919
      
              * media/video-set-rate-from-pause-expected.txt: Added.
              * media/video-set-rate-from-pause.html: Added.
      2011-04-06  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Eric Carlson.
      
              MediaPlayerPrivateAVFoundation does not change rate due to setRate().
              https://bugs.webkit.org/show_bug.cgi?id=57919
      
              Test: media/video-set-rate-from-pause.html
      
              The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
              of the media; instead a subclass must do that work.  So when setRate() is called,
              inform a subclass through a new pure virtual updateRate() function that there's
              work to be done.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              (WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added.  Set the requested rate.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83134 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7ef6838a
    • kinuko@chromium.org's avatar
      2011-04-06 Dai Mikurube <dmikurube@chromium.org> · 3c7c546d
      kinuko@chromium.org authored
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * win/tools/vsprops/FeatureDefines.vsprops: Added QUOTA build flag
              * win/tools/vsprops/FeatureDefinesCairo.vsprops: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * configure.ac: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
              * GNUmakefile.am: Added QUOTA build flag
              * WebCore.pri: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Scripts/build-webkit: Added QUOTA build flag
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83133 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3c7c546d
    • mitz@apple.com's avatar
      Correct results for the Geeza Pro metrics change. · 53ad20b2
      mitz@apple.com authored
      * platform/mac/fast/dom/52776-expected.checksum:
      * platform/mac/fast/dom/52776-expected.png:
      * platform/mac/fast/dom/52776-expected.txt:
      * platform/mac/fast/text/complex-text-opacity-expected.checksum:
      * platform/mac/fast/text/complex-text-opacity-expected.png:
      * platform/mac/fast/text/complex-text-opacity-expected.txt:
      * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.png:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83132 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      53ad20b2
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · 90c2da9d
      enne@google.com authored
              Unreviewed, update Chromium expectations for failing test from r83075.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83131 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      90c2da9d
    • dpranke@chromium.org's avatar
      2011-04-06 Dirk Pranke <dpranke@chromium.org> · 0e2e0204
      dpranke@chromium.org authored
              Reviewed by Tony Chang.
      
              Adjust the apple webkit port's default timeout to match
              old-run-webkit-tests at 35 seconds.
      
              https://bugs.webkit.org/show_bug.cgi?id=37738
      
              * Scripts/webkitpy/layout_tests/port/mac.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83130 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0e2e0204
    • commit-queue@webkit.org's avatar
      2011-04-06 Scott Cameron <sccameron@rim.com> · 94b8245f
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove global variable $httpdPath and replace with the return value of
              getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
              https://bugs.webkit.org/show_bug.cgi?id=53499
      
              * Scripts/run-iexploder-tests:
              * Scripts/webkitperl/httpd.pm:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83129 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      94b8245f
    • slewis@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57997 · c943942d
      slewis@apple.com authored
      <rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
      Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
      Cancel all enqueued events when detaching the Document the events cannot keep the Document
      alive.
      
      Reviewed by Darin Adler.
      
      No change in functionality so no new tests.  
      
      * dom/Document.cpp:
      (WebCore::Document::detach):
      * dom/EventQueue.cpp:
      (WebCore::EventQueue::cancelQueuedEvents):
      * dom/EventQueue.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83128 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c943942d
    • levin@chromium.org's avatar
      2011-04-06 David Levin <levin@chromium.org> · 9045bedd
      levin@chromium.org authored
              Reviewed by Ojan Vafai.
      
              Augment style guidelines about meaningless parameters from text the unwritten rules email.
              https://bugs.webkit.org/show_bug.cgi?id=55275
      
              * coding/coding-style.html:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83127 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9045bedd
    • mitz@apple.com's avatar
      <rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has... · 5b96199f
      mitz@apple.com authored
      <rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
      https://bugs.webkit.org/show_bug.cgi?id=58002
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
      does not require the vertical metrics tweaks that were needed in Leopard. That the
      tweaks were being applied went mostly unnoticed until r73993, because until then it
      only affected cases where Geeza Pro was specified, not when it occurred as a fallback
      font.
      
      LayoutTests: 
      
      * platform/mac/fast/dom/52776-expected.checksum:
      * platform/mac/fast/dom/52776-expected.png:
      * platform/mac/fast/dom/52776-expected.txt:
      * platform/mac/fast/text/complex-text-opacity-expected.txt:
      * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.png:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83126 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5b96199f
    • commit-queue@webkit.org's avatar
      2011-04-06 Anders Bakken <agbakken@gmail.com> · 984bd06c
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] FrameLoaderClientQt.cpp has coding-style errors
              https://bugs.webkit.org/show_bug.cgi?id=40254
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (drtDescriptionSuitableForTestResult):
              (WebCore::FrameLoaderClientQt::hasWebView):
              (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
              (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
              (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
              (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
              (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
              (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
              (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
              (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
              (WebCore::FrameLoaderClientQt::willChangeTitle):
              (WebCore::FrameLoaderClientQt::didChangeTitle):
              (WebCore::FrameLoaderClientQt::finishedLoading):
              (WebCore::FrameLoaderClientQt::frameLoadCompleted):
              (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
              (WebCore::FrameLoaderClientQt::didFinishLoad):
              (WebCore::FrameLoaderClientQt::setTitle):
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
              (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
              (WebCore::FrameLoaderClientQt::updateGlobalHistory):
              (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
              (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
              (WebCore::FrameLoaderClientQt::committedLoad):
              (WebCore::FrameLoaderClientQt::download):
              (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
              (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
              (WebCore::FrameLoaderClientQt::createFrame):
              (WebCore::FrameLoaderClientQt::objectContentType):
              (WebCore::FrameLoaderClientQt::createPlugin):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83125 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      984bd06c
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · c75196e5
      enne@google.com authored
              Unreviewed, update expectations for Chromium visited link test.
              https://bugs.webkit.org/show_bug.cgi?id=58000
      
              Apparently, this just hasn't been working for a while.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83124 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c75196e5
  2. 06 Apr, 2011 21 commits
    • rolandsteiner@chromium.org's avatar
      2011-04-06 Roland Steiner <rolandsteiner@chromium.org> · f8121e4b
      rolandsteiner@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Bug 57994 - Move guardRef functionality back to Document
              https://bugs.webkit.org/show_bug.cgi?id=57994
      
              Move the relevant code parts from TreeScope back into Document.
      
              No new tests. (no new functionality)
      
              * dom/Document.cpp:
              (WebCore::Document::removedLastRef):
              * dom/Document.h:
              * dom/TreeScope.cpp:
              (WebCore::TreeScope::destroyTreeScopeData):
              * dom/TreeScope.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83123 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f8121e4b
    • simon.fraser@apple.com's avatar
      2011-04-06 Ian Henderson <ianh@apple.com> · 1be39e07
      simon.fraser@apple.com authored
              Reviewed by Simon Fraser, Antti Koivisto.
      
              Fast path for parsing simple CSS values
              https://bugs.webkit.org/show_bug.cgi?id=57964
      
              Add functions to parse simple color or dimension values, skipping the
              overhead of full CSS parsing.
      
              Change parseValue to a static method to avoid unnecessary allocation
              of a CSSParser in the fast case.
      
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::setProperty):
              Changed to use the new, static parseValue method.
              * css/CSSParser.cpp:
              (WebCore::isColorPropertyID):
              (WebCore::parseColorValue):
              Parses any color accepted by the existing parseColor() static method.
              We must handle color identifiers separately, since parseColor() will
              change 'red' into 'rgb(255, 0, 0)'.
              (WebCore::isSimpleLengthPropertyID):
              (WebCore::parseSimpleLengthValue):
              Parses a value of the form 'NNpx', 'NN%', or 'NN' (when strict is
              false, or 'NN' is '0').  Returns false to fall back to the slow path.
              (WebCore::CSSParser::parseValue):
              * css/CSSParser.h:
              * css/WebKitCSSMatrix.cpp:
              (WebCore::WebKitCSSMatrix::setMatrixValue):
              Changed to use the new, static parseValue method.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1be39e07
    • kevino@webkit.org's avatar
      Reviewed by Darin Adler. · 232315b9
      kevino@webkit.org authored
      Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
      
      https://bugs.webkit.org/show_bug.cgi?id=27551
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83121 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      232315b9
    • tony@chromium.org's avatar
      2011-04-06 Tony Chang <tony@chromium.org> · 9ce69712
      tony@chromium.org authored
              Reviewed by Darin Adler.
      
              teach run-webkit-tests to read checksums from png files
              https://bugs.webkit.org/show_bug.cgi?id=57993
      
              * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
                no .checksum and look for the checksum in there.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83120 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9ce69712
    • simon.fraser@apple.com's avatar
      2011-04-06 Simon Fraser <simon.fraser@apple.com> · 8a220589
      simon.fraser@apple.com authored
              Reviewed by Antti Koivisto.
      
              Some minor style resolution optimizations
              https://bugs.webkit.org/show_bug.cgi?id=57996
      
              A couple of minor optimizations to style-related code.
      
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::isCSSPropertyName):
              (WebCore::JSCSSStyleDeclaration::putDelegate):
              Avoid calling cssPropertyName() twice when setting style on an element.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::useSVGZoomRules):
              (WebCore::CSSStyleSelector::applyProperty):
              Avoid calling isSVGElement() for every property, since only a two properties
              care about it.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83119 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8a220589
    • simon.fraser@apple.com's avatar
      2011-04-06 Ian Henderson <ianh@apple.com> · af150f1b
      simon.fraser@apple.com authored
              Reviewed by Antti Koivisto.
      
              Unnecessary string allocation in CSSStyleDeclaration::setProperty
              https://bugs.webkit.org/show_bug.cgi?id=57995
      
              Pass the bool representing the property's importance directly instead
              of constructing a string.
      
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::setProperty):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83118 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      af150f1b
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · 32f8bb6c
      enne@google.com authored
              Unreviewed, rebaseline more Chromium mac tests after r83075.
      
              * platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
              * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83117 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      32f8bb6c
    • commit-queue@webkit.org's avatar
      2011-04-06 Siddharth Mathur <siddharth.mathur@nokia.com> · a0d70469
      commit-queue@webkit.org authored
              Reviewed by Benjamin Poulain.
      
              [Qt][WK2][Symbian] Remove use of stack arrays with variable size
              https://bugs.webkit.org/show_bug.cgi?id=57877
      
              For better compiler portability, use new/delete for arrays when size
              isn't known at compile time. Also fix one compiler warning about bitshift
              operations on signed integers.
              * Platform/CoreIPC/qt/ConnectionQt.cpp:
              (CoreIPC::Connection::readyReadHandler):
              (CoreIPC::Connection::sendOutgoingMessage):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83116 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a0d70469
    • commit-queue@webkit.org's avatar
      2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org> · f503206b
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              Make the style of createFunctionOnlyCallback in V8 consistent with the JavaScriptCore version.
              https://bugs.webkit.org/show_bug.cgi?id=57963
      
              No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
      
              * bindings/v8/V8Utilities.h:
              (WebCore::createFunctionOnlyCallback):
              * bindings/v8/custom/V8GeolocationCustom.cpp:
              (WebCore::V8Geolocation::getCurrentPositionCallback):
              (WebCore::V8Geolocation::watchPositionCallback):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f503206b
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · d9444be7
      enne@google.com authored
              Unreviewed, try to green Chromium mac tree by marking failing tests as more generally failing.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83114 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d9444be7
    • bweinstein@apple.com's avatar
      WebKit2: Support Windows 7 Gestures · 713b15f5
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49824
      <rdar://problem/8689728>
              
      Reviewed by Adam Roben.
      
      Source/WebCore: 
      
      Move WindowTouch.h from WebKit/win, so it can be used in both WebKit and WebKit2.
      
      * WebCore.vcproj/WebCore.vcproj:
      * platform/win/WindowsTouch.h: Copied from WebKit/win/WindowsTouch.h.
      
      Source/WebKit/win: 
      
      Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
      used in both WebKit and WebKit2.
      
      * WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
      * WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
      * WindowsTouch.h: Removed.
      
      Source/WebKit2: 
      
      Port code from WebKit1 -> WebKit2 to handle Windows 7 gestures.
              
      The UIProcess gets a WM_GESTURENOTIFY message, it sends a sync message to the WebProcess to ask
      if we should allow panning. The WebProcess checks if we're in a scrollable area, and the mouse
      isn't over a scrollbar.
      
      The UIProcess then gets a WM_GESTURE message, and if it is a pan gesture, it sends a message to
      the WebProcess to scroll by the amount fingers have moved since the last WM_GESTURE messeage. The
      X and Y are reversed because panning up -> moving the page down, and vice versa.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::gestureWillBegin): Send a sync message to the WebProcess
          to initialize the gesture. The WebProcess returns whether or not we can start a pan
          gesture from where we are.
      (WebKit::WebPageProxy::gestureDidScroll): Send a message to the WebProcess to scroll by
          pan gesture.
      (WebKit::WebPageProxy::gestureDidEnd): Send a message to the WebProcess that the gesture has ended.
      * UIProcess/WebPageProxy.h:
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::wndProc): Add WM_GESTURE and WM_GESTURENOTIFY handlers.
      (WebKit::WebView::WebView): Initialize two new variables.
      (WebKit::WebView::onGestureNotify): Figure out which gestures we should support based on where
          the gesture is beginning.
      (WebKit::WebView::onGesture): Support starting a gesture, ending a gesture, and panning.
      * UIProcess/win/WebView.h:
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in: Add messages needed for gestures.
      * WebProcess/WebPage/win/WebPageWin.cpp:
      (WebKit::WebPage::gestureWillBegin): Set the node that the gesture started on (so we 
          know which layer to scroll if the user pans), and determine whether or not we should allow
          panning. If the page can't scroll, or the user is on a scrollbar, disallow panning.
      (WebKit::WebPage::gestureDidScroll): Scroll the enclosing layer of the element the gesture
          started on.
      (WebKit::WebPage::gestureDidEnd): Clear the node the gesture started on.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      713b15f5
    • commit-queue@webkit.org's avatar
      2011-04-06 David Dorwin <ddorwin@chromium.org> · 0aa1c1ce
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Enable fullscreen layout tests for Chromium
              https://bugs.webkit.org/show_bug.cgi?id=55726
      
              Remove test_expectations override for fullscreen tests.
      
              * platform/chromium/test_expectations.txt:
      2011-04-06  David Dorwin  <ddorwin@chromium.org>
      
              Reviewed by David Levin.
      
              Enable fullscreen layout tests for Chromium
              https://bugs.webkit.org/show_bug.cgi?id=55726
      
              Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
      
              * DumpRenderTree/chromium/WebPreferences.cpp:
              (WebPreferences::applyTo):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83112 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0aa1c1ce
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · d6187b1f
      enne@google.com authored
              Unreviewed, rebaseline Chromium Mac tests after r83075.
      
              * platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
              * platform/chromium-mac/fast/multicol/nested-columns-expected.png: Removed.
              * platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
              * platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png: Removed.
              * platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
              * platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83111 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d6187b1f
    • jeffm@apple.com's avatar
      2011-04-06 Jeff Miller <jeffm@apple.com> · 9fba5a50
      jeffm@apple.com authored
              Reviewed by Adam Roben.
      
              Add WKStringGetCharactersPtr() and WKStringGetLength() to WebKit2 C API
              https://bugs.webkit.org/show_bug.cgi?id=57989
              
              Note that WKChar, which is returned by WKStringGetCharactersPtr(), is defined the same way we define JSChar in JSStringRef.h.
      
              * Shared/API/c/WKString.cpp:
              (WKStringGetLength): Added.
              (WKStringGetCharactersPtr): Added.
              * Shared/API/c/WKString.h: Define WKChar and added WKStringGetLength() and WKStringGetCharactersPtr().
              * Shared/WebString.h:
              (WebKit::WebString::length): Added.
              (WebKit::WebString::characters): Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83110 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9fba5a50
    • andersca@apple.com's avatar
      2011-04-06 Anders Carlsson <andersca@apple.com> · f2eb6885
      andersca@apple.com authored
              Reviewed by Oliver Hunt.
      
              Dock stays in front of Hulu.com full screen video output
              https://bugs.webkit.org/show_bug.cgi?id=57988
              <rdar://problem/9216260>
      
              Instead of using -[NSMenu setMenuBarVisible:] to toggle full screen, use
              -[NSApp setPresentationOptions:]. Also, make the UI process the front most app before
              setting the presentation options when exiting full screen, otherwise the dock won't
              be restored correctly.
      
              * PluginProcess/mac/PluginProcessShim.mm:
              Remove some shim functions that aren't needed.
      
              * UIProcess/Plugins/PluginProcessProxy.cpp:
              (WebKit::PluginProcessProxy::PluginProcessProxy):
              Initialize m_preFullscreenAppPresentationOptions.
      
              * UIProcess/Plugins/PluginProcessProxy.h:
              Add m_preFullscreenAppPresentationOptions.
      
              * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
              (WebKit::PluginProcessProxy::enterFullscreen):
              Change the presentation options for the app.
      
              (WebKit::PluginProcessProxy::exitFullscreen):
              Restore the presentation options.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83109 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f2eb6885
    • alexis.menard@openbossa.org's avatar
      2011-04-06 Alexis Menard <alexis.menard@openbossa.org> · 2cbd0777
      alexis.menard@openbossa.org authored
              Reviewed by Andreas Kling.
      
              [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
              https://bugs.webkit.org/show_bug.cgi?id=57974
      
              We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
      
              No new tests needed, just a config flag rename.
      
              * features.pri:
      2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
              https://bugs.webkit.org/show_bug.cgi?id=57974
      
              We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
      
              No new tests needed, just a config flag rename.
      
              * Api/qwebkitplatformplugin.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
              * WebCoreSupport/FullScreenVideoQt.cpp:
              (WebCore::FullScreenVideoQt::FullScreenVideoQt):
              (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
              (WebCore::FullScreenVideoQt::enterFullScreenForNode):
              (WebCore::FullScreenVideoQt::exitFullScreenForNode):
              (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
              (WebCore::FullScreenVideoQt::isValid):
              * WebCoreSupport/FullScreenVideoQt.h:
              * WebCoreSupport/QtPlatformPlugin.cpp:
              * WebCoreSupport/QtPlatformPlugin.h:
              * examples/platformplugin/WebPlugin.cpp:
              (WebPlugin::supportsExtension):
              (WebPlugin::createExtension):
              * examples/platformplugin/WebPlugin.h:
              * examples/platformplugin/platformplugin.pro:
              * examples/platformplugin/qwebkitplatformplugin.h:
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::loadHtml5Video):
              * tests/tests.pri:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2cbd0777
    • oliver@apple.com's avatar
      2011-04-06 Oliver Hunt <oliver@apple.com> · 1a208ddf
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Stop JSObject::isUsingInlineStorage() from using the structure
              https://bugs.webkit.org/show_bug.cgi?id=57986
      
              Make the isUsingInlineStorage() implementation just look at
              whether the property storage is inside the object.
      
              * runtime/JSObject.h:
              (JSC::JSObject::isUsingInlineStorage):
              (JSC::JSObject::JSObject):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83107 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1a208ddf
    • barraclough@apple.com's avatar
      Update comments documenting JSVALUE64/JSVALUE32_64 JSValue representations. · c6406642
      barraclough@apple.com authored
      Rubber stamped by Geoff Garen.
      
      * runtime/JSImmediate.h:
      * runtime/JSValue.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83106 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c6406642
    • commit-queue@webkit.org's avatar
      2011-04-06 Tyler Close <tjclose@chromium.org> · 36068d58
      commit-queue@webkit.org authored
              Reviewed by Nate Chapin.
      
              run-bindings-tests reference files out of sync with CodeGenerator*.pm
              https://bugs.webkit.org/show_bug.cgi?id=57967
      
              * bindings/scripts/test/V8/V8TestCallback.cpp:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83105 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      36068d58
    • mrowe@apple.com's avatar
      Expose the original URL of a WKBackForwardListItem. · 591b12c2
      mrowe@apple.com authored
      Reviewed by Darin Adler.
      
      Needed for <rdar://problem/9074651>.
      
      * UIProcess/API/C/WKBackForwardListItem.cpp:
      (WKBackForwardListItemCopyOriginalURL):
      * UIProcess/API/C/WKBackForwardListItem.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      591b12c2
    • scheib@chromium.org's avatar
      2011-04-06 Vincent Scheib <scheib@chromium.org> · 5c99ac26
      scheib@chromium.org authored
              Fixed GPU expectations for r80867
      
              * platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
              * platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83103 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5c99ac26