GitLab

Also remove a few Windows newlines :-/

BUG=560836
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1470093004 .

Cr-Commit-Position: refs/heads/master@{#361344}

* Now targets all devices by default rather than failing
* Allows --device flag to target a specific device

BUG=

Review URL: https://codereview.chromium.org/1469143002

Cr-Commit-Position: refs/heads/master@{#361343}

https://url.spec.whatwg.org/#api

This changes the generated code, but ought not be observable, as any
call to `new URL(x, urlObject)` will now instead behaves as
`new URL(x, urlObject.toString())`.

BUG=460722

Review URL: https://codereview.chromium.org/1464133002

Cr-Commit-Position: refs/heads/master@{#361342}

BUG=557430

Review URL: https://codereview.chromium.org/1438863002

Cr-Commit-Position: refs/heads/master@{#361341}

BUG=560836
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1466423006 .

Cr-Commit-Position: refs/heads/master@{#361340}

The current minor GC collects all unmodified wrappers that are not active. It does not take care about references. Hence, it is not safe to mark any object that might contain a reference as not active. Several object wrappers could have references, so disabled collecting them during minor GC.

BUG=553054

Review URL: https://codereview.chromium.org/1464783002

Cr-Commit-Position: refs/heads/master@{#361339}

Rename buildSVGPathByteStreamFromString to buildByteStreamFromString to
be more consistent with other functions (buildStringFromByteStream and
buildPathFromByteStream). Also drop the PathParsingMode argument, since
it's always UnalteredParsing (and it's unlikely we'll need to build
normalized byte streams ATM.)

Make buildStringFromByteStream return the resulting String instead of
using an out-parameter. Tidies up call-sites and makes for slightly
smaller code.

BUG=467592

Review URL: https://codereview.chromium.org/1469323002

Cr-Commit-Position: refs/heads/master@{#361338}

BUG=442514

Review URL: https://codereview.chromium.org/1467003002

Cr-Commit-Position: refs/heads/master@{#361337}

This is an attempt to get 90% cycle time under 2 hours.

Currently cycle time is considered higher priority than false rejections,
although we try to keep both low.

BUG=none
R=sergiyb@chromium.org, tandrii@chromium.org

Review URL: https://codereview.chromium.org/1474703002 .

Cr-Commit-Position: refs/heads/master@{#361336}

Use immutable texture for the default FBO like chromium compositor.

In theory, it speeds up drawing speed, because immutable texture skips texture
validation on drawing call.

In addition, immutable texture allows GL_INTEL_framebuffer_CMAA more optimization.

BUG=557848
TEST=
WebglConformance.conformance_renderbuffers_framebuffer_state_restoration
WebglConformance.conformance_textures_misc_texture_size_cube_maps
WebglConformance.conformance_textures_misc_texture_sub_image_cube_maps
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_byte
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_short_5_6_5
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_byte
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_4_4_4_4
WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_5_5_5_1

Review URL: https://codereview.chromium.org/1449043005

Cr-Commit-Position: refs/heads/master@{#361335}

Revert of Remove fallback tick software draw. (patchset #3 id:100001 of https://codereview.chromium.org/1428263003/ )

Reason for revert:
Causes scheduler to stop activating after clearView is called. PrepareTiles is required to advance the scheduler, so draws are currently needed.

crbug.com/558743

Original issue's description:
> Remove fallback tick software draw.
>
> The fallback software draw was needed to allow the scheduler to advance
> in cases where the WebView is detached or offscreen. Because it is now
> possible for the pending tree to activate without a draw, the fallback
> tick is no longer needed in order for VisualStateListener callbacks
> to fire.
>
> BUG=431166
>
> Committed: https://crrev.com/9addff46d3bc49f8d04e43eeb3f55e01a4982a00
> Cr-Commit-Position: refs/heads/master@{#358156}

TBR=boliu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=431166

Review URL: https://codereview.chromium.org/1474653002

Cr-Commit-Position: refs/heads/master@{#361334}

One layout text requires rebaselining after the last roll:
canvas-imageSmoothingQuality-pixel.html.

BUG=559240
NOTRY=true
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1468403002

Cr-Commit-Position: refs/heads/master@{#361333}

New SELECT Popup: Do not select and scroll to an option of which visible area is less than 1px height.

BUG=558287
TEST=automated

Review URL: https://codereview.chromium.org/1468353002

Cr-Commit-Position: refs/heads/master@{#361332}

BUG=540702

Review URL: https://codereview.chromium.org/1471213002

Cr-Commit-Position: refs/heads/master@{#361331}

BUG=557197

Committed: https://crrev.com/0eb771aa98ba2bd4db0e2b82241afe8f5760c32e
Cr-Commit-Position: refs/heads/master@{#361053}

Review URL: https://codereview.chromium.org/1453903002

Cr-Commit-Position: refs/heads/master@{#361330}

It's a rare flake (3/200), but still.
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/61716
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/61770
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/61897

I don't see anything interesting in the logs, just a timeout.

BUG=523255
TBR=sky

Review URL: https://codereview.chromium.org/1476463002

Cr-Commit-Position: refs/heads/master@{#361329}

- Notifications.PersistentNotificationActionCount tracks number of
  action buttons per notification

- Notifications.Persistent.ClickedActionButton counts clicks on action
  buttons

- Notifications.Persistent.Clicked no longer includes clicks on action
  buttons

BUG=513671

Review URL: https://codereview.chromium.org/1422193003

Cr-Commit-Position: refs/heads/master@{#361328}

This test is flaky on the Win XP bot. See bug for more info.

BUG=560716
TBR=rockot

Review URL: https://codereview.chromium.org/1472043002

Cr-Commit-Position: refs/heads/master@{#361327}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6ed50d99..b787e6bc

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1467413003

Cr-Commit-Position: refs/heads/master@{#361326}

BUG=

Review URL: https://codereview.chromium.org/1466423005

Cr-Commit-Position: refs/heads/master@{#361325}

Review URL: https://codereview.chromium.org/1468163002

Cr-Commit-Position: refs/heads/master@{#361324}

Revert of Remove SkFontConfigInterface race suppression. (patchset #1 id:1 of https://codereview.chromium.org/1467313002/ )

Reason for revert:
The data race is still reproducible (see the bug)

BUG=chromium:369257

Original issue's description:
> Remove SkFontConfigInterface race suppression.
>
> The race was fixed with https://codereview.chromium.org/355573006 ,
> committed as
> https://skia.googlesource.com/skia/+/e438ddbc7451ec80f953266409fea4695e78c8c2
>
> This is effectively a revert of https://codereview.chromium.org/273523002 .
>
> BUG=chromium:369257
>
> Committed: https://crrev.com/a8c01b568251a5dc191e4fb67ab5c1dc6b8af86e
> Cr-Commit-Position: refs/heads/master@{#361125}

TBR=mtklein@chromium.org,bungeman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:369257

Review URL: https://codereview.chromium.org/1468173005

Cr-Commit-Position: refs/heads/master@{#361323}

Initial implementation of CSS font-display, a new @font-face descriptor
behind the experimental web platform feature flag.

Spec: https://tabatkins.github.io/specs/css-font-display/
Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/7s4-eQTAxqs/SoahsGpMAQAJ

BUG=530015

Review URL: https://codereview.chromium.org/1429713004

Cr-Commit-Position: refs/heads/master@{#361322}

BUG=455638
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1468383002

Cr-Commit-Position: refs/heads/master@{#361321}

[1] and [2] placed release assertions to investigate a crash bug and provide a
workaround solution. Now the right fix has been landed and we can remove them.

1: https://crrev.com/4b823461db8e2bc8faf5438be4cc30f6a9401aef
2: https://crrev.com/a6af78bd57595484765d2a3ca18f38fa135be796

BUG=550632

Review URL: https://codereview.chromium.org/1456463002

Cr-Commit-Position: refs/heads/master@{#361320}

This commit grays out unmanaged WiFis and button to joining other WiFis
when AllowOnlyPolicyNetworksToConnect is true after user logged in, as
well as adds the tooltip to tell users why.

BUG=208378

Review URL: https://codereview.chromium.org/1469733003

Cr-Commit-Position: refs/heads/master@{#361319}

BUG=348877

Review URL: https://codereview.chromium.org/1406323003

Cr-Commit-Position: refs/heads/master@{#361318}

This affects the generated code of the constructor, which will now throw
a TypeError if "parameter 1 is not of type 'Path2D'."

However, this code path is unreachable, because there's a type check
(V8Path2D::hasInstance()) to determine that this form of the constructor
should be used.

Promoting [TypeChecking=Interface] to the interface level will make it
possible to make [TypeChecking=Interface] the default without changing
the generated code for this interface.

BUG=462561

Review URL: https://codereview.chromium.org/1471563002

Cr-Commit-Position: refs/heads/master@{#361317}

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/3rsQQJvhY8k/P2cAFq3hAwAJ

BUG=353484

Review URL: https://codereview.chromium.org/1461993002

Cr-Commit-Position: refs/heads/master@{#361316}

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.

BUG=554291
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1462763002

Cr-Commit-Position: refs/heads/master@{#361315}

This CL adds a method to ResourceRequestInfo that returns a callback that can
be used on the UI thread to get the WebContents associated with the request.It
is used in the SSLErrorHandler code, instead of using a RenderProcessHost ID
and a RenderFrameHost ID directly .This allows SSL error interstitials to work
with PlzNavigate enabled.

BUG = 504347

Review URL: https://codereview.chromium.org/1459473003

Cr-Commit-Position: refs/heads/master@{#361314}

Policy is no longer used on iOS, this is dead code cleanup.

BUG=550401

Review URL: https://codereview.chromium.org/1459223002

Cr-Commit-Position: refs/heads/master@{#361313}

GCMS::OnCookieChanged needs to always mark the list accounts as stale,
even when they're being fetched. Otherwise, a call to
GCMS::ListAccounts could return an invalid list if called right after
GCMS::OnCookieChanged.

BUG=558367

Review URL: https://codereview.chromium.org/1448983002

Cr-Commit-Position: refs/heads/master@{#361312}

Prepare for auditing Signed Certificate Timestamps (which are tied to
specific certificates) by having a per-profile CT verification.
That would allow auditing SCTs separately for separate profiles.

BUG=506227

Review URL: https://codereview.chromium.org/1440643002

Cr-Commit-Position: refs/heads/master@{#361311}

BUG=

Review URL: https://codereview.chromium.org/1471833002

Cr-Commit-Position: refs/heads/master@{#361310}

BUG=557128

Review URL: https://codereview.chromium.org/1467343002

Cr-Commit-Position: refs/heads/master@{#361309}

BUG=

Review URL: https://codereview.chromium.org/1466393002

Cr-Commit-Position: refs/heads/master@{#361308}

This patch moves paint related timings of DocumentTiming into a new
class, PaintTiming, which is a document supplement and created on demand
only for visible documents.

BUG=544811

Review URL: https://codereview.chromium.org/1456883002

Cr-Commit-Position: refs/heads/master@{#361307}

Instead of each user of base setting the native-side global app context
separately, introduce a Java-side global app context, which is always
in sync with the native-side one. Switch most callers to setting
it on the Java side, except where this is problematic.

Callers of ApplicationStatus.getApplicationContext will be updated
incrementally in followup CLs once it's been verified that they only
require a Context and not a BaseChromiumApplication.

BUG=552419

Review URL: https://codereview.chromium.org/1407233017

Cr-Commit-Position: refs/heads/master@{#361306}

When there is offline copy for the page, "Show saved copy" will be shown. Otherwise when there is offline copy for other pages, "Show all saved pages" will be shown.

BUG=559354

Review URL: https://codereview.chromium.org/1442433003

Cr-Commit-Position: refs/heads/master@{#361305}