GitLab

We obviously want to bound the memory usage of hpack. http2 has an in-protocol
mechanism for this: send SETTINGS_MAX_HEADER_LIST_SIZE to the peer with a
suitable value. With the default 16 KB limit on header list size, the limit
removed by this CL is redundant. If we ever increased the
SETTINGS_MAX_HEADER_LIST_SIZE value then we are still limited to whatever we
set that to.

This CL lands server change 123307298 by rjshade.

BUG=488484

Review-Url: https://codereview.chromium.org/2026593002
Cr-Commit-Position: refs/heads/master@{#400716}

BUG=596401

Review-Url: https://codereview.chromium.org/2080763002
Cr-Commit-Position: refs/heads/master@{#400715}

Followup to https://codereview.chromium.org/2021403002

BUG=599917, 618061

Review-Url: https://codereview.chromium.org/2074363002
Cr-Commit-Position: refs/heads/master@{#400714}

Fix a bug in QUIC's SpdyUtils where Content-Length was being parsed as an int, not an int64, causing >4GB downloads to fail.  Not flag protected.

Merge internal change: 125208956
Fixes crbug/621295

R=rch@chromium.org
BUG=621295

Review-Url: https://codereview.chromium.org/2086533002
Cr-Commit-Position: refs/heads/master@{#400713}

https://chromium.googlesource.com/chromium/src/+/5cdeb1b84

BUG=617799
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2080713003 .

Cr-Commit-Position: refs/heads/master@{#400712}

This CL removes a bunch of builders that no longer exist and
adds a few that didn't have configs yet.

TBR=thakis@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2079173002
Cr-Commit-Position: refs/heads/master@{#400711}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/56b4ce52..f9c1dd04

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2081763002
Cr-Commit-Position: refs/heads/master@{#400710}

The feature was disabled because of two bugs. Both have since been fixed.

BUG=617249, 581777
TBR=piman@chromium.org, kbr@chromium.org

Review-Url: https://codereview.chromium.org/2085573002
Cr-Commit-Position: refs/heads/master@{#400709}

The CL is ready but causes a Warning C4267 (implicit size_t to int
conversion) in some Windows Waterfall bots (not in CQ).
After some land-archaeology, it seems that capture.gyp did not
have the warning explicitly disable, I believe it was lost in some
rebase. So, re-enabling it and relanding.

Original re-reland description -----------------------------------------
Re-reland: Make media/capture gn and gyps produce components

Reland got reverted due to a WinX64 typical issue:
warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
causing C4267 in
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/compile/logs/stdio

Original reland description -------------------------------------------
Reland: Make media/capture gn and gyps produce components

Which got reverted due to a Mac build breakage (see
https://codereview.chromium.org/2059493002/) and
a Win one  (https://crbug.com/618854).

Original description ---------------------------------------------------
Make media/capture gn and gyps produce components
This CL separates media/capture into a component,
to allow, in a subsequent CL, linking with mojo for using
ImageCapture types.

This basically reproduces the media/cast and media/midi
structure.

Windows import/export issues made necessary to add
capture_export and associated CAPTURE_EXPORT macro,
again, replicating media/midi.

gn gen ... --check uncovered some transitive dependencies
during the "analyze" phase of the bots and I had to make
them explicit (e.g. media:gpu).

BUG=518807
-----------------------------------------------------------------------
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

TBR=avi@chromium.org, xhwang@chromium.org, miu@chromium.org
rationale:
reland: since the PS2/3 are trivial, just making explicit libs that are
already elsewhere in media/ build files- I wonder why it didn't fail in
the bots :( .
re-reland: I'm just adding a MSVS-warning disable that was lost in a
rebase :)

Review-Url: https://codereview.chromium.org/2068763002
Cr-Commit-Position: refs/heads/master@{#400708}

BackgroundBudgetService to be asynchonous. This is a step on the path to
converting BackgroundBudgetService budget storage to use a LevelDB storage
instead of prefs storage, which will require some of the budget service's
methods to run on a thread other than the UI thread.

BUG=617971

Review-Url: https://codereview.chromium.org/2058523003
Cr-Commit-Position: refs/heads/master@{#400707}

https://chromium.googlesource.com/chromium/src/+/5cdeb1b84

BUG=617799
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2081773002 .

Cr-Commit-Position: refs/heads/master@{#400706}

https://chromium.googlesource.com/chromium/src/+/5cdeb1b84

BUG=617799
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2080783003 .

Cr-Commit-Position: refs/heads/master@{#400705}

https://chromium.googlesource.com/skia.git/+log/d2809573deb7..52ede1d90572

$ git log d2809573d..52ede1d90 --date=short --no-merges --format='%ad %ae %s'
2016-06-20 brianosman More removal of SkColorProfileType...
2016-06-20 msarett Sanitize parsing of color look-up table

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2082683002
Cr-Commit-Position: refs/heads/master@{#400704}

The original CL was later reverted (CL crrev.com/2068953003) due to
frequent failures of the SAMLPolicyTest.SAMLInterstitialNext test.

This follow-up CL should resolve the tests flakiness.

The problem with the original CL was that it could introduce raising the
"ready" event too early, so that the test code could start working when
the webview was still pointing to the blank page.

BUG=613245,620353
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2082533002
Cr-Commit-Position: refs/heads/master@{#400703}

https://chromium.googlesource.com/chromium/src/+/5cdeb1b84

BUG=617799
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2084643002 .

Cr-Commit-Position: refs/heads/master@{#400702}

BUG=614277, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2082663003
Cr-Commit-Position: refs/heads/master@{#400701}

In SkiaBitLocker::cgContext()

We query the clip, which is empty, so we set clip_bounds to 0,0,1,1 (since CGBitmapContextCreate will fail for an empty width or height) and set bitmapIsDummy_ to true.

Then we call releaseIfNeeded(), which can change bitmapIsDummy_. In that case, back in cgContext() we are confused, and then call canvas_->temporary_internal_describeTopLayer() which can reset clip_bounds to empty... and thus CGBitmapContextCreate fails (unexpectedly).

The fix is to make the call to releaseIfNeeded() at the start of the function so any (hidden) mutations of fields is done before we start to set-and-use them.

BUG=620981

Review-Url: https://codereview.chromium.org/2086543002
Cr-Commit-Position: refs/heads/master@{#400700}

Now that linux_chromium_chromeos_rel_ng is using GN, the GN
builder is redundant.

R=phajdan.jr@chromium.org, jam@chromium.org
BUG=433082

Review-Url: https://codereview.chromium.org/2079163002
Cr-Commit-Position: refs/heads/master@{#400699}

https://chromium.googlesource.com/chromium/src/+/5cdeb1b84

BUG=620141,619630,612874,619983,621025,621024,617799,620126
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2087483002 .

Cr-Commit-Position: refs/heads/master@{#400698}

BUG=b/28967332
TEST=Manually
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2085533002
Cr-Commit-Position: refs/heads/master@{#400697}

BUG=603138

Review-Url: https://codereview.chromium.org/2078073002
Cr-Commit-Position: refs/heads/master@{#400696}

This serializes and deserializes SharedQuadStateList via an iterator as
ListContainer does not support O(1) random access.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2075853004
Cr-Commit-Position: refs/heads/master@{#400695}

PasswordFormManager::not_best_matches_ used to be a ScopedVector, now it is a
vector of unique_ptr.

BUG=555132

Review-Url: https://codereview.chromium.org/2074373003
Cr-Commit-Position: refs/heads/master@{#400694}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/62740faa..56b4ce52

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2086503002
Cr-Commit-Position: refs/heads/master@{#400693}

BUG=620371

Review-Url: https://codereview.chromium.org/2067303002
Cr-Commit-Position: refs/heads/master@{#400692}

Review-Url: https://codereview.chromium.org/2080223003
Cr-Commit-Position: refs/heads/master@{#400691}

Since I can't work out why things are null in native code anymore.

BUG=618807

Review-Url: https://codereview.chromium.org/2076633002
Cr-Commit-Position: refs/heads/master@{#400690}

https://chromium.googlesource.com/skia.git/+log/452ba88066b5..d2809573deb7

$ git log 452ba8806..d2809573d --date=short --no-merges --format='%ad %ae %s'
2016-06-20 msarett Support sRGB dsts in opt code

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2083613002
Cr-Commit-Position: refs/heads/master@{#400689}

- Triggering time is 5s instead of 3s.
- Disable animation on JellyBean.
- Animation width is 30% of progress instead of 50%.
- Two-step animation is now slow then fast.
- Animation duration is a function of progress bar length.
- Indeterminate animation has max dp width of 400.

BUG=464377

Review-Url: https://codereview.chromium.org/2015663002
Cr-Commit-Position: refs/heads/master@{#400688}

This is necessary for https://codereview.chromium.org/2074183002/
(Telemetry patch in the Catapult repository).

BUG=612140

Review-Url: https://codereview.chromium.org/2085483002
Cr-Commit-Position: refs/heads/master@{#400687}

The today extension does not alway get notification.
Check if there is a new entry before returning it.

Review-Url: https://codereview.chromium.org/2082513002
Cr-Commit-Position: refs/heads/master@{#400686}

This fixes the win-asan build, which has been offline since https://crrev.com/f265187bf390845c6d353fa7c4a9a72575fd86dd

This is a partial revert of https://codereview.chromium.org/2053953002/

TBR=caitkp@chromium.org
BUG=621460

Review-Url: https://codereview.chromium.org/2081713002
Cr-Commit-Position: refs/heads/master@{#400685}

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=

Review-Url: https://codereview.chromium.org/2065313002
Cr-Commit-Position: refs/heads/master@{#400684}

The method took a const reference for a PasswordForm, but never used it.
Instead it hard-coded using pending_credentials_, which was passed as the
argument all the times anyway. This CL changes the function to use its
argument, changes the argument from a const ref to a non-const pointer to allow
modification, and moves the function to the anonymous namespace, because it
does not need any state of PasswordFormManager.

R=kolos@chromium.org

BUG=621355

Review-Url: https://codereview.chromium.org/2086483002
Cr-Commit-Position: refs/heads/master@{#400683}

BUG=618311

Review-Url: https://codereview.chromium.org/2049543003
Cr-Commit-Position: refs/heads/master@{#400682}

Possible outputs are:
- "none"
- "1 app (<example>)"
- "2 apps (<example 1>, <example 2>)"
- "X apps (<example 1>, <example 2>, and X-2 more)"

Since this is rather complex, also add a unittest.

BUG=510028

Review-Url: https://codereview.chromium.org/2080283002
Cr-Commit-Position: refs/heads/master@{#400681}

metadata are updated and not just on OnComplete(). Keeping the OnComplete()
logging intact for a few more relaeses and will phase them out eventually.
BUG=611813

Review-Url: https://codereview.chromium.org/2034223002
Cr-Commit-Position: refs/heads/master@{#400680}

Revert of Make the notification builder more XPC friendly (patchset #6 id:100001 of https://codereview.chromium.org/2053613002/ )

Reason for revert:
Broke compilation on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/16903/steps/compile/logs/stdio

../../chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm:11:10: fatal error: 'chrome/grit/generated_resources.h' file not found
#include "chrome/grit/generated_resources.h"

Original issue's description:
> Make the notification builder more XPC friendly
>
> Move it to ui/cocoa/notifications where the xpc service will eventually live.
> Make it a static library so it can be linked by both the app and the XPC.
> Make sure the build operation only uses information from the underlying
> dictionary.
>
> BUG=571056
>
> Committed: https://crrev.com/aafb03bf0df164a2fb86db117ae6053e9578c437
> Cr-Commit-Position: refs/heads/master@{#400672}

TBR=jochen@chromium.org,peter@chromium.org,rsesek@chromium.org,miguelg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=571056

Review-Url: https://codereview.chromium.org/2080733002
Cr-Commit-Position: refs/heads/master@{#400679}

BUG=619103
TBR=wangxianzhu@chromium.org,chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2085503002 .

Cr-Commit-Position: refs/heads/master@{#400678}

Previously, the fill-on-account-select experiment in the password
manager had used a custom flag and Finch to manage the experiment. This
updates the experiment to use the Features API which handles all of that
automagically.

Note: This is an updated copy of jww's
https://codereview.chromium.org/2066703004/. Patch set 1 is equal to the
approved patch set 3 of that CL, and patch set 2 here addresses jochen@'s
comment from that CL.

BUG=568713
TBR=jww@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2080263002
Cr-Commit-Position: refs/heads/master@{#400677}