- 20 Dec, 2017 40 commits
-
-
Jacob Dufault authored
Bug: 792654 Change-Id: Icf7419c14f4a32d1c168e40060e495c7581bc0de Reviewed-on: https://chromium-review.googlesource.com/812152 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#525365}
-
Dirk Pranke authored
This reverts commit 7f446eb0. Reason for revert: reverting for now, now that we've established that it seems to work. Original change's description: > Enable proprietary_codecs=true by default. > > We want most of our test coverage to be done against builds with > the proprietary codecs included, so this changes the default to > do so. However, it is important that we *not* publicize or distribute > any builds that includes these codecs (since they likely won't have > the correct licensing), and so we explicitly turn the flag off on > the builders that do publish builds. > > This change includes a roll of the FFmpeg repo from 423f74fa..c94da9e8 > in order to pick up that change, which changes ffmpeg to pick up > `ffmpeg_branding`'s default value directly from `proprietary_codecs`, > making the actual ffmpeg_branding GN arg kinda pointless (the branding > is now driven by proprietary_codecs and is_chromeos). > > R=dalecurtis@chromium.org, chcunningham@chromium.org, jbudorick@chromium.org, kbr@chromium.org > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Id0b6cccbd235875c9386a527cb39c8f17d2dab03 > Reviewed-on: https://chromium-review.googlesource.com/832383 > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525172} TBR=dalecurtis@chromium.org,dpranke@chromium.org,kbr@chromium.org,chcunningham@chromium.org,jbudorick@chromium.org BUG=795935 Change-Id: I30b9d447facc94f3eaaa55c7252e3f050720619f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/836414 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#525364}
-
Evan Stade authored
notifications (i.e. the sign in profile). As per xiyuan&, during login, it's not safe to access the last used profile. And, as he points out, this is a system-level notification. NDS::GetForSystemNotifications was introduced recently and is a good fit. Bug: 791200 Change-Id: I6ecd2660a42a9a35a47643f2c166ee039b319b99 Reviewed-on: https://chromium-review.googlesource.com/833019 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#525363}
-
Kurt Horimoto authored
The completion blocks of the property animator is not guaranteed to be called in the synchronously from |-finishAnimationAtPosition:|, so despite previous safeguards put in place, the animator was still sometimes deallocated when the state was active. This CL updates StopAnimating() to no longer perform property animator completion blocks. Bug: 793623 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5d6d08c229d5fabe78f2ff79ab69560f79532d21 Reviewed-on: https://chromium-review.googlesource.com/835790Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#525362}
-
Samuel Huang authored
This CL adds to Zucchini Ensemble matching functionality, which takes detected Elements (executables) in (uncompressed)"old" and "new" archives, and for each "new" Element, attempts to find the best "old" Element to apply architecture-specific patching. EnsembleMatcher is the base class for the feature, and is extended by HeuristicEnsembleMatcher, which applies Courgette's ensemble matching heuristics, with enhancements (using BinaryDataHistogram and OutlierDetector). Zucchini-match tool is also added for testing. Upcoming work: - Add ImposedEnsembleMatcher, which enables ensemble matching to be injected via command line. - Implement ensemble maching in Zucchini-gen. Bug: 729154 Change-Id: Ia68818b725e2d27875871fece21c4a16a25fb608 Reviewed-on: https://chromium-review.googlesource.com/826283 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#525361}
-
Mike Reed authored
Future CL is here: https://skia-review.googlesource.com/c/skia/+/87788 Bug: Change-Id: Ib0c4988bdbbaf076f91b1f37f51ddc50d12b57c5 Reviewed-on: https://chromium-review.googlesource.com/836930Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#525360}
-
Roger McFarlane authored
This reverts commit 384930af. Reason for revert: compile break on missed occurrences of renamed symbol. Original change's description: > Rename kEnableSpellcheck -> kSpellCheckEnable. > > This is more consistent with other spellcheck preferences. > > Also reformatted with 'git cl format' due to presubmit warning. > > Bug: > Change-Id: I8ce447586432f2a72ccc1e93282d7810335ee13f > Reviewed-on: https://chromium-review.googlesource.com/832712 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Drew Wilson <atwilson@chromium.org> > Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525358} TBR=avi@chromium.org,stevenjb@chromium.org,atwilson@chromium.org,groby@chromium.org,macourteau@chromium.org Change-Id: I73eec84c94247262f5808176b8d610269f45a377 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/837207Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#525359}
-
Marc-Antoine Courteau authored
This is more consistent with other spellcheck preferences. Also reformatted with 'git cl format' due to presubmit warning. Bug: Change-Id: I8ce447586432f2a72ccc1e93282d7810335ee13f Reviewed-on: https://chromium-review.googlesource.com/832712Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#525358}
-
Rohit Rao authored
Bug: 787821 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3187e7175426f8453469283b58414618b3d4d3fb Reviewed-on: https://chromium-review.googlesource.com/758117 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Rohit Rao authored
BUG=794660 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7096b63b52aefa5e1da1128bfb9326d87f250822 Reviewed-on: https://chromium-review.googlesource.com/836814Reviewed-by:
-
Stepan Khapugin authored
This reverts commit 2d55caf6. Reason for revert: fails tests downstream Original change's description: > Fix URL clipping on iOS 11. > > Wraps omnibox textfield into a container that positions the textfield > inside of itself and clips its bounds so that the optimal clipping is > used. The clipping logic replicates that of the pre-iOS 11 solution > with UITextField overrides that are now broken in iOS 11. > To mask the clipped ends of the omnibox, a ClippingMaskView is used > as a maskView of the clipping view. > All of this is behind kClippingTextfield flag that is enabled by > default. > > Bug: 749788 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia03649618397d19990d39914fe1fb1b152b2760d > Reviewed-on: https://chromium-review.googlesource.com/779191 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525322} TBR=rohitrao@chromium.org,sdefresne@chromium.org,justincohen@chromium.org,stkhapugin@chromium.org Change-Id: I6b97cd711ef968ded8ff9a45574d6670b7c7f05f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749788 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/837087Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#525355}
-
Zhenyao Mo authored
And delete functions that become obsolete. BUG=744658 TEST=bots R=piman@chromium.org,kbr@chromium.org TBR=asargent@chromium.org Change-Id: Ib840edfb89b904a8972cbdd441ed3a4fc1d39e48 Reviewed-on: https://chromium-review.googlesource.com/835272 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#525354}
-
Gauthier Ambard authored
The ContentSuggestions coordinator layer was incorrectly created in ios/chrome/browser/content_suggestions instead of in ios/chrome/browser/ui/content_suggestions. This CL fixes it by moving all the files to the correct location. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifd3518f668f07726af0b8a320ea337de182099e2 Reviewed-on: https://chromium-review.googlesource.com/836392 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#525353}
-
Michael McGreevy authored
Isolate sha1s were taken from the following builds: https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-precise-64/10415 https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-mac-10.10-64/9839 https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-win-64/10696 This will pick up an isolate binary which the following changes: * exparchive subcommand is removed, * archive and batcharchive now ignore --exparchive (treating it as true). The old implementations for archive and batcharchive (i.e. those used when --exparchive=false) no longer exist. * --max-concurrent-uploads defaults to 8. Submitting this CL will have the effect of rolling out the exparchive-based implementations everywhere. Bug: 692940 Change-Id: I01b57c4b00ec8f82c2b1c162782da497d40bb55c Reviewed-on: https://chromium-review.googlesource.com/835769 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael McGreevy <mcgreevy@chromium.org> Cr-Commit-Position: refs/heads/master@{#525352}
-
Ken Rockot authored
content/common headers expose a dependency on ui/accessibility headers and ultimately on the generated ax_enums.h file, yet the dependency on //ui/accessibility is currently private. This can cause intermittent build flake. This fixes that. Bug: 796492 Change-Id: I0b60ec0ba9abc54d873a869326fef77cbb202d46 Reviewed-on: https://chromium-review.googlesource.com/836728Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#525351}
-
Chandan Padhi authored
|matched_output_device_id| as an empty string doesn't necessarily mean the absence of an output device. It can also represent a default output device. Changing |matched_output_device_id| to base::Optional will allow us to use base::nullopt to indicate the absence of an output device. Bug: 793255 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If405534df9c8b558a56a1a862f6aa72ce34df5dc Reviewed-on: https://chromium-review.googlesource.com/833828Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#525350}
-
Roger McFarlane authored
Test has been flaky. TBR=jochen@chromium.org,antrim@chromium.org Bug: 796308, 527045 Change-Id: Ifd05e090d8067cd43d016c38d26d203e4ac337f8 Reviewed-on: https://chromium-review.googlesource.com/836812 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
-
David Bokan authored
This patch makes synthetic pinch zoom gestures zoom to the correct scale. We do this by fixing two bugs in the scale gesture detector. The first is error due to touch slop. Slop is the amount that the touch points must move before the zoom gesture is activated. Unfortunately, the gesture recognizer drops the entire event that crosses the slop threshold. The second issue is similar but has to do with the minimum scaling span. The "span" is the distance between the two fingers in the pinch gesture. The minimum scaling span is the span at which point making the span smaller doesn't change the zoom level. Similarly to slop, the event that crosses this threshold is entirely dropped. At high speeds this resulted in losing a significant amount of delta. This CL fixes these issues by modifying the prev_span_ field on the first event that initiates a scale to be at the threshold, thus contributing the delta beyond it. I moved the reset and end that happens when a zoom out crosses the min span threshold to happen after we send an update, which allows us to send the final delta, clamped to the min span, before ending the gesture. I also start a pinch-zoom if the initial span is large enough but the first update causes us to cross this threshold. This means a single update can cuase a PinchBegin, PinchUpdate, PinchEnd. It also fixes existing tests that didn't expect that the first touch move that initiates a pinch zoom would also include a gesture pinch update. Bug: 610021 Change-Id: I22e2ff8d4b89f5da67ab102658175dbb5f2b2cec Reviewed-on: https://chromium-review.googlesource.com/784213 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#525348}
-
Mostyn Bramley-Moore authored
Change-Id: I63d49a3954e939adfd4337ef8e81498e1cdf3643 Reviewed-on: https://chromium-review.googlesource.com/836888Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#525347}
-
rhalavati@google.com authored
Added last updated place holder and content hash code to network traffic annotation auditor's TSV report, to be used for keeping up the annotations trix. Bug: 656607 Change-Id: If7e998250d827daedb9653e0a5d20135130a7325 Reviewed-on: https://chromium-review.googlesource.com/836589Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#525346}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a279326..cead990c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I291ed6166fc55c165f68b08e395bff783d8652c0 Reviewed-on: https://chromium-review.googlesource.com/836668Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#525345}
-
Peter Wen authored
https://groups.google.com/d/topic/error-prone-announce/-ExdzeDOURY/discussion BUG=793900 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4e3c7b3a39a64a4c1ef85c0ce5db770b33dba4b Reviewed-on: https://chromium-review.googlesource.com/820530Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525344}
-
Jiaquan He authored
This is a pre-flight commit for refactoring ChromeAppListItem, which: - uses ChromeAppListItem in chrome AppListModelUpdater interfaces instead of AppListItem, since they're always instances of ChromeAppListItem and we won't have AppListItem included in chrome; - changes test APIs to accept the an item's id instead of its pointer; - removes item order checks to care about the item set only; - removes AppListModelUpdater::MoveItem since it's only used in order-related tests. Bug: 733662 Change-Id: I118a1649cd2468dce586486043662f33dc9ad394 Reviewed-on: https://chromium-review.googlesource.com/832378Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 2562 2563 2564 2567 2569 2571 2573 2579 2581 2582 2585 917 lines were removed by consecutive passes since 2537. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9bf666bfc006ef869f4e1efa6d762af13b5bda57 Reviewed-on: https://chromium-review.googlesource.com/836827 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#525342}
-
Mike Klein authored
There may not be anything to rebaseline here after all. We'll see. Bug: skia:5733 Change-Id: Ia58097395850ec15a840bd99ed85e4109bcac607 Reviewed-on: https://chromium-review.googlesource.com/836807Reviewed-by:
-
Andrew Grieve authored
It's unused and the functionality is duplicated in dist_jar(). Change-Id: I9d689e4bb310412a1e1a883bc0fb9f46f7cd1ede Reviewed-on: https://chromium-review.googlesource.com/833157Reviewed-by:
-
Donn Denman authored
The native ContextualSearchRankerLoggerImpl was holding on to a WebContents pointer, which is somewhat dangerous. We're seeing crashes due to the WebContents going stale. This change just uses the WebContents to get the UKM SourceId and hangs on to it instead. The SourceId is all that's needed when we write the log. Now we also invalidate the SourceId when the log is written to ensure that we don't try to write more than once per SetupLoggingAndRanker call. BUG=795936 Change-Id: I4d1363ae709263bc76fc54f4c6316963c12f5018 Reviewed-on: https://chromium-review.googlesource.com/836127Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL moves the ownership of the OmniboxPopupViewIOS to the OmniboxPopupCoordinator. The coordinator is now owned by the toolbar, where the popup view was previous owned. It also changes the PopupView so it communicates with the mediator and has now no knowledge of the coordinator. Bug: 788640 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I530562cc0e52ed8ede575fc689a5326faf978e81 Reviewed-on: https://chromium-review.googlesource.com/833878 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525338}
-
Lily Houghton authored
Setting the QUIC user agent ID to a non-default value should be done using the experimental options API. Bug: 670686 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79bdbde1b1f8be0af3eff7d8d6080974e322b33c Reviewed-on: https://chromium-review.googlesource.com/822811 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#525337}
-
Boris Sazonov authored
This CL removes support for old generic signin promos from Bookmarks and RecentTabs. These promos were superseded by personalized signin promos. Old promos were implemented in SigninAndSyncView, so this CL also removes support for signin promos from this class. SigninAndSyncView will be renamed in follow-up CLs. Bug: 792430 Change-Id: I752f90339377e34c70766109a13f5e92e5ef1ea7 Reviewed-on: https://chromium-review.googlesource.com/836867Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#525336}
-
Charlie Andrews authored
This reverts commit af0c9396. The underlying problem was that disables without an associated reason weren't having any effect. I already had a fix for this in the most recent build, so this additional disable shouldn't be necessary. TBR=oysteine@chromium.org, aseemgarg@chromium.org, nednguyen@google.com NOTRY=true Bug: 796547 Change-Id: Idfc6e3b90619d54630125753ea76abb2dfa939ee Reviewed-on: https://chromium-review.googlesource.com/836948 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#525335}
-
Peter Beverloo authored
Instead use the Permission Service directly from Blink. TBR=thakis for header *removal* from //chrome/browser/DEPS Bug: 612312 Change-Id: I88e7a2f8913bdd0e97521b11193ff0ccd96c6aad Reviewed-on: https://chromium-review.googlesource.com/822936Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#525334}
-
Daniel Bratell authored
There was still two NOTIFY_OBSERVERS macros and in jumbo builds they triggered an error about macros being redeclared. This patch renames the macro that implements observer handling methods for Windows from NOTIFY_OBSERVERS to NOTIFY_OBSERVERS_METHOD. Bug: 773275 Change-Id: Ie58fd1793b144b694a0a34bfa552569db3f8a200 Reviewed-on: https://chromium-review.googlesource.com/836611Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#525333}
-
John Abd-El-Malek authored
This is already the case for chrome & content_shell, but wasn't for android_webview or headless. This is split off from https://chromium-review.googlesource.com/c/chromium/src/+/826303 which needs this behavior. Bug: 769401 Change-Id: I9777d85de6206ba932a83d6b48516acdf5de1671 Reviewed-on: https://chromium-review.googlesource.com/836069Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#525332}
-
Colin Blundell authored
WebHistoryService is a client of SigninManager and ProfileOAuth2TokenService. Its unittest creates fakes of these classes to supply them to the WebHistoryService instance under test. However, these dependencies are actually unnecessary: - WebHistoryService's only usage of these classes is to pass them to an internal RequestImpl class that makes access token requests. - The unittest deliberately eschews usage of RequestImpl, replacing it with a TestRequest class that makes no usage of //components/signin. Note that changing the tests to actually exercise RequestImpl would be a non-trivial amount of work, as RequestImpl has substantial other interactions that would need to be stubbed out (e.g., with the network). This CL simply eliminates the unused dependencies from the test. Bug: 796545 Change-Id: I45c55684e119ece7172c8ee406486a46faca815e Reviewed-on: https://chromium-review.googlesource.com/835109Reviewed-by:
-
clamy authored
This CL ensures that PlzNavigate aka browser-side navigation is always enabled. Renderer-side navigation is no longer supported. BUG= 789577 Change-Id: Icc8f99966ae562799ebd44d077287970702d642f Reviewed-on: https://chromium-review.googlesource.com/832651 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
When the type of an HTMLInputElement changes, the labels LiveNodeList inconsistently gets invalidated (depending whether the shadow subtree of the input element changes). This CL causes invalidation of the labels nodelist to happen any time any of the name/id/type/for/form attributes changes for an element. Bug: 795910 Change-Id: Ice58060e06150f58b4fb5c8771a413091446ff62 Reviewed-on: https://chromium-review.googlesource.com/833249Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#525329}
-
Oystein Eftevaag authored
CC=aseemgarg@chromium.org NOTRY=true TBR=nednguyen@chromium.org BUG=796547 Change-Id: I96d814ed8c23d539cb17b448521c4a009d22a275 Reviewed-on: https://chromium-review.googlesource.com/836598 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#525328}
-
Jochen Eisinger authored
Otherwise, the traces won't include events from renderers R=skyostil@chromium.org Change-Id: I40e33b3191c3e1d58a77aadf57583600286430df Reviewed-on: https://chromium-review.googlesource.com/833880Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525327}
-
Balazs Engedy authored
Move method definitions after type definitions to comply with style guide, and rearrange methods to make more sense. Bug: 740081 Change-Id: I0c77ac065203d9d917815151417ea1d24de56b61 Reviewed-on: https://chromium-review.googlesource.com/833887 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
