- 17 Jun, 2019 40 commits
-
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=kmackay@chromium.org Change-Id: I1ac52d598e71f6569f544c0cdaee67c07ffd7f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648269 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#669598}
-
Yi Su authored
This CL moves the handler method for navigation.didPushState message from CRWWebController into CRWJSNavigationHandler. Bug: 956511 Change-Id: I6a3941f8ab46725fe1a5680af6f89b7ed44fb8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660491 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#669597}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=tbarzic@chromium.org Change-Id: Ib2a2cd41a6a01184a2876bcc099f4c49879dcb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648206 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#669596}
-
Mario Sanchez Prada authored
This repeating callback got introduced along with crrev.com/c/1630162 but it's not used anywhere, so let's remove it. Bug: 939372 Change-Id: I772d7c766da0669b4b11fa55a77e7adbb3c483cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660445Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#669595}
-
Lin Sun authored
Remove several suppressions on the passthrough command decoder with ANGLE's OpenGL backend, and one Windows suppression with the D3D11 backend. Bug: 602688, 782317 Change-Id: I7782106acd05fbef1828c4c4be7b3c3cf6aef9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645493Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#669594}
-
Mario Sanchez Prada authored
This converts the GetPushMessaging() method from DocumentInterfaceBroker along with the relevant parts of the implementation of mojom::PushMessaging at chrome::PushMessagingManager, and the two classes that use it from Blink, that is, blink::PushProvider and blink::PushMessagingClient. Note that, for now, this still relies on implicit conversions to get a PendingReceiver<T> from InterfaceRequest<T> in PushMessagingManager, which should go away once RenderProcessHostImpl has migrated away from service_manager::BinderRegistry, to service_manager::BinderMap. Also, it needs to keep using the InterfaceProvider in PushProvider to bind the remote interface to avoid thread-related issues that would happen if we tried to use service_manager::Connector now, since that requires being in the main thread to run Connect(), and that code usually runs from the ServiceWorker thread instead. This should stop being a problem once we have a ServiceWorkers-based InterfaceBroker, at which point the code can be fully migrated to service_manager::Connector. Bug: 955171 Change-Id: I62fb6d8b8e1a5872a14740260ea2bca14daf1a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655536Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#669593}
-
Takuto Ikuta authored
Bots are added in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1387683 TBR=jbudorick Bug: 954450, 956776 Change-Id: I1444fd2b196e10310abc449d965a7213b81deecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661319Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#669592}
-
Takuto Ikuta authored
TBR=jbudorick Bug: 956776, 954450 Change-Id: I4ef5268679a71be3b1d368fc1eeab30e1aadfa29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662105Reviewed-by:
-
Noel Gordon authored
Since rendering work here is way more important, idle delay the UMA to a better place: when the browser is idle. Bug: 965370 Change-Id: Idf14450312b07a751901f3a3b0ea99f988890c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662106Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669590}
-
Tim Schumann authored
fast/scrolling/unscrollable-layer-subpixel-size-with-negative-overflow.html media/audio-concurrent-supported.html virtual/fractional_scrolling/fast/scrolling/unscrollable-layer-subpixel-size-with-negative-overflow.html virtual/gpu/fast/canvas/OffscreenCanvas-copyImage.html virtual/scroll_customization/fast/scrolling/unscrollable-layer-subpixel-size-with-negative-overflow.html TBR=mstensho@chromium.org BUG: 974652 Change-Id: I93e60942e80ceb71c2b267996cc8141414f54944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660330 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#669589}
-
Wei Lee authored
This CL puts the callback of RemoveTrack() to a member variable rather than passing as parameter to fix an issue that UserMediaClientImpl sometimes cannot process request after MediaStreamVideoSource dies. Bug: 972017, b/131272798 Test: Manually Change-Id: I04dc594b23ce981f3443996be4a5ac3538770211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660394 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#669588}
-
Chih-Yu Huang authored
QP value is used to control the quality and the bitrate of encoded video stream. When QP value increases, the bitrate will decreased. Originally the bitrate is higher than expected value when encoding small resolution video. This CL increases the upper bound of QP value, let the encoder could encode the video with lower bitrate. BUG=b:110059922 BUG=chromium:974593 TEST=Run video_encode_accelerator_unittest on Eve and Cyan Change-Id: I4922989f279052d2d19a87b1b858554c51120249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660376Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#669587}
-
Noel Gordon authored
DriveFs shipped and it reports Team Drive modification time: show that in QuickView metadatabox. CL:1141459 mentioned some patch to come that would fix it ...
👌 that never happened it seems. Bug: 965370, 925229 Change-Id: Ie12e1b5c1fb77c288777f0f54a67302c1d543457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662103Reviewed-by:Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669586}
-
Kunihiko Sakamoto authored
This adds an interface for parsing the Bundled Exchanges format into the data_decoder service. The actual parsing code will be added in the next CL (https://crrev.com/c/1626065). Bug: 969596 Change-Id: I776199c8a55cd0137dc629ef6199ffa1959b9922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640524 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#669585}
-
Ryo Hashimoto authored
Partially revert r665168 (CL:1637649) which broke ARC Custom Tabs' UA override: - chrome::SetAndroidOsForTabletSite() doesn't work because there is no NavigationEntry yet. - The removed TODO is still valid. BUG=b:64863368 TEST=Open an ARC Custom Tab Change-Id: Iabac4ad68b7b8452a44b9768a2637ce106b43d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660390 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#669584}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/69596baef36c..def9662348b0 git log 69596baef36c..def9662348b0 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 johnkslang@users.noreply.github.com Merge pull request #1796 from Igalia/siglesias/fix-gl_SubGroupSizeARB-tese-geom Created with: gclient setdep -r src/third_party/glslang/src@def9662348b0 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Ic5bfc19876f942a8b59da333d9c1a7eec266b565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669583}
-
Michael Lippautz authored
- Fix various operator new invocations. - Disallow nesting of HeapLinkedHashSet which depends on the fact that the collection itself does not move. Change-Id: I37978a0ea226ab40227caaff0246e3c70f47b022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660556 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. Although previous CLs have been adding the keywork in some submodules of html, there are still IDL files which don't have the keyword. So this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/html directory. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: Id48acfab328a7b63b4898fa397fa79527487a136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662090Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#669581}
-
Tim Schumann authored
as flaky on Mac 10.13 Notry: true TBR=kojii@chromium.org Bug: 974666 Change-Id: I8fb8bf96fdf5a5e57e3b4754e7e712778af222b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659450 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
HitTestLocation rounds the hit test location to the closest 1x1 rect for no good reason, causing some confusing hit test results. Hence, this patch removes such rounding. Bug: 974314 Change-Id: I48266a7ec8bffbeb746085c5d8835d3f300dd4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661297Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#669579}
-
Reilly Grant authored
The SerialPort.Open method originally took a SerialPortClient as an associated interface. This ensures the ordering of responses to SerialPort methods is synchronized with events on the SerialPortClient interface. This prevents SerialPort.Open from being used from the Mojo JS bindings because they do not support associated interfaces. Web tests for the Serial API implementation in Blink would like to use these bindings. Upon deeper investigation the only method for which ordering really matters is SerialPort.Open itself. This is because serial data is sent using a pair of data pipes and those do not have any ordering guarantee with either the SerialPort or SerialPortClient pipes. To avoid messages on the now-unassociated SerialPortClient interface from racing ahead of the reply to the SerialPort.Open method the SerialConnection class is modified to only create its client binding and start watchers on the data pipes after the reply to the Open method is received. Bug: 893334 Change-Id: I511060d45c5d537af1edddaeccd0436e34c0b0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660603Reviewed-by:
-
Alan Cutter authored
The AppBanners and PwaImprovedSplashScreen flags are no longer in use and can be removed. Bug: 734897, 759945, 974596 Change-Id: I4590d97cb7d747aa9d509a66e0771b6f2f419ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662093Reviewed-by:
-
Noel Gordon authored
All callers send an argument, being the way in which the QuickView was opened for recording in UMA. It's not really optional argument: change display_() API code and closure markup require the argument. Bug: 965370 Change-Id: I055ed3206299468a22af802ea27761e072b5b378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661325Reviewed-by:
-
Alexey Baskakov authored
This is a move-only CL, no behavior changes. chrome/browser/extensions/ will not contain any bookmark_app* code. TBR=sky@chromium.org Bug: 973288 Change-Id: I46f4f05d21f300a78b73bf7b66273ff5c122a9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662089Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
Bug: 961186 Change-Id: I64303876eb6fd7cc594436c8dff32fde85e5ffbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659663 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Auto-Submit: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#669574}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8dc16c755161662515d2dbd5db347ed4780c6f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661574Reviewed-by:
-
Greg Kerr authored
Now that the MDS hardware issue is public, add a comment explaining the scheduler configuration manager settings and purpose. Bug: 927840 Change-Id: I57467494099c2d592da001b5221aa3e58f3b5c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660032 Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669572}
-
Keishi Hattori authored
Convert the global MutationObserver data, active_mutation_observers, suspended_mutation_observers, and active_slot_change_list to per agent. Introduces the MutationObserverNotifier class which is created for every WindowAgent. MutationObserverNotifier now manages active_mutation_observers, suspended_mutation_observers, and active_slot_change_list. Also the Document's agent is now set using the ContextDocument frame's WindowAgentFactory. This is because some Documents such as those created with DOMImplementation.createHTMLDocument do not have a frame. Some Documents created in unit tests have neither a ContextDocument nor a frame so we assign a new WindowAgent. In theory agent's are tied to ExecutionContexts, and these Documents that do not have an ExecutionContext should not have their own WindowAgent. Bug: 961186 Change-Id: Ie36a64791a3e1b424bcbf248b083fdf1bf5d465d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655412 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
This CL makes a global boolean variable atomic to fix a race condition found by TSAN. It's only used when DCHECK_IS_ON(), thus the performance is not an issue here. Bug: 893606 Change-Id: I9c22fd44ed49d7b20c5267e6215ad42248034f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659665Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#669570}
-
Kent Tamura authored
Now it supports single character strings, U+E004, and U+E050. The following tests are workable. - focus-01.html and inert-node-is-uneditable.tentative.html: Send a single ASCII character - focus-tabindex-*.html: Send U+E004 - focus-visible-007.html: Sends U+E050 Bug: 828858 Change-Id: I17d20c21e3f34eca609c1f027784f200de2addae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652635Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#669569}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/915bada1..5e14bd7e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie8ab0b87fe420163f71330d4e8c1c45f3f75d55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661497Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669568}
-
Alexey Baskakov authored
AppRegistrar is repsonsible for any counting of apps. Bug: 891172 Change-Id: I1ce10615bb1363d34704a4812ef7578da510f384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660294Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#669567}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/96ee92f09b7c..69596baef36c git log 96ee92f09b7c..69596baef36c --date=short --no-merges --format='%ad %ae %s' 2019-06-17 johnkslang@users.noreply.github.com Merge pull request #1799 from jeffbolznv/volatile_semantics Created with: gclient setdep -r src/third_party/glslang/src@69596baef36c The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I3e7d8d60200f4d58ea1a04fc2ca15b028d4a5b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661571Reviewed-by:
-
Ramin Halavati authored
A histogram metric is added to count the number of times bookmarks are used in each profile type. Bug: 966747 Change-Id: Iaca0beedfd63b65d1f7cc0184d9d5dba21e2f428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649535Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#669565}
-
Luciano Pacheco authored
Change the test to use repeatUntil to check for the a11y messages, instead checking it only once, because it was racy. Running locally with --gtest_repeat=50 indicate that this is enough to deflake this test. Bug: 973795 Change-Id: I2704191821c2fc6dfe02aaba82729cc118f631b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660374Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e38ced61. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." 8bbed8ff "Reland tests from "Change ICE connection state on transceiver changes"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2c20a4646abd466212af428f64a67a58ab230f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661753Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669563}
-
tby authored
Bug: 951287 Change-Id: I4b4a9ff809908b7804e1111b07d41279d8e66039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640797Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#669562}
-
Kenichi Ishibashi authored
When off-the-main-thread script fetch is enabled we don't have to create WebServiceWorkerNetworkProvider as it isn't used. Bypass creating WebServiceWorkerNetworkProvider and directly pass a URLLoaderFactoryInfo to ServiceWorkerFetchContextImpl. Change-Id: I7c9806a6ed1b291acb83063e23f84492f8a20b19 Bug: 692909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657370 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Id5cc6127be263bf768643c39c29efa3ed4abda6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660274Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#669560}
-
Victor Costan authored
This CL works around the following confluence of problems. 1) If a cached response contains a Last-Modified header, AppCacheUpdateJob::URLFetcher::AddConditionalHeaders() adds an If-Modified-Since header, so the server may return an HTTP 304 Not Modified response. AppCacheUpdateJob::HandleUrlFetchCompleted() reuses the existing cache entry when a 304 is received, even though the HTTP specification mandates updating the cached headers with the headers in the 304 response. This deviation from the HTTP specification is Web-observable when AppCache resources are served with Last-Modified and Cache-Control: max-age headers. Specifically, if a server returns a 304 with a Cache-Control: max-age header, the response stored in AppCache should be updated to reflect the new cache expiration time. Instead, Chrome ignores all the headers in the 304 response, so the Cache-Control: max-age directive is discarded. In other words, once a cached resource's lifetime expires, 304 responses won't refresh its lifetime. Chrome gets stuck in a cycle where it sends If-Modified-Since requests, the server responds with 304, and the response headers are discarded. 2) The implementation of AppCacheUpdateJob::UpdateURLLoaderRequest::OnReceiveResponse() introduced in https://crrev.com/c/599359 did not populate |request_time| and |response_time|. When the Network Service was enabled, caches got populated with the default value of base::Time, which is the Windows epoch. So, cached entries with max-age values below ~40 years will require re-validation. https://crrev.com/c/1636266 fixed the cache population bug, but did not address the incorrect times that have already been written to users' disks. The 1st problem, on its own, hasn't had a large impact. This is likely because we have been advising sites to set max-age=31536000 (~1 year) for immutable resources, and most AppCache caches have been getting evicted before the entries' max-age expired. However, the 2nd problem caused us to create a large number of expired cache entries, and the unnecessary If-Modified-Since requests are causing noticeable levels of traffic. This CL introduces a workaround while a longer-term fix gets developed and deployed. We'll consider all cache entries with invalid times to have been created on Tue, Jan 29 2019. This is the day when M72 was released to Chrome's Stable channel, and was chosen be cause M72 had the first large Network Service deployment. This CL was tested manually because the cost of developing an automated test outweighs the benefits. * Costs: AppCache doesn't support injecting a base::Clock, so the test would have either required a lot of plumbing, or would not have tested the exact bug scenario. * Benefits: The code added here is a workaround. It will be replaced by logic that updates the cache entry's headers when a 304 response is received. Since the code has a short expected lifetime, it's unlikely that an automated test will catch any regressions. Tested: Manually, using the repro steps in https://crbug.com/972983#c3 Bug: 972983, 968179 Change-Id: I68860ed28c4980e0a16297a243181995f5993ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661472 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#669559}
-
