GitLab

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7585015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91755
TEST=see bug

Review URL: http://codereview.chromium.org/7569028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=74065
TEST=Launch chromium and trigger an infobar.  Enter presentation mode, then Cmd-F to trigger find in page.  Findbar should be visible even when the overlay is open.
TEST=Launch chromium and trigger an infobar.  Enter fullscreen, ensure that presentation mode is off (the UI is always visible), then Cmd-F to trigger find in page.  Findbar should be visible even when the overlay is open.

Review URL: http://codereview.chromium.org/7491095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95948 0039d316-1c4b-4281-b951-d872f2087c98

Patch from Fabien Tassin <fta@sofaraway.org>.

Review URL: http://codereview.chromium.org/7585038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95947 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91878
TEST=Can connect remoting Client on Windows, with sandbox active, to a Host.

Review URL: http://codereview.chromium.org/7528015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95946 0039d316-1c4b-4281-b951-d872f2087c98

Discard selection from the the GetLeft/RightSelectionModel return value.
Update the cursor properly on edits.

BUG=90426
TEST=--use-pure-views cursor movement, position after editing.

Review URL: http://codereview.chromium.org/7598014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92111
TEST=


Review URL: http://codereview.chromium.org/7558015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95944 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leak in GetWebkitPrefs occurring on CrOS Valgrind bot.  Generalizing an existing suppression.

BUG=90400
TEST=Tests go green on CrOS Valgrind bot.
TBR=glider@chromium.org

Review URL: http://codereview.chromium.org/7529040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=VideoCapture sample (in a later CL)

Review URL: http://codereview.chromium.org/7528006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95942 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leak in net::HostResolverImpl::Job occurring on CrOS Valgrind bot.

BUG=92123
TEST=Tests go green on CrOS Valgrind bot.
TBR=agayev@chromium.org

Review URL: http://codereview.chromium.org/7528019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95941 0039d316-1c4b-4281-b951-d872f2087c98

as views_delegate may not be initialized when touchui is set

BUG=none.
TEST=none.

Review URL: http://codereview.chromium.org/7529031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95940 0039d316-1c4b-4281-b951-d872f2087c98

Test still fails due to a NOTIMPLEMENTED() call from r93120. Marked as DISABLED
until bug is fixed so the GPU bots are green (otherwise, it times out).

BUG=89964
TEST=gpu_tests --gtest_filter=GpuPixelBrowserTest.WebGLTeapot


Review URL: http://codereview.chromium.org/7528012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95937 0039d316-1c4b-4281-b951-d872f2087c98

Support for them was removed in r87618, but these constants were missed.

BUG=none
TEST=no
R=aa@chromium.org


Review URL: http://codereview.chromium.org/7600005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95936 0039d316-1c4b-4281-b951-d872f2087c98

The sync performance tests began timing out on the XP and Vista performance bots
shortly after tab sync tests were added.  This seems to be coincidental, because the
InProcessBrowserTest.Empty is timing out as well.

As an attempt to fix this issue, this patch takes all non test case source files that
are included in sync_integration_tests, and adds them to sync_performance_tests.

BUG=91992
TEST=sync_performance_tests


Review URL: http://codereview.chromium.org/7602002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95935 0039d316-1c4b-4281-b951-d872f2087c98

That CL was revert due to build breakage. The cause of build break
should be fixed in http://codereview.chromium.org/7529031/

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7528009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95934 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r91768.

BUG=91905
TEST=none


Review URL: http://codereview.chromium.org/7583036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95932 0039d316-1c4b-4281-b951-d872f2087c98

This attempted fix for the bug referenced below did not help.

Original message:

TaskClosureAdapter::Run does not invoke the task if it is null.

This is an attempt to fix http://crbug.com/81449. If this actually fixes it then there is probably something more fundamentally wrong.

BUG=81449

Review URL: http://codereview.chromium.org/7598015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18815
TEST=Pepper Flash in full-screen

Review URL: http://codereview.chromium.org/7599009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95930 0039d316-1c4b-4281-b951-d872f2087c98

Refactor webkit_glue::FormField to remove hacky methods:  Remove webkit_glue::FormField's unwieldy full constructor and StricktlyEqualsHack() method.  The only clients are in test code, and we can better support these clients in other ways.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7576001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77634
TEST=None

R=akalin@chromium.org

Review URL: http://codereview.chromium.org/7550059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95927 0039d316-1c4b-4281-b951-d872f2087c98

This CL is made by:
- Got harfbuzz ToT (revision d10a264823e81631336bab37f08a52cc243d3654)
- Applied third_party/harfbuzz/chromium.patch to harfbuzz ToT.
- Applied the change made by http://codereview.chromium.org/543067/
  (chromium.patch doesn't include this change)
- Copied revised files to third_party/harfbuzz
- Updated README.chromium and chromium.patch

BUG=91789
TEST=ran WebKit layout tests.

Review URL: http://codereview.chromium.org/7595001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95926 0039d316-1c4b-4281-b951-d872f2087c98

* Update extract_actions.py to scan for metrics specified in the WebUI code.  A common pattern is <input pref="blah" metric="Options_Blah" type="checkbox">.

* Clean up almost all of the existing warnings thrown by extract_actions.py.  There is one remaining use of RecordComputedAction that is a bit too subtle for me to lump into this patch.

* Add a new warning to extract_actions.py that scans for uses of UserMetricsAction with a non-literal string.  Any such uses are going to be missed by the script, and hence should use RecordComputedAction instead.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7314020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95925 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87457
TEST=none

Review URL: http://codereview.chromium.org/7600007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95923 0039d316-1c4b-4281-b951-d872f2087c98

BUG=54942,50481
TEST=none

Review URL: http://codereview.chromium.org/7599002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95919 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87457
TEST=none

Review URL: http://codereview.chromium.org/7598010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95918 0039d316-1c4b-4281-b951-d872f2087c98

Revert overly-wide change in dependency chain.  Now the new build step will only be enabled when the optimizations are turned on.

Review URL: http://codereview.chromium.org/7598008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95916 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581

Review URL: http://codereview.chromium.org/7598020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95914 0039d316-1c4b-4281-b951-d872f2087c98

Whitespace change: http://codereview.chromium.org/7600002

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7600001

TBR=jianli@chromium.org

The following tests started to fail (crash) on WK canary with this roll: 2d.path.arc.zero.1.html 2d.path.bezierCurveTo.basic.html 2d.path.bezierCurveTo.shape.html 2d.path.fill.closed.unaffected.html 2d.path.fill.winding.subtract.3.html 2d.path.moveTo.basic.html 2d.path.rect.end.1.html 2d.path.rect.selfintersect.html 2d.path.rect.zero.4.html 2d.path.stroke.prune.arc.html 2d.path.stroke.prune.rect.html 2d.path.stroke.union.html 2d.shadow.canvas.basic.html 2d.shadow.enable.x.html 2d.state.saverestore.globalCompositeOperation.html context.unrecognised.nullsuffix.html canvas-copyPixels.html canvas-drawImage-incomplete.html canvas-fillPath-pattern-shadow.html canvas-font-ex-units-crash.html
Review URL: http://codereview.chromium.org/7600012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95913 0039d316-1c4b-4281-b951-d872f2087c98

This should help reduce confusion on when/whether a sandbox is running.

Review URL: http://codereview.chromium.org/7528013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95912 0039d316-1c4b-4281-b951-d872f2087c98

Change PrintWebViewHelper::PrintPreviewContext to have a PreviewMetafile, removing the need to cast it.

BUG=NONE
TEST=NONE


Review URL: http://codereview.chromium.org/7582014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95911 0039d316-1c4b-4281-b951-d872f2087c98

  * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ .  Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
  * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*.  This also allows doing string operations on them.
  * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
  * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
  * Avoid #define and "using".
  * Use standard algorithms for similar reasons as using string ops.
  * Use file_util functions to significantly abbreviate file reading/writing code.
  * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
  * Avoid casting where possible.  Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
  * Convert non-error uses of stderr to the chrome-standard VLOG(1).
  * Correctly handle hostnames with trailing dots in the input file.
  * In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly.  It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7529035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95910 0039d316-1c4b-4281-b951-d872f2087c98

Reverting to make merging next patch into M14 easier.

Added formatting API for browser extension as well as event routing. 
Created a complete UI for formatting.

This code depends on the following changes to libcros:
http://gerrit.chromium.org/gerrit/#change,4446

BUG=chromium-os:4541, chromium-os:17071
TEST=Try to format removable media.


Review URL: http://codereview.chromium.org/7471024

TBR=sidor@chromium.org
Review URL: http://codereview.chromium.org/7599015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95909 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7550053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95908 0039d316-1c4b-4281-b951-d872f2087c98

  * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ .  Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
  * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*.  This also allows doing string operations on them.
  * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
  * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
  * Avoid #define and "using".
  * Use standard algorithms for similar reasons as using string ops.
  * Use file_util functions to significantly abbreviate file reading/writing code.
  * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
  * Avoid casting where possible.  Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
  * Convert non-error uses of stderr to the chrome-standard VLOG(1).
  * Correctly handle hostnames with trailing dots in the input file.
  * In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly.  It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95907 0039d316-1c4b-4281-b951-d872f2087c98

1) Unit tests were incorrectly using TextureInfo
2) GLES2Implementation::TexSubImageImpl was reading 1-7 bytes
   too many.

TEST=ran with Dr.Memory
BUG=91786


Review URL: http://codereview.chromium.org/7541074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95906 0039d316-1c4b-4281-b951-d872f2087c98

This headerfile is required on newer systems.

BUG=none
TEST=print preview works after including the header file.


Review URL: http://codereview.chromium.org/7558008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/7598012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95902 0039d316-1c4b-4281-b951-d872f2087c98

One of the issues is that a nested event loop in |-mouseDown:| was causing the
thread to block after the menu closes, because the opening of the menu pumps the
mouseUp event.

BUG=91850
TEST=Open a bookmark from the folder and the spinner spins.

Review URL: http://codereview.chromium.org/7528007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95901 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7598006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95900 0039d316-1c4b-4281-b951-d872f2087c98