- 15 Jan, 2021 40 commits
-
-
Leonid Baraz authored
Convert uint64->int64 where necessary. Also, when uploading, generate double sequeincing information in EncryptedRecord to enable gradual server transition (unsigned one will go away later, with only signed one remaining). Bug: b:174509632 Bug: b:177677467 Change-Id: I8deec42dfa4978b5fdf3fbee9ee8e77cb58f0a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631725 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#844287}
-
kyle Ju authored
Bug: 1167318, 1167321 Change-Id: I444c090f5e9ae90168fa29cb3a4cec788bb6cb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633372Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#844286}
-
James Cook authored
This is a step towards allowing existing interactive_ui_tests to use the TestController crosapi interface to interact with the ash window manager. We have to filter out one test, because hooking up crosapi applies a restriction to the main browser profile that it is a "regular" profile that matches the device account. This restriction matches production behavior, so this is desirable in general. Bug: 1166936 Test: interactive_ui_tests Change-Id: I20ace7c9f98be32596437de8223c069bd7fcffaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631746Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844285}
-
Stephen McGruer authored
Due to mandatory code review, we need to migrate off of the automatic copy of tools/ in external/wpt, and instead use the manually rolled copy in blinkpy. Bug: 1165950 Change-Id: Ib38a8db4de3d52e2b590b7aaef35b5c01bdaad91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626048Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#844284}
-
Lachlan Ford authored
This change contains the flags, IDL definitions and blink stubs for the WebXR Hand Input module. https://immersive-web.github.io/webxr-hand-input/ https://github.com/immersive-web/webxr-hand-input/issues/ Subsequent changes will provide the Blink implementation, OpenXR device implementation and test code. Change-Id: I90169c4be02cf5daa29283a3fdf7fda6a4a2c319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623532 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#844283}
-
Hui Yingst authored
Change-Id: I660cee5c3c59c263a01935ee6b16a283f7680cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634008Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844282}
-
Ken Rockot authored
Bug: 1004256 Change-Id: Ib3d235767a074de954326085484e737ba6c8457a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633269Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#844281}
-
Adam Langley authored
With CTAP 2.1 it's possible for a security key to have an RP ID hardcoded into it which can receive enterprise attestation on request. If the RP ID is listed in the enterprise policy then this is permitted automatically. Otherwise, we need to alert the user that this is happening. This change adds an attestation permission step to the WebAuthn UI which acts the same as the current one, but with different wording to reflect the greater impact of enterprise attestations. Change-Id: I27fb9f7978b112910a51424f48c8e2567b146719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616736 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#844280}
-
Gavin Williams authored
This changes fixes a bug where the wrong option in the dropdown is selected when the selected scanner is changed. This happens when the new scanner has different available options than the previously selected scanner. Bug: 1166808 Change-Id: I2f81f39358ad6c104e1dc360d429cc14cbe94055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633087Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#844279}
-
Aaron Leventhal authored
R=chrishtr@chromium.org Bug: 1166296 Change-Id: I26d9e83ce62d9b28a610cf7e747cc4403af3c2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633027 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844278}
-
Yi Gu authored
See linked bug for details. TBR=aleventhal@chromium.org Bug: 1167331 Change-Id: I4b9ec1ec4acd90d59765655f18ea7a406962c7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633924Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844277}
-
Scott Violet authored
I believe these should all be converted to other more appropriate conditionals. BUG=none TEST=covered by other tests Change-Id: Ibd81116aa800ce25876fe3816569b71139007b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631350 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844276}
-
Josh Santana authored
Added UMA histogram metrics for the browser settings UI. Mainly affects language_page.js and add_languages_dialog.js. The metrics tracked should now match the android version's implementation here: https://uma.googleplex.com/p/chrome/histograms?sid=475eec68a50e5bcf24652249c380d74e Bug: 1159266 Change-Id: Id533c550b27ca3630a793131f47258b64a404e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600455 Commit-Queue: Joshua Santana <joshsantana@google.com> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#844275}
-
Kaiyu Chen authored
The feature flag controls the GPay native app integration for dynamic update on Android. If this feature flag is enabled, the GooglePayPaymentApp would enable a callback service and handle communications between the native GPay app and the browser for dynamic updates on shipping and payment data. Design doc is go/dynamic-update-mweb. Bug: 1074423 Change-Id: I898199446179d6c314b833c3ecb8f017481fc596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628745 Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#844274}
-
Joshua Peraza authored
Bug: 1163660 Change-Id: I272e8006207b917d8b58b67a783f81c919952c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622956 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844273}
-
Alex Newcomer authored
Files app copies raw images onto the clipboard by: 1. In JS, save files app metadata. 2. Later, on the chrome side, add raw image data by: - Reading step 1's data from Clipboard. - Add raw image data. - Write to clipboard a second time. In a way, files app uses the clipboard as a temp variable. This results in two entries to ClipboardHistory. Delete the old one, then allow the second Write to create a new entry in history. Bug: 1150155 Change-Id: I90649d9b56ebfc538ab962e4c769a869b9d5d082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630405Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844272}
-
Maggie Chen authored
In addition to the released version (stable) of Edge, now the versions from the insider channels (beta, dev, can) can be automated in the Intel power measurement script. This CL also adds support for command line switches for Edge. Bug: 867155 Change-Id: I021c3715b46213d12531a98a3eca52a03824a846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631157 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844271}
-
Andre Le authored
Add controller to show notification icons in large screen system tray button. This CL only contains code to add mocked icons view to the appropriate place. BUG=1161557 Change-Id: Ida03ee96ab891dfec069ae59e943baa3bcf90680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625728 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#844270}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/86e4bd2600ce..ff5c7857d90c 2021-01-15 janscheffler@chromium.org [JSDOC2TS]: Migrate cookie_table If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1c4da1c05b30741eb2a7e0bb9b24004e68b61782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633074Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844269}
-
Tom Sepez authored
Bug: 1166972 Change-Id: I258c25573d5900e8dae2d3f26bde5eeb200fd8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633964Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#844268}
-
Kaiyu Chen authored
This reverts commit 768c05c0. Reason for revert: Should add this GPayAppDynamicUpdate feature flag to components/ instead of chrome/ Original change's description: > Add GPayAppDynamicUpdate feature flag. > > The feature flag controls the GPay native app integration for dynamic update with web payments on Android. > The integration for dynamic update is mainly about adding callback service to notify the browser about changes like shipping address. > Design doc is go/dynamic-update-mweb. > > Bug: 1074423 > Change-Id: I608ca5ddd5aa28f2da5672da83eefd0128720992 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617201 > Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841632} TBR=sahel@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,kylechenkyc@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1074423 Change-Id: I4b80472636a4673e7e96414d4c54fc6555f37bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628490 Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844267}
-
John Abd-El-Malek authored
Change-Id: I7c3c32972b09c3b508015a5a12d8da8a022c2f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634123 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844266}
-
Xiaodan Zhu authored
The frequency of showing reverse scrolling toast is wrong when the continuous desks animation is enabled. This is because the functions DesksController::GetNext/PreviousDesk were modified to get the next/previous desk of the target active desk instead of the current active desk. This CL modifies the functions GetNext/PreviousDesk to make them can also return next/previous desks of currently active desk. Bug: 1166002 Change-Id: If45e6964bd5c3e382716d4695aa9b18a4ba593cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633875 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844265}
-
Anastasia Helfinstein authored
NOTRY=true Bug: None Change-Id: I90dd3a5f54a13d56b4e19667504ecba44d8f42ad AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633946 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#844264}
-
Yuly Novikov authored
Times out listing tests. Remove from the bot while investigating. Bug: 1167314 Change-Id: Idf85933ff83ef8a954e98ae2d403bb18d41b99b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633373Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#844263}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/071c3b1b313a..dabd9655278a 2021-01-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I895eb8ce2b3822225e3956617466a373359d243c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633075Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844262}
-
Sonny Sasaka authored
This fixes a bug where the error log is not printed when stop discovery fails in SecureChannel. Note: this reverts the changes in chromeos/services/secure_channel from CL:2068886. Bug: 1165598 Change-Id: I4959051c6f471b4d71ac96777f06bc484ffe6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626098 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#844261}
-
Yi Gu authored
This fixes an issue in crrev.com/c/2633342. TBR=tvanderlippe@chromium.org Bug: 1167158 Change-Id: I1855b3c2a20cd7d328b4cfcfb960be5e4773227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633370Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844260}
-
James Cook authored
Clean up some leftover logic from when we disabled lacros in M87 for non-google managed users. In particular, don't skip the policy check for developer builds with channel unknown. The LacrosAllowed pref defaults to true, so this doesn't affect developers who aren't working with policy. Bug: 1135494 Test: updated unit_tests Change-Id: I510ada8de5d266626ba8adef64a7dd33202574a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628592Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844259}
-
Klaus Weidner authored
This works around issues where using the screen keyboard (IME) during a WebXR AR session with DOM Overlay active left the compositor view in a confused state with SurfaceControl active. Keep SurfaceControl disabled for the duration of the session, and recreate the SurfaceManager at session exit. Bug: 1166248 Change-Id: I7f816ab0cfec40e316998c7c94ea6973d2d57826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631470Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#844258}
-
Josh Karlin authored
Renames most occurrences of 'blacklist' with 'blocklist' in safe_browsing. Bug: 1160252 Change-Id: I30cd41f0dd73187745f3f438ac283e3ce36a2586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597460 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844257}
-
Yue Zhang authored
This CL makes cart module scrollable by adding side scroll buttons to show previous/next items. The side scroll buttons will only be visible when the cart number goes beyond what we can show. Bug: 1160967 Change-Id: Ib06a3e89d8555a4194d38917f08dcec41994a0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612126 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844256}
-
Torne (Richard Coles) authored
Add the nonembedded WebView code to the 64-bit library, because even though it's not used when running on a "regular" 64-bit device, it's needed if the license viewer (or anything else in the future that needs to load native code in the nonembedded processes) is launched on a 64-bit-only device. Bug: 1167259 Change-Id: I3fd21db8943c4a9b7fb4be2ab9254eb71ea709dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627755Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844255}
-
Esmael El-Moslimany authored
When creating many new tabs, requestIdleCallback() seems to hang until there is a mouse action in the content area. This does not happen in the normal use case of opening a single new tab and interacting with it. Adding a timeout to requestIdleCallback() works around this issue. Bug: 1167047 Change-Id: Ic10d7f75f0be0c6ce9b34992df1a4dc09b9d0e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633068 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#844254}
-
arthursonzogni authored
This content/public method shouldn't be used, because this bypass most of the navigation code and will inherit the wrong security properties. It might be good enough for testing, and is currently used only as such. Appending ForTesting to make it clear. Context: I would like to push the sandbox flags from the browser process. There are some unit test running without a browser process and dummy flags will be provided. I need to convince this would be for testing only. Bug: 1151340,1041376 Change-Id: I4004711692713360a3f4517db9f4f3a2962e9c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631271 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844253}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aedd133cd85f..af4a3a998449 2021-01-15 amaiorano@google.com LLVMReactorDebugInfo: fix location filename always "<unknown>" on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib48932a61b9c23ccdd3f465b28a9e2d1a610ae1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844252}
-
Ali Juma authored
This CL disallows navigations to tel: URLs when the target frame is cross-origin with respect to the frame that is initiating the navigation. Change-Id: If2ce2d464065414513ed646e8611a919e5339f45 Bug: 1103119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627751Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#844251}
-
Dan Sanders authored
This CL adds VideoFrame.close() as an alias for VideoFrame.destroy(), adds a deprecation message for VideoFrame.destroy(), and changes all callsites to use close(). Bug: 1166930 Change-Id: I39b9c68262553a6814f6bb0b6b81c02012c2d026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631405 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#844250}
-
Alex Turner authored
This is a reland of db1fc486 Reason for reland: The previous changes that led to test flakiness have been removed, but the other changes are retained. A comment has been added to land the removed changes when the flakiness is fixed. Original change's description: > Reland "Finish base::Bind -> Once/Repeating migration for media/blink and /cdm" > > This is a reland of 878c8c7d > > Reason for reland: media_blink_unittests should no longer be flaky after > updating the condition in UpdateBackgroundVideoOptimzationState(). The > flakiness derived from CancelableOnceCallback/Closure::IsCancelled() > returning true after the callback is run. > > Original change's description: > > Finish base::Bind -> Once/Repeating migration for media/blink and /cdm > > > > Use of base::Bind, ::Callback, etc. is deprecated in favor of the more > > explicit Once/Repeating versions. Despite being marked as fixed, a few > > directories have some remaining uses that were missed in the conversion. > > This cl fixes those stragglers in the media/blink and media/cdm > > directories. The presubmit is also enabled for these directories to > > avoid any future regressions. > > > > Bug: 1141533, 1102651, 1007802 > > Change-Id: I0a58ba3165c1c8873a25de76065a7425495b62b1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505580 > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > > Commit-Queue: Alex Turner <alexmt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822344} > > Bug: 1141533 > Bug: 1102651 > Bug: 1007802 > Change-Id: Id1f87603ca9d41fe4fad91d6a7b389c889669fba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508930 > Commit-Queue: Alex Turner <alexmt@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838765} Bug: 1141533 Bug: 1102651 Bug: 1007802 Change-Id: I1d8aa13942b6aa563f0b2cc2ef76b91a5a335418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633367Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#844249}
-
evliu authored
This CL adds the Speech On-Device API (SODA) language pack components for de-DE, es-ES, fr-FR, and it-IT. The language pack components are implemented as separate components because users will be able to install any combination of language packs. Bug: 1161569 Change-Id: I98f1dc2416056c10ea1d7c528ec45bca07343f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602579 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#844248}
-