GitLab

This change updates the WebOTP API shape to the latest spec.
It adds the following changes.

1. Adds `code` field for the one-time-code
2. Updates `id` to be undefined for OTPCredentials
3. Updates OtpCredentials to be OTPCredentials

WebOTP Explainer: https://github.com/samuelgoto/WebOTP/blob/master/explainer.md

Bug: 1053594
Change-Id: I747446b2fffc8f00afef105db3a5bcb35b124890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068300Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745092}

This reverts commit 959b4db4.

Reason for revert: Failing consistently (2/2) since this change landed.
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17292
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17293

Failed with status TIMEOUT

Original change's description:
> [Kiosk] Fix flaky KioskTest.LaunchAppUserCancel
> 
> Sometimes network timer was timing out and we were going into
> network configure screen. This screen is orthogonal to the purpose of
> this test. Let's disable network handling in this test.
> 
> Bug: 964333
> Change-Id: Ic93568970b7af07f4703c9474868aaefabccf1cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075457
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745038}

TBR=rsorokin@chromium.org,apotapchuk@chromium.org

Change-Id: I39fa8e39a956c0780839eed42d4a43ca1264b3e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 964333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078999Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745091}

This adds helper functions for going from an SVGResource or
StyleSVGResource to the associated LayoutSVGResourceContainer type.
This reduces the amount of boilplate needed for this a little bit. These
types of access is expected to be little more common when the
SVGResources object has been phased out.

Add a special overload for ReferenceClipPathOperation that maps to a
LayoutSVGResourceClipper, and GetFilterResourceForSVG to capture the
current "single url(...)" restriction.

Bug: 1028063
Change-Id: I7d408a4d25d024162ace818a088b25be1205cedb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072218
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745090}

Bug: 1056575
Change-Id: I3df2c9af1ee19becf4164d06ad210e81f29a4fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078911Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745089}

Bug: 1056468
Change-Id: I03e3028246ef19c7d6dbc5547a10b8a438a1ea28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076790Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745088}

This CL is the clean up for Large splash icon for oneoff.

We already removed all usage of badge icon, so this CL removes
badge_icon related field in InstallableData and InstallableParams,
and also obsoletes BADGE_ICON_HASH_DIFFERS.

Bug: 1043271
Change-Id: I52a32a9dee9177dd911ffbc94e410010253a0acb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037820
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745087}

This reverts commit e3a03f83.

Reason for revert: Try to fix the compile failure.

Original change's description:
> Revert "Make tab strip auto scroll to position of the selected tab"
> 
> This reverts commit 7767aa96.
> 
> Reason for revert: suspect causing compile failure on android-archive-rel
> 
> Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9648
> 
> Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887341380366474896/+/steps/compile/0/stdout?format=raw
> ----
> ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
>         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(true);
>                           ^
>   symbol:   method setGridTabSwitcherEnabledForTesting(boolean)
>   location: class CachedFeatureFlags
> ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:71: error: cannot find symbol
>         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(true);
>                           ^
>   symbol:   method setTabGroupsAndroidEnabledForTesting(boolean)
>   location: class CachedFeatureFlags
> ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:83: error: cannot find symbol
>         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(null);
>                           ^
>   symbol:   method setGridTabSwitcherEnabledForTesting(<null>)
>   location: class CachedFeatureFlags
> ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:84: error: cannot find symbol
>         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(null);
>                           ^
>   symbol:   method setTabGroupsAndroidEnabledForTesting(<null>)
>   location: class CachedFeatureFlags
> 4 errors
> ----
> 
> Original change's description:
> > Make tab strip auto scroll to position of the selected tab
> > 
> > Currently, when a tab in group is selected or a new tab is created
> > within group, the tab strip doesn't scroll to the position of the
> > currently selected tab. This could lead to a state where user needs to
> > scroll by themselves to find their selected tab in strip. This CL fixes
> > this issue by making following changes:
> >   * Always scroll the strip to the last position when new tab is added
> >     in group.
> >   * When selected a tab in group (through tab grid dialog etc), try to
> >     scroll to a state where the selected tab is in the middle of the
> >     strip, if possible,
> > 
> > Bug: 1054079
> > Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888
> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#744892}
> 
> TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> 
> Change-Id: I8db970a5e6c2338ce19c8870964b96c48e66eb44
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1054079
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076219
> Reviewed-by: Takashi Sakamoto <tasak@google.com>
> Commit-Queue: Takashi Sakamoto <tasak@google.com>
> Cr-Commit-Position: refs/heads/master@{#744908}

TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org

Change-Id: If473ca1321615dd4d2972287274f53be6e0bb574
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078415
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745086}

This is a follow up of [1]. |web_request| made sense when instances
were of type WebUserMediaRequest.

[1] https://crrev.com/c/2064748

BUG=NONE
R=guidou@chromium.org

Change-Id: I0ea86f3219eae54211f56014529345ee7fea01aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078191
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745085}

In-session password change success detection mechanism is based on
IdP-dependent heuristics. Small differences are possible even within a
single IdP which may lead to improper detection of successful password
change and left it unsynced between a chromebook and IdP.

This CL extends success scenarios for Ping IdP. The problem was detected
in customer installation and verified with a test account.


Bug: 1056602
Change-Id: I6a83c7e3e9eb070cd1677afe181db395b4593420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078451Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maciek Slusarczyk <mslus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745084}

This callback is repeating because it is used as part of a handler for an event,
which can fire repeatedly:
* https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_transport_ipc.cc?sq=package:chromium&dr&g=0&l=135

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: Ic2ef406352713bf023bfa476688c9c7a89e5a2df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071894
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Auto-Submit: Jose Lopes <jabolopes@google.com>
Cr-Commit-Position: refs/heads/master@{#745083}

https://webrtc.googlesource.com/src.git/+log/40b764a6ba45..eed48b86ed9c

git log 40b764a6ba45..eed48b86ed9c --date=short --first-parent --format='%ad %ae %s'
2020-02-27 srte@webrtc.org Disable PeerScenarioQualityTest.PsnrIsCollected on windows.
2020-02-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7c2b6c4e..4f8e062e (744850:744969)

Created with:
  gclient setdep -r src/third_party/webrtc@eed48b86ed9c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ia170b44b8bdda16ccef73b7f387403d46508ed92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078300Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745082}

Removes the remaining overrides (which are just tests inside Views) and marks
the method not virtual. It should probably be renamed to something like just
'buttons()' at some point.

Bug: 1011446
Change-Id: I8affaf1e80d7f0c2c8245edcd419f3dab14d9472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075078
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745081}

This CL re-enables StatusBarColorControllerTest on phones only. The
test does not apply to tablets where the status bar is always black

BUG=1056196

Change-Id: Ie8a06eeb272ab17a36eeb28668320ffdd1592425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075976Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745080}

Remove definition from WebWidgetClient because it is used in various
classes that have no concept of the WebWidgetClient.

Stop including web_widget_client.h inside chrome_client.h

Change-Id: I14f6fa28c87054cd1004e078c828a24b817c50f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078592
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745079}

Makes the drag/drop input events ignore the "ignore events" flag on
WebContents.

Bug: 1045015
Change-Id: Ia0ba24dac83f0e83a78b8ba000fcc9806090c77d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078654
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745078}

This patch adds the authentication flow required to sign-in or sign-out
a user account following a click on one of the "Turn on Sync?" buttons.

This CL is part of a series of refactors to move the existing sign-in
architecture to the Coordinator-Mediator design paradigm.

Fore more information, see go/chrome-ios-signin-migration.

Bug: 971989
Change-Id: Id9e38721b4343929d23f7861b5b5199a5dfb6a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059414
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745077}

The bug was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2032427
and code was moved to here by https://chromium-review.googlesource.com/c/chromium/src/+/2063037

Bug: 1053790
Change-Id: I683351902f635ba329c14ccaec87540c36758cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075418Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745076}

This moves logic from ToolbarManager into a Coordinator, Mediator, and
ViewBinder that are hooked up to the existing progress view, and adds
unit tests for the new mediator.
This change shouldn't affect visible behavior.

Bug: 865801
Change-Id: I24e121aec7be79535b67d8c5b647327c0e8ba99c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001264Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745075}

https://chromium.googlesource.com/angle/angle.git/+log/201bb086c442..f0d32401cf06

git log 201bb086c442..f0d32401cf06 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 cclao@google.com Vulkan: Optimize element buffer conversion

Created with:
  gclient setdep -r src/third_party/angle@f0d32401cf06

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: Ib2ee8280ff6a99ac2e62abb99d14bebf0620617e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078297Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745074}

Normally we don't whitelist files for determinism, but nacl's on the
way out.

Bug: 1040247
Change-Id: I27fb62f05903532c128e8feeca252eb5e9e887e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078773
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745073}

https://skia.googlesource.com/skia.git/+log/66adad7d3726..289ecf8b9b71

git log 66adad7d3726..289ecf8b9b71 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 westont@google.com Update Go Deps
2020-02-27 bsalomon@google.com Remove cheap/any texture distinction from SkImageGenerator.

Created with:
  gclient setdep -r src/third_party/skia@289ecf8b9b71

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I6d02fcfac33da8a5f56ca7df3e4f5746129356c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078296Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745072}

Patch #3: Unify flag control for the minimal UI feature.

Before this patch, chrome://flags/#enable-web-payments-minimal-ui
controlled whether the minimal UI could be displayed,
while chrome://flags/#enable-experimental-web-platform-features
controlled whether the respondWithMinimalUI() API was available in
Blink.

After this patch, both UI display and availability of the feature in
Blink is controlled by the single flag
chrome://flags/#enable-web-payments-minimal-ui.

Bug: 1005076
Change-Id: I43c449b0ca14c97ccadcd25da8261119d261d80f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075479
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745071}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/235fe2c3aa10..6165cdcbe8fa

git log 235fe2c3aa10..6165cdcbe8fa --date=short --first-parent --format='%ad %ae %s'
2020-02-27 vapier@chromium.org scripts: convert random standalone programs to python3 only
2020-02-27 jiyounha@google.com arc: Increase timeout even more for master-pi-android-pfq.
2020-02-27 vapier@chromium.org image_test: fix bytes processing
2020-02-27 saklein@chromium.org flash-ap: initial `cros flash-ap` support.
2020-02-27 vapier@chromium.org cros_test/cros_vm: convert to python3 only
2020-02-26 chrome-bot@chromium.org Update config settings by config-updater.
2020-02-26 mmortensen@google.com Support multiple -s arguments in contrib/query_build_logs.
2020-02-26 vapier@chromium.org cbuildbot_launch: switch to python3 only [reland]
2020-02-26 saklein@chromium.org cli/command: Make device argument named by default.

Created with:
  gclient setdep -r src/third_party/chromite@6165cdcbe8fa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I7121d005ee41afbc032a1217ee4f185317645ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078299Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745070}

Fixes this error:
ld.lld: error: undefined symbol: __cxa_thread_atexit

BUG=1047860
R=thakis

Change-Id: I0fc3ddd44b68fcdcc594a3bdc398a6b2924ac15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075840
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745069}

This CL adds checkbox to animation tests inside WebView system shell
that enables external stencil by adding rounded corners clip path to
WebView.

Bug: 956709

Change-Id: Ia918bf2fa6af522bdda90d559eddf24c48172dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075970
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745068}

This CL starts the componentization of URLUtilities.java and its native
counterpart in order for sharing with WebLayer (specifically, this code
is used by //chrome's launching of external intents). As this class is
used internally we structure the componentization as a 3-sided patch:
this patch just copies the existing //chrome code and deprecates the
//chrome code, while a followup will remove the //chrome code once the
internal code has been ported.

An immediate followup CL will componentize ShadowUrlUtilities.java.

TBR=mmenke@chromium.org

Bug: 1031465
Change-Id: I73d29744808a33e86b277f2d88c19e76f18ff10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077681
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745067}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/36f7f246a827..572d6abf7f22

$ git log 36f7f246a..572d6abf7 --date=short --no-merges --format='%ad %ae %s'
2020-02-26 junyer Don't break the RE2 object when compiling the reverse Prog fails.

Created with:
  roll-dep src/third_party/re2/src

R=mmoroz@chromium.org

Change-Id: I582e0c47696cf5d156cc93a5b2e6b43c83a0c3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077588Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745066}

Follow up change to make PaintPreviewBaseService use DirectoryKey for
accessing protos. Also move the access methods to FileManager.


Bug: 1055505
Change-Id: I322998cbd5d7d6d78d9aa541ac81a8f292059235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075043
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745065}

A trace is uploaded via "slow reports" when a long input delay
is detected (for opted-in clients). This trace event will make
it easier to identify the location of the long input delay when
analyzing the trace.

Bug: 1055890
Change-Id: Iba0e818b9c1a245da0099f44cc1224c437c8df97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072665
Commit-Queue: Hailey Wang <haileywang@google.com>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745064}

When the passthrough command decoder is destroyed, the callback needs
to be un-registered from ANGLE. That way if the ANGLE context is used
elsewhere, it won't dereferences an invalid pointer.

Bug: chromium:1048205
Change-Id: Icf1b9969fa2bbc53d449e1b73ef66853303e94c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055423Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#745063}

TraceAfterDispatch is used avoid adding vtables to types. Instead a
flag in the object is used to choose the right Trace method. This CL
changes all the non-const flags used for dispatching to const.

Change-Id: I29b1817b56808360c27b31dd41b98c5ae5ece1a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078533Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745062}

If the webstate is nil or if it's not the active webstate, then
it is likely that the BadgeTabHelper is not valid, so return early.

This change also ensures that all InfobarCoordinator blocks
use weakSelf in calls of InfobarContainerMediator

Fixed: 1055908
Change-Id: Ic68ee9950ce928f1143981425cbac934057bbe64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075300
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745061}

Bug: 1032561
Change-Id: I77d1aeba69c58c88d19fb9a239f2ec4b912539ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077739Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745060}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bc110cba..f4467316

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6a83693816b373441924e03290f5fa694c4741d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078551Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745059}

Removed remaining use of global NativeTheme accessor from profile
menu and added color update capability on theme change.

Fixed spacing on HoverButtons taking image views for consistency with
other constructors.

Bug: None
Change-Id: I717a45fb068a3bd35b992797e38e729da1cd3521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072998
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745058}

Missed removing arguments from iOS' WPR test runner constructor

Bug: 1055330
Change-Id: I21faef3071ce28a0d3c7e4f3e51c20d987b3af4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076764Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745057}

This reverts commit 0e5a5146.

Reason for revert: Fixed errors in AppLaunchController. Time refactor all of this.

Original change's description:
> Revert "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably"
>
> This reverts commit cdce07c9.
>
> Reason for revert: KioskTest.LaunchAppWithNetworkConfigAccelerator has been failing on msan fairly consistently since this landed:
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17653
>
> Original change's description:
> > [Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably
> >
> > This handler was little bit overcomplicated. This led to a bug in web
> > kiosk mode when we update network state, but do not update the handler.
> >
> > Because of this convolution, in web kiosks, the network configure
> > screen did not update itself when connected to network(which is what
> > client will expect from the handler which observes network state).
> > Now it behaves more logically and predictably.
> >
> > Bug: 1015383
> > Change-Id: I78b024b1d51b54b0d01d0a5a5694f6ae3f5ac19e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031406
> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#739128}
>
> TBR=xiyuan@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1015383
> Change-Id: Ibc08de19048d9c8af95c3f517b748d09e37c7597
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045479
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739735}

TBR=xiyuan@chromium.org,thakis@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1015383
Change-Id: Ie77ba40fa6bf3bc94a22c97a8d2b0764ef0614d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047225Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745056}

While checking an unrelated piece, I found the element_finder to still
be very confusing. This should CL should clean it up and make it a bit
more understandable.

It also fixes a minor bug, where the container_frame_selector_index was
not correctly set for OOPIF.

Bug: none
Change-Id: I49965dcbc5378a0f73812489b68790b5db9f888f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072386Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#745055}

This reverts commit 77288e6f.

Reason for revert: All/DeclarativeNetRequestBrowserTest.AllowAllRequests_SrcDoc/0 is
consistently failing, and this change touches that test and is in the
blamelist, so I expect reverting it will be the fix. First failing build:
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44692

Original change's description:
> DNR: Speculatively fix flaky DeclarativeNetRequestBrowserTest.AllowAllRequests_SrcDoc.
> 
> Wait for the fetch to complete before checking whether xhr request was
> seen by the browser. This should hopefully fix the flakiness since page
> load won't necessarily wait for the fetch to complete.
> 
> BUG=1050536, 1056031
> 
> Change-Id: I9c043d69c4d619e00737303d2aaa3c15dc587ae2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076658
> Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744926}

TBR=lazyboy@chromium.org,karandeepb@chromium.org

Change-Id: I032be2858ed91613891949a5540a8875b56d5d04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1050536, 1056031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078595Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745054}

This reverts commit a9df7cc8.

Reason for revert: Seems to be causing compile failures on multiple builders:
[2431/2474] CXX obj/chromeos/services/assistant/audio_decoder/lib/ipc_data_source.o
FAILED: obj/chromeos/services/assistant/audio_decoder/lib/ipc_data_source.o
../../build/cros_cache/chrome-sdk/symlinks/eve+12933.0.0+target_toolchain/bin/x86_64-cros-linux-gnu-...(too long)
In file included from ../../chromeos/services/assistant/audio_decoder/ipc_data_source.cc:5:
../../chromeos/services/assistant/audio_decoder/ipc_data_source.h:37:37: error: non-virtual member function marked 'override' hides virtual member function
const ReadCB& callback) override;
^

Original change's description:
> media: Migrate DataSource::ReadCB to once callback.
> 
> This callback is used to signal completion of the read operation,
> therefore, it's a once callback:
> * https://cs.chromium.org/chromium/src/media/base/data_source.h?rcl=6e8610f8f31aa3bb8266660380a66c6c25b2e64a&l=27
> 
> This is part of the base::Callback migration.
> 
> Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40
> 
> Bug: 714018
> Change-Id: Ie43febda1247be065f9f22cc4aec0d8412873491
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056729
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: Jose Lopes <jabolopes@google.com>
> Cr-Commit-Position: refs/heads/master@{#745018}

TBR=danakj@chromium.org,xhwang@chromium.org,treib@chromium.org,jabolopes@google.com

Change-Id: I29a9ef7f049320a36dcd52212b7f5ac80e6fc02b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 714018,1056660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078593Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745053}