- 26 Apr, 2019 40 commits
-
-
Nicolas Ouellet-payeur authored
Bug: 957003 Change-Id: I60f2c62d75dfc2a7d1b86f5b9880151d5d11c78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585465Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#654474}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/419c9cd57073..75c4cbfa717a Created with: gclient setdep -r src-internal@75c4cbfa717a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I10b65df10fdb516c26b0dd3f695e74e1bada10c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585921Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654473}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eb37b1394300..e670fd97951a git log eb37b1394300..e670fd97951a --date=short --no-merges --format='%ad %ae %s' 2019-04-26 srte@webrtc.org Adds getter for FieldTrialParameter keys. Created with: gclient setdep -r src/third_party/webrtc@e670fd97951a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie183d7aaf9756d506940118a1c822303f1b7938b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654472}
-
Jan Krcal authored
This reverts commit 948191bb. Reason for revert: introduces flakiness in integration tests Original change's description: > [AF Wallet] Ignore remote metadata deletions in USS sync > > This CL changes behavior of the wallet_metadata sync bridge to ignore > remote deletions. This is safe as every deletion should be eventually > processed locally and for corner cases there is anyway already a GC > routine. > > This is motivated by observed ping-pongs of deletions-creations between > clients running Directory code and clients running USS code, leading > to considerably increased number of address conversions on USS. This > CL breaks these ping-pongs and should get the conversion counts on > comparable levels. > > Bug: 953693 > Change-Id: I1a30f51d4727a08f84ef33091089d2a7a366b4df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583896 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654413} TBR=jkrcal@chromium.org,mastiz@chromium.org Change-Id: Ia8afa93aa834101d154e1a1a3db3996f686d1786 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583711Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#654471}
-
Saman Sami authored
We already do this in PixelsMatchReference() but that only applies to references that are stored in a file. Do something similar for the other variation of RunPixelTest where the reference is stored in memory. Bug: 939442 Change-Id: If71be3a9fa1d701711740dc11d341c57f56cbcfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585546Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#654470}
-
Jérôme Lebel authored
The footer view for SectionIdentifierWebServices section only exists when Unified consent flag is off. Bug: 957025 Change-Id: Ia24835365878169abe0db58a49fb4f9073b997e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584277Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#654469}
-
John Abd-El-Malek authored
Bug: b/130750620 Change-Id: Ibc476c617578abbc73d9cdfebaac84e07617e46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579422Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#654468}
-
Justin Cohen authored
Bug: 845992 Change-Id: I48a17d1c9749a8fa56b155b48d2ae923245ecacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529951 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#654467}
-
Evan Stade authored
Newly implemented: Observer::SuspendDone() Bug: 644348 Change-Id: I2fd3057e839c8580608f8e934627d2652ed54b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584393Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#654466}
-
Evan Stade authored
Newly implemented: RequestRestart() Bug: 644348 Change-Id: Ia3aab1d6acbc5dc817d72b7a8eb5641a6dce10ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584365Reviewed-by:
-
Evan Stade authored
The old API returned a callback which encoded the identifier for the client's block-suspend request. The new API takes and uses an UnguessableToken as the identifier for the request. There should be no functional change. The new API will be easier to implement in the Mojo client. TBR=shik@chromium.org Bug: 644348 Change-Id: I395f7746ad7075d1a994d4a08ebaaf267da1782a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575777Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#654464}
-
Huanzhong Huang authored
Currently Clear Browsing Data contains the following chain of actions: Cell selection -> Update on the browser state -> Browsing Data Counter restarted -> Cell reloaded (instead of reconfigured) to accommodate latest data counting result -> Cell selection state cleared due to reload -> Cell needs to be reselected to compensate These actions form a cycle and thus are the cause of responses to tapping being laggy. This change fixes the issue essentially through breaking the chain at the first step. Bug: 957013 Change-Id: Ibf25fde3845378640856ab158cf0e37339ec7f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584506Reviewed-by:
-
Tommy Martino authored
This CL represents a big chunk of the work towards generalizing the Password-specific structures to also handle manual filling of Credit Cards (and, later, Profiles). Specifically, it introduces a new parent class, AccessoryController, which fills the role originally called "AccessoryItemTranslator" in our design doc. This class handles the translation of domain-specific data types (e.g., AutofillProfile) into UserInfo that can be sent along to the filling UI. It took on some a slightly larger role than was previously planned, because after digging around in this code, it felt like knowing how to translate a T into a UserInfo and knowing how to route a selection event to the appropriate manager were functionally similar. This is only the first step towards that structure; there are other chunks of code I can generalize further, but I wanted to keep the scope somewhat manageable. My goal is that, ideally, once this work is done, we can simply implement a class that extends AccessoryController<CreditCard> or AccessoryController<AutofillProfile>, and require only trivial changes to the ManualFillingControllerImpl to get that data through to the UI. Bug: 902425 Change-Id: I104afad234114be034c791b53c2cfad693a91554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519091Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#654462}
-
Tibor Goldschwendt authored
Bug: 925126 Change-Id: I155fd5ad81729aa01de476e073115a3246a0ca99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547706 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#654461}
-
Samuel Huang authored
Previously SuperSize failed for desktop Chrome, because the linker .map generated when CFI is enabled (desktop only) has many Level 3 entries with sizes are equal to the containing Level 2 entries. But these entries have advancing addresses, so overflow occurs, and the ensuing negative gaps size triggers assert failure. This CL implements CFI support for SuperSize to fix the issue. Details: * linker_map_parser.py: * Detect (Level 2) .L.cfi.jumptable entries, and extract them as Level 2 symbol "** CFI jump table". * This sidesteps the above overflow problem -- this appears only for .L.cfi.jumptable entries. * Collected and print various stats in verbose mode. * Note: Level 3 details in .L.cfi.jumptable are discarded (~64k symbols). * Process CFI's __typeid_*_type_array: These are Level 3 entries that have size = 1: So we use |span| explicitly. * All other __typeid_ entries are found to be suppressed by the |next_usable_address| mechanism: Print warnings if found. * archive.py: * _AssignNmAliasPathsAndCreatePathAliases(): Suppress "Symbol not found" warnings for __typeid_ symbols to reduce noise. * _AddNmAliases(): Add special case to skip "** CFI jump table" symbols (can't skip all "*" symbols though; we still want e.g., "** outlined functions"). * Add LinkerMapParserTest.test_ParserCfi() to handle only the new CFI-related cases. There is no change in SuperSize results for ChromePublicApk.apk generated without CFI (currently the default). Bug: 947114 Change-Id: Iaa0b7c8a779bddbd899afb88b246b978f0c41cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579461 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#654460}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b68af7ca8e02..2de3e3c02f29 git log b68af7ca8e02..2de3e3c02f29 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 462213+sl1pkn07@users.noreply.github.com Add spirv-lesspipe.sh into SPIRV_SKIP_EXECUTABLES umbrella (https://github.com/KhronosGroup/SPIRV-Tools/issues/2497) (#2504) 2019-04-26 stevenperron@google.com Fix spirv-headers link in the README. (#2516) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2de3e3c02f29 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org,geofflang@chromium.org Change-Id: Ib47941c0084bb86bf1602e7b1c4ab1ac0ccadd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585813Reviewed-by:
-
Benoit L authored
This reverts commit e7d3094b. Reason for revert: Bot ran once, let's go back to the newer orderfile pipeline. Original change's description: > cygprofile: Temporarily re-enable legacy orderfile. > > Now that we have memory and performance measurements in the orderfile generation > pipeline, re-enable the legacy one temporarily to compare its impact vs the > current system health based one. > > Bug: 956960 > Change-Id: I8a01ce89e58f694ce546c73479333ae8919b627a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584285 > Commit-Queue: Egor Pasko <pasko@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654395} TBR=pasko@chromium.org,lizeb@chromium.org,msalama@google.com Change-Id: I77711f619546a833a433bfd8fc6841537290668f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584289Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#654458}
-
Philip Rogers authored
the common case in LayerImpl::bounds. gfx: :ToCeiledVector2d is hot on profiles and can be skipped entirely in Change-Id: I36ece29ac44b8ae6f2ba0a47382e9d1132890a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557074Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#654457}
-
Jan Krcal authored
This CL introduces an additional waiting in a test to avoid flakiness. Bug: 956043 Change-Id: Ibef2e32fbb6a82350137cb506519dd8fcc5b84e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583734 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#654456}
-
Juan Antonio Navarro Perez authored
Data is now coming from new bot in the main waterfall. Also take the chance to fix typo in cloud storage bucket name. Bug: 943601 Change-Id: Ia825557783afe878db0ad95637c7bf57ee2d09b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584309 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#654455}
-
Jan Krcal authored
This CL fixes flaky tests by using a more careful initial setup procedure that avoids race conditions. Bug: 956043 Change-Id: I606f198c6783a450086cdea166875408bdf1fc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584274 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Daniel Bratell authored
chrome/browser/previews have two distinct (but similar) RemoveStaleEntries functions and in some extreme jumbo builds they compile in the same translation unit and clash. This CL renames them RemoveStaleBlacklistEntries and RemoveStaleOfflinePageEntries. Bug: 914577 Change-Id: I69a837393d0586194bcd85f66eadfe85522418e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584261 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#654453}
-
Lily Chen authored
This CL implements the interface between NetworkErrorLoggingServiceImpl and its PersistentNELStore. If a store is provided upon construction, The NetworkErrorLoggingService will attempt to load all NEL policies from the store on the first call to OnHeader(), OnRequest(), QueueSignedExchangeReport(), RemoveBrowsingData(), or RemoveAllBrowsingData(). Until the store notifies us that it is done loading, calls to those public methods will be queued in a backlog to be run in order upon completion of loading. Any changes to the NEL policies stored in memory will be reflected in the PersistentNELStore. Bug: 895821 Change-Id: Ib9a18a2b6c73641ee0a3d2f7b119b4c710c4db5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555242 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#654452}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/152ac9be2f84..d3aeecd01069 git log 152ac9be2f84..d3aeecd01069 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 michaelludwig@google.com Visualize geometry domains in degenerate quad sample Created with: gclient setdep -r src/third_party/skia@d3aeecd01069 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I6ca0842544d91aabda37fc32df2a094e94eba89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585919Reviewed-by:
-
Jan Krcal authored
This CL fixes a few flaky tests for theme sync by using a more careful process for initial sync setup. Bug: 956043 Change-Id: Id0d92c87af973fc5ba62e3e4dee29fcf5d1fdf2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583706Reviewed-by:
-
Liquan(Max) Gu authored
The text side of FCP++ should update the candidate when any node is removed in the same frame, in the same style as the image side. Before, we didn't update candidate on node removal unless the node is the last detached node. We shouldn't special case this. Instead, everytime a node is removed we should update the candidate. Bug: 948119 Change-Id: Ia4075be5148168c47222f31d775bfa07436c0d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579248 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#654449}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/42fa30fdac9a..eb37b1394300 git log 42fa30fdac9a..eb37b1394300 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 peah@webrtc.org Add peah to more audio watchlists 2019-04-26 philipel@webrtc.org Use CodecBufferUsage to determine dependencies. 2019-04-26 solenberg@webrtc.org Reduce watchlist spam for myself. 2019-04-26 peah@webrtc.org Allow setting the AGC2 fixed gain during runtime 2019-04-26 henrik.lundin@webrtc.org NetEq: Create an audio interruption metric Created with: gclient setdep -r src/third_party/webrtc@eb37b1394300 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5195ff21c68039859537c4395d55f90becbf9dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585816Reviewed-by:
-
Oskar Sundbom authored
Speculative fix for what looks like a race during CoreAudio initialization. The device enumerator created to ensure for CoreAudio availability is leaked rather than destroyed immediately after construction. Bug: 955434 Change-Id: Ifa70350691448ec6ba57c9eb2b93106aa8edf65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584276Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654447}
-
Daniel Cheng authored
Bug: 841899 Change-Id: I5e66901262c7ccfe5bbedd67203572c55d53b881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584591 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#654446}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/809c46b7808b..419c9cd57073 Created with: gclient setdep -r src-internal@419c9cd57073 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: Idf30619edeed4f6848ae4cd01303d19e5415b13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585817Reviewed-by:
-
Liquan(Max) Gu authored
In this CL we explicitly exclude body from being captured as a background image. Before, we assumed that the background image would automatically be transferred to the layout view. But that's not the case in some examples, as found by the attached bug. Bug: 952828 Change-Id: I8f1c97e924ae14e61ac39d7d86af801a93f2863b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579253 Auto-Submit: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Michael Lippautz authored
- Slots and references are on-heap these days as Persistent heap collections are gone for quite some time now. Remove off-heap logic and add CHECKs for on-heap at the very beginning. - DCHECK->CHECK until compaction has been stabilized for incremental marking. - Add liveness checks for slot and reference. - Inline AddInteriorFixup helper method that cannot be called stand-alone. Bug: 918064 Change-Id: Ia343f67b3a715c954bccbf3bf939f39875b5e22e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584302 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#654443}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I0c2c3add660f0ae4373bca1844d2730ba184b5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580989 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Bruno Santos authored
Following advice in https://crrev.com/c/1570426 Bug: 927809 Change-Id: I377ef29160228abc1a4242156974c8de926d9fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584874Reviewed-by:
Lucas Tenório <ltenorio@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#654441}
-
Sahel Sharify authored
This cl adds IconSizeCalculator helper class so that payment icon related files uses this class for the ideal icon size. Bug: 879741 Change-Id: I0f3a912c98e7c4d605c2b8e88203cf4ce5573278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574687Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#654440}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib1d75e52f326a6e23cd42a5eee812fb02ef7579f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585818Reviewed-by:
-
Dave Tapuska authored
There already was a pass expectation for the non-worker case but it appears we need one for the worker case in order to land the V8 change. BUG=948678 Change-Id: I6c670b52e93e4de4449835b31bc4d336f58140b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585814Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#654438}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2fca490a57e7c7dd2a45372afa05e5600f48e3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585812Reviewed-by:
-
Miyoung Shin authored
This is a followup CL of https://crrev.com/c/1575315. This CL uses bit_cast<float> to convert FloatSize's width/height for Hash similar to WTF::FloatHash and WTF::FloatHashTraits. Bug: 952716 Change-Id: Ibafa38c9f1481472066c5a556297ee2d630e1e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585286Reviewed-by:
-
Dan Zhang authored
R=rch@chromium.org Change-Id: I345efbb9d5ba4ba21eb50433b6d579307dffbb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568848 Commit-Queue: Dan Zhang <danzh@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#654435}
-
