GitLab

This cl adds new metrics for GSU events that are generated from a
touchscreen fling progress. We want to keep the latency of these GSUs
separate from GSU events generated from touch move events since the
latency for handling the GSU events from fling doesn't include the time
needed for handling a touch event.

Bug: 249063
Test: RenderWidgetHostLatencyTrackerTest.TestInertialToScrollHistograms
Change-Id: Iba4664d19e5218cae4886ee543b709d4c2152fa4
Reviewed-on: https://chromium-review.googlesource.com/1062806Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561525}

This CL switches the v8.browsing_* benchmarks to the histogram pipeline.

NOTRY=true

Bug: 744736
Change-Id: Ied3d2bc472251e875e45b2d932d2951ff1cba06b
Reviewed-on: https://chromium-review.googlesource.com/1048849
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561524}

This is a new name that seems to alias the existing Turkish layout.

Bug: 845389
Change-Id: Ie7cfb42589644ff410f044d1420fbeb196de2289
Reviewed-on: https://chromium-review.googlesource.com/1071727Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561523}

This code does not have tests and is likely unnecessary.

HandleActiveDecendant is called on the item with @aria-activedescendant,
therefore to invalidate something, followingthe forward relation is
correct. Using the reverse relation would make sense if something was
pointing at the element with @aria-activedescendant that needed
updating.

TBR=nektar@chromium.org
NOTRY=true

Bug: None
Change-Id: Ifc2e3d71a2089e5fbeb58c1bc6e020811ad9b1d6
Reviewed-on: https://chromium-review.googlesource.com/1070806
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561522}

This is needed as KeyEvents are sent directly to the focused window, where as
LocatedEvents consider the WindowTargeter of each window.

BUG=837692
TEST=covered by tests

Change-Id: I935aaa1aaea6a8ea0339e99cc076ee7d459d9034
Reviewed-on: https://chromium-review.googlesource.com/1070857
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561521}

Bug: 846337
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5820f2715e41f9e13430a939a9d61cdca921bb70
Reviewed-on: https://chromium-review.googlesource.com/1071692Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561520}

Bug: 766909
Change-Id: Idd0cbfc8755ee7d0d26d77b6c534ceddc9422bde
Reviewed-on: https://chromium-review.googlesource.com/1067610Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561519}

Currently tests that check that a RFH tried to commit in unit tests used
MockRenderProcessHost::did_frame_commit_navigation(). This was set by
intercepting the interface commit using
TestRenderFrameHost::NavigationInterceptor. This is problematic because in the
future the RFH will not be the one holding the interface directly, making it
harder to use this mechanism. Instead, we just check that the RFH has a
navigation request, which is equivalent to it trying to commit.

We also remove TestRenderFrameHost::pending_commit() that was never used and
now redundant.

Bug: 784904
Change-Id: I7ea3c1410d70f9e164ea700a257e167d6ce3ae8c
Reviewed-on: https://chromium-review.googlesource.com/1071608Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561518}

ConnectionMedium represents the medium through which a connection is
made, which currently only includes BLE, but will eventually include
GCM. ConnectionDetails represents a type of connection to a given
device, and includes the device's ID and the ConnectionMedium.

ConnectionDetails will be used to track which connections over which
mediums are active or pending at any given time.

This CL also integrates ConnectionDetail into two classes,
ConnectionAttempt and MultiplexedChannel, in place of the IDs that they
were previously using. The reason for this change is that clients of
these classes need to categorize them via their ConnectionDetails. If
we had stayed with an ID instead, these classes would then have to keep
an extra map from ID to ConnectionDetails. This change eliminates this
extra complexity in those client classes.

Bug: 824568, 752273
Change-Id: Ia3532048c2df7c6a39cb231d21656774bc9263ab
Reviewed-on: https://chromium-review.googlesource.com/1070710
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561517}

- DXVAVideoDecodeAccelerator's constructor is changed to take a MediaLog
  pointer.
- Added logs to check whether it is taking the D3D9 or D3D11 path.

Test: Verified that the logs show up in media-internals when using MojoVideoDecoder.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8894b48594ca4026195b42935f7947331effa29b
Reviewed-on: https://chromium-review.googlesource.com/1070755Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561516}

Two suites are Cocoa-only so they are marked as such.

PopupBlockerBrowserTest has one broken test because of a known bug; the part of
the test that fails is now skipped in Views mode on Mac.

TBR=sky@chromium.org

Bug: 845389,846329
Change-Id: I5643899196401bec3af23e5edcd28c1c865dbfaf
Reviewed-on: https://chromium-review.googlesource.com/1071730
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561515}

Fundamentally, change MULTI_VALUE_TYPE to FEATURE_VALUE_TYPE for the
tab switch suggestions flag, since we don't need the 'button' option
any more. Should be functionally equivalent.

Bug: 780835
Change-Id: I56f2d20a577b0755935a5d3de6e9ae6f5c6ba8d9
Reviewed-on: https://chromium-review.googlesource.com/1069805
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561514}

If enabled:
>Removes NTP Button from toolbar when on NTP
>Tapping NTP Button leads to NTP

Bug: 843639
Change-Id: I5023097f316f1548acef860225d1d7f863d85102
Reviewed-on: https://chromium-review.googlesource.com/1069212
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561513}

WebContentsObserver is in the 'content' namespace, not in the global.
This causes a collision with a 'using' directive for the same class,
which breaks Jumbo builds.

TBR=avi@chromium.org,siggi@chromium.org

Bug: 755840, 846328
Change-Id: I977106611b374c955bf3c5c161c8a52eea927698
Reviewed-on: https://chromium-review.googlesource.com/1071663Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#561512}

Adds and uses new button icons for the location bar's trailing button.

Bug: 821804
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icf1ca41bb65610940545dee1e94a7e16ca33895f
Reviewed-on: https://chromium-review.googlesource.com/1069356Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561511}

Bug: 846302
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I959a7b1657531d7170a35df69dd38d210122ea1d
Reviewed-on: https://chromium-review.googlesource.com/1071661
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561510}

- Add H264Parser::GetCurrentSubsamples to get the subsamples entries
  for the current NALU.

Bug: 836557
Change-Id: I18ed7c0bb0f9706a1e5f66d4406c4321e284a363
Reviewed-on: https://chromium-review.googlesource.com/1033500
Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561509}

Some code was still using the cc namespace in the viz component.
This CL fixes that. No change to logic.

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I534da76538feb6855aab008965e82d056583eaa4
Reviewed-on: https://chromium-review.googlesource.com/1070167
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561508}

Nullcheck |window_->GetHost()| to avoid crashes in
RenderWidgetHostViewAura::GetRootFrameSinkId().

Bug: 844447
Change-Id: Ic8d6df563a60be5463f1a90c3386f0f2360f49c4
Reviewed-on: https://chromium-review.googlesource.com/1071276Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561507}

This CL sets up the test class for the download infobar controller and
adds a few tests. More extensive tests will be added in the subsequent CLs.

Bug: 845730
Change-Id: I41e64887bd2da1330743ec4a32cdd08766bccb90
Reviewed-on: https://chromium-review.googlesource.com/1069787
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561506}

This is a top-level GitHub magic file for setting owners of code, which
isn't useful to us in Chromium. And it seems to cause weird presubmit
errors, so let's skip it.

TBR=foolip

No-Try: True
Change-Id: I0f67ce81c62ac787eed2eda01f456eaa3166e981
Reviewed-on: https://chromium-review.googlesource.com/1071721
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561505}

I have an APNG with an embedded complex (A2B) profile that previously
rendered as garbage, and now renders correctly.

Bug: chromium:845931
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia592323db44fba12b45e158fd6b1f3025ed17953
Reviewed-on: https://chromium-review.googlesource.com/1069614Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#561504}

Some PasswordManagerBrowserTestWithConditionalPopupViews are flaky. An additional check may help to detect the problem earlier in the test flow.

Bug: 355145
Change-Id: Id0927d943d345b1c9a1d301fee6ee6f352719a52
Reviewed-on: https://chromium-review.googlesource.com/1071668Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561503}

Move ScreenForShutdown cleanup from AshTestBase to AshTestHelper. This
makes sure it gets cleaned up after tests that don't use AshTestBase,
such as BrowserWithTestWindowTest.

This eliminates ~10 flakes from chrome's unit_tests suite, for
example the screen_ash.cc DCHECKS in this run:
https://chromium-swarm.appspot.com/task?id=3da674dacfa3c110&refresh=10&show_raw=1

Bug: none
Test: ash_unittests, unit_tests
Change-Id: I307329012599a198629e86ceeb352fb2039b9d32
Reviewed-on: https://chromium-review.googlesource.com/1070319Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561502}

Bug: 809261
Change-Id: I5c26d594f09a3cbbf01a4c747968a67d4d078029
Reviewed-on: https://chromium-review.googlesource.com/1066816
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561501}

Bug: N/A
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I91d65b32cbd51de3e9692d47bef9dfe104a208d5
Reviewed-on: https://chromium-review.googlesource.com/1070956Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561500}

Bug: 823534
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I289ae4f321e69da48af83d1fe2a727b45fc0b28a
Reviewed-on: https://chromium-review.googlesource.com/1069126Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561499}

This CL makes sure Picture-in-Picture Web API tests don't require
kPictureInPicture feature flag.

Bug: 806249
Change-Id: Ic2a95b6ded01813f97373f91f13bdad01ccc419a
Reviewed-on: https://chromium-review.googlesource.com/1071569Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#561498}

Part 3 of Active Directory extension policy support. This CL wires
ComponentActiveDirectoryPolicyService up with ActiveDirectoryPolicyManager
and unlocks extension policy for Active Directory managed Chrome OS
devices (Chromad). It is the final missing link to enable extension
policy for Chromad. You can now do all the crazy things you've always
been dreaming of like using the Certificate Enrollment for Chrome OS
extension to mint client certificates in a PKI environment based off
ADCS.

BUG=chromium:784595
TEST=browser_tests --gtest_filter=ComponentActiveDirectory*

Change-Id: I27aaba07aff9460779b18a01cc88cc338a78f381
Reviewed-on: https://chromium-review.googlesource.com/1057621Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561497}

The method returns true if the LifeycleUnit can be frozen.

For now, a TabLifecycleUnit can be frozen unless:
- It is already frozen.
- It is visible.
- It is playing audio, has played audio recently, is accessing the
  microphone, is accessing the camera, is being mirrored.

Change-Id: I81157289264a4dbfd97d7a42ce78c5e4c2f19151
Reviewed-on: https://chromium-review.googlesource.com/1070323
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561496}

Bug: 755840
Change-Id: If82a6287bacecb3e636b8d0d60cae83e5a3d35a3
Reviewed-on: https://chromium-review.googlesource.com/1070226Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561495}

VS2017 is now using a different version format with VS2015. This patch
updated the doc to the latest version of VS2017.

Change-Id: Idb758805de8f195e6c8cd51556c1ea6bccb9f7f5
Reviewed-on: https://chromium-review.googlesource.com/1067800Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561494}

PasswordManager::OnPasswordFormSubmitted is called when a form is submitted. It doesn't mean that PasswordManager should forget about everything it saw before.
Despite the data is provisionally saved, it's not time to show the bubble yet. Therefore, there may be another event coming that would trigger the bubble.

For the concrete bug the consequences are the following:
- the hashed password is still provisionally saved via OnPasswordFormSubmitted(). It's correct because we don't know that it's hashed. Ideally, we should protect against JS modifications in PasswordManager. Currently we do it in PasswordAutofillAgent::OnWillSubmitForm.
- PasswordAutofillAgent::OnFrameDetached() later triggers the successful login. The data provided is actually correct and propagated to the bubble.

Bug: 823562
Change-Id: Ib23f2d4188e57f04d766997367c69f8613dacb17
Reviewed-on: https://chromium-review.googlesource.com/1044605
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561493}

LayoutObject used to determine whether there is a touch event handler by
checking if it has touch-action property set. However, after we enable
site isolation, a LayoutObject may still have touch event handler if it
inherits touch-action from the parent frame.

This CL makes LayoutObject determine the existence by looking at its
effective touch action.

Bug: 759042
Change-Id: I60e868090a7725757a910bfca8766ec430cf72aa
Reviewed-on: https://chromium-review.googlesource.com/1040350Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561492}

The single TestTabLifecycleUnit definition replaces the multiple
DummyLifecycleUnit definitions that we previously had in
chrome/browser/resource_coordinator/.

Change-Id: I7c7adb7972dcccc88ece76cbd93296af4ceedf9f
Reviewed-on: https://chromium-review.googlesource.com/1070322Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561491}

The alert element must be visible for a screen reader to read it,
so we place it far off the left edge of the screen. However extremely
large text could cause it to overflow onto the page. This patch
limits the width of the element, and also limits the max text length
of the alerts for better performance.

Bug: 845766
Change-Id: I79aadcf863f09ebfdaf2bcb3ba579b891fec2351
Reviewed-on: https://chromium-review.googlesource.com/1067690Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561490}

CL 4 of 5 to plumb echo canceller output device information from the renderer into
native AEC implementations. For a full outline of the changes, see:
https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifb42647650325a2a8954a4adabfbf7ea93f32c25
Bug: 837661
Reviewed-on: https://chromium-review.googlesource.com/1032612Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561489}

This CL also deprecates some redirect chain metrics, which are not
currently being used.

Bug: None
Change-Id: Ia3bfb4ac363e57866a6616cd748d97951017d7e3
Reviewed-on: https://chromium-review.googlesource.com/1070345
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561488}

Bug: 846303
Change-Id: I623b296faa9c4eaca88c877f01ca5d83628b3185
Reviewed-on: https://chromium-review.googlesource.com/1070803Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561487}

The overloaded LayoutObjectIsNeeded was introduced for a crasher which
no longer happens with the overloaded method removed.

This change makes us correctly recalc style for re-attachment of
foreignObject when <g> parent changes display from none to block.

TEST=svg/foreignObject/foreign-object-defs-crash.svg

Bug: 843520
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I78e073ff41090b4b9d53f2f2be921a70ddc993e2
Reviewed-on: https://chromium-review.googlesource.com/1070137
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#561486}