- 05 Nov, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1028db2c..937e42d5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65ce88630cc7a76a8e2b9bcae15af901124bb191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520797Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824426}
-
Ehimare Okoyomon authored
Do not show any warning in SingleWebsiteSettings if the permission is blocked. Bug: 1077766 Change-Id: Ic0ad85d69de4e95998a91116e740468918fdf6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481123 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#824425}
-
Collin Baker authored
These histograms are still actively checked for two experiments. Bug: 1144790 Change-Id: I2565d4a5df024c0da3a29c067c3bd34a6aa35f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518701 Auto-Submit: Collin Baker <collinbaker@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#824424}
-
Francois Doray authored
With this CL, if the buffer passed to NtQuerySystemInformation requests a large buffer size more than twice, the startup temperature is set to UNDETERMINED. Previously, we read the content of the empty buffer (according to https://docs.microsoft.com/en-us/windows/win32/api/winternl/nf-winternl-ntquerysysteminformation, the buffer is not filled if its size is insufficient). Bug: 1085716 Change-Id: I5c7b642cf17d8de0655c0e926e6e5f063d1f0cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518943Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#824423}
-
Maksim Moskvitin authored
This CL adds partial implementation of TrustedVaultConnectionImpl to support basic scenario of authentication factor registion, when there is known and pre-existing trusted vault key. Bug: 1113598 Change-Id: I6d4e30afea7f6c42bd987c8df083dd166b6c8813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413949 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824422}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/744b988ae1b0..83b6c1ebd54d 2020-11-05 hjd@google.com Merge "ui: Convert all queries to use slowlyCountRows" 2020-11-05 fmayer@google.com Merge "Document issue with missing frames." 2020-11-05 hjd@google.com Merge "ui: Fix topbar CSS" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3686ae040398251930ccf6cf4d88c774ed93a648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520878Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824421}
-
sczs authored
It seems that the NS_RETURNS_RETAINED annotation is causing a zombie crash when dealoc-ing the VC. The crash started to happen after http://cl/339487970/depot/google3/googlemac/iPhone/Shared/Discover/Library/UI/Protocols/DSCActionProducer.h Which fixed a retention cycle inside Discover In order to fix this crash the annotation is removed and the provider will own the ViewController (as it should be the case since we don't have the NS_RETURNS_RETAINED annotation anymore, which means the caller shouldn't be in charge of owning the object) Downstream CL:3381210 Bug: 1145136, 1145136, 1145153 Change-Id: I3dbd0f576ab9c290c8d636a0a086876ff9ba340a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518937 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#824420}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1e59a0e12e6d..3942e801a65b 2020-11-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from bcf5b211db92 to c2b2b5788575 (3 revisions) 2020-11-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 19f01495a8a1 to ad54c71632cc (2 revisions) 2020-11-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 07bbf14a831b to f635feea18cb (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I9dc2379151e9122be78c0df81411994283b176ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520394Reviewed-by:
-
Sergey Poromov authored
This change plumbs the request from Data Leak Prevention layer to pause or unpause running desktop share streams to the media request. The stream is paused when restricted(confidential) content appears in the captured area and unpaused when the content leaves the captured area. Bug: 1134566 Change-Id: I00e31e71dc0ca3be015e0a8bbaed7fa7c94748c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462134Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#824418}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df4403112ffa..744b988ae1b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8c40b585e3d0e11b84b73aff8b1a41cc6459f13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520798Reviewed-by:
-
Ramin Halavati authored
System profile has a regular and an off-the-record profile. Previously IsSystemProfile did not return true for the OTR one, now it does. Bug: 1142370 Change-Id: I5cd6376d58d1110c69d9b359a0eaba0da0f2feb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516539Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#824416}
-
Aaron Tagliaboschi authored
Remove duplicate code and move to slightly less flaky messages Bug: 1127313 Change-Id: I926c6f66d23ac6ed101ff85777d187a45ad9a50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519393 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#824415}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/110009e66adc..92b3447087b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fhorschig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fhorschig@google.com Change-Id: Ia0a41b7ede79e1e435d82d9c58c0916166daa791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520391Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824414}
-
Ramin Halavati authored
Updates browser unittest and Browser Close unittest to cover ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I62ab9f41abac7eedff1ff3b61e140997d95a12cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502369Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#824413}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604555639-418519ab0f0a3d63001d91c3a146cb7504055699.profdata to chrome-linux-master-1604577537-33195dde368ac3649b204ac4f693c7d7b8d917b5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If0605284593bf8eedd0a37e9c1f4bfbcf478c7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520881Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/771ac0bce101..c73062875890 2020-11-05 alexrudenko@chromium.org Enable TypeScript for PersistenceUtils.js 2020-11-05 sigurds@chromium.org Show API availability in FrameDetailsView 2020-11-05 yangguo@chromium.org Make console info text more precise 2020-11-05 patrick.brosset@microsoft.com Rolling DevTools deps 2020-11-05 tvanderlippe@chromium.org Typecheck timeline/TimelineHistoryManager.js with TypeScript 2020-11-05 tvanderlippe@chromium.org Typecheck media/EventDisplayTable.js with TypeScript 2020-11-05 tvanderlippe@chromium.org Typecheck media/TickingFlameChart.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1139899,chromium:1139949 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6d4e83d3cab8d2b7965f2f55f1cd978784d48b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520395Reviewed-by:
-
Sigurd Schneider authored
Front-end CL: https://crrev.com/c/2123048 Bug: chromium:945786 Change-Id: I64c21d7b7569ba60347c659a7a2dc8de877abd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517449Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#824410}
-
Peter Kvitek authored
Headless tests were scattered between /lib and /test directories. Moving them to where they all belong helps to keep things nice and tidy. Change-Id: I0aee0ae4da8e1f19dd45beb6cda2f108d9ec26a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511751 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#824409}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604555639-6427f288759af11a05c7facb538fa5f1c7c3ab83.profdata to chrome-mac-master-1604577537-36e0dad6a87a9c5b37b85a7b6521b35cfbf49108.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idd2b7674a6a85c2a859544e7437f613f27d4491d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520876Reviewed-by:
-
Thomas Tellier authored
Bug: 1066489 Change-Id: Idd47ef778190510a73685a97d082ae9334a35b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516360 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824407}
-
Austin Sullivan authored
Bug: 925306 Change-Id: I8aa9504c6ce8472101dbadf5e9f391971e5de1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519427Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#824406}
-
Dominique Fauteux-Chapleau authored
This CL refactors tests in ContentAnalysisDelegate to use Connector policies directly instead of the indirect helpers that map to legacy policies. Bug: 1109242 Change-Id: I3f7f356ac5076a4f98a66c1fc8bac42c8401a70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519200Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#824405}
-
Andrew Grieve authored
* Includes fix for L8 non-determinism * Enables proto enum unboxing * Includes fixes for tracereferences tool Bug: 1142530 Change-Id: Ifd09646ac296f85ef1102ed69541d04dd64b141f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519098 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#824404}
-
Marc Treib authored
...plus all the code for handling them. These were unused (outside of some tests), so this was all dead code. Bug: 1145589 Change-Id: Ic54a7fa293dc8cf5e785acb6cb137118f91f51d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518981Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#824403}
-
Nico Weber authored
This reverts commit b8222e3d. Reason for revert: Codebase doens't build with this change, https://crbug.com/1145992 Original change's description: > Treat CheckedPtr specially in FindBadConstructsConsumer > > Treat CheckedPtr specially in FindBadConstructsConsumer for now as discussed in: > https://groups.google.com/a/google.com/g/chrome-memory-safety/c/kw3i_zd3FW4/m/40FkyrLtAQAJ > This CL helps to avoid "Complex constructor has an inlined body" and similar errors during go/miracleptr experiments. > > Bug: 1080832 > Change-Id: Ibfb6b3b418f36e2c6868b0fbd579d1bf18226ceb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487023 > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824252} TBR=dcheng@chromium.org,keishi@chromium.org,lukasza@chromium.org,bartekn@chromium.org Change-Id: Ia1012a029e4b4b2b8a4ed6e65eaaeb45f0298cf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520936Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824402}
-
Friedrich [CET] authored
This reverts commit 67317286. Reason for revert: Compile failure not (or only very loosely) related to this CL. Local reland doesn't seem to affect reproduction of compile failure. Original change's description: > Revert "Nearby Share: Consolidate and autogenerate grd files" > > This reverts commit 5c7c88d7. > > Reason for revert: Most-likely suspect for CrOS compile failure: > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42591 > > Log: > [5898/61571] ACTION //ui/file_manager/file_manager/test:create_test_main(//build/toolchain/linux:clang_x64) > FAILED: gen/ui/file_manager/file_manager/test.html > /b/s/w/ir/cipd_bin_packages/cpython/bin/python ../../ui/file_manager/file_manager/test/scripts/create_test_main.py --output=gen/ui/file_manager/file_manager/test.html > Traceback (most recent call last): > File "../../ui/file_manager/file_manager/test/scripts/create_test_main.py", line 144, in <module> > write(GEN + R_GEN + colors, open(GEN + '../../' + colors).read()) > IOError: [Errno 2] No such file or directory: '/b/s/w/ir/cache/builder/src/out/Release/gen/ui/file_manager/file_manager/../../chromeos/colors/cros_colors.generated.css' > > Original change's description: > > Nearby Share: Consolidate and autogenerate grd files > > > > Bug: 1132403 > > Change-Id: I809b1a97e43457b92ac67fde208b200bfbf37d58 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507400 > > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: dpapad <dpapad@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824322} > > TBR=avi@chromium.org,dpapad@chromium.org,rbpotter@chromium.org > > Change-Id: I275146470b9fc70dbff9203ee8f951eda7e624d8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1132403 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517734 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824345} TBR=avi@chromium.org,dpapad@chromium.org,rbpotter@chromium.org,fhorschig@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1132403 Change-Id: If7466f38cc0114c50adeef011c22c0c0cf2f437a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517446Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824401}
-
Titouan Rigoudy authored
This change enables the test except when a conflicting feature is enabled. It improves on the status quo (test disabled everywhere) until the underlying failure can be fixed, letting the test run on all CI bots except for the offending Network Service bot. Bug: chromium:1142865 Change-Id: I4bb870d04c6b35961c1c32d9d3549d03afeaa3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519693 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824400}
-
Brian Ho authored
Enabling SkiaRenderer on Chrome OS currently fails a DCHECK [1] that asserts the backing GLSurface has a top-left origin. Since GetOrigin() returns the OS presentation API's origin, GbmSurfaceless should also return a top-left origin. For example, if you call gbm_bo_map with (x = 0, y = 0), the returned data pointer will correspond to the top-left of the buffer. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/output_presenter_gl.cc;l=223;drc=238120617b24d1856e0d66e2a6d3272a5e94f658 Change-Id: I0cdfa9d3414cb844dc33470c6342a3a944074d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511879Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#824399}
-
Peng Huang authored
Because a mesa bug, the vulkan swapchain can hang with X11, fix the hang by using a one second timeout with vkWaitForFences() call. Bug: 1130495 Change-Id: Id9f36a3b087e9d7f6307e708a5cde41d631a9d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518949Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#824398}
-
Sylvain Defresne authored
Since Chrome can be build for "catalyst" environment, add the key SUPPORTS_MACCATALYST to the generated Xcode project. Bug: 1138425 Change-Id: Idb56060a53266f5b9a4ab6a2328970cfa84973de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518858Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#824397}
-
Titouan Rigoudy authored
This move was suggested by droger@ in crrev.com/c/2490012. Bug: chromium:1124358 Change-Id: I2ab058c6e302f440bc643f0cbcd16ab848278d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518855 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824396}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cd11945c5a1..df4403112ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4301e0d345b40f7188b07d7c69d87df8cc5a3ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519042Reviewed-by:
-
Stephen McGruer authored
Bug: None Change-Id: Icc075456c6762fb8ae841ffccb743b3b8e9ddc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519480Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#824394}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aa14597ebcfa..771ac0bce101 2020-11-05 yangguo@chromium.org Add missing common owners 2020-11-05 aerotwist@chromium.org Move WebVitals out of experiments 2020-11-05 sigurds@chromium.org DevTools: Allow users to override storage quota size. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:945786 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iac45cf68e5009fa5fda05bc36d744e7168f39e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520796Reviewed-by:
-
Mark Mentovai authored
This includes universalizer.py and the Widevine signing scripts. Depends on: https://chromium-review.googlesource.com/c/2515521 and https://chrome-internal-review.googlesource.com/c/3383223 https://chrome-internal-review.googlesource.com/c/3380436 (DEPS) https://chromium-review.googlesource.com/c/2520327 (DEPS) Code-Word: calamity Bug: 1142017 Change-Id: I83bc47a2edbd031f4d7f291a6b4922d3c862f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518800 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#824392}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cd11945c5a1..df4403112ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If3d9a1db7b8806feb72cad6b94732164cf0ddeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520717Reviewed-by:
-
Roberto Moura authored
Tapping the tab switcher button, after the tab grid had been revealed once, while on Peeked state would crash because the scene_controller's displayTabSwitcher would be called when self.tabSwitcherIsActive is YES. The proposed fix is to set self.tabSwitcherIsActive to NO whenever there is a transition from the Revealed state to another state. This CL adds a method to the ThumbStripCoordinatorDelegate protocol to inform that the tab grid has been dismissed. Bug: 1127604 Change-Id: I9ace9a2ff27143eb40774b7ff563c600bdfe4e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463822 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#824390}
-
Sylvain Defresne authored
The linker fails if any object file does not define LC_BUILD_VERSION when linking a binary for "catalyst" environment. As nasm does not create such a section, the build fail if using optimised version of libvpx. As a workaround, use generic implementation instead of the optimized one in that configuration (since it is still experimental anyway). Bug: 1145197, 1138425 Change-Id: I6bf02c499d8e35dcc0fe34f5bb53df230a8449cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517955 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#824389}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df4403112ffa..744b988ae1b0 2020-11-05 treehugger-gerrit@google.com Merge "Fixed protobuf deprecated API" 2020-11-05 treehugger-gerrit@google.com Merge "Extend export_json to read from memory tables" 2020-11-04 fmayer@google.com Merge "Assert we don't stop reading the shmem." 2020-11-04 hjd@google.com Merge "Parse dpu and g2d" 2020-11-04 delphick@google.com Merge "trace_processor_shell: add .read command" 2020-11-03 treehugger-gerrit@google.com Merge "Improved flow navigation" 2020-11-03 simonmacm@google.com Merge "Work around b/169226092 where we see wrong or truncated process names." 2020-11-03 treehugger-gerrit@google.com Merge "base: Allow message() calls when status.ok() == true" 2020-11-03 fmayer@google.com Merge "Only send on socket when service stopped reading." 2020-11-03 primiano@google.com Merge "SDK: remove spurious ELOG when no error occurs" 2020-11-03 treehugger-gerrit@google.com Merge "Fix parsing of locations that have DEX in subfolder." 2020-11-03 primiano@google.com Merge "Update CHANGELOG for v9.0 release" 2020-11-03 primiano@google.com Merge "CI: fix Stats link" 2020-11-03 hjd@google.com Merge "trace_processor: Handle armv8l syscall traces" 2020-11-03 treehugger-gerrit@google.com Merge "docs: Fix trigger config instructions" 2020-11-03 treehugger-gerrit@google.com Merge "sdk: Rename kCatIndex in track event macro to highlight common error" 2020-11-03 hjd@google.com Merge "trace_processor: support fastrpc event" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6f18d6c282ce69a9c6b564b2b725fbea523575c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520532Reviewed-by:
-
Jérôme Lebel authored
Adding: * Signin.SSOIdentityListRequest.FetchIdentitiesWithCallback.Duration Time needed to fetch the identity list * Signin.SSOIdentityListRequest.RunAfterCacheIsPopulated.CacheState State of the identity cache before calling RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.RunAfterCacheIsPopulated.Duration Time needed for the callback to be called for RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.WaitUntilCacheIsPopulated.CacheState State of the identity cache before calling RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.WaitUntilCacheIsPopulated.Duration Time blocked in WaitUntilCacheIsPopulated() Those metrics are implemented in crrev.com/i/3353162. Design doc: http://go/async-identityservice-api crrev.com/c/2489915 Adding methods in ChromeIdentityService crrev.com/i/3353161 Implementing in ChromeIdentityServiceImpl => crrev.com/c/2490110 Adding metrics crrev.com/i/3353162 Implementing the metrics crrev.com/c/2490010 Adding WaitUntilCacheIsPopulated calls crrev.com/i/3354983 Adding DCHECK for cache state Bug: 897470 Change-Id: I83744b7eaec3f7eb4c2515550e6a2638e5c0ec15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490110 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824387}
-
![Friedrich [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich [CET]")
