GitLab

Review URL: https://codereview.chromium.org/1330573002

git-svn-id: svn://svn.chromium.org/blink/trunk@201700 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We decided to unship oilpan from temporary animation objects
(i.e., AnimatableValues, InterpoableValues, Interpolations and its associated objects) for the following reasons:

- The balls_css_properties_* benchmarks allocate an incredible number of AnimatableValues & InterpolableValues.
If we put those temporary objects on Oilpan's heap, they add a significant pressure on the heap.

- There is no advantage in putting those temporary objects on Oilpan's heap because their lifetime is very clear.

- I have tried a bunch of approaches to resolve the regression but concluded that we won't be able to resolve the regression
without introducing an incremental marking or/and a generational GC to Oilpan. I don't think that
the engineering cost and the complexity outweighs the benefit. At the very least, it won't be a task of Oilpan v1.

c.f., we already shipped oilpan for other animation objects (https://codereview.chromium.org/1318543009/).

For more details, see this thread: https://groups.google.com/a/chromium.org/d/topic/oilpan-reviews/V7d-7o4AbeA/discussion

BUG=340522

Review URL: https://codereview.chromium.org/1276183004

git-svn-id: svn://svn.chromium.org/blink/trunk@201698 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1308383007

git-svn-id: svn://svn.chromium.org/blink/trunk@201696 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There does not seem to be a reason to use implicit for the 'auto' initial
value. Also this way we can simplify the logic somewhat.

BUG=471917

Review URL: https://codereview.chromium.org/1311503006

git-svn-id: svn://svn.chromium.org/blink/trunk@201695 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to allow invalidation during painting which is needed by paint
offset change detection during painting.

BUG=410097

Review URL: https://codereview.chromium.org/1315303007

git-svn-id: svn://svn.chromium.org/blink/trunk@201694 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is just a consolidation. No observed bug.

Non-cacheable display items might use different early return policy
during painting and make clientCacheIsValid true even if there is no
cached cacheable display items.

Review URL: https://codereview.chromium.org/1323253002

git-svn-id: svn://svn.chromium.org/blink/trunk@201692 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1317743006

git-svn-id: svn://svn.chromium.org/blink/trunk@201691 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently absent from specifications and seeing very low usage. We can
restore this functionality in the future un-prefixed if/when it's
clarified in a spec.

Usage: 0.0221%

Intent To Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/rKDXtqvgDv4/1Q5ByQllDAAJ

BUG=522215

Review URL: https://codereview.chromium.org/1328673003

git-svn-id: svn://svn.chromium.org/blink/trunk@201690 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527611

Review URL: https://codereview.chromium.org/1327903003

git-svn-id: svn://svn.chromium.org/blink/trunk@201689 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526826

Review URL: https://codereview.chromium.org/1326053002

git-svn-id: svn://svn.chromium.org/blink/trunk@201688 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=483272

Review URL: https://codereview.chromium.org/1328723003

git-svn-id: svn://svn.chromium.org/blink/trunk@201687 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1305343003

git-svn-id: svn://svn.chromium.org/blink/trunk@201686 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: [security] open certificate viewer from devtools security overview (blink) (patchset #3 id:40001 of https://codereview.chromium.org/1327593003/ )

Reason for revert:
Broke the front_end compilation.

Original issue's description:
> DevTools: [security] open certificate viewer from devtools security overview (blink)
> 
> BUG=506468
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201676

TBR=lgarron@chromium.org,dgozman@chromium.org,estark@chromium.org,pfeldman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=506468

Review URL: https://codereview.chromium.org/1318003004

git-svn-id: svn://svn.chromium.org/blink/trunk@201685 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The assertion failure occurs in the following sequence:
- Out-of-order matching to n-th item;
- Synchronized matching to (n+m)-th item;
- Out-of-order matching to (n-k)-th item;
- Out-of-order matching to (n+m+l)-th.

The problem is that we only update nextItemToIndex during out-of-order
matching, but not during synchronized matching, causing we tried to
index already copied items (n to n+m).

BUG=526590
TEST=DisplayItemListTest.OutOfOrderNoCrash

Review URL: https://codereview.chromium.org/1307653007

git-svn-id: svn://svn.chromium.org/blink/trunk@201684 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change fixes several issues with tooltip UI:
 - Fixes overflow issue regressed in https://codereview.chromium.org/1300743002
 - Displays media queries tooltips on top and under the cursor instead of left
   aligned.
 - Closes tooltips when the mouse leaves devtools
 - Closes tooltips on any keyboard press
 - Aligns tooltips for palette colors above the anchor

This change also changes the default behaviour of tooltips to track the cursor except when used in the toolbars (buttons/labels).

BUG=525721,525609,521200,524371,526936,526972

Review URL: https://codereview.chromium.org/1318903007

git-svn-id: svn://svn.chromium.org/blink/trunk@201683 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1317913004

git-svn-id: svn://svn.chromium.org/blink/trunk@201681 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When tying floats in a block-flow to the last linebox stop when we hit a float that sits
in clean lines in the block-flow.

BUG=492918

Review URL: https://codereview.chromium.org/1306733003

git-svn-id: svn://svn.chromium.org/blink/trunk@201680 bbb929c8-8fbe-4397-9dbb-9b2b20218538

validateTexFuncLevel is called twice from validateTexFunc and
validateTexFuncParameters. Move validateTexFuncLevel out of
validateTexFuncParameters.

BUG=295792

Review URL: https://codereview.chromium.org/1326653002

git-svn-id: svn://svn.chromium.org/blink/trunk@201679 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527354
TBR=pfeldman

Review URL: https://codereview.chromium.org/1327893002

git-svn-id: svn://svn.chromium.org/blink/trunk@201677 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=506468

Review URL: https://codereview.chromium.org/1327593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201676 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1325713004

git-svn-id: svn://svn.chromium.org/blink/trunk@201675 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Subresource Integrity gives an incorrect console message stating that a
resource has not been blocked when the request is made cross-origin
without CORS. In fact, the resource has been blocked, and the console
message is incorrect. This fixes that message and the respective test.

BUG=527436
TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1308253004

git-svn-id: svn://svn.chromium.org/blink/trunk@201674 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522739

Review URL: https://codereview.chromium.org/1323143005

git-svn-id: svn://svn.chromium.org/blink/trunk@201673 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change reverts adding Cmd+L clear console shortcut, as it conflicts
with Chrome's omnibox focus shortcut on Mac.

This change also allows the pause script shortcuts to be used while
inside the inspected page, allowing the user to perform a series of
mouse/focus actions before pausing script.

BUG=527220

Review URL: https://codereview.chromium.org/1312393004

git-svn-id: svn://svn.chromium.org/blink/trunk@201672 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL puts the classname under GC_PROFILING flag since it increases
binary size in production builds.

BUG=527054

Review URL: https://codereview.chromium.org/1317563005

git-svn-id: svn://svn.chromium.org/blink/trunk@201671 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1314773009

git-svn-id: svn://svn.chromium.org/blink/trunk@201670 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=504537
TEST=Open Network Panel, navigate to mixed.badssl.com, type
"mixed-content:true" in the filter

Review URL: https://codereview.chromium.org/1320343005

git-svn-id: svn://svn.chromium.org/blink/trunk@201669 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Split ResourceFetcher::loadPriority() into 3 functions:
* typeToPriority(), which converts Resource::Type into its default ResourceLoadPriority
* modifyPriorityForExperiments(), which contains all of the currently-running experimental logic.
* loadPriority() remains the entry point, and contains permanent special cases (e.g., synchronous loads).

BUG=

Review URL: https://codereview.chromium.org/1319153004

git-svn-id: svn://svn.chromium.org/blink/trunk@201667 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522739

Review URL: https://codereview.chromium.org/1324073003

git-svn-id: svn://svn.chromium.org/blink/trunk@201666 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526239

Review URL: https://codereview.chromium.org/1315193014

git-svn-id: svn://svn.chromium.org/blink/trunk@201661 bbb929c8-8fbe-4397-9dbb-9b2b20218538

blink-dev intent to remove thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/E9LKKtcKbv8/cB7QmTlACgAJ

BUG=470301

Review URL: https://codereview.chromium.org/1291723004

git-svn-id: svn://svn.chromium.org/blink/trunk@201659 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1310533007

git-svn-id: svn://svn.chromium.org/blink/trunk@201658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes an old TODO where processNewItem took a pointer
to make the initial review easier. The pointer indirection is not
necessary and has been switched to a reference.

Review URL: https://codereview.chromium.org/1330453002

git-svn-id: svn://svn.chromium.org/blink/trunk@201657 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201644

BUG=522797
TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/1322243004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This helps people who follow a link directly to the class without reading its
file top-down.

Review URL: https://codereview.chromium.org/1305933006

git-svn-id: svn://svn.chromium.org/blink/trunk@201655 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We would like to be able to prioritize loading tasks, but in order to
do that we need to make sure loading tasks are posted to the right queue
to make sure tasks run in the expected order.  If this task is posted as
a timer, and loading tasks are prioritzed, it's possible
FrameHostMsg_DidStopLoading will be sent before the corresponding
FrameHostMsg_DidStartLoading ipc which causes various browser tests to
break.

BUG=497761,510398

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201563

Review URL: https://codereview.chromium.org/1312353004

git-svn-id: svn://svn.chromium.org/blink/trunk@201654 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RemoteArray wrapper incapsulates at and length methods. RemoteFunction incapsulates targetFunction method. Wrappers have createFromObject methods which check type of object.
In utilities.js method storeResultTo is added to Promise.prototype. This method allow to save promise result value to object[propertyName] and return it for following processing.

BUG=61643
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1325783003

git-svn-id: svn://svn.chromium.org/blink/trunk@201653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We want to introduce a WebTaskRunner which maps to a chromium
SingleThreadTaskRunner and migrate WebScheduler and WebThread
over to it.  The motivation is:

* Brings the blink side closer to the underlying chrome code.
* For spatial scheduling we plan to have a loading and timer
  task queue per frame.
* We want to be able to post delayed tasks to the loading
  task queue and architecturally we feel the WebTaskRunner
  will be cleaner than adding a postDelayedLoadingTask to
  WebScheduler.

Patch 2: https://codereview.chromium.org/1308183005
Patch 3: https://codereview.chromium.org/1303153005
Patch 4: https://codereview.chromium.org/1309423004
Patch 5: https://codereview.chromium.org/1310253009

BUG=510398,497761

Review URL: https://codereview.chromium.org/1325073002

git-svn-id: svn://svn.chromium.org/blink/trunk@201652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524115

Review URL: https://codereview.chromium.org/1327693002

git-svn-id: svn://svn.chromium.org/blink/trunk@201651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1312073003

git-svn-id: svn://svn.chromium.org/blink/trunk@201650 bbb929c8-8fbe-4397-9dbb-9b2b20218538