GitLab

Quirks mode layout is slower than no-quirks.

Bug: 1131185
Change-Id: Ie5421ac90e24f9e8936b431e745ffed07bbfd770
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424670
Commit-Queue: Nate Chapin <japhet@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809931}

We capture the logs in system integration Tast tests, but not small
gtest tests. But it appears some gtests do need system logs, so this
pulls them for every gtest as well.

Also update old uses of the arg name.

Bug: None
Change-Id: I47de8617575dfda5a74d9d1319f3d9dbaad4714b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424817Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809930}

1. Added DataLeakPreventionRulesList policy.
2. Added DlpRulesManager to be responsible for parsing
the rules and providing an API for other services.


Bug: 1121987
Change-Id: I819503645f0513bc643e37c9f1468c304e6ef239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377928
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809929}

This adds a mechanism to rotate the Nearby Connections advertisement
and Bluetooth MAC address every [12, 15) minutes. This is to protect
user privacy by preventing tracking using this data.

Spec: go/nearby-chrome-bt

Bug: b:154846485
Change-Id: I841aa103fb374a4812ab928bc862af026835a03c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419692
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809928}

This flag is already 50% on stable, enable it by default.

Bug: 933358
Change-Id: Idebaa9a0544f0da022240864a96c38718df04332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426727Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809927}

This patch is for refactoring RespondWithCallback class
and include below changes.

- Expose RespondWithCallback from PaymentAppProviderImpl.

- Adds helper class like as "ServiceWorkerCoreThreadEventDispatcher"
it appears that all of the functions that access WebContents on the
service worker core thread are for dispatching some type of event.

- Remove InvokeRespondWithcallbacksRepository then
ServiceWorkerCoreThreadEventDispatcher owns an instance of
InvokeRespondWithCallback instead and manage its lifetime.

Bug: 1075687
Change-Id: I34ee154600a137ef47a03f797f15da689d205a79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368660
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809926}

Creates new class ContentSuggestionsSchedulerAppAgent which brings
together all the Content Suggestion service notifications code.

Introduces AppStateAgents (app state associated objects).
Adds a new AppStateObserver method, sceneDidConnect:, that allows for
unified logic between iOS 12 and 13.

Bug: 1072366,1094916
Change-Id: Idd520e71668e6fc230b73eb3485085bf423b39bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414223
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809925}

Pull out a hard-to-read conditional into its own boolean variable.
Also remove an unused variable and compact code after that.

Change-Id: I34b101a9fb95f734a4cb67967ad5874ca4d7a7a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425425Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809924}

This change adds missing metrics on the chrome://apps page for webapps.
These metrics help us track usage, as well as os integration failures
(in this case specifically from installing 'locally' from chrome://apps,
where the app exists in sync already).

Change-Id: I467c0adf0ecec8db998d62ec0471201eb82d887c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419115
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809923}

Bug: none
Change-Id: I32c7ef252d2fbfa4b4d5c3868c8e65c360f54929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424929
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809922}

`create_srcjar = false` was needed during the transition to moving
R.java generation to android_library targets. Now this variable is
unused (the variable is asserted to be false), clean up all references.

TBR=#mechanical change, noop

Bug: 1073476
Change-Id: Ie272288eb4988d0e4bdb8aeebc9b4debb08fbcfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426243
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809921}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2daeda990573..8134d1f70669

2020-09-23 tvanderlippe@chromium.org Cleanup _loadModules in Runtime
2020-09-23 tvanderlippe@chromium.org Add back + button for style insertion of stylesheets
2020-09-23 jacktfranklin@chromium.org Ensure that data setters in components take an interface
2020-09-23 changhaohan@chromium.org Add collapsable Computed pane into Styles pane
2020-09-23 tvanderlippe@chromium.org Typecheck network/NetworkLogView.js with TypeScript

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1073899,chromium:1129881,chromium:1131500
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9b8bcc22d80630824168c320162d7ce2e438b648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426804Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809920}

This should not happen, and we're crashing the renderer when it does
but we need more info to determine why it is happening.

I have narrowed it down to being browser-initiated by code inspection
but the number of ways a NavigationRequest gets created and put in a
RenderFrameHost is too numerous to continue reasonably on that path.

R=avi@chromium.org,dcheng@chromium.org

Bug: 1125106
Change-Id: I6f9db7c7386298208bb39c9f91fa1dbf91e1eb4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413563
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809919}

We need to pass in some floating point feature flags
to WebUI. Adding this method to make it possible.

Bug: 1099917
Change-Id: I1d9cd115c2234d66239fe555ed89aee3314df779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426608Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809918}

In cases where an oof element's static position was taken in a later
fragmentainer than the start of its containing block, we would
calculate the wrong start offset and starting fragmentainer for the
oof.

To fix this, instead of passing fragmentainer_consumed_block_size
(which is the consumed column block size up to the column that the
static position was taken in), update the containing_block_offset to
be the offset from the start of the containing block to the root
fragmentation context, as well as update the static position to be
relative to this adjusted containing_block_offset.

Bug: 1079031
Change-Id: I48c08e7debd291fa3acfa77af0bb6d242cedbbd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422213
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#809917}

Bug: 1130865
Change-Id: I6ff276495f08928a68be3cd53a2681c37a14dd1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423263Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809916}

On Android, SIGQUIT is masked by default and handled specially by ART to
generate stack traces on demand (usually during an ANR or bugreport) in
a way that does not intrinsically terminate the process (though the
process may be killed afterward in some cases).

Apps that use WebView sometimes unmask SIGQUIT in the browser process
due to having their own crash handler or similar, and if that happens,
we don't want to treat this as a browser process crash and generate a
minidump, as there's no real way to know why the signal was sent.

Just disable handling SIGQUIT on Android in the browser process. This
leaves child processes alone; they only run our code so can't end up
with SIGQUIT accidentally unmasked.

Fixed: 1077890
Change-Id: Iff896135f0ff417f92dbf660d58569774eb4a0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426471Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809915}

Check if there is an on-going desk animation before starting a new
window cycle.

Previously, Alt+Tabbing in quick succession between windows on different
desks leads to a broken state where the activated desk doesn't contain
the active window, preventing Alt+Tab from working until clicking on the
window.

Test: manual, added test
Fixed: 1115343
Change-Id: I5d0ffbcf00275a770b27dd923b7c14aab44264df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425113
Commit-Queue: Richard Chui <richui@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809914}

This test tickles a heap UAF.

Bug: 1012356
Change-Id: Ia5a46e23d203521e114e71095e6c91a84af36a05
Tbr: brucedawson@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427405Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809913}

https://android.googlesource.com/platform/external/perfetto.git/+log/06f3474ec4dc..637111bf309e

2020-09-23 primiano@google.com Merge "Update libcxx, libcxxabi, libunwind, clang-format"
2020-09-23 fmayer@google.com Add Known Issue about sampling_interval_bytes=0.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ica165ba113e587cc11c4127203db4c77ad2d1036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426903Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809912}

Alpha-sorted input method list is needed for "All input methods" list
in "Add input methods" dialog.
View: http://screen/C67B6b3t9Em3KQM

Bug: 1113439
Change-Id: I48a55520d02fb663d5b35e5656a98178797680a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423801Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809911}

This histogram is used to track health status of content verification,
and this CL extends the histogram by a year.

Bug: 1088778
Test: None
Change-Id: I94c808291cbb3f6e78f60a10255091d222ee5157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422353Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809910}

This CL adds a fade out animation to the paint preview on exit.

Bug: 1131497
Change-Id: Id1b99d4ed4e98ced4aaa2acae6a579de65b8bce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425461Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809909}

The new API attempts to open the Downloads folder in the Files app.
This API will be invoked in response to a button press in Holding Space.

Bug: 1131260
Change-Id: I3d90b3f3f71c692618df756bae6cd46105b1f29e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425193Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#809908}

ChallengeUserKey is almost identical to ChallengeMachineKey, only
differing by an enum. This CL simply hooks up the appropriate logic.

Bug: 1127505
Change-Id: I2e54be9ec447cce2d11eb46ee3f70d3e2e2d85c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406852Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809907}

https://webrtc.googlesource.com/src.git/+log/81d691852dc8..3a5612a8de0b

2020-09-23 mheikal@chromium.org Clean up references to deprecated create_srcjar in android_resources
2020-09-23 nisse@webrtc.org Demote method EncodedImage::capacity() to private.
2020-09-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 590f451b..dc725cd5 (809630:809732)
2020-09-23 nisse@webrtc.org Deprecate the raw-pointer constructor of EncodedImage.
2020-09-23 ilnik@webrtc.org Remove deprecated i420 buffer pool

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1073476
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I884b526069ff6fcda18a73a5be748762b2d9dadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426808Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809906}

Bug: 1066489
Change-Id: I1d4a0faaad3ff753995ecf68c9d227b150f31eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391146Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#809905}

Bug: 1077766
Change-Id: I99780cdf421768f5da4630e95b53cf6c53c1257f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411940
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809904}

The original of this test got marked a while ago by r775178, but
these virtuals (which have the same problem) didn't.

Bug: 1057060
Change-Id: I349dd8c930d6af0ab4c4a38f0ffadde333b45ad0
Tbr: bokan@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427204Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809903}

Followup to
https://chromium-review.googlesource.com/c/chromium/src/+/2424986/

Bug: 783819
Change-Id: Ic89fc2d6f330c471bfcc18696fafa1f077b901fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427063
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809902}

The various .def files used in Windows builds are generated using
llvm-nm and only support being used with the clang compiler. These .def
files can't be used with MSVC, though we are unsure if that's related to
how they are generated by generate_def_files.py or how MSVC consumes
them (i.e. the format it expects for the symbols).

The issue is primarly about the custom libcxx and MSVC's inability to
work correctly with it. //build/config/c++/c++.gni handles this
automatically by disabling the custom libcxx for non-clang (MSVC) builds
by setting use_custom_libcxx = false. However, this causes the .def
symbols to be generated differently (incorrectly), causing link
failures related to too many symbols being exported.

This change helps support using Abseil in ANGLE, particularly standalone
component builds built with MSVC.

This is a workaround until:
1.) EXPORT macros are used (preferred).
OR
2.) generate_def_files.py can generate .def files for both clang and
MSVC, either manually or as part of the build (unpreferred, since the
script itself is a workaround).
Abseil: Only use Windows .def files with clang

The various .def files used in Windows builds are generated using
llvm-nm and only support being used with the clang compiler. These .def
files can't be used with MSVC, though we are unsure if that's related to
how they are generated by generate_def_files.py or how MSVC consumes
them (i.e. the format it expects for the symbols).

The issue is primarly about the custom libcxx and MSVC's inability to
work correctly with it. //build/config/c++/c++.gni handles this
automatically by disabling the custom libcxx for non-clang (MSVC) builds
by setting use_custom_libcxx = false. However, this causes the .def
symbols to be generated differently (incorrectly), causing link
failures related to too many symbols being exported.

This change helps support using Abseil in ANGLE, particularly standalone
component builds built with MSVC.

This is a workaround until:
1.) EXPORT macros are used (preferred).
OR
2.) generate_def_files.py can generate .def files for both clang and
MSVC, either manually or as part of the build (unpreferred, since the
script itself is a workaround).

Bug: 1126524
Test: Manual verification with standalone ANGLE build
Change-Id: Icf071635938f83818b8345b38074c21f362b897c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419155
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809901}

This reverts commit 229a7c61.

Reason for revert: Breaks mojo builders, forgot to update testing/buildbot and mb_config.

Original change's description:
> Switch the builder group for mojo builders.
> 
> The recipe-side config for the mojo builders has already been copied to
> the new builder group.
> 
> Bug: 1131163
> Change-Id: Id1d01ccdac7f242e347db02586b04bb6927b9e0b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427123
> Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#809869}

TBR=dpranke@google.com,gbeaty@chromium.org

Change-Id: Ib70aa384011d8b1aace921e08683048f9a9aa32b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1131163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427285Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809900}

Retry bringing in symupload native symbols support on Mac (with fix from
previous roll attempt in https://crrev.com/c/2380139).

9c4671f Change JSON serialization error check.
bdac77a file_id_unittest: avoid system()
5640e57 CopyFile: add a C++ API
c6d49c4 linux: Fix leak when the offset of memory_mapped_file is greater than 0
039c4c9 Add a .clang-format file to give us local control over Chromium style.
9c38ab7 Add native symbol uploads to Mac OS symupload tool.
62d9272 linux: Fix segfault when there is no section header in ELF file
087795c processor: subtract 1 from return pointers while scanning
014e842 Escape more characters in Mac OS sym-upload-v2 debug_file strings.

BUG=1021742
R=mark@chromium.org, nbilling@google.com

Change-Id: If54fbc92bf1253c25cb8ca0ef15494a506a9d793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426729Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809899}

This change introduces a set of classes and properties enabling the
TileView to become a MVC component.

The change collapses the TileView and TileWithTextView classes into
one to avoid awkward naming. The TileView base class is never used as
a stand-alone component and MVC allows the class to control the
visibility of the TextView with ease.

The MVC component features all UI specific features used by TileView,
TileWithTextView, SuggestionsTileView and TopSitesTileView.

Bug: 1106109
Change-Id: I3dde36e767ae876759089bd3580ac5d9ac61e66e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424490
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809898}

This test was disabled due to an M85 bot on failing. However, the tests
were drastically refactored for M86. I don't think this is still an
issue with the refactored tests as the crash location no longer exists.
See comments on bug for more details on why I think a simple enable
should suffice.

Will monitor for new flakes over the next few days.

Bug: 1117264
Change-Id: Ifffbca7f9612b4577ca7884c78c8f73695d6fdf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426365Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809897}

This adds the familiar MVC pieces, in addition to the existing Coordinator and View: a Mediator, a ViewBinder, and a Properties class. Logic is moved out of the MenuButton and MenuButtonCoordinator to the Mediator. Of note, there are two compound properties for combinations of properties that need to be set together:
* show/hide badge and shouldAnimate
* useLight and ColorStateList

Bug: 1086676
Change-Id: I12fb7aa1e21b78b0cddf6b72c322e3c030fae78e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406378
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809896}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009230800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uJOBjWHF-V8jOwZMkbWeP1rWi_kNv9l_Fsc2gObjg3wC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/166042882
Tbr: help-app@grotations.appspotmail.com
Change-Id: Ia47749e95cecdf61c4882a147bf9c7fd17078a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426297Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809895}

Bug: 772945
Change-Id: I1f347bc404e5b347159c64cdb9ff0e45f3903590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425153
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#809894}

This test is quite flaky.

Bug: 1131541
Change-Id: I6cd6660221b570a1e10343fa108308b3cd1a6e18
Tbr: msarda@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425401Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809893}

The result of the IPC call GetContentSettingsManager::AllowStorageAccess
was cached to prevent further redundant IPC calls. But this was only
done for local and session storage permissions (via the AllowStorage()
method).

This change consolidates the caching logic to be used for all storage
types. We also remove the AllowStorage() method and integrate it into
the general purpose AllowStorageAccess() methods, adding new storage
types for local and session storage.

IDBFactory::CachedAllowIndexedDB() is also removed as it is now
redundant.

Change-Id: I518cf05bc1e12feec25c96aa5c1cd2cefebd1a29
Bug: 1122633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401847Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#809892}